On Sat, Nov 24, 2012 at 4:13 PM, Keshav Kini <keshav.k...@gmail.com> wrote:
> Ivan Andrus <darthand...@gmail.com> writes:
>> I disagree.  Perhaps I am alone in this, but I often (used to) move
>> to the end of the line, go back a few characters (to get inside
>> parenthesis or something), and start typing.  If there is trailing
>> whitespace that I didn't know about I would be extremely annoyed
>> because all my typing was in the wrong place.  That's why I now show
>> all trailing whitespace in my editor and have a draconian
>> kill-all-trailing-whitespace-on-save policy.  It has caused very few
>> problems for me.  I just have to remember to kill any hunks with
>> whitespace only changes.
>>
>> For those reasons I would love if we just got rid of trailing
>> whitespace everywhere.  Unfortunately, as you have mentioned,
>> changing trailing whitespace causes hg/git to think that the line has
>> changed thereby messing up blame etc.  If there was a way to remove
>> all whitespace from every revision ever when we change over to git, I
>> think that would be awesome.  I have no idea how much work it would
>> be though, and there's always the slight chance you might break
>> something that way.
>
> That's definitely doable. I need to refactor my repository
> conversion/merging script to make it more extensible for stuff like
> this. Right now it's an unholy mess of bash code...

Cool. (The doable part, not the unholy mess part :-). If that's the
case, how about we simply ignore the issue at the moment, remove it
all in the git conversion, and document + enforce a no-whitespace
policy as as part of the new development workflow. If there are no
objections, I'll write this up in #11956 as a new official policy.

- Robert

-- 
You received this message because you are subscribed to the Google Groups 
"sage-devel" group.
To post to this group, send email to sage-devel@googlegroups.com.
To unsubscribe from this group, send email to 
sage-devel+unsubscr...@googlegroups.com.
Visit this group at http://groups.google.com/group/sage-devel?hl=en.


Reply via email to