Re: [sage-devel] Re: Matrix unicode output

2016-01-25 Thread Jori Mäntysalo
On Mon, 25 Jan 2016, Samuel Lelievre wrote: When starting the Sage REPL, we currently display the following advice:     Type "notebook()" for the browser-based notebook interface.     Type "help()" for help. We could add a few more hints that answer frequently asked questions:     Type "%disp

Re: [sage-devel] Re: Matrix unicode output

2016-01-25 Thread David Roe
On Mon, Jan 25, 2016 at 8:42 PM, Samuel Lelievre wrote: > When starting the Sage REPL, we currently display the following advice: > > Type "notebook()" for the browser-based notebook interface. > Type "help()" for help. > > We could add a few more hints that answer frequently asked questi

[sage-devel] Re: Matrix unicode output

2016-01-25 Thread Samuel Lelievre
When starting the Sage REPL, we currently display the following advice: Type "notebook()" for the browser-based notebook interface. Type "help()" for help. We could add a few more hints that answer frequently asked questions: Type "%display unicode_art" for a nicer display of some ou

Re: [sage-devel] Plots in plot.py documentation

2016-01-25 Thread Jeroen Demeyer
I'm sure there is probably a good reason, but why don't we just display all plots in the documentation? -- You received this message because you are subscribed to the Google Groups "sage-devel" group. To unsubscribe from this group and stop receiving emails from it, send an email to sage-devel

[sage-devel] Re: Plots in plot.py documentation

2016-01-25 Thread jhonrubia6
forget it. It has some problems with list comprehension with real numbers (e.g. sum(circle((i,0), i, hue=sin(i/10)) for i in [10,9.9,..,0]) ) but I can work around it with more code. El lunes, 25 de enero de 2016, 20:19:46 (UTC+1), jhonrubia6 escribió: > > It seems that the option *hue* does not

[sage-devel] Re: Plots in plot.py documentation

2016-01-25 Thread jhonrubia6
It seems that the option *hue* does not work properly inside the PLOT block rendering one-color plots, so the graphics do not correspond to the code, I think it's better in this case to not show them, as it would be misleading. What do you think? El domingo, 24 de enero de 2016, 19:51:34 (UTC+1)

[sage-devel] Re: Help with translating the Sage tutorial to Greek

2016-01-25 Thread kcrisman
Dear Dimitris, No template per se, but if you start browsing the code you'll see how it's created, e.g. https://github.com/sagemath/sage/tree/master/src/doc/fr and of course the entire documentation folder https://github.com/sagemath/sage/tree/master/src/doc . Usually one starts with the cur

[sage-devel] Help with translating the Sage tutorial to Greek

2016-01-25 Thread D. Papachristoudis
Hello, I'm intrested in translating the official Sage tutorial and documentation found here to Greek. By reading through the documents I can't help but notice that they all share a uniform structure (both HTML and .pdf). Is a specific set of template files used for the

Re: [sage-devel] Re: Developing in general

2016-01-25 Thread Nathann Cohen
> That thinking is precisely whats wrong here, there is no dead end. If you > dislike how Poset is being used then change it or get over it. But sulking > in your corner with this never-compromising obstructionist attitude is not a > way forward. "Sulking in my corner with this never-compromising

Re: [sage-devel] Re: Developing in general

2016-01-25 Thread Volker Braun
On Monday, January 25, 2016 at 11:28:21 AM UTC-5, Nathann Cohen wrote: > > And really, I don't think that we could devise a new set of rule that > could solve this kind of dead-end situations. That thinking is precisely whats wrong here, there is no dead end. If you dislike how Poset is being

Re: [sage-devel] Re: Developing in general

2016-01-25 Thread William Stein
On Mon, Jan 25, 2016 at 8:28 AM, Nathann Cohen wrote: >> Examples of not "getting" code review from this thread: >> * At review of some small addition we start a general discussions about what >> Poset should do and then everybody votes on that >> * Dislike of change/design pattern/author/..., hen

Re: [sage-devel] Re: Developing in general

2016-01-25 Thread Nathann Cohen
> Examples of not "getting" code review from this thread: > * At review of some small addition we start a general discussions about what > Poset should do and then everybody votes on that > * Dislike of change/design pattern/author/..., hence I'm not reviewing this > * I just make some comments on

Re: [sage-devel] Re: Developing in general

2016-01-25 Thread Nathann Cohen
> Examples of not "getting" code review from this thread: > * At review of some small addition we start a general discussions about what > Poset should do and then everybody votes on that > * Dislike of change/design pattern/author/..., hence I'm not reviewing this > * I just make some comments on

[sage-devel] Re: Developing in general

2016-01-25 Thread Volker Braun
Most of the mathematicians by training do a terrible job at code review in Sage, whereas the compsci people do much better. I'm guessing that this is because the latter actually contribute to other projects and get some exposure to how code review is done right, whereas the former only ever exp

[sage-devel] Re: Random doctest error in real_double.pyx

2016-01-25 Thread Volker Braun
I've seen random test error there, too. +1 to removing them. On Monday, January 25, 2016 at 8:28:16 AM UTC-5, Eric Gourgoulhon wrote: > > Hi, > > It appears that occasionaly the following doctest error occurs in > src/sage/rings/real_double.pyx: > > File "src/sage/rings/real_double.pyx", line

[sage-devel] Re: Matrix unicode output

2016-01-25 Thread Volker Braun
On Sunday, January 24, 2016 at 6:33:00 PM UTC-5, Nils Bruin wrote: > > For attracting novice users who care about presentation of results, I > would guess the terminal-based output is basically irrelevant. > And by making the terminal UI as unwelcoming as possible we can ensure that it stays ou

Re: [sage-devel] Developing in general

2016-01-25 Thread Jeroen Demeyer
On 2016-01-25 14:47, Jori Mäntysalo wrote: But numbers 2-1 does not seem so strong base for decision. Sure, but that is because it is such a specific question about Posets. You cannot expect every Sage developer to have an opinion about Posets. I never used Posets in Sage, so I don't have an

Re: [sage-devel] Developing in general

2016-01-25 Thread Nathann Cohen
I'm sorry to insist, but if everybody agreed that I am wrong to dislike a design pattern, that still would not force me to click on "positive review" if I do not want to. Nathann Le 25 janv. 2016 14:47, "Jori Mäntysalo" a écrit : > On Mon, 25 Jan 2016, Jeroen Demeyer wrote: > > But what if -- a

Re: [sage-devel] Developing in general

2016-01-25 Thread Jori Mäntysalo
On Mon, 25 Jan 2016, Jeroen Demeyer wrote: But what if -- a slightly artificial example -- I make function A that uses Poset as a wrapper, function B that does not, then Nathann reviews A and Travis reviews B...? In such a case you should try to agree with everybody which of the two approache

Re: [sage-devel] Random doctest error in real_double.pyx

2016-01-25 Thread Jeroen Demeyer
On 2016-01-25 14:28, Eric Gourgoulhon wrote: Should this doctest be skipped by adding the marker # random to it? Even better: remove the whole time_alloc() function with its doctests. It's not clear what those doctests test anyway... -- You received this message because you are subscribed to

[sage-devel] Random doctest error in real_double.pyx

2016-01-25 Thread Eric Gourgoulhon
Hi, It appears that occasionaly the following doctest error occurs in src/sage/rings/real_double.pyx: File "src/sage/rings/real_double.pyx", line 2789, in sage.rings.real_double.time_alloc Failed example: pool_stats() Expected: Used pool 0 / 0 times Pool contains 7 / 50 items Got:

Re: [sage-devel] Developing in general

2016-01-25 Thread Jeroen Demeyer
On 2016-01-25 13:26, Jori Mäntysalo wrote: But what if -- a slightly artificial example -- I make function A that uses Poset as a wrapper, function B that does not, then Nathann reviews A and Travis reviews B...? In such a case you should try to agree with everybody which of the two approaches

Re: [sage-devel] Developing in general

2016-01-25 Thread Jori Mäntysalo
On Mon, 25 Jan 2016, Jeroen Demeyer wrote: I actually think that it's a very good thing if reviewers point out flaws and give constructive suggestions. I wish all my tickets had that... Pointing out clear flaws is the reason to have reviewers at all. Constructive suggestions are good thing.

Re: [sage-devel] Developing in general

2016-01-25 Thread Nathann Cohen
Hello Jori, When in front of a patch I do not agree with, the least harmful thing I can do to the author's work is to not review it. Especially when I consider that it is only a matter of taste, and thus do not oppose any positive review given by somebody else to the very same patch. Especially w

Re: [sage-devel] Developing in general

2016-01-25 Thread Jeroen Demeyer
I actually think that it's a very good thing if reviewers point out flaws and give constructive suggestions. I wish all my tickets had that... Jeroen. -- You received this message because you are subscribed to the Google Groups "sage-devel" group. To unsubscribe from this group and stop receiv

[sage-devel] Developing in general

2016-01-25 Thread Jori Mäntysalo
There was a discussion between I, Travis and Nathann about HasseDiagram-Poset; maybe a year ago there was discussion about 'self' in docstrings. I have made some simple functions to add to Sage. Most of them have been reviewed and accepted. Now, if I ask Nathann to review a function that uses