> Examples of not "getting" code review from this thread: > * At review of some small addition we start a general discussions about what > Poset should do and then everybody votes on that > * Dislike of change/design pattern/author/..., hence I'm not reviewing this > * I just make some comments on the ticket but would never set it to positive > review. > > On Monday, January 25, 2016 at 3:27:09 AM UTC-5, Jori Mäntysalo wrote: >> >> There was a discussion between I, Travis and Nathann about >> HasseDiagram-Poset; maybe a year ago there was discussion about 'self' in >> docstrings. >> >> I have made some simple functions to add to Sage. Most of them have been >> reviewed and accepted. Now, if I ask Nathann to review a function that >> uses Poset class only as a wrapper, he rejects them (but makes good >> suggestions for the code). If Travis is reviewing, he rejects >> modifications where "self" is changed to "this thing" (but makes good >> suggestions for the docstring). (Well, I can also ask Frédéric and get a >> positive review (with good comments about making the code >> PEP-compliance).) >> >> This is kind of complicated. If this is just me, then forget this mail. >> But do other have similar feelings about need of common view of some >> details? >> >> -- >> Jori Mäntysalo > > -- > You received this message because you are subscribed to the Google Groups > "sage-devel" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to sage-devel+unsubscr...@googlegroups.com. > To post to this group, send email to sage-devel@googlegroups.com. > Visit this group at https://groups.google.com/group/sage-devel. > For more options, visit https://groups.google.com/d/optout.
-- You received this message because you are subscribed to the Google Groups "sage-devel" group. To unsubscribe from this group and stop receiving emails from it, send an email to sage-devel+unsubscr...@googlegroups.com. To post to this group, send email to sage-devel@googlegroups.com. Visit this group at https://groups.google.com/group/sage-devel. For more options, visit https://groups.google.com/d/optout.
