Re: [PR] [SPARK-51441][SQL] Add DSv2 APIs for constraints [spark]

aokolnychyi commented on code in PR #50253: URL: https://github.com/apache/spark/pull/50253#discussion_r2021698784 ## sql/catalyst/src/main/java/org/apache/spark/sql/connector/catalog/constraints/Check.java: ## @@ -0,0 +1,132 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] [SPARK-51441][SQL] Add DSv2 APIs for constraints [spark]

beliefer commented on code in PR #50253: URL: https://github.com/apache/spark/pull/50253#discussion_r2019766381 ## sql/catalyst/src/main/java/org/apache/spark/sql/connector/catalog/constraints/Constraint.java: ## @@ -0,0 +1,121 @@ +/* + * Licensed to the Apache Software Foundati

Re: [PR] [SPARK-51441][SQL] Add DSv2 APIs for constraints [spark]

gengliangwang commented on code in PR #50253: URL: https://github.com/apache/spark/pull/50253#discussion_r2021759785 ## sql/catalyst/src/main/java/org/apache/spark/sql/connector/catalog/constraints/Constraint.java: ## @@ -0,0 +1,121 @@ +/* + * Licensed to the Apache Software Fou

Re: [PR] [SPARK-51441][SQL] Add DSv2 APIs for constraints [spark]

aokolnychyi commented on code in PR #50253: URL: https://github.com/apache/spark/pull/50253#discussion_r2006452472 ## sql/catalyst/src/main/java/org/apache/spark/sql/connector/catalog/constraints/Constraint.java: ## @@ -0,0 +1,128 @@ +/* + * Licensed to the Apache Software Found

Re: [PR] [SPARK-51441][SQL] Add DSv2 APIs for constraints [spark]

beliefer commented on code in PR #50253: URL: https://github.com/apache/spark/pull/50253#discussion_r2019766733 ## sql/catalyst/src/main/java/org/apache/spark/sql/connector/catalog/constraints/Constraint.java: ## @@ -0,0 +1,121 @@ +/* + * Licensed to the Apache Software Foundati

Re: [PR] [SPARK-51441][SQL] Add DSv2 APIs for constraints [spark]

aokolnychyi commented on code in PR #50253: URL: https://github.com/apache/spark/pull/50253#discussion_r2021695162 ## sql/catalyst/src/main/java/org/apache/spark/sql/connector/catalog/constraints/Constraint.java: ## @@ -0,0 +1,121 @@ +/* + * Licensed to the Apache Software Found

Re: [PR] [SPARK-51441][SQL] Add DSv2 APIs for constraints [spark]

aokolnychyi commented on code in PR #50253: URL: https://github.com/apache/spark/pull/50253#discussion_r2006450589 ## sql/catalyst/src/main/java/org/apache/spark/sql/connector/catalog/constraints/Check.java: ## @@ -0,0 +1,90 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] [SPARK-51441][SQL] Add DSv2 APIs for constraints [spark]

aokolnychyi commented on code in PR #50253: URL: https://github.com/apache/spark/pull/50253#discussion_r2021692158 ## sql/catalyst/src/main/java/org/apache/spark/sql/connector/catalog/constraints/Constraint.java: ## @@ -0,0 +1,121 @@ +/* + * Licensed to the Apache Software Found

Re: [PR] [SPARK-51441][SQL] Add DSv2 APIs for constraints [spark]

aokolnychyi commented on PR #50253: URL: https://github.com/apache/spark/pull/50253#issuecomment-2770951237 Thank you, @gengliangwang @beliefer @dongjoon-hyun @singhpk234 @szehon-ho! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

Re: [PR] [SPARK-51441][SQL] Add DSv2 APIs for constraints [spark]

gengliangwang commented on PR #50253: URL: https://github.com/apache/spark/pull/50253#issuecomment-2770947845 Thanks, merging to master -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

Re: [PR] [SPARK-51441][SQL] Add DSv2 APIs for constraints [spark]

gengliangwang closed pull request #50253: [SPARK-51441][SQL] Add DSv2 APIs for constraints URL: https://github.com/apache/spark/pull/50253 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

Re: [PR] [SPARK-51441][SQL] Add DSv2 APIs for constraints [spark]

gengliangwang commented on PR #50253: URL: https://github.com/apache/spark/pull/50253#issuecomment-2770510424 Hi @beliefer, @dongjoon-hyun, @singhpk234 — just checking if you have any further comments on this PR. Thanks! -- This is an automated message from the Apache Git Service. To resp

Re: [PR] [SPARK-51441][SQL] Add DSv2 APIs for constraints [spark]

gengliangwang commented on code in PR #50253: URL: https://github.com/apache/spark/pull/50253#discussion_r2021829036 ## sql/catalyst/src/main/java/org/apache/spark/sql/connector/catalog/constraints/ForeignKey.java: ## @@ -0,0 +1,151 @@ +/* + * Licensed to the Apache Software Fou

Re: [PR] [SPARK-51441][SQL] Add DSv2 APIs for constraints [spark]

aokolnychyi commented on code in PR #50253: URL: https://github.com/apache/spark/pull/50253#discussion_r2021697512 ## sql/catalyst/src/main/java/org/apache/spark/sql/connector/catalog/constraints/Constraint.java: ## @@ -0,0 +1,121 @@ +/* + * Licensed to the Apache Software Found

Re: [PR] [SPARK-51441][SQL] Add DSv2 APIs for constraints [spark]

aokolnychyi commented on code in PR #50253: URL: https://github.com/apache/spark/pull/50253#discussion_r2021688278 ## sql/catalyst/src/main/java/org/apache/spark/sql/connector/catalog/constraints/BaseConstraint.java: ## @@ -0,0 +1,137 @@ +/* + * Licensed to the Apache Software F

Re: [PR] [SPARK-51441][SQL] Add DSv2 APIs for constraints [spark]

gengliangwang commented on code in PR #50253: URL: https://github.com/apache/spark/pull/50253#discussion_r2021829036 ## sql/catalyst/src/main/java/org/apache/spark/sql/connector/catalog/constraints/ForeignKey.java: ## @@ -0,0 +1,151 @@ +/* + * Licensed to the Apache Software Fou

Re: [PR] [SPARK-51441][SQL] Add DSv2 APIs for constraints [spark]

aokolnychyi commented on code in PR #50253: URL: https://github.com/apache/spark/pull/50253#discussion_r2021695162 ## sql/catalyst/src/main/java/org/apache/spark/sql/connector/catalog/constraints/Constraint.java: ## @@ -0,0 +1,121 @@ +/* + * Licensed to the Apache Software Found

Re: [PR] [SPARK-51441][SQL] Add DSv2 APIs for constraints [spark]

aokolnychyi commented on code in PR #50253: URL: https://github.com/apache/spark/pull/50253#discussion_r2021690970 ## sql/catalyst/src/main/java/org/apache/spark/sql/connector/catalog/constraints/Check.java: ## @@ -0,0 +1,132 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] [SPARK-51441][SQL] Add DSv2 APIs for constraints [spark]

aokolnychyi commented on code in PR #50253: URL: https://github.com/apache/spark/pull/50253#discussion_r2021697874 ## sql/catalyst/src/main/java/org/apache/spark/sql/connector/catalog/constraints/Constraint.java: ## @@ -0,0 +1,121 @@ +/* + * Licensed to the Apache Software Found

Re: [PR] [SPARK-51441][SQL] Add DSv2 APIs for constraints [spark]

aokolnychyi commented on code in PR #50253: URL: https://github.com/apache/spark/pull/50253#discussion_r2021696873 ## sql/catalyst/src/main/java/org/apache/spark/sql/connector/catalog/constraints/Unique.java: ## @@ -0,0 +1,102 @@ +/* + * Licensed to the Apache Software Foundatio

Re: [PR] [SPARK-51441][SQL] Add DSv2 APIs for constraints [spark]

aokolnychyi commented on code in PR #50253: URL: https://github.com/apache/spark/pull/50253#discussion_r2021696312 ## sql/catalyst/src/main/java/org/apache/spark/sql/connector/catalog/constraints/ForeignKey.java: ## @@ -0,0 +1,149 @@ +/* + * Licensed to the Apache Software Found

Re: [PR] [SPARK-51441][SQL] Add DSv2 APIs for constraints [spark]

beliefer commented on code in PR #50253: URL: https://github.com/apache/spark/pull/50253#discussion_r2019767142 ## sql/catalyst/src/main/java/org/apache/spark/sql/connector/catalog/constraints/BaseConstraint.java: ## @@ -0,0 +1,137 @@ +/* + * Licensed to the Apache Software Foun

Re: [PR] [SPARK-51441][SQL] Add DSv2 APIs for constraints [spark]

beliefer commented on code in PR #50253: URL: https://github.com/apache/spark/pull/50253#discussion_r2019773251 ## sql/catalyst/src/main/java/org/apache/spark/sql/connector/catalog/constraints/Unique.java: ## @@ -0,0 +1,102 @@ +/* + * Licensed to the Apache Software Foundation (

Re: [PR] [SPARK-51441][SQL] Add DSv2 APIs for constraints [spark]

beliefer commented on code in PR #50253: URL: https://github.com/apache/spark/pull/50253#discussion_r2019773146 ## sql/catalyst/src/main/java/org/apache/spark/sql/connector/catalog/constraints/PrimaryKey.java: ## @@ -0,0 +1,105 @@ +/* + * Licensed to the Apache Software Foundati

Re: [PR] [SPARK-51441][SQL] Add DSv2 APIs for constraints [spark]

beliefer commented on code in PR #50253: URL: https://github.com/apache/spark/pull/50253#discussion_r2019772916 ## sql/catalyst/src/main/java/org/apache/spark/sql/connector/catalog/constraints/ForeignKey.java: ## @@ -0,0 +1,149 @@ +/* + * Licensed to the Apache Software Foundati

Re: [PR] [SPARK-51441][SQL] Add DSv2 APIs for constraints [spark]

beliefer commented on code in PR #50253: URL: https://github.com/apache/spark/pull/50253#discussion_r2019772730 ## sql/catalyst/src/main/java/org/apache/spark/sql/connector/catalog/constraints/Check.java: ## @@ -0,0 +1,132 @@ +/* + * Licensed to the Apache Software Foundation (A

Re: [PR] [SPARK-51441][SQL] Add DSv2 APIs for constraints [spark]

beliefer commented on code in PR #50253: URL: https://github.com/apache/spark/pull/50253#discussion_r2019767377 ## sql/catalyst/src/main/java/org/apache/spark/sql/connector/catalog/constraints/Check.java: ## @@ -0,0 +1,132 @@ +/* + * Licensed to the Apache Software Foundation (A

Re: [PR] [SPARK-51441][SQL] Add DSv2 APIs for constraints [spark]

beliefer commented on code in PR #50253: URL: https://github.com/apache/spark/pull/50253#discussion_r201974 ## sql/catalyst/src/main/java/org/apache/spark/sql/connector/catalog/constraints/Constraint.java: ## @@ -0,0 +1,121 @@ +/* + * Licensed to the Apache Software Foundati

Re: [PR] [SPARK-51441][SQL] Add DSv2 APIs for constraints [spark]

beliefer commented on code in PR #50253: URL: https://github.com/apache/spark/pull/50253#discussion_r2019766568 ## sql/catalyst/src/main/java/org/apache/spark/sql/connector/catalog/constraints/Constraint.java: ## @@ -0,0 +1,121 @@ +/* + * Licensed to the Apache Software Foundati

Re: [PR] [SPARK-51441][SQL] Add DSv2 APIs for constraints [spark]

szehon-ho commented on code in PR #50253: URL: https://github.com/apache/spark/pull/50253#discussion_r2019748826 ## sql/catalyst/src/main/java/org/apache/spark/sql/connector/catalog/constraints/Constraint.java: ## @@ -0,0 +1,121 @@ +/* + * Licensed to the Apache Software Foundat

Re: [PR] [SPARK-51441][SQL] Add DSv2 APIs for constraints [spark]

aokolnychyi commented on code in PR #50253: URL: https://github.com/apache/spark/pull/50253#discussion_r2019388447 ## sql/catalyst/src/main/java/org/apache/spark/sql/connector/catalog/constraints/Check.java: ## @@ -0,0 +1,132 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] [SPARK-51441][SQL] Add DSv2 APIs for constraints [spark]

gengliangwang commented on PR #50253: URL: https://github.com/apache/spark/pull/50253#issuecomment-2762734695 I will merge this one next Monday if there are no more comments -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] [SPARK-51441][SQL] Add DSv2 APIs for constraints [spark]

gengliangwang commented on code in PR #50253: URL: https://github.com/apache/spark/pull/50253#discussion_r2019243439 ## sql/catalyst/src/main/java/org/apache/spark/sql/connector/catalog/constraints/Check.java: ## @@ -0,0 +1,132 @@ +/* + * Licensed to the Apache Software Foundati

Re: [PR] [SPARK-51441][SQL] Add DSv2 APIs for constraints [spark]

aokolnychyi commented on code in PR #50253: URL: https://github.com/apache/spark/pull/50253#discussion_r2019058527 ## sql/catalyst/src/main/java/org/apache/spark/sql/connector/catalog/constraints/Check.java: ## @@ -0,0 +1,125 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] [SPARK-51441][SQL] Add DSv2 APIs for constraints [spark]

aokolnychyi commented on code in PR #50253: URL: https://github.com/apache/spark/pull/50253#discussion_r2019055927 ## sql/catalyst/src/main/java/org/apache/spark/sql/connector/catalog/constraints/Check.java: ## @@ -0,0 +1,125 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] [SPARK-51441][SQL] Add DSv2 APIs for constraints [spark]

aokolnychyi commented on code in PR #50253: URL: https://github.com/apache/spark/pull/50253#discussion_r2019056747 ## sql/catalyst/src/main/java/org/apache/spark/sql/connector/catalog/constraints/BaseConstraint.java: ## @@ -0,0 +1,135 @@ +/* + * Licensed to the Apache Software F

Re: [PR] [SPARK-51441][SQL] Add DSv2 APIs for constraints [spark]

beliefer commented on code in PR #50253: URL: https://github.com/apache/spark/pull/50253#discussion_r2017839853 ## sql/catalyst/src/main/java/org/apache/spark/sql/connector/catalog/constraints/Check.java: ## @@ -0,0 +1,125 @@ +/* + * Licensed to the Apache Software Foundation (A

Re: [PR] [SPARK-51441][SQL] Add DSv2 APIs for constraints [spark]

beliefer commented on code in PR #50253: URL: https://github.com/apache/spark/pull/50253#discussion_r2017839061 ## sql/catalyst/src/main/java/org/apache/spark/sql/connector/catalog/constraints/Check.java: ## @@ -0,0 +1,125 @@ +/* + * Licensed to the Apache Software Foundation (A

Re: [PR] [SPARK-51441][SQL] Add DSv2 APIs for constraints [spark]

beliefer commented on code in PR #50253: URL: https://github.com/apache/spark/pull/50253#discussion_r2017836996 ## sql/catalyst/src/main/java/org/apache/spark/sql/connector/catalog/constraints/BaseConstraint.java: ## @@ -0,0 +1,135 @@ +/* + * Licensed to the Apache Software Foun

Re: [PR] [SPARK-51441][SQL] Add DSv2 APIs for constraints [spark]

gengliangwang commented on code in PR #50253: URL: https://github.com/apache/spark/pull/50253#discussion_r2017744155 ## sql/catalyst/src/main/java/org/apache/spark/sql/connector/catalog/constraints/Check.java: ## @@ -0,0 +1,125 @@ +/* + * Licensed to the Apache Software Foundati

Re: [PR] [SPARK-51441][SQL] Add DSv2 APIs for constraints [spark]

aokolnychyi commented on code in PR #50253: URL: https://github.com/apache/spark/pull/50253#discussion_r2017716870 ## sql/catalyst/src/main/java/org/apache/spark/sql/connector/catalog/constraints/Check.java: ## @@ -0,0 +1,125 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] [SPARK-51441][SQL] Add DSv2 APIs for constraints [spark]

aokolnychyi commented on code in PR #50253: URL: https://github.com/apache/spark/pull/50253#discussion_r2017716214 ## sql/catalyst/src/main/java/org/apache/spark/sql/connector/catalog/constraints/Check.java: ## @@ -0,0 +1,125 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] [SPARK-51441][SQL] Add DSv2 APIs for constraints [spark]

aokolnychyi commented on code in PR #50253: URL: https://github.com/apache/spark/pull/50253#discussion_r2017667999 ## sql/catalyst/src/test/scala/org/apache/spark/sql/connector/catalog/ConstraintSuite.scala: ## @@ -0,0 +1,136 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] [SPARK-51441][SQL] Add DSv2 APIs for constraints [spark]

gengliangwang commented on code in PR #50253: URL: https://github.com/apache/spark/pull/50253#discussion_r2017545379 ## sql/catalyst/src/main/java/org/apache/spark/sql/connector/catalog/constraints/Check.java: ## @@ -0,0 +1,125 @@ +/* + * Licensed to the Apache Software Foundati

Re: [PR] [SPARK-51441][SQL] Add DSv2 APIs for constraints [spark]

gengliangwang commented on code in PR #50253: URL: https://github.com/apache/spark/pull/50253#discussion_r2017540301 ## sql/catalyst/src/test/scala/org/apache/spark/sql/connector/catalog/ConstraintSuite.scala: ## @@ -0,0 +1,136 @@ +/* + * Licensed to the Apache Software Foundati

Re: [PR] [SPARK-51441][SQL] Add DSv2 APIs for constraints [spark]

aokolnychyi closed pull request #50253: [SPARK-51441][SQL] Add DSv2 APIs for constraints URL: https://github.com/apache/spark/pull/50253 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [SPARK-51441][SQL] Add DSv2 APIs for constraints [spark]

aokolnychyi commented on code in PR #50253: URL: https://github.com/apache/spark/pull/50253#discussion_r2006450589 ## sql/catalyst/src/main/java/org/apache/spark/sql/connector/catalog/constraints/Check.java: ## @@ -0,0 +1,90 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] [SPARK-51441][SQL] Add DSv2 APIs for constraints [spark]

aokolnychyi commented on code in PR #50253: URL: https://github.com/apache/spark/pull/50253#discussion_r2006450047 ## sql/catalyst/src/main/java/org/apache/spark/sql/connector/catalog/constraints/Constraint.java: ## @@ -0,0 +1,128 @@ +/* + * Licensed to the Apache Software Found

Re: [PR] [SPARK-51441][SQL] Add DSv2 APIs for constraints [spark]

aokolnychyi commented on code in PR #50253: URL: https://github.com/apache/spark/pull/50253#discussion_r2006452472 ## sql/catalyst/src/main/java/org/apache/spark/sql/connector/catalog/constraints/Constraint.java: ## @@ -0,0 +1,128 @@ +/* + * Licensed to the Apache Software Found

Re: [PR] [SPARK-51441][SQL] Add DSv2 APIs for constraints [spark]

aokolnychyi commented on code in PR #50253: URL: https://github.com/apache/spark/pull/50253#discussion_r2006436172 ## sql/catalyst/src/main/java/org/apache/spark/sql/connector/catalog/constraints/ForeignKey.java: ## @@ -0,0 +1,104 @@ +/* + * Licensed to the Apache Software Found

Re: [PR] [SPARK-51441][SQL] Add DSv2 APIs for constraints [spark]

aokolnychyi commented on code in PR #50253: URL: https://github.com/apache/spark/pull/50253#discussion_r2006431228 ## sql/catalyst/src/main/java/org/apache/spark/sql/connector/catalog/constraints/BaseConstraint.java: ## @@ -0,0 +1,71 @@ +/* + * Licensed to the Apache Software Fo

Re: [PR] [SPARK-51441][SQL] Add DSv2 APIs for constraints [spark]

singhpk234 commented on code in PR #50253: URL: https://github.com/apache/spark/pull/50253#discussion_r1997406617 ## sql/catalyst/src/main/java/org/apache/spark/sql/connector/catalog/constraints/Constraint.java: ## @@ -0,0 +1,128 @@ +/* + * Licensed to the Apache Software Founda

Re: [PR] [SPARK-51441][SQL] Add DSv2 APIs for constraints [spark]

singhpk234 commented on code in PR #50253: URL: https://github.com/apache/spark/pull/50253#discussion_r1997406617 ## sql/catalyst/src/main/java/org/apache/spark/sql/connector/catalog/constraints/Constraint.java: ## @@ -0,0 +1,128 @@ +/* + * Licensed to the Apache Software Founda

Re: [PR] [SPARK-51441][SQL] Add DSv2 APIs for constraints [spark]

dongjoon-hyun commented on code in PR #50253: URL: https://github.com/apache/spark/pull/50253#discussion_r1993739512 ## sql/catalyst/src/main/java/org/apache/spark/sql/connector/catalog/constraints/ForeignKey.java: ## @@ -0,0 +1,104 @@ +/* + * Licensed to the Apache Software Fou

Re: [PR] [SPARK-51441][SQL] Add DSv2 APIs for constraints [spark]

dongjoon-hyun commented on code in PR #50253: URL: https://github.com/apache/spark/pull/50253#discussion_r1993729490 ## sql/catalyst/src/main/java/org/apache/spark/sql/connector/catalog/constraints/Constraint.java: ## @@ -0,0 +1,128 @@ +/* + * Licensed to the Apache Software Fou

Re: [PR] [SPARK-51441][SQL] Add DSv2 APIs for constraints [spark]

dongjoon-hyun commented on code in PR #50253: URL: https://github.com/apache/spark/pull/50253#discussion_r1993729490 ## sql/catalyst/src/main/java/org/apache/spark/sql/connector/catalog/constraints/Constraint.java: ## @@ -0,0 +1,128 @@ +/* + * Licensed to the Apache Software Fou

Re: [PR] [SPARK-51441][SQL] Add DSv2 APIs for constraints [spark]

dongjoon-hyun commented on code in PR #50253: URL: https://github.com/apache/spark/pull/50253#discussion_r1993729490 ## sql/catalyst/src/main/java/org/apache/spark/sql/connector/catalog/constraints/Constraint.java: ## @@ -0,0 +1,128 @@ +/* + * Licensed to the Apache Software Fou

Re: [PR] [SPARK-51441][SQL] Add DSv2 APIs for constraints [spark]

dongjoon-hyun commented on code in PR #50253: URL: https://github.com/apache/spark/pull/50253#discussion_r1993731273 ## sql/catalyst/src/main/java/org/apache/spark/sql/connector/catalog/constraints/Constraint.java: ## @@ -0,0 +1,128 @@ +/* + * Licensed to the Apache Software Fou

Re: [PR] [SPARK-51441][SQL] Add DSv2 APIs for constraints [spark]

dongjoon-hyun commented on code in PR #50253: URL: https://github.com/apache/spark/pull/50253#discussion_r1993729490 ## sql/catalyst/src/main/java/org/apache/spark/sql/connector/catalog/constraints/Constraint.java: ## @@ -0,0 +1,128 @@ +/* + * Licensed to the Apache Software Fou

Re: [PR] [SPARK-51441][SQL] Add DSv2 APIs for constraints [spark]

dongjoon-hyun commented on code in PR #50253: URL: https://github.com/apache/spark/pull/50253#discussion_r1993722344 ## sql/catalyst/src/main/java/org/apache/spark/sql/connector/catalog/constraints/BaseConstraint.java: ## @@ -0,0 +1,71 @@ +/* + * Licensed to the Apache Software