beliefer commented on code in PR #50253: URL: https://github.com/apache/spark/pull/50253#discussion_r2019767142
########## sql/catalyst/src/main/java/org/apache/spark/sql/connector/catalog/constraints/BaseConstraint.java: ########## @@ -0,0 +1,137 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.spark.sql.connector.catalog.constraints; + +import java.util.StringJoiner; + +import org.apache.spark.sql.connector.expressions.NamedReference; + +abstract class BaseConstraint implements Constraint { + + private final String name; + private final boolean enforced; + private final ValidationStatus validationStatus; + private final boolean rely; + + protected BaseConstraint( + String name, + boolean enforced, + ValidationStatus validationStatus, + boolean rely) { + this.name = name; + this.enforced = enforced; + this.validationStatus = validationStatus; + this.rely = rely; + } + + protected abstract String definition(); + + @Override + public String name() { + return name; + } + + @Override + public boolean enforced() { + return enforced; + } + + @Override + public ValidationStatus validationStatus() { + return validationStatus; + } + + @Override + public boolean rely() { + return rely; + } + + @Override + public String toDDL() { + return String.format( + "CONSTRAINT %s %s %s %s %s", + name, + definition(), + enforced ? "ENFORCED" : "NOT ENFORCED", + validationStatus, + rely ? "RELY" : "NORELY"); + } + + @Override + public String toString() { + return toDDL(); + } + + protected String toDDL(NamedReference[] columns) { Review Comment: How about `joinColumns` ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
