dongjoon-hyun commented on code in PR #50253: URL: https://github.com/apache/spark/pull/50253#discussion_r1993729490
########## sql/catalyst/src/main/java/org/apache/spark/sql/connector/catalog/constraints/Constraint.java: ########## @@ -0,0 +1,128 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.spark.sql.connector.catalog.constraints; + +import org.apache.spark.annotation.Evolving; +import org.apache.spark.sql.connector.catalog.Identifier; +import org.apache.spark.sql.connector.expressions.NamedReference; +import org.apache.spark.sql.connector.expressions.filter.Predicate; + +/** + * A constraint that defines valid states of data in a table. + * + * @since 4.1.0 + */ +@Evolving +public interface Constraint { + /** + * Returns the name of this constraint. + */ + String name(); + + /** + * Returns the definition of this constraint in DDL format. + */ + String toDDL(); + + /** + * Returns the state of this constraint. + */ + ConstraintState state(); + + /** + * Creates a CHECK constraint with a search condition defined in SQL (Spark SQL dialect). + * + * @param name the constraint name + * @param sql the SQL representation of the search condition (Spark SQL dialect) + * @param state the constraint state + * @return a CHECK constraint with the provided configuration + */ + static Check check(String name, String sql, ConstraintState state) { + return new Check(name, sql, null /* no predicate */, state); Review Comment: Shall we use Java `Optional.empty()` instead of `null`? IIRC, this `null` was not a part of SPIP, wan't it? Please correct me if there is a reason to have `null`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
