Re: [PR] [SPARK-51419][SQL] Get hours of TIME datatype [spark]

2025-04-09 Thread via GitHub
senthh commented on code in PR #50355: URL: https://github.com/apache/spark/pull/50355#discussion_r2036545758 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/timeExpressions.scala: ## @@ -233,3 +233,60 @@ object MinuteExpressionBuilder extends Expression

Re: [PR] [SPARK-51419][SQL] Get hours of TIME datatype [spark]

2025-04-09 Thread via GitHub
MaxGekk commented on code in PR #50355: URL: https://github.com/apache/spark/pull/50355#discussion_r2035305029 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/timeExpressions.scala: ## @@ -233,3 +233,60 @@ object MinuteExpressionBuilder extends Expressio

Re: [PR] [SPARK-51419][SQL] Get hours of TIME datatype [spark]

2025-03-25 Thread via GitHub
senthh commented on PR #50355: URL: https://github.com/apache/spark/pull/50355#issuecomment-2753355194 @MaxGekk @HyukjinKwon @beliefer Thank you for patiently reviewing my PR -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

Re: [PR] [SPARK-51419][SQL] Get hours of TIME datatype [spark]

2025-03-25 Thread via GitHub
MaxGekk closed pull request #50355: [SPARK-51419][SQL] Get hours of TIME datatype URL: https://github.com/apache/spark/pull/50355 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

Re: [PR] [SPARK-51419][SQL] Get hours of TIME datatype [spark]

2025-03-25 Thread via GitHub
MaxGekk commented on PR #50355: URL: https://github.com/apache/spark/pull/50355#issuecomment-2753342009 The test failure is not related to the changes, I believe: ``` [info] - SPARK-51097: Verify snapshot lag metrics are updated correctly with RocksDBStateStoreProvider (with changelog

Re: [PR] [SPARK-51419][SQL] Get hours of TIME datatype [spark]

2025-03-25 Thread via GitHub
senthh commented on code in PR #50355: URL: https://github.com/apache/spark/pull/50355#discussion_r2013274760 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/timeExpressions.scala: ## @@ -233,3 +233,62 @@ object MinuteExpressionBuilder extends Expression

Re: [PR] [SPARK-51419][SQL] Get hours of TIME datatype [spark]

2025-03-25 Thread via GitHub
MaxGekk commented on code in PR #50355: URL: https://github.com/apache/spark/pull/50355#discussion_r2012779809 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/timeExpressions.scala: ## @@ -233,3 +233,62 @@ object MinuteExpressionBuilder extends Expressio

Re: [PR] [SPARK-51419][SQL] Get hours of TIME datatype [spark]

2025-03-25 Thread via GitHub
senthh commented on code in PR #50355: URL: https://github.com/apache/spark/pull/50355#discussion_r2011945249 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/timeExpressions.scala: ## @@ -233,3 +233,73 @@ object MinuteExpressionBuilder extends Expression

Re: [PR] [SPARK-51419][SQL] Get hours of TIME datatype [spark]

2025-03-25 Thread via GitHub
senthh commented on code in PR #50355: URL: https://github.com/apache/spark/pull/50355#discussion_r2011945249 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/timeExpressions.scala: ## @@ -233,3 +233,73 @@ object MinuteExpressionBuilder extends Expression

Re: [PR] [SPARK-51419][SQL] Get hours of TIME datatype [spark]

2025-03-25 Thread via GitHub
senthh commented on code in PR #50355: URL: https://github.com/apache/spark/pull/50355#discussion_r2011945249 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/timeExpressions.scala: ## @@ -233,3 +233,73 @@ object MinuteExpressionBuilder extends Expression

Re: [PR] [SPARK-51419][SQL] Get hours of TIME datatype [spark]

2025-03-25 Thread via GitHub
MaxGekk commented on code in PR #50355: URL: https://github.com/apache/spark/pull/50355#discussion_r2011915228 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/timeExpressions.scala: ## @@ -233,3 +233,73 @@ object MinuteExpressionBuilder extends Expressio

Re: [PR] [SPARK-51419][SQL] Get hours of TIME datatype [spark]

2025-03-25 Thread via GitHub
MaxGekk commented on code in PR #50355: URL: https://github.com/apache/spark/pull/50355#discussion_r2011769945 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/timeExpressions.scala: ## @@ -233,3 +233,73 @@ object MinuteExpressionBuilder extends Expressio

Re: [PR] [SPARK-51419][SQL] Get hours of TIME datatype [spark]

2025-03-25 Thread via GitHub
senthh commented on code in PR #50355: URL: https://github.com/apache/spark/pull/50355#discussion_r2011876637 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/timeExpressions.scala: ## @@ -233,3 +233,73 @@ object MinuteExpressionBuilder extends Expression

Re: [PR] [SPARK-51419][SQL] Get hours of TIME datatype [spark]

2025-03-25 Thread via GitHub
senthh commented on code in PR #50355: URL: https://github.com/apache/spark/pull/50355#discussion_r2011826801 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/timeExpressions.scala: ## @@ -233,3 +233,73 @@ object MinuteExpressionBuilder extends Expression

Re: [PR] [SPARK-51419][SQL] Get hours of TIME datatype [spark]

2025-03-25 Thread via GitHub
senthh commented on code in PR #50355: URL: https://github.com/apache/spark/pull/50355#discussion_r2011759656 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/timeExpressions.scala: ## @@ -233,3 +233,73 @@ object MinuteExpressionBuilder extends Expression

Re: [PR] [SPARK-51419][SQL] Get hours of TIME datatype [spark]

2025-03-25 Thread via GitHub
MaxGekk commented on code in PR #50355: URL: https://github.com/apache/spark/pull/50355#discussion_r2011492293 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/timeExpressions.scala: ## @@ -233,3 +233,73 @@ object MinuteExpressionBuilder extends Expressio

Re: [PR] [SPARK-51419][SQL] Get hours of TIME datatype [spark]

2025-03-24 Thread via GitHub
HyukjinKwon commented on code in PR #50355: URL: https://github.com/apache/spark/pull/50355#discussion_r2011373286 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/timeExpressions.scala: ## @@ -233,3 +233,73 @@ object MinuteExpressionBuilder extends Expre