HyukjinKwon commented on code in PR #50355: URL: https://github.com/apache/spark/pull/50355#discussion_r2011373286
########## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/timeExpressions.scala: ########## @@ -233,3 +233,73 @@ object MinuteExpressionBuilder extends ExpressionBuilder { } } } + +@ExpressionDescription( + usage = """ + _FUNC_(time_expr) - Returns the hour component of the given time. + """, + examples = """ + Examples: + > SELECT _FUNC_(TIME'11:35:35.999999'); + 11 + """, + since = "4.1.0", Review Comment: I am still confused by this. We registered `HourExpressionBuilder` so this description won't be shown via `DESC FUNCTION EXTENDED hour` right? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org