MaxGekk commented on PR #50355: URL: https://github.com/apache/spark/pull/50355#issuecomment-2753342009
The test failure is not related to the changes, I believe: ``` [info] - SPARK-51097: Verify snapshot lag metrics are updated correctly with RocksDBStateStoreProvider (with changelog checkpointing) *** FAILED *** (11 seconds, 275 milliseconds) [info] Assert on query failed: Execute: The code passed to eventually never returned normally. Attempted 667 times over 10.010695936 seconds. Last failure message: instanceMetrics.forall(((x$2: (String, Long)) => x$2._2.==(2))) was false. ``` +1, LGTM. Merging to master. Thank you, @senthh and @HyukjinKwon @beliefer for review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
