MaxGekk commented on code in PR #50355:
URL: https://github.com/apache/spark/pull/50355#discussion_r2012779809
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/timeExpressions.scala:
##########
@@ -233,3 +233,62 @@ object MinuteExpressionBuilder extends ExpressionBuilder {
}
}
}
+
+// scalastyle:on line.size.limit
+case class HoursOfTime(child: Expression)
+ extends RuntimeReplaceable
+ with ExpectsInputTypes {
+
+ override def replacement: Expression = StaticInvoke(
+ classOf[DateTimeUtils.type],
+ IntegerType,
+ "getHoursOfTime",
+ Seq(child),
+ Seq(child.dataType)
+ )
+
+ override def inputTypes: Seq[AbstractDataType] = Seq(TimeType())
+
+ override def children: Seq[Expression] = Seq(child)
+
+ override def prettyName: String = "hour"
+
+ override protected def withNewChildrenInternal(
+ newChildren: IndexedSeq[Expression]): Expression = {
+ copy(child = newChildren.head)
+ }
+}
+
+@ExpressionDescription(
+ usage = """
+ _FUNC_(expr) - Returns the hour component of the given expression.
+
+ If `expr` is a TIMESTAMP or a string that can be cast to timestamp,
+ it returns the hour of that timestamp.
+ If `expr` is a TIME type (since 4.1.0), it returns the hour of the
time-of-day.
+ """,
+ examples = """
+ Examples:
+ > SELECT _FUNC_('2018-02-14 12:58:59');
+ 12
+ > SELECT _FUNC_(TIME'13:59:59.999999');
+ 13
+ """,
+ since = "1.5.0",
+ group = "datetime_funcs")
+// scalastyle:on line.size.limit
Review Comment:
Remove it.
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/timeExpressions.scala:
##########
@@ -233,3 +233,62 @@ object MinuteExpressionBuilder extends ExpressionBuilder {
}
}
}
+
+// scalastyle:on line.size.limit
Review Comment:
It is not needed, it seems. Could you remove it, please.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
