Re: [PR] [SPARK-51350][SQL] Implement Show Procedures [spark]

2025-04-05 Thread via GitHub
cloud-fan commented on code in PR #50109: URL: https://github.com/apache/spark/pull/50109#discussion_r2011716165 ## sql/core/src/main/scala/org/apache/spark/sql/execution/command/ShowProceduresCommand.scala: ## @@ -0,0 +1,69 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] [SPARK-51350][SQL] Implement Show Procedures [spark]

2025-04-05 Thread via GitHub
szehon-ho commented on PR #50109: URL: https://github.com/apache/spark/pull/50109#issuecomment-2752721518 failure looks unrelated, re-runnng -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

Re: [PR] [SPARK-51350][SQL] Implement Show Procedures [spark]

2025-04-04 Thread via GitHub
szehon-ho commented on PR #50109: URL: https://github.com/apache/spark/pull/50109#issuecomment-2741789689 Rebased. FYI I split out part of this pr https://github.com/apache/spark/pull/50329 to make this slightly smaller, but its optional -- This is an automated message from the Apache G

Re: [PR] [SPARK-51350][SQL] Implement Show Procedures [spark]

2025-04-04 Thread via GitHub
aokolnychyi commented on code in PR #50109: URL: https://github.com/apache/spark/pull/50109#discussion_r2008414173 ## sql/catalyst/src/main/java/org/apache/spark/sql/connector/catalog/CatalogPlugin.java: ## @@ -74,4 +74,12 @@ public interface CatalogPlugin { default String[]

Re: [PR] [SPARK-51350][SQL] Implement Show Procedures [spark]

2025-03-27 Thread via GitHub
aokolnychyi commented on PR #50109: URL: https://github.com/apache/spark/pull/50109#issuecomment-2758556795 LGTM as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [SPARK-51350][SQL] Implement Show Procedures [spark]

2025-03-27 Thread via GitHub
szehon-ho commented on code in PR #50109: URL: https://github.com/apache/spark/pull/50109#discussion_r2008483160 ## sql/core/src/test/scala/org/apache/spark/sql/connector/ProcedureSuite.scala: ## @@ -40,15 +40,23 @@ class ProcedureSuite extends QueryTest with SharedSparkSession

Re: [PR] [SPARK-51350][SQL] Implement Show Procedures [spark]

2025-03-26 Thread via GitHub
aokolnychyi commented on code in PR #50109: URL: https://github.com/apache/spark/pull/50109#discussion_r2008407964 ## sql/catalyst/src/main/java/org/apache/spark/sql/connector/catalog/ProcedureCatalog.java: ## @@ -34,4 +34,11 @@ public interface ProcedureCatalog extends CatalogP

Re: [PR] [SPARK-51350][SQL] Implement Show Procedures [spark]

2025-03-26 Thread via GitHub
cloud-fan commented on PR #50109: URL: https://github.com/apache/spark/pull/50109#issuecomment-2753413446 thanks, merging to master! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

Re: [PR] [SPARK-51350][SQL] Implement Show Procedures [spark]

2025-03-26 Thread via GitHub
cloud-fan closed pull request #50109: [SPARK-51350][SQL] Implement Show Procedures URL: https://github.com/apache/spark/pull/50109 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

Re: [PR] [SPARK-51350][SQL] Implement Show Procedures [spark]

2025-03-25 Thread via GitHub
szehon-ho commented on code in PR #50109: URL: https://github.com/apache/spark/pull/50109#discussion_r2012737340 ## sql/core/src/main/scala/org/apache/spark/sql/execution/command/ShowProceduresCommand.scala: ## @@ -0,0 +1,69 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] [SPARK-51350][SQL] Implement Show Procedures [spark]

2025-03-25 Thread via GitHub
cloud-fan commented on code in PR #50109: URL: https://github.com/apache/spark/pull/50109#discussion_r2011717787 ## sql/core/src/main/scala/org/apache/spark/sql/execution/command/ShowProceduresCommand.scala: ## @@ -0,0 +1,69 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] [SPARK-51350][SQL] Implement Show Procedures [spark]

2025-03-24 Thread via GitHub
szehon-ho commented on code in PR #50109: URL: https://github.com/apache/spark/pull/50109#discussion_r2010649599 ## sql/core/src/main/scala/org/apache/spark/sql/execution/command/ShowProceduresCommand.scala: ## @@ -0,0 +1,69 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] [SPARK-51350][SQL] Implement Show Procedures [spark]

2025-03-24 Thread via GitHub
cloud-fan commented on code in PR #50109: URL: https://github.com/apache/spark/pull/50109#discussion_r2009933420 ## sql/core/src/main/scala/org/apache/spark/sql/execution/command/ShowProceduresCommand.scala: ## @@ -0,0 +1,69 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] [SPARK-51350][SQL] Implement Show Procedures [spark]

2025-03-24 Thread via GitHub
cloud-fan commented on code in PR #50109: URL: https://github.com/apache/spark/pull/50109#discussion_r2009909586 ## sql/core/src/main/scala/org/apache/spark/sql/execution/command/ShowProceduresCommand.scala: ## @@ -0,0 +1,69 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] [SPARK-51350][SQL] Implement Show Procedures [spark]

2025-03-24 Thread via GitHub
cloud-fan commented on code in PR #50109: URL: https://github.com/apache/spark/pull/50109#discussion_r2009903677 ## sql/core/src/main/scala/org/apache/spark/sql/execution/command/ShowProceduresCommand.scala: ## @@ -0,0 +1,69 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] [SPARK-51350][SQL] Implement Show Procedures [spark]

2025-03-23 Thread via GitHub
szehon-ho commented on code in PR #50109: URL: https://github.com/apache/spark/pull/50109#discussion_r2006543439 ## sql/catalyst/src/main/java/org/apache/spark/sql/connector/catalog/ProcedureCatalog.java: ## @@ -34,4 +34,11 @@ public interface ProcedureCatalog extends CatalogPlu

Re: [PR] [SPARK-51350][SQL] Implement Show Procedures [spark]

2025-03-22 Thread via GitHub
aokolnychyi commented on code in PR #50109: URL: https://github.com/apache/spark/pull/50109#discussion_r2008416435 ## sql/core/src/main/scala/org/apache/spark/sql/execution/command/ShowProceduresCommand.scala: ## @@ -0,0 +1,69 @@ +/* + * Licensed to the Apache Software Foundatio

Re: [PR] [SPARK-51350][SQL] Implement Show Procedures [spark]

2025-03-22 Thread via GitHub
aokolnychyi commented on code in PR #50109: URL: https://github.com/apache/spark/pull/50109#discussion_r2008408216 ## sql/catalyst/src/main/java/org/apache/spark/sql/connector/catalog/ProcedureCatalog.java: ## @@ -34,4 +34,9 @@ public interface ProcedureCatalog extends CatalogPl

Re: [PR] [SPARK-51350][SQL] Implement Show Procedures [spark]

2025-03-21 Thread via GitHub
aokolnychyi commented on code in PR #50109: URL: https://github.com/apache/spark/pull/50109#discussion_r2008438853 ## sql/catalyst/src/main/java/org/apache/spark/sql/connector/catalog/ProcedureCatalog.java: ## @@ -34,4 +34,11 @@ public interface ProcedureCatalog extends CatalogP

Re: [PR] [SPARK-51350][SQL] Implement Show Procedures [spark]

2025-03-21 Thread via GitHub
szehon-ho commented on code in PR #50109: URL: https://github.com/apache/spark/pull/50109#discussion_r2008452023 ## sql/catalyst/src/main/java/org/apache/spark/sql/connector/catalog/ProcedureCatalog.java: ## @@ -34,4 +34,11 @@ public interface ProcedureCatalog extends CatalogPlu

Re: [PR] [SPARK-51350][SQL] Implement Show Procedures [spark]

2025-03-21 Thread via GitHub
aokolnychyi commented on code in PR #50109: URL: https://github.com/apache/spark/pull/50109#discussion_r2008435817 ## sql/core/src/main/scala/org/apache/spark/sql/execution/command/ShowProceduresCommand.scala: ## @@ -0,0 +1,69 @@ +/* + * Licensed to the Apache Software Foundatio

Re: [PR] [SPARK-51350][SQL] Implement Show Procedures [spark]

2025-03-21 Thread via GitHub
szehon-ho commented on code in PR #50109: URL: https://github.com/apache/spark/pull/50109#discussion_r2008434712 ## sql/catalyst/src/main/java/org/apache/spark/sql/connector/catalog/ProcedureCatalog.java: ## @@ -34,4 +34,11 @@ public interface ProcedureCatalog extends CatalogPlu

Re: [PR] [SPARK-51350][SQL] Implement Show Procedures [spark]

2025-03-21 Thread via GitHub
aokolnychyi commented on code in PR #50109: URL: https://github.com/apache/spark/pull/50109#discussion_r2008419447 ## sql/core/src/main/scala/org/apache/spark/sql/execution/command/ShowProceduresCommand.scala: ## @@ -0,0 +1,69 @@ +/* + * Licensed to the Apache Software Foundatio

Re: [PR] [SPARK-51350][SQL] Implement Show Procedures [spark]

2025-03-21 Thread via GitHub
aokolnychyi commented on code in PR #50109: URL: https://github.com/apache/spark/pull/50109#discussion_r2008407964 ## sql/catalyst/src/main/java/org/apache/spark/sql/connector/catalog/ProcedureCatalog.java: ## @@ -34,4 +34,11 @@ public interface ProcedureCatalog extends CatalogP

Re: [PR] [SPARK-51350][SQL] Implement Show Procedures [spark]

2025-03-21 Thread via GitHub
aokolnychyi commented on code in PR #50109: URL: https://github.com/apache/spark/pull/50109#discussion_r2008408216 ## sql/catalyst/src/main/java/org/apache/spark/sql/connector/catalog/ProcedureCatalog.java: ## @@ -34,4 +34,9 @@ public interface ProcedureCatalog extends CatalogPl

Re: [PR] [SPARK-51350][SQL] Implement Show Procedures [spark]

2025-03-21 Thread via GitHub
aokolnychyi commented on code in PR #50109: URL: https://github.com/apache/spark/pull/50109#discussion_r2008407964 ## sql/catalyst/src/main/java/org/apache/spark/sql/connector/catalog/ProcedureCatalog.java: ## @@ -34,4 +34,11 @@ public interface ProcedureCatalog extends CatalogP

Re: [PR] [SPARK-51350][SQL] Implement Show Procedures [spark]

2025-03-19 Thread via GitHub
szehon-ho commented on code in PR #50109: URL: https://github.com/apache/spark/pull/50109#discussion_r2004544291 ## sql/core/src/main/scala/org/apache/spark/sql/execution/command/ShowProceduresCommand.scala: ## @@ -0,0 +1,54 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] [SPARK-51350][SQL] Implement Show Procedures [spark]

2025-03-19 Thread via GitHub
szehon-ho commented on code in PR #50109: URL: https://github.com/apache/spark/pull/50109#discussion_r2004543517 ## sql/core/src/main/scala/org/apache/spark/sql/execution/command/ShowProceduresCommand.scala: ## @@ -0,0 +1,54 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] [SPARK-51350][SQL] Implement Show Procedures [spark]

2025-03-19 Thread via GitHub
szehon-ho commented on PR #50109: URL: https://github.com/apache/spark/pull/50109#issuecomment-2738647847 Synced offline with @cloud-fan and @srielau , the show xxx output is better to be 'one column per qualifier' in general for ease of parsing by user. To deal with multi-part namesp

Re: [PR] [SPARK-51350][SQL] Implement Show Procedures [spark]

2025-03-13 Thread via GitHub
szehon-ho commented on code in PR #50109: URL: https://github.com/apache/spark/pull/50109#discussion_r1993927792 ## sql/catalyst/src/test/scala/org/apache/spark/sql/connector/catalog/InMemoryTableCatalog.scala: ## @@ -268,6 +268,11 @@ class InMemoryTableCatalog extends BasicInM

Re: [PR] [SPARK-51350][SQL] Implement Show Procedures [spark]

2025-03-13 Thread via GitHub
cloud-fan commented on code in PR #50109: URL: https://github.com/apache/spark/pull/50109#discussion_r1993740184 ## sql/core/src/test/scala/org/apache/spark/sql/connector/ProcedureSuite.scala: ## @@ -40,15 +40,23 @@ class ProcedureSuite extends QueryTest with SharedSparkSession

Re: [PR] [SPARK-51350][SQL] Implement Show Procedures [spark]

2025-03-13 Thread via GitHub
cloud-fan commented on code in PR #50109: URL: https://github.com/apache/spark/pull/50109#discussion_r1993737628 ## sql/core/src/main/scala/org/apache/spark/sql/execution/command/ShowProceduresCommand.scala: ## @@ -0,0 +1,54 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] [SPARK-51350][SQL] Implement Show Procedures [spark]

2025-03-13 Thread via GitHub
cloud-fan commented on code in PR #50109: URL: https://github.com/apache/spark/pull/50109#discussion_r1993734437 ## sql/catalyst/src/test/scala/org/apache/spark/sql/connector/catalog/InMemoryTableCatalog.scala: ## @@ -268,6 +268,11 @@ class InMemoryTableCatalog extends BasicInM

Re: [PR] [SPARK-51350][SQL] Implement Show Procedures [spark]

2025-03-13 Thread via GitHub
cloud-fan commented on code in PR #50109: URL: https://github.com/apache/spark/pull/50109#discussion_r1993733934 ## sql/catalyst/src/test/scala/org/apache/spark/sql/connector/catalog/InMemoryTableCatalog.scala: ## @@ -268,6 +268,11 @@ class InMemoryTableCatalog extends BasicInM

Re: [PR] [SPARK-51350][SQL] Implement Show Procedures [spark]

2025-03-13 Thread via GitHub
cloud-fan commented on code in PR #50109: URL: https://github.com/apache/spark/pull/50109#discussion_r1993728678 ## sql/catalyst/src/main/java/org/apache/spark/sql/connector/catalog/ProcedureCatalog.java: ## @@ -34,4 +34,9 @@ public interface ProcedureCatalog extends CatalogPlug

Re: [PR] [SPARK-51350][SQL] Implement Show Procedures [spark]

2025-03-13 Thread via GitHub
cloud-fan commented on code in PR #50109: URL: https://github.com/apache/spark/pull/50109#discussion_r1993730085 ## sql/catalyst/src/main/java/org/apache/spark/sql/connector/catalog/ProcedureCatalog.java: ## @@ -34,4 +34,9 @@ public interface ProcedureCatalog extends CatalogPlug

Re: [PR] [SPARK-51350][SQL] Implement Show Procedures [spark]

2025-03-12 Thread via GitHub
aokolnychyi commented on code in PR #50109: URL: https://github.com/apache/spark/pull/50109#discussion_r1992411229 ## docs/sql-ref-ansi-compliance.md: ## @@ -648,6 +648,7 @@ Below is a list of all the keywords in Spark SQL. |PRECEDING|non-reserved|non-reserved|non-reserved| |P

Re: [PR] [SPARK-51350][SQL] Implement Show Procedures [spark]

2025-03-12 Thread via GitHub
zhengruifeng commented on code in PR #50109: URL: https://github.com/apache/spark/pull/50109#discussion_r1991972859 ## sql/core/src/main/scala/org/apache/spark/sql/execution/command/ShowProceduresCommand.scala: ## @@ -0,0 +1,54 @@ +/* + * Licensed to the Apache Software Foundati

Re: [PR] [SPARK-51350][SQL] Implement Show Procedures [spark]

2025-03-11 Thread via GitHub
szehon-ho commented on code in PR #50109: URL: https://github.com/apache/spark/pull/50109#discussion_r1990117123 ## sql/core/src/test/scala/org/apache/spark/sql/connector/ProcedureSuite.scala: ## @@ -40,15 +40,23 @@ class ProcedureSuite extends QueryTest with SharedSparkSession

Re: [PR] [SPARK-51350][SQL] Implement Show Procedures [spark]

2025-03-11 Thread via GitHub
szehon-ho commented on code in PR #50109: URL: https://github.com/apache/spark/pull/50109#discussion_r1990109864 ## sql/core/src/test/scala/org/apache/spark/sql/connector/ProcedureSuite.scala: ## @@ -40,15 +40,23 @@ class ProcedureSuite extends QueryTest with SharedSparkSession

Re: [PR] [SPARK-51350][SQL] Implement Show Procedures [spark]

2025-03-11 Thread via GitHub
szehon-ho commented on code in PR #50109: URL: https://github.com/apache/spark/pull/50109#discussion_r1990109864 ## sql/core/src/test/scala/org/apache/spark/sql/connector/ProcedureSuite.scala: ## @@ -40,15 +40,23 @@ class ProcedureSuite extends QueryTest with SharedSparkSession

Re: [PR] [SPARK-51350][SQL] Implement Show Procedures [spark]

2025-03-11 Thread via GitHub
szehon-ho commented on code in PR #50109: URL: https://github.com/apache/spark/pull/50109#discussion_r1990109152 ## sql/catalyst/src/test/scala/org/apache/spark/sql/connector/catalog/InMemoryTableCatalog.scala: ## @@ -268,6 +268,11 @@ class InMemoryTableCatalog extends BasicInM

Re: [PR] [SPARK-51350][SQL] Implement Show Procedures [spark]

2025-03-07 Thread via GitHub
cloud-fan commented on code in PR #50109: URL: https://github.com/apache/spark/pull/50109#discussion_r1984471179 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/InMemoryCatalog.scala: ## @@ -651,5 +651,4 @@ class InMemoryCatalog( requireDbExists(db)

Re: [PR] [SPARK-51350][SQL] Implement Show Procedures [spark]

2025-03-07 Thread via GitHub
cloud-fan commented on code in PR #50109: URL: https://github.com/apache/spark/pull/50109#discussion_r1984475040 ## sql/core/src/test/scala/org/apache/spark/sql/connector/ProcedureSuite.scala: ## @@ -40,15 +40,23 @@ class ProcedureSuite extends QueryTest with SharedSparkSession

Re: [PR] [SPARK-51350][SQL] Implement Show Procedures [spark]

2025-03-06 Thread via GitHub
cloud-fan commented on code in PR #50109: URL: https://github.com/apache/spark/pull/50109#discussion_r1984474247 ## sql/catalyst/src/test/scala/org/apache/spark/sql/connector/catalog/InMemoryTableCatalog.scala: ## @@ -268,6 +268,11 @@ class InMemoryTableCatalog extends BasicInM

Re: [PR] [SPARK-51350][SQL] Implement Show Procedures [spark]

2025-03-06 Thread via GitHub
cloud-fan commented on code in PR #50109: URL: https://github.com/apache/spark/pull/50109#discussion_r1984473827 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/v2Commands.scala: ## @@ -1664,3 +1664,21 @@ case class Call( override protected def with

Re: [PR] [SPARK-51350][SQL] Implement Show Procedures [spark]

2025-03-06 Thread via GitHub
cloud-fan commented on code in PR #50109: URL: https://github.com/apache/spark/pull/50109#discussion_r1984471013 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala: ## @@ -28,13 +28,7 @@ import scala.util.{Failure, Random, Success, Try} import

Re: [PR] [SPARK-51350][SQL] Implement Show Procedures [spark]

2025-03-06 Thread via GitHub
cloud-fan commented on code in PR #50109: URL: https://github.com/apache/spark/pull/50109#discussion_r1984470634 ## sql/catalyst/src/main/java/org/apache/spark/sql/connector/catalog/ProcedureCatalog.java: ## @@ -34,4 +41,11 @@ public interface ProcedureCatalog extends CatalogPlu

Re: [PR] [SPARK-51350][SQL] Implement Show Procedures [spark]

2025-03-06 Thread via GitHub
szehon-ho commented on PR #50109: URL: https://github.com/apache/spark/pull/50109#issuecomment-2705156517 Addressed review (thanks @allisonwang-db ). Also had an offline chat with @cloud-fan , we will not support LIKE in the first cut due to avoid consistency problems as different c

Re: [PR] [SPARK-51350][SQL] Implement Show Procedures [spark]

2025-03-05 Thread via GitHub
allisonwang-db commented on code in PR #50109: URL: https://github.com/apache/spark/pull/50109#discussion_r1982287527 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/v2Commands.scala: ## @@ -1664,3 +1664,22 @@ case class Call( override protected def

Re: [PR] [SPARK-51350][SQL] Implement Show Procedures [spark]

2025-03-01 Thread via GitHub
szehon-ho commented on PR #50109: URL: https://github.com/apache/spark/pull/50109#issuecomment-2692426656 @cloud-fan @aokolnychyi do you want to look when you have a chance, thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Git