szehon-ho commented on code in PR #50109: URL: https://github.com/apache/spark/pull/50109#discussion_r1993927792
########## sql/catalyst/src/test/scala/org/apache/spark/sql/connector/catalog/InMemoryTableCatalog.scala: ########## @@ -268,6 +268,11 @@ class InMemoryTableCatalog extends BasicInMemoryTableCatalog with SupportsNamesp procedure } + override def listProcedures(namespace: Array[String]): Array[Identifier] = { + procedures.asScala.filter{case (_, p) => !p.name().equals("dummy_increment")} Review Comment: this is filter, it has to return predicate, do you mean ```.filter{case (_, p) if !p.name().equals("dummy_increment") => true}```? it looks a bit weird. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org