cloud-fan commented on code in PR #50109:
URL: https://github.com/apache/spark/pull/50109#discussion_r1984470634
##########
sql/catalyst/src/main/java/org/apache/spark/sql/connector/catalog/ProcedureCatalog.java:
##########
@@ -34,4 +41,11 @@ public interface ProcedureCatalog extends CatalogPlugin {
* @return the loaded unbound procedure
*/
UnboundProcedure loadProcedure(Identifier ident);
+
+ /**
+ * List all procedures in the specified database.
+ */
+ default Identifier[] listProcedures(String[] namespace) {
Review Comment:
This API is new in 4.0, I think it's better to have this change in 4.0 so
that we don't need a default implementation for compatibility reasons. It's
better to have compilation error and remind people to implement it, instead of
runtime error.
##########
sql/catalyst/src/main/java/org/apache/spark/sql/connector/catalog/ProcedureCatalog.java:
##########
@@ -34,4 +41,11 @@ public interface ProcedureCatalog extends CatalogPlugin {
* @return the loaded unbound procedure
*/
UnboundProcedure loadProcedure(Identifier ident);
+
+ /**
+ * List all procedures in the specified database.
+ */
+ default Identifier[] listProcedures(String[] namespace) {
Review Comment:
This interface is new in 4.0, I think it's better to have this change in 4.0
so that we don't need a default implementation for compatibility reasons. It's
better to have compilation error and remind people to implement it, instead of
runtime error.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
