cloud-fan commented on code in PR #50109: URL: https://github.com/apache/spark/pull/50109#discussion_r1984473827
########## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/v2Commands.scala: ########## @@ -1664,3 +1664,21 @@ case class Call( override protected def withNewChildInternal(newChild: LogicalPlan): Call = copy(procedure = newChild) } + +/** + * The logical plan of the SHOW PROCEDURES command. + */ +case class ShowProcedures( Review Comment: I think a better way to implement commands today is to follow `DescribeRelationJsonCommand`: 1. extends `UnaryRunnableCommand` so that it merges logical and physical plans, while still leverages the v2 framework to resolve table/namespace 2. put in `sql/core` as `UnaryRunnableCommand` is in `sql/core`. The parser change should be put in `SparkSqlAstBuilder` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org