Re: [openstreetmap/openstreetmap-website] Installation on Ubuntu 24.04 Failure with MIni Racer (Issue #5733)
jessequinn left a comment (openstreetmap/openstreetmap-website#5733) https://github.com/user-attachments/assets/620e4c6c-949a-46ad-aba3-45b11a55c8d2"; /> -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/5733#issuecomment-2691346
Re: [openstreetmap/openstreetmap-website] Switch to using annotaterb for annotations (PR #5716)
@tomhughes pushed 3 commits. a52558ecc440d37f2aefc27f81e2a7596a428bfd Switch to using annotaterb for annotations 1213e7009aac7448ac1478c4536cba81fa74f679 Update model annotations ab4f96261fe043ba704616e8b6f7cf77e79817bf Drop explicit lengths from bigint columns -- View it on GitHub: https:/
Re: [openstreetmap/openstreetmap-website] Add permalinks to changeset comments (PR #4789)
tomhughes left a comment (openstreetmap/openstreetmap-website#4789) Can you rebase this on current master please, to get rid of the merge commits, and also squash any fixup commits into the commit they are fixing. -- Reply to this email directly or view it on GitHub: https://github.com/openstre
Re: [openstreetmap/openstreetmap-website] Remove obsolete element from docker-compose.yml (PR #5743)
Merged #5743 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5743#event-16538438442 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-
Re: [openstreetmap/openstreetmap-website] Add pluralizers to I18n (PR #5654)
@tomhughes commented on this pull request. > @@ -1,6 +1,7 @@ <%= tag.head :data => application_data do %> <%= render :partial => "layouts/meta" %> <%= javascript_include_tag "turbo", :type => "module" %> + <%= javascript_include_tag "make-plural/cardinals" %> Obviously that global names
Re: [openstreetmap/openstreetmap-website] Removes optional using first comments records (PR #5744)
tomhughes left a comment (openstreetmap/openstreetmap-website#5744) I don't think this is the right approach to the tests - a factory that modifies the record's parent seems wrong to me. Probably the `note_comment` factory shouldn't be defaulting to creating an `opened` comment now, as in the f
Re: [openstreetmap/openstreetmap-website] Add permalinks to changeset comments (PR #4789)
@gy-mate pushed 1 commit. 2db5b718047d8dfb494fdc8fdd6012bf73f3f0ab Add button instead of hyperlinking time_ago -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/4789/files/56c38f7466728951ca021e83c90340fe29e9e997..2db5b718047d8dfb494fdc8fdd6012bf73f3f0ab You are
Re: [openstreetmap/openstreetmap-website] Add permalinks to changeset comments (PR #4789)
gy-mate left a comment (openstreetmap/openstreetmap-website#4789) @tomhughes This seemed too complicated for me but I've cut the Gordian knot by basically squashing all commits into one and rebasing it on top of the master. Is it okay this way? -- Reply to this email directly or view it on Git
Re: [openstreetmap/openstreetmap-website] Replace CC-BY-SA icon with SVG (PR #4792)
@hlfan commented on this pull request. > + + + + + + + + + + + + + + Let's not make it more complex than what is needed: ```suggestion ``` -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap
Re: [openstreetmap/openstreetmap-website] I18n fallback fixes (PR #5745)
hlfan left a comment (openstreetmap/openstreetmap-website#5745) Shouldn't this affect the change put in place in #5527 too? -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5745#issuecomment-2695912284 You are receiving this becaus
[openstreetmap/openstreetmap-website] Bump @stylistic/eslint-plugin-js from 4.1.0 to 4.2.0 (PR #5746)
Bumps [@stylistic/eslint-plugin-js](https://github.com/eslint-stylistic/eslint-stylistic/tree/HEAD/packages/eslint-plugin-js) from 4.1.0 to 4.2.0.Release notes
Sourced from
@stylis
Re: [openstreetmap/openstreetmap-website] Add permalinks to changeset comments (PR #4789)
tomhughes left a comment (openstreetmap/openstreetmap-website#4789) Given that it winds up with one tiny change, yes, that is perfect. Do we actually use that icon anywhere else at the moment? It seems very bold to me, and poorly aligned: 
A few fixes and cleanups for I18n fallback: * Disable client side fallback in javascript that isn't doing anything as we only load one locale - note that in the embed view the story is different as we load all locales there. * Drop an old monkey patch that no longer seems to be needed. * Fix the
[openstreetmap/openstreetmap-website] Activity indexes (PR #5747)
### Description This PR adds database indexes to improve query performance for the user activity feature as part of #5298. Specifically, it adds concurrent indexes on: - `gpx_files` table: `[user_id, timestamp]` index to optimize retrieval of user's GPS trace uploads - `notes` table: `[user_id,
Re: [openstreetmap/openstreetmap-website] Replace CC-BY-SA icon with SVG (PR #4792)
@AntonKhorev commented on this pull request. > + + + + + + + + + + + + + + The simplest thing is to just not change anything because this statement is not exactly true: > to ensure screens with high pixel densities can display the OpenSt
Re: [openstreetmap/openstreetmap-website] Installation on Ubuntu 24.04 Failure with Mini Racer (Issue #5733)
Hatsune39 left a comment (openstreetmap/openstreetmap-website#5733) I had the same issue before, check this path: `/var/lib/gems/3.2.0/gems/libv8-node-18.19.0.0-x86_64-linux/vendor/v8/x86_64-linux-gnu/libv8/obj/libv8_monolith.a` If the v8 directory contains x86_64-linux instead of x86_64-linux-g
[openstreetmap/openstreetmap-website] Removes optional using first comments records (PR #5744)
### Description PR removes optional using of note's first comments records for retrieving note's description and author in Note model file. Also, adds note's initializing when created using `note_comments` factory by initializing note's `description`, `user_ip` and `user_id` from note's comme
Re: [openstreetmap/openstreetmap-website] Remove obsolete element from docker-compose.yml (PR #5743)
tomhughes left a comment (openstreetmap/openstreetmap-website#5743) Looks good to me, thanks. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5743#issuecomment-2695133542 You are receiving this because you are subscribed to this t
Re: [openstreetmap/openstreetmap-website] Use svg symbols for routing icons (PR #4901)
@hlfan commented on this pull request. > + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + +
