tomhughes left a comment (openstreetmap/openstreetmap-website#5744)
I don't think this is the right approach to the tests - a factory that modifies
the record's parent seems wrong to me.
Probably the `note_comment` factory shouldn't be defaulting to creating an
`opened` comment now, as in the future there won't be any such thing. It should
probably default to `commented` and the `note` factory should generate food
defaults for the initial open and tests should be adapted to all that.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5744#issuecomment-2695474775
You are receiving this because you are subscribed to this thread.
Message ID:
<openstreetmap/openstreetmap-website/pull/5744/c2695474...@github.com>
_______________________________________________
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev
