@hlfan commented on this pull request.
> +<svg width="20" height="20" class="d-none">
+ <symbol id="routing-sprite-start" fill="none" stroke="currentColor"
stroke-width="2">
+ <path d="M10 16 a1 1 0 1 0 0 -2 1 1 0 1 0 0 2 m0 -4 v-8 m2.5 2 l-2.5 -2.5
-2.5 2.5 z" />
+ </symbol>
+ <symbol id="routing-sprite-destination" fill="none" stroke="currentColor"
stroke-width="2">
+ <path d="M10 5 a1 1 0 1 0 0 -2 1 1 0 1 0 0 2 m0 12 v-8 m2.5 2 l-2.5 -2.5
-2.5 2.5 z" />
+ </symbol>
+
+ <symbol id="routing-sprite-straight" fill="none" stroke="currentColor"
stroke-width="2">
+ <path d="M10 17 v-13 m2.5 2 l-2.5 -2.5 -2.5 2.5 z" />
+ </symbol>
+ <symbol id="routing-sprite-slight-right" fill="none" stroke="currentColor"
stroke-width="2">
+ <path d="M7 17 v-3 q0 -2 2 -4 l5 -5 m0 0 h-3 l3 3 z" />
+ </symbol>
+ <symbol id="routing-sprite-right" fill="none" stroke="currentColor"
stroke-width="2">
+ <path d="M8 17 v-5 q0 -3 3 -3 h4 m-2 2.5 l2.5 -2.5 -2.5 -2.5 z" />
+ </symbol>
+ <symbol id="routing-sprite-sharp-right" fill="none" stroke="currentColor"
stroke-width="2">
+ <path d="M8 17 v-7 q0 -6 6 0 l2 2 m0 0 v-3 l-3 3 z" />
+ </symbol>
+ <symbol id="routing-sprite-u-turn" fill="none" stroke="currentColor"
stroke-width="2">
+ <path d="M16 17 v-7 a4.5 4.5 0 0 0 -9 0 v5 m-2.5 -2 l2.5 2.5 2.5 -2.5 z" />
+ </symbol>
+ <symbol id="routing-sprite-slight-left" fill="none" stroke="currentColor"
stroke-width="2">
+ <path d="M13 17 v-3 q0 -2 -2 -4 l-5 -5 m0 0 h3 l-3 3 z" />
+ </symbol>
+ <symbol id="routing-sprite-left" fill="none" stroke="currentColor"
stroke-width="2">
+ <path d="M13 17 v-5 q0 -3 -3 -3 h-4 m2 2.5 l-2.5 -2.5 2.5 -2.5 z" />
+ </symbol>
+ <symbol id="routing-sprite-sharp-left" fill="none" stroke="currentColor"
stroke-width="2">
+ <path d="M13 17 v-7 q0 -6 -6 0 l-2 2 m0 0 v-3 l3 3 z" />
+ </symbol>
+
+ <symbol id="routing-sprite-roundabout" fill="none" stroke="currentColor"
stroke-width="2">
+ <path d="M8 17 v-3 a 3 3 0 1 0 0 -6 3 3 0 1 0 0 6 m2 -4 l5 -5 m0 0 h-3 l3
3 z" />
+ </symbol>
+
+ <symbol id="routing-sprite-fork-right" fill="none" stroke="currentColor"
stroke-width="2">
+ <path d="M9 14 q0 -2 -2 -4 l-3 -3" opacity=".5" />
+ <path d="M9 17 v-3 q0 -2 2 -4 l5 -5 m0 0 h-3 l3 3 z" />
+ </symbol>
+ <symbol id="routing-sprite-fork-left" fill="none" stroke="currentColor"
stroke-width="2">
+ <path d="M11 14 q0 -2 2 -4 l3 -3" opacity=".5" />
+ <path d="M11 17 v-3 q0 -2 -2 -4 l-5 -5 m0 0 h3 l-3 3 z" />
+ </symbol>
+ <symbol id="routing-sprite-merge-left" fill="none" stroke="currentColor"
stroke-width="2">
+ <path d="M8 7 q0 2 -2 4 l-3 3" opacity=".5" />
+ <path d="M8 4 v3 q0 2 2 4 l5 5 m-5 -5 h3 l-3 3 z" />
+ </symbol>
+ <symbol id="routing-sprite-merge-right" fill="none" stroke="currentColor"
stroke-width="2">
+ <path d="M12 7 q0 2 2 4 l3 3" opacity=".5" />
+ <path d="M12 4 v3 q0 2 -2 4 l-5 5 m5 -5 h-3 l3 3 z" />
+ </symbol>
+ <symbol id="routing-sprite-end-of-road-right" fill="none"
stroke="currentColor" stroke-width="2">
+ <path d="M2 9 h10" opacity=".5" />
+ <path d="M9 17 v-5 q0 -3 3 -3 h4 m-2 2.5 l2.5 -2.5 -2.5 -2.5 z" />
+ </symbol>
+ <symbol id="routing-sprite-end-of-road-left" fill="none"
stroke="currentColor" stroke-width="2">
+ <path d="M18 9 h-10" opacity=".5" />
+ <path d="M11 17 v-5 q0 -3 -3 -3 h-4 m2 2.5 l-2.5 -2.5 2.5 -2.5 z" />
+ </symbol>
+ <symbol id="routing-sprite-exit-right" fill="none" stroke="currentColor"
stroke-width="2">
+ <path d="M9 14 v-8" opacity=".5" />
+ <path d="M9 17 v-3 q0 -2 2 -4 l5 -5 m0 0 h-3 l3 3 z" />
+ </symbol>
+ <symbol id="routing-sprite-exit-left" fill="none" stroke="currentColor"
stroke-width="2">
+ <path d="M11 14 v-8" opacity=".5" />
+ <path d="M11 17 v-3 q0 -2 -2 -4 l-5 -5 m0 0 h3 l-3 3 z" />
+ </symbol>
+
+ <symbol id="routing-sprite-ferry" fill="none" stroke="currentColor"
stroke-width="1">
+ <path d="M10.5 8 l-6 2 l2.5 2 v1.5 a2.828 2.828 0 0 1 1.5 1 a2.828 2.828 0
0 1 4 0 a2.828 2.828 0 0 1 1.5 -1 v-1.5 l2.5 -2 z" fill="currentColor" />
+ <path d="M6.5 9.5 v-5 h8 v5 m-5.5 -6 h3" />
+ <path d="M5.5 16.5 a1.414 2.828 0 0 1 2 0 a1.414 2.828 0 0 0 2 0 a1.414
2.828 0 0 1 2 0 a1.414 2.828 0 0 0 2 0 a1.414 2.828 0 0 1 2 0" />
+ </symbol>
+</svg>
If you add `fill="none" stroke="currentColor" stroke-width="1"` to the use
element when filling the `turnByTurnTable`, you can clean up the icon
definitions.
```suggestion
<svg width="20" height="20" class="d-none">
<path id="routing-sprite-start" d="M10 16a1 1 0 1 0 0-2 1 1 0 1 0 0
2m0-4V4m2.5 2L10 3.5 7.5 6z"/>
<path id="routing-sprite-destination" d="M10 5a1 1 0 1 0 0-2 1 1 0 1 0 0 2m0
12V9m2.5 2L10 8.5 7.5 11z"/>
<path id="routing-sprite-straight" d="M10 17V4m2.5 2L10 3.5 7.5 6z"/>
<path id="routing-sprite-slight-right" d="M7 17v-3q0-2 2-4l5-5m0 0h-3l3 3z"/>
<path id="routing-sprite-right" d="M8 17v-5q0-3 3-3h4m-2 2.5L15.5 9 13 6.5z"/>
<path id="routing-sprite-sharp-right" d="M8 17v-7q0-6 6 0l2 2m0 0V9l-3 3z"/>
<path id="routing-sprite-u-turn" d="M16 17v-7a4.5 4.5 0 0 0-9 0v5m-2.5-2L7
15.5 9.5 13z"/>
<path id="routing-sprite-slight-left" d="M13 17v-3q0-2-2-4L6 5m0 0h3L6 8z"/>
<path id="routing-sprite-left" d="M13 17v-5q0-3-3-3H6m2 2.5L5.5 9 8 6.5z"/>
<path id="routing-sprite-sharp-left" d="M13 17v-7q0-6-6 0l-2 2m0 0V9l3 3z"/>
<path id="routing-sprite-roundabout" d="M8 17v-3a3 3 0 1 0 0-6 3 3 0 1 0 0
6m2-4 5-5m0 0h-3l3 3z"/>
<g id="routing-sprite-fork-right">
<path d="M9 14q0-2-2-4L4 7" opacity=".5"/>
<path d="M9 17v-3q0-2 2-4l5-5m0 0h-3l3 3z"/>
</g>
<g id="routing-sprite-fork-left">
<path d="M11 14q0-2 2-4l3-3" opacity=".5"/>
<path d="M11 17v-3q0-2-2-4L4 5m0 0h3L4 8z"/>
</g>
<g id="routing-sprite-merge-left">
<path d="M8 7q0 2-2 4l-3 3" opacity=".5"/>
<path d="M8 4v3q0 2 2 4l5 5m-5-5h3l-3 3z"/>
</g>
<g id="routing-sprite-merge-right">
<path d="M12 7q0 2 2 4l3 3" opacity=".5"/>
<path d="M12 4v3q0 2-2 4l-5 5m5-5H7l3 3z"/>
</g>
<g id="routing-sprite-end-of-road-right">
<path d="M2 9h10" opacity=".5"/>
<path d="M9 17v-5q0-3 3-3h4m-2 2.5L16.5 9 14 6.5z"/>
</g>
<g id="routing-sprite-end-of-road-left">
<path d="M18 9H8" opacity=".5"/>
<path d="M11 17v-5q0-3-3-3H4m2 2.5L3.5 9 6 6.5z"/>
</g>
<g id="routing-sprite-exit-right">
<path d="M9 14V6" opacity=".5"/>
<path d="M9 17v-3q0-2 2-4l5-5m0 0h-3l3 3z"/>
</g>
<g id="routing-sprite-exit-left">
<path d="M11 14V6" opacity=".5"/>
<path d="M11 17v-3q0-2-2-4L4 5m0 0h3L4 8z"/>
</g>
<g id="routing-sprite-ferry" stroke-width="1">
<path fill="currentColor" d="m10.5 8-6 2L7 12v1.5a2.828 2.828 0 0 1 1.5 1
2.828 2.828 0 0 1 4 0 2.828 2.828 0 0 1 1.5-1V12l2.5-2z"/>
<path d="M6.5 9.5v-5h8v5M9 3.5h3m-6.5 13a1.414 2.828 0 0 1 2 0 1.414 2.828
0 0 0 2 0 1.414 2.828 0 0 1 2 0 1.414 2.828 0 0 0 2 0 1.414 2.828 0 0 1 2 0"/>
</g>
</svg>
```
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4901#pullrequestreview-2655360499
You are receiving this because you are subscribed to this thread.
Message ID:
<openstreetmap/openstreetmap-website/pull/4901/review/2655360...@github.com>
_______________________________________________
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev