### Description PR removes optional using of note's first comments records for retrieving note's description and author in Note model file.
Also, adds note's initializing when created using `note_comments` factory by initializing note's `description`, `user_ip` and `user_id` from note's comment (this is used only when notes are created by `create(:note_comment, ...)`) in unit tests. ### How has this been tested? Automated unit tests and manual testing on previously created set of notes (with special cases). You can view, comment on, or merge this pull request online at: https://github.com/openstreetmap/openstreetmap-website/pull/5744 -- Commit Summary -- * Removes optional using first comments records * Improves initializing note's records in test factory -- File Changes -- M app/models/note.rb (17) M test/factories/note_comments.rb (4) M test/models/note_test.rb (9) -- Patch Links -- https://github.com/openstreetmap/openstreetmap-website/pull/5744.patch https://github.com/openstreetmap/openstreetmap-website/pull/5744.diff -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5744 You are receiving this because you are subscribed to this thread. Message ID: <openstreetmap/openstreetmap-website/pull/5...@github.com>
_______________________________________________ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
