Most of error messages are not translated. `report_error` receives many from
exceptions defined in `lib/osm.rb`, no translations there.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5314#issuecomment-2489801776
You are receiving
Great work! I almost feel bad for missing this.
> Context menu selection is not remembered
What is currently planned for this? Just persistence via `localStorage` or
similar? Something more intricate? User syncing like mentioned in #5324 (also
how would this work for non logged-in users?)?
--
> Maybe for discussion in #5328 to conclude?
@matkoniecz The problem is that the map should not have been dimmed to begin
with, especially without any proper discussion. This should be merged and the
map should remain as default until #5328 is concluded.
--
Reply to this email directly or view
In any case, the current implementation of the dimming filter for all dark mode
users is problematic.
I believe that providing an easy way to switch between light and dark maps
independent of the UI like
[this](https://github.com/openstreetmap/openstreetmap-website/issues/5324#issuecomment-2480
Merged #5314 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5314#event-15371213528
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Merged, thanks for the updated version.
I'm interested to hear any thoughts on the translations:
> "I'm not sure if the error messages should come from the translation system.
> Other usage of report_error is inconsistent whether error strings are
> translated or not."
We can always refactor t
> Let's suppose we have a group of people who don't want any filter and a group
> of people who want inverse.
Yes unfortunately it's not possible to make everyone happy when their
preferences are in conflict with each other. But we need to pick a default
behaviour for when dark mode is active (
Looks good to me. Only two small things:
* PR contains a fixup commit (i.e. a commit that changes code that itself is
added by this PR)
* I'm not sure if the error messages should come from the translation system.
Other usage of `report_error` is inconsistent whether error strings are
translated
Changed to have error messages right away.
The original version had response bodies intentionally undefined, and they are
still intentionally undefined for ok responses.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5314#issuec
There weren't any *problems* with the code. Not having an error message is not
a *problem*. You could as well have said that not adding `destroy` together
with `create` is a problem because it requires changing a.k.a. fixing routes
and abilities.
--
Reply to this email directly or view it on G
>It's also not helpful to dismiss other opinions with "people don't know how
>things work, so they're scared and afraid of change".
I explained some technical reasons why messing with the maps appearance means
tampering with their message. It's measurable in numbers, don't dismiss it as
uninform
1 Warning
:warning:
Merge commits are found in PR. Please rebase to
get rid of the merge commits in this PR, see CONTRIBUTING.md.
Generated by :no_entry_sign: https://danger.systems/";>Danger
--
Reply to this em
your proposal is missing big part: "why"
why spending effort in coding, maintaining and complexity increase of interface
would be worth it?
> Yes various plugins have come and gone and are one
> big mess. So let's just cut to the chase and have
> it built into the OSM website!
just because plug
> > > Really this is a bug tracker, not a support forum, but bear in mind that
> > > our production setups don't even use the rails API implementation for the
> > > main map data calls precisely because there is no way to get reasonable
> > > performance.
> > > If you have significant amounts of
Thanks everyone for your detailed feedback.
As I mentioned [on the
forum](https://community.openstreetmap.org/t/openstreetmap-in-dark-mode/119216/30)
I have a big conflict of interest here, since I'm both a maintainer of the
site, but also a cartographer for some of the map layers. I need to be