<!-- Please read the contributing guidelines before making a PR: https://github.com/openstreetmap/openstreetmap-website/blob/master/CONTRIBUTING.md
Pay particular attention to the section on how to present PRs: https://github.com/openstreetmap/openstreetmap-website/blob/master/CONTRIBUTING.md#pull-requests --> ### Description <!--Describe your changes in detail. If you have made changes to the UI, include screenshots. If your PR addresses a Github issue, please link to it.--> PR adds support for note tags as described in #5294 Following changes are made: 1. Created `note_tags` table, connected it with note table (using foreign key and associations), created `NoteTag` model file and `NoteTagTest` class with basic tests (PR #5323 does this) 2. Added preparing and rendering of note tags in left sidebar using `browse/tag_details` partial, also, created test with multiple tags added rendering and checking if rendered HTML contains tags 3. Updated (j)builder files to write note tags in XML, JSON, GPX, RSS and feed files and updated test to check existence of tags in each of above files (creation of tag is performed using ActiveLayer) 4. Added support for creating tags at note creation time using POST HTTP request and improved tests to check existence of tags in each of generated files (creation of tag is performed using POST HTTP request). Also, added creating tag `created_by, OpenStreetMaps-Website` for notes created using OSM website. Displayed resolved note:  Displayed opened note:  XML output for "opened note":  Displayed note without tags (all current):  Fixes #5294 ### How has this been tested? <!--Explain the steps you took to test your code.--> Run tests from workflows, tested creating and displaying notes manually as administrator / moderator / regular user, tested displaying already existing notes (they will be displayed as earlier - without tags) You can view, comment on, or merge this pull request online at: https://github.com/openstreetmap/openstreetmap-website/pull/5344 -- Commit Summary -- * Added NoteTag model and note_tags table * Added displaying tags on Notes sidebar * Updated (j)builder files with note tags * Added support for tags in note creation API * Added note_tag factory and NoteTag model test-case * Added unit test for notes with tags * Test note/tag output created at ActiveRecord level * Test note/tag output created at POST/HTML level -- File Changes -- M app/assets/javascripts/index/new_note.js (3) M app/controllers/api/notes_controller.rb (20) M app/models/note.rb (12) A app/models/note_tag.rb (20) M app/views/api/notes/_note.gpx.builder (4) M app/views/api/notes/_note.json.jbuilder (2) M app/views/api/notes/_note.rss.builder (4) M app/views/api/notes/_note.xml.builder (4) M app/views/api/notes/feed.rss.builder (4) M app/views/notes/show.html.erb (2) A db/migrate/20241030122707_create_note_tags.rb (13) M db/structure.sql (35) M test/controllers/api/notes_controller_test.rb (42) M test/controllers/notes_controller_test.rb (21) A test/factories/note_tags.rb (8) A test/models/note_tag_test.rb (49) -- Patch Links -- https://github.com/openstreetmap/openstreetmap-website/pull/5344.patch https://github.com/openstreetmap/openstreetmap-website/pull/5344.diff -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5344 You are receiving this because you are subscribed to this thread. Message ID: <openstreetmap/openstreetmap-website/pull/5...@github.com>
_______________________________________________ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
