On 29 September 2012 17:11, Alex Barcelo wrote:
> Re: [Qemu-devel] [PATCH 2/2] signal: sigsegv protection on do_sigprocmask
The convention for the initial summary line of a patch is that
it starts with an indication of the subsystem being patched. For
instance, here it might be:
"linux-user: Do
On 10 October 2012 18:23, Andreas Färber wrote:
> Am 10.10.2012 17:07, schrieb Peter Maydell:
>> Implement support for using the KVM in-kernel GIC for ARM.
>>
>> Signed-off-by: Peter Maydell
>> ---
>> hw/a15mpcore.c |8 ++-
>> hw/arm/Make
c_internal.h hw/armv7m_nvic.c
Signed-off-by: Peter Maydell
---
As suggested by Andreas...
hw/arm_gic.c | 44 ++--
hw/arm_gic_common.c | 16
hw/arm_gic_internal.h | 20 ++--
hw/armv7m_nvic.c |6 +++---
Thanks for this bug report; it would be helpful if you could let us know
the following info:
(1) Are you running qemu built directly from the upstream sources, or have you
built this from the versions shipped by fink or similar package management
system?
(2) can you give the full configure line
Thanks. QEMU 1.2 (or earlier) won't work when built with a gcc which is
really an llvm-gcc, because llvm-gcc doesn't support the "tie this
variable to a specific native register" which QEMU requires. (I had
hoped it would give a compile failure, but it seems to just generate
wrong code.) We've actu
On 11 October 2012 06:13, Sriram Sundararajan
wrote:
> I am invoking my overo image with qemu-linaro (1.2.0) with sdl as display.
>
> qemu-system-arm -M overo -m 512 -drive
> if=sd,cache=writeback,file=myovero.img -clock unix -sdl -device
> usb-kbd -device usb-mouse
>
> After a few keystro
On 11 October 2012 02:57, David Gibson wrote:
> Actually, turns out I had another use of these helpers. That was to
> store the real page address from the ppcmeb_tlb_t structure. That
> structure is used to represent TLB entries on a number of different
> embedded chips, which don't all have the
On 11 October 2012 20:22, Richard Henderson wrote:
> Signed-off-by: Richard Henderson
Reviewed-by: Peter Maydell
-- PMM
On 12 October 2012 06:43, Andre Beckus wrote:
> Yes, I was being lazy. Now that I think about it, we could handle all
> sizes with one block of code directly in the nvic_sysreg_read and
> nvic_sysreg_write functions - the write would look like this:
>
> for(i = 0; i < size; i++) {
> s
On 12 October 2012 07:53, Andre Beckus wrote:
> As a case study, the STM32 does have a reference clock. It is simply
> the system clock divided by 8 (maybe not ARM's intention for it to be
> tied so closely to the system clock). The documentation says the TENMS
> field is hardwired to 9000, whic
)
Evgeny Voevodin (1):
hw/arm_gic.c: Fix improper DPRINTF output.
Jean-Christophe PLAGNIOL-VILLARD (1):
versatilepb: add gpio pl061 support
Peter A. G. Crosthwaite (1):
zynq_slcr: Fixed ResetValues enum
Peter Maydell (5):
hw/ds1338: Fix
From: Jean-Christophe PLAGNIOL-VILLARD
Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD
Signed-off-by: Peter Maydell
---
hw/versatilepb.c |5 +
1 file changed, 5 insertions(+)
diff --git a/hw/versatilepb.c b/hw/versatilepb.c
index b3f8077..7b1b025 100644
--- a/hw/versatilepb.c
+++ b
the interrupt register are ignored
Signed-off-by: Soren Brinkmann
Signed-off-by: Peter Crosthwaite
Signed-off-by: Peter Maydell
---
hw/cadence_ttc.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/cadence_ttc.c b/hw/cadence_ttc.c
index dd02f86..77b6976 100644
--- a/hw
e.
>
> Reported-by: Alex Barcelo
> Signed-off-by: Alexander Graf
Reviewed-by: Peter Maydell
From: "Peter A. G. Crosthwaite"
There is a gap in the reset region of the address space at offset 0x208. This
throws out all these enum values by one when translating them to address
offsets.
Fixed by putting the corresponding gap in the enum as well.
Signed-off-by: Peter A. G. C
The 'struct tm now' field in the state structure is in fact only
ever used as a temporary (the actual RTC state is held in 'offset').
Remove it from the state structure in favour of using local variables
to avoid confusion about whether it needs to be saved on migration.
.
* ds1338_send was attempting to use 'data' as both the data and
the register offset simultaneously, which meant that writes to
any register were broken; fix to use the register pointer.
Signed-off-by: Peter Maydell
---
hw/ds1338.c | 20 +---
1 file changed, 13
c_internal.h hw/armv7m_nvic.c
Acked-by: Andreas Färber
Signed-off-by: Peter Maydell
---
hw/arm_gic.c | 44 ++--
hw/arm_gic_common.c | 16
hw/arm_gic_internal.h | 20 ++--
hw/armv7m_nvic.c |6 +++---
Implement state save/restore for the DS1338. This requires
the usual minor adjustment of types in the state struct to
get fixed-width ones with vmstate macros.
Signed-off-by: Peter Maydell
---
hw/ds1338.c | 27 ++-
1 file changed, 22 insertions(+), 5 deletions(-)
diff
From: Evgeny Voevodin
s->cpu_enabled is an array, so s->cpu_enabled ? "En" : "Dis" returns
"En" always. We should use s->cpu_enabled[cpu] here.
Signed-off-by: Evgeny Voevodin
Signed-off-by: Peter Maydell
---
hw/arm_gic.c |2 +-
1 file changed, 1 in
The DS1338 datasheet documents that the current time is captured into
the secondary registers when the register pointer wraps round to zero
as well as at a START condition. Implement this.
Signed-off-by: Peter Maydell
---
hw/ds1338.c | 59
which were defining TARGET_NR_pread/pwrite to define
TARGET_NR_pread64/pwrite64 instead, and drop the TARGET_NR_pread/pwrite
implementation code completely.
(Based on examination of the kernel sources for the four architectures
this patch affects.)
Signed-off-by: Peter Maydell
---
This patch appl
On 26 September 2012 19:48, Peter Maydell wrote:
> These patches implement movcond_i32 for the ARM TCG backend; we
> emit "mov dst, v2; cmp c1, c2; movcc dst, v1". We could have
> done this with a pair of conditional movs, but (a) this is not
> actually any shorter (b) it
Commit 4be403c accidentally defined the target_phys_addr_t type when
building user-mode emulators. Since the type doesn't really make
any sense except for system emulators, avoid defining it when building
in user mode.
Signed-off-by: Peter Maydell
---
cf brief discussion earlier:
Commit 33ebc29 fixed the bugs in the implementation of VQRSHL,
but forgot to remove the FIXME comment...
Signed-off-by: Peter Maydell
---
target-arm/neon_helper.c |1 -
1 file changed, 1 deletion(-)
diff --git a/target-arm/neon_helper.c b/target-arm/neon_helper.c
index 8bb5129..9aa920d
On 12 October 2012 21:47, Richard Henderson wrote:
> On 10/12/2012 11:24 AM, riku.voi...@linaro.org wrote:
>> As the first step of the cleanup, I'd like to move implementation of each
>> syscall
>> completely to their own functions. While at it, we define more standard
>> interface between
>> do
On 13 October 2012 10:09, Blue Swirl wrote:
> On Wed, Oct 10, 2012 at 3:07 PM, Peter Maydell
> wrote:
>> From: Christoffer Dall
>>
>> Add basic support for KVM on ARM architecture.
>> +#include "device_tree.h"
>
> Is this used?
Don't
Use the new LOG_UNIMP and LOG_GUEST_ERROR logging types rather
than hw_error().
Signed-off-by: Peter Maydell
---
hw/pl011.c | 12
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/hw/pl011.c b/hw/pl011.c
index 3245702..743eea6 100644
--- a/hw/pl011.c
+++ b/hw/pl011.c
Use LOG_UNIMP and LOG_GUEST_ERROR where appropriate rather
than hw_error().
Signed-off-by: Peter Maydell
---
hw/pl022.c | 9 ++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/hw/pl022.c b/hw/pl022.c
index 60e35da..91e5df0 100644
--- a/hw/pl022.c
+++ b/hw/pl022.c
@@ -9,6
If the guest attempts an offset to a nonexistent register, just
log this via LOG_GUEST_ERROR rather than killing QEMU with a hw_error.
Signed-off-by: Peter Maydell
---
hw/pl190.c | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/hw/pl190.c b/hw/pl190.c
index 7332f4d
Rather than a mix of direct printing to stderr and aborting
via hw_error(), use LOG_UNIMP and LOG_GUEST_ERROR.
Signed-off-by: Peter Maydell
---
hw/pl181.c | 19 +++
1 file changed, 11 insertions(+), 8 deletions(-)
diff --git a/hw/pl181.c b/hw/pl181.c
index 7d91fbb..23fc063
g to include qemu-log.h directly in lots of device model
source files?
Peter Maydell (7):
qemu-log: Add new log category for guest bugs
hw/pl181: Use LOG_UNIMP and LOG_GUEST_ERROR
hw/pl041: Use LOG_UNIMP
hw/pl190: Use LOG_GUEST_ERROR
hw/pl011: Use LOG_UNIMP and LOG_GUEST_ERROR
hw/pl022:
Use the new LOG_UNIMP tracing to report unimplemented
features.
Signed-off-by: Peter Maydell
---
hw/pl041.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/hw/pl041.c b/hw/pl041.c
index b6723be..260c560 100644
--- a/hw/pl041.c
+++ b/hw/pl041.c
@@ -21,6 +21,7
Use LOG_GUEST_ERROR rather than hw_error or direct fprintf.
Signed-off-by: Peter Maydell
---
hw/pl031.c | 17 +++--
1 file changed, 11 insertions(+), 6 deletions(-)
diff --git a/hw/pl031.c b/hw/pl031.c
index 9602664..a718d2e 100644
--- a/hw/pl031.c
+++ b/hw/pl031.c
@@ -14,6 +14,7
complaints
without bothering most users.
Signed-off-by: Peter Maydell
---
qemu-log.c | 3 +++
qemu-log.h | 1 +
2 files changed, 4 insertions(+)
diff --git a/qemu-log.c b/qemu-log.c
index 396aafd..a4c3d1f 100644
--- a/qemu-log.c
+++ b/qemu-log.c
@@ -116,6 +116,9 @@ const CPULogItem cpu_log_items
Michal Suchanek wrote:
> So this is a compiler or system header error?
>
> Anybody examined the differences in code generated with native compiler and
> crosscompiler?
...this comment doesn't make much sense to me -- did you add it to the
wrong bug report by mistake? i386 user mode's issues are n
> How come that the functionality that is missing magically appears for
some people?
Coincidence. Nobody on this bug report has reported that they've been
able to run x86 binary X with a native compiled qemu but not with a
cross compiled version of the same qemu sources. I think it is vastly
more
On 14 October 2012 15:02, Blue Swirl wrote:
> On Sun, Oct 14, 2012 at 1:11 PM, Peter Maydell
> wrote:
>> One question that comes to mind -- should we include qemu-log.h
>> in qemu-common.h (or some other common header?) rather than
>> having to include qemu-log.h di
Rework the handling of arguments to ARM semihosting calls so that we
handle a possible failure return from get_user_ual() or put_user_ual().
(This incidentally silences a lot of warnings from clang about
"expression result unused").
Signed-off-by: Peter Maydell
---
target-m68k/m68k-se
On 14 October 2012 20:58, Blue Swirl wrote:
> index 2fc4137..2c02a83 100644
> --- a/hw/omap_gpmc.c
> +++ b/hw/omap_gpmc.c
> @@ -871,24 +871,3 @@ void omap_gpmc_attach(struct omap_gpmc_s *s, int cs,
> MemoryRegion *iomem)
> f->iomem = iomem;
> omap_gpmc_cs_map(s, cs);
> }
> -
> -void om
nitializer overrides prior initialization of
this subobject" when it encountered the specific entry.
Signed-off-by: Peter Maydell
---
This is basically a judgement that our coding style is legitimate
and the compiler is being overly alarmist. I don't think we would
benefit from trying to
On 14 October 2012 21:15, Blue Swirl wrote:
> On Sun, Oct 14, 2012 at 8:00 PM, Peter Maydell
> wrote:
>> Blue Swirl previously submitted a patch which enabled this flag
>> (among others):
>> http://lists.gnu.org/archive/html/qemu-devel/2012-07/msg04203.html
>
> I
On 14 October 2012 21:33, Blue Swirl wrote:
> On Sun, Oct 14, 2012 at 8:09 PM, Peter Maydell
> wrote:
>> Please don't delete this function, it is the public facing interface
>> for allowing board models to attach NAND devices to the GPMC. This
>> might not be
On 14 October 2012 21:49, Blue Swirl wrote:
> On Sun, Oct 14, 2012 at 8:35 PM, Peter Maydell
> wrote:
>> On 14 October 2012 21:33, Blue Swirl wrote:
>>> On Sun, Oct 14, 2012 at 8:09 PM, Peter Maydell
>>> wrote:
>>>> In general anything in linux-use
the C flag which should happen before the update.
Fixed the ordering of the two, the old carry is read by "r13,RRX" before being
updated.
Signed-off-by: Peter Crosthwaite
Reported-by: Vinesh Peringat
---
target-arm/translate.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
g_read/write.
>
> Because the "nvic_state *s" variable now needs to be declared in
> nvic_sysreg_read/write, the "void *opaque" parameter of
> nvic_readl/writel is changed to "nvic_state *s".
>
> Signed-off-by: Andre Beckus
Reviewed-by: Peter Maydell
and added to arm-devs.next.
thanks!
-- PMM
On 16 October 2012 07:53, Catalin Patulea wrote:
> Sorry this got abandoned.. here is a fresh (and slightly leaner) patch on top
> of master. Can anyone take a look?
>
> ---
> This broke when the tests were moved from tests/ to tests/tcg/.
>
> On x86_64 host/i386-linux-user non-kvm guest, test-i3
On 16 October 2012 19:09, Catalin Patulea wrote:
> On Tue, Oct 16, 2012 at 8:50 AM, Peter Maydell
> wrote:
>> I can't work out how to get a working i386 compiler on my 64-bit Ubuntu
>> system
>> but I think that's an Ubuntu issue :-) Tests run ok on a 32
On 16 October 2012 20:37, Catalin Patulea wrote:
> Fixes compile line for test-x86_64 target as well.
>
> ---
> This broke when the tests were moved from tests/ to tests/tcg/.
>
> On x86_64 host/i386-linux-user non-kvm guest, test-i386 and test-mmap are
> broken, but at least they build.
>
> To b
On 16 October 2012 20:57, Catalin Patulea wrote:
> On Tue, Oct 16, 2012 at 3:54 PM, Peter Maydell
> wrote:
>> This patch isn't in the right format to apply, I'm afraid.
>> Major problem:
>> * missing signed-off-by line: we can't accept any patch
>&g
$BUILD_PATH/tests/tcg
> $ SRC_PATH=path/to/qemu make
>
> Signed-off-by: Catalin Patulea
Reviewed-by: Peter Maydell
-- PMM
On 16 October 2012 20:55, Anthony Liguori wrote:
>
> We discussed nvram and it's interaction with boot order in today's KVM
> call. Here's the outcome. This list is completely incremental so it's
> fine to start with 1-4, for instance, as long as we eventually get to 6.
>
> Today, on x86, we imp
On 16 October 2012 21:20, Stefan Weil wrote:
> Hi Peter, hi Blue,
>
> gcc uses a different flag -Wno-override-init to disable initializer override
> warnings.
>
> I tested the following patch which uses -Wextra with gcc-4.4 and gcc-4.7.
> It allows compilation of QEMU without
On 17 October 2012 15:18, Alex Barcelo wrote:
> Create a wrapper for signal mask changes initiated by the guest;
> this will give us a place to put code which prevents the guest
> from changing the handling of signals used by QEMU itself
> internally.
>
> The wrapper is called from all the guest-i
On 16 October 2012 10:15, Peter Crosthwaite
wrote:
> Instructions that both use the RRX second operand and update CS were
> incorrect, as the Carry flag was updated too early. An example of such an
> instruction would be:
>
> ands r12,r13,RRX
>
> Ands, because of the &qu
On 17 October 2012 19:00, Riku Voipio wrote:
> On 17 October 2012 18:15, Aurelien Jarno wrote:
>> This is not very clear if it is a pull request or a call for review.
>
> It was for review, pull request would come with [PULL] in subject. I
> wanted to wait a week for comments before sending them
On 17 October 2012 19:11, Anthony Liguori wrote:
> It's dangerously close to bike-shedding, but i don't think qdev belongs
> in qom/. It's not core infrastructure. It's the device base class and
> belongs IMHO in hw/.
"-user emulators don't get anything from hw/" is one of those semi
arbitrary
On 17 October 2012 23:06, Alex Barcelo wrote:
> On Wed, Oct 17, 2012 at 5:01 PM, Peter Maydell
> wrote:
>> In my comments on v1 of this patch I wrote:
>> "I think all the uses of sigprocmask() in linux-user/signal.c also
>> need to be do_sigprocmask(), as they ar
On 13 October 2012 10:09, Blue Swirl wrote:
> On Wed, Oct 10, 2012 at 3:07 PM, Peter Maydell
> wrote:
>> +#include "hw/arm-misc.h"
>> +
>> +const KVMCapabilityInfo kvm_arch_required_capabilities[] = {
>
> 'static'. In fact, 'static'
Ping!
-- PMM
On 4 October 2012 16:22, Peter Maydell wrote:
> Update the -help output and documentation so that it recommends
> 'help' rather than '?' for the various "list valid values for this
> option" cases. '?' is deprecated (as it can fai
Rather than a mix of direct printing to stderr and aborting
via hw_error(), use LOG_UNIMP and LOG_GUEST_ERROR.
Signed-off-by: Peter Maydell
---
hw/pl181.c | 18 ++
1 file changed, 10 insertions(+), 8 deletions(-)
diff --git a/hw/pl181.c b/hw/pl181.c
index 7d91fbb..5a73473
g
LOG_UNIMP where that is more appropriate). There are obviously
more conversions that could be made; this is just a sample
to demonstrate the utility of the log category.
Changes v1->v2:
* add patch 2 including qemu-log.h in hw/hw.h
* update 3..8 to not include qemu-log.h directly
Peter Maydell
Use the new LOG_UNIMP and LOG_GUEST_ERROR logging types rather
than hw_error().
Signed-off-by: Peter Maydell
---
hw/pl011.c | 11 +++
1 file changed, 7 insertions(+), 4 deletions(-)
diff --git a/hw/pl011.c b/hw/pl011.c
index 3245702..fb22736 100644
--- a/hw/pl011.c
+++ b/hw/pl011.c
complaints
without bothering most users.
Signed-off-by: Peter Maydell
---
qemu-log.c |3 +++
qemu-log.h |1 +
2 files changed, 4 insertions(+)
diff --git a/qemu-log.c b/qemu-log.c
index 396aafd..a4c3d1f 100644
--- a/qemu-log.c
+++ b/qemu-log.c
@@ -116,6 +116,9 @@ const CPULogItem cpu_log_items
Add an include of qemu-log.h to hw.h, so that device model
code has access to these logging functions without the need
to directly include qemu-log.h.
Signed-off-by: Peter Maydell
---
hw/hw.h |1 +
1 file changed, 1 insertion(+)
diff --git a/hw/hw.h b/hw/hw.h
index 16101de..b337ee3 100644
Use the new LOG_UNIMP tracing to report unimplemented
features.
Signed-off-by: Peter Maydell
---
hw/pl041.c |5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/hw/pl041.c b/hw/pl041.c
index b6723be..9a6db1b 100644
--- a/hw/pl041.c
+++ b/hw/pl041.c
@@ -536,8 +536,9
On 18 October 2012 11:43, Kevin Wolf wrote:
> Am 17.10.2012 23:24, schrieb Tim Hardeck:
>> On Wednesday 17 October 2012 17:00:15 Andreas Färber wrote:
>>> Am 14.10.2012 15:08, schrieb Tim Hardeck:
When calling QTAILQ_REMOVE or QLIST_REMOVE on an unitialized list
QEMU segfaults.
>>>
>>> C
Use LOG_GUEST_ERROR rather than hw_error or direct fprintf.
Signed-off-by: Peter Maydell
---
hw/pl031.c | 16 ++--
1 file changed, 10 insertions(+), 6 deletions(-)
diff --git a/hw/pl031.c b/hw/pl031.c
index 9602664..6cbaf23 100644
--- a/hw/pl031.c
+++ b/hw/pl031.c
@@ -120,11
On 14 October 2012 14:08, Tim Hardeck wrote:
> When calling QTAILQ_REMOVE or QLIST_REMOVE on an unitialized list
> QEMU segfaults.
>
> Check for this case specifically on item removal.
Incidentally, this commit message is inaccurate -- you can't
call the _REMOVE macros on a list (uninitialised or
If the guest attempts an offset to a nonexistent register, just
log this via LOG_GUEST_ERROR rather than killing QEMU with a hw_error.
Signed-off-by: Peter Maydell
---
hw/pl190.c |6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/hw/pl190.c b/hw/pl190.c
index 7332f4d
Use LOG_UNIMP and LOG_GUEST_ERROR where appropriate rather
than hw_error().
Signed-off-by: Peter Maydell
---
hw/pl022.c |8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/hw/pl022.c b/hw/pl022.c
index 60e35da..e2ae315 100644
--- a/hw/pl022.c
+++ b/hw/pl022.c
calls vnc_stop_worker_thread(), so we can fix this by
simply deleting all the untested racy code.
Signed-off-by: Peter Maydell
---
Seems the easiest way to deal with this bug spotted via code
inspection :-)
ui/vnc-jobs.c | 26 --
ui/vnc-jobs.h |2 --
2 files changed, 28 dele
On 18 October 2012 15:26, Igor Mammedov wrote:
> Peter Maydell wrote:
>> Add an include of qemu-log.h to hw.h, so that device model
>> code has access to these logging functions without the need
>> to directly include qemu-log.h.
> It would be better to include qemu-
Fix some minor typos/grammar errors in comments.
Signed-off-by: Peter Maydell
---
ui/vnc-jobs.c | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/ui/vnc-jobs.c b/ui/vnc-jobs.c
index 087b84d..84b074e 100644
--- a/ui/vnc-jobs.c
+++ b/ui/vnc-jobs.c
@@ -33,21
On 18 October 2012 16:01, Paolo Bonzini wrote:
> Il 18/10/2012 16:28, Peter Maydell ha scritto:
>> The function vnc_stop_worker_thread() is buggy, beacuse it tries to
>> delete jobs from the worker thread's queue but the worker thread itself
>> will not cope with this
Another bug:
(4) if vnc_job_push() discovers that queue->exit is true it
will free the job but leak its rectangle list
(5) the early-exit ("goto disconnected") code paths in
vnc_worker_thread_loop() also leak the rectangle list
And a couple of inefficiencies/oddities which aren't actually bugs:
On 18 October 2012 17:09, Stefan Weil wrote:
> Am 18.10.2012 17:03, schrieb Peter Maydell:
>> - * if two threads try to write on it at the same
>> time
>> + * two threads try to write on it at the same
>> time
>
Fix some minor typos/grammar errors in comments.
Signed-off-by: Peter Maydell
---
v1->v2: reinstated carelessly dropped 'if', noted by Stefan Weil.
ui/vnc-jobs.c | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/ui/vnc-jobs.c b/ui/vnc-jobs.c
Implement abs_i32 inline (with movcond) rather than using a helper
function.
Signed-off-by: Peter Maydell
---
target-arm/helper.c|5 -
target-arm/helper.h|1 -
target-arm/translate.c | 10 --
3 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/target-arm
bit
of the instruction set (it's a Neon operation) so I'm not too
worried.
(A fully native TCG abs op would be able to use the fact that
neg sets flags to avoid the test as well.)
Peter Maydell (2):
target-arm: Use TCG operation for Neon 64 bit negation
target-arm: Implement abs_i32 i
Use the TCG operation to do Neon 64 bit negations rather than calling
a helper routine for it.
Signed-off-by: Peter Maydell
---
target-arm/helper.h |1 -
target-arm/neon_helper.c |6 --
target-arm/translate.c |4 +++-
3 files changed, 3 insertions(+), 8 deletions(-)
diff
On 18 October 2012 18:40, malc wrote:
> On Thu, 18 Oct 2012, Peter Maydell wrote:
>
> [..snip..]
>
>>
>> -/* FIXME: Implement this natively. */
>> -#define tcg_gen_abs_i32(t0, t1) gen_helper_abs(t0, t1)
>> +static void tcg_gen_abs_i32(TCGv dest, TCGv src)
>
On 18 October 2012 18:41, Jan Kiszka wrote:
> Minor: If you do
>
> function()
> {
> #ifdef CONFIG_KVM
> ...
> #endif
> }
>
>> +
>> qemu_irq *arm_pic_init_cpu(ARMCPU *cpu)
>> {
>> +#ifdef CONFIG_KVM
>> +if (kvm_enabled()) {
>> +return qemu_allocate_irqs(kvm_arm_pic_cpu_handler, cpu, 2
On 18 October 2012 19:59, Dmitry Fleytman wrote:
> Real HW always treats RX ring with RDH == RDT as empty.
> Emulation is supposed to behave the same.
If you need to do a v3 of this patch for some reason, it would
be nice to amend the summary line so it started "e1000: " so
people scanning git lo
On 18 October 2012 23:06, Oliver wrote:
> I tried compiling under Ubuntu
> Linux oliverks-virtual-machine 2.6.38-16-generic #67-Ubuntu SMP Thu Sep 6
> 17:58:38 UTC 2012 x86_64 x86_64 x86_64 GNU/Linux
>
> and it does not appear to work. I just get the statement
>
> VNC server running on `127.0.0.
assert_fail ()
#3 0x00463ffa in qdev_get_gpio_in ()
#4 0x00588f94 in armv7m_init ()
#5 0x0060c62a in stellaris_init ()
#6 0x0060cc4e in lm3s6965evb_init ()
#7 0x004fdb11 in main ()
(gdb)
Bisection points at this commit:
commit 1e8cae4dfea2bcc91d
** Changed in: qemu
Status: New => Fix Released
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/944645
Title:
ARM: CORTEX M, ICI/IT bits in XPSR were not cleared then entering
exception
Sta
I just built QEMU from source (git master commit b6348f29, same gcc as you,
MacOS 10.8.2), like this:
./configure --target-list=arm-softmmu && make -j2
and the resulting QEMU works for me. I tested with a Cortex-M3 image from here:
https://bugs.launchpad.net/qemu/+bug/1028260/+attachment/3233691/
(see the FIXME:s) at the moment but im pushing
for this now as the more conterversial QOM-entangled aspects of this device
model are encapsulated by this series. The device does also fully work for
Linux.
Edgar E. Iglesias (1):
nand: Reset addressing after READSTATUS.
Peter Crosthwaite (6
This field is completely unused. The base address should also be abstracted
away from the device anyway. Removed.
Signed-off-by: Peter Crosthwaite
---
hw/pflash_cfi01.c |2 --
hw/pflash_cfi02.c |4 +---
2 files changed, 1 insertions(+), 5 deletions(-)
diff --git a/hw/pflash_cfi01.c b
This field is completely unused.
Signed-off-by: Peter Crosthwaite
---
hw/pflash_cfi01.c |2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/hw/pflash_cfi01.c b/hw/pflash_cfi01.c
index 4f3f5f0..ebc8a57 100644
--- a/hw/pflash_cfi01.c
+++ b/hw/pflash_cfi01.c
@@ -62,7 +62,6
morph into something else with Anthony sysbus purge
so its intended to be a bridging patch until those refactorings go live.
Signed-off-by: Peter Crosthwaite
---
hw/sysbus.c | 11 ---
hw/sysbus.h |2 ++
2 files changed, 10 insertions(+), 3 deletions(-)
diff --git a/hw/sysbus.c b
Initial device model for the pl35x series of memory controllers. The SRAM
interface is just implemented as a passthrough using memory regions. NAND
interfaces are modelled.
Signed-off-by: Peter Crosthwaite
---
default-configs/arm-softmmu.mak |1 +
hw/Makefile.objs|1
Add the pl353 memory controller with both NAND and parallel flashes
attached.
Signed-off-by: Peter Crosthwaite
---
hw/xilinx_zynq.c | 49 +
1 files changed, 41 insertions(+), 8 deletions(-)
diff --git a/hw/xilinx_zynq.c b/hw/xilinx_zynq.c
From: Edgar E. Iglesias
Signed-off-by: Edgar E. Iglesias
---
hw/nand.c |6 ++
1 files changed, 6 insertions(+), 0 deletions(-)
diff --git a/hw/nand.c b/hw/nand.c
index 01f3ada..f931d0c 100644
--- a/hw/nand.c
+++ b/hw/nand.c
@@ -478,6 +478,12 @@ void nand_setio(DeviceState *dev, uint32
Hi All,
Thanks for the responses. Ill look into further in the near future,
probably starting the the Linker based approaches.
Regards,
Peter
QOMified the pflash_cfi0x so machine models can connect them up in custom ways.
Kept the pflash_cfi0x_register functions as is. They can still be used to
create a flash straight onto system memory.
Signed-off-by: Peter Crosthwaite
---
hw/pflash_cfi01.c | 142
** Changed in: qemu
Status: New => Invalid
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1065325
Title:
qemu-system-arm hangs on SIGUSR1 on OS X 10.8.2
Status in QEMU:
Invalid
Bug descri
On 19 October 2012 07:40, Peter Crosthwaite
wrote:
> This field is completely unused. The base address should also be abstracted
> away from the device anyway. Removed.
>
> Signed-off-by: Peter Crosthwaite
Reviewed-by: Peter Maydell
-- PMM
On 19 October 2012 07:40, Peter Crosthwaite
wrote:
> This field is completely unused.
>
> Signed-off-by: Peter Crosthwaite
Reviewed-by: Peter Maydell
-- PMM
501 - 600 of 75752 matches
Mail list logo
