On 13 October 2012 10:09, Blue Swirl <blauwir...@gmail.com> wrote: > On Wed, Oct 10, 2012 at 3:07 PM, Peter Maydell <peter.mayd...@linaro.org> > wrote: >> +#include "hw/arm-misc.h" >> + >> +const KVMCapabilityInfo kvm_arch_required_capabilities[] = { > > 'static'. In fact, 'static' not used at all in this file, probably it > could be used a lot more.
Actually this one can't be static -- it's defined here but used in kvm-all.c. The same applies for most of the functions in this file. I was able to add a 'static' to the regs[] array, but I couldn't find anywhere else here where a 'static' was missing. -- PMM