On 18 October 2012 15:26, Igor Mammedov <imamm...@redhat.com> wrote: > Peter Maydell <peter.mayd...@linaro.org> wrote: >> Add an include of qemu-log.h to hw.h, so that device model >> code has access to these logging functions without the need >> to directly include qemu-log.h. > It would be better to include qemu-log.h to files that have > immediate dependency on it, then creating another include all > "qemu-common.h." and compile/preprocess it for every hw file.
That is what v1 of this patch did; Blue suggested it would be better to put it in a common header, and I agree: basically every device model will have cases where it will want to diagnose bad guest behaviour, and so we would end up including qemu-log.h in every file in hw/. -- PMM
