Re: [Qemu-devel] [PATCH] vmstate: Add support for saving/loading bitmaps

2012-08-10 Thread Peter Maydell
On 10 August 2012 17:22, Igor Mitsyanko wrote: > On 08/09/2012 03:54 PM, Peter Maydell wrote: >> --- a/vmstate.h >> +++ b/vmstate.h >> @@ -139,6 +139,7 @@ extern const VMStateInfo vmstate_info_uint64; >> extern const VMStateInfo vmstate_info_timer; &g

Re: [Qemu-devel] [PATCH] device_tree: load_device_tree(): Allow NULL sizep

2012-08-10 Thread Peter Crosthwaite
On Fri, Aug 10, 2012 at 11:42 PM, Stefan Hajnoczi wrote: > On Fri, Aug 10, 2012 at 01:54:26PM +1000, Peter A. G. Crosthwaite wrote: >> The sizep arg is populated with the size of the loaded device tree. Since >> this >> is one of those informational "please populate&qu

Re: [Qemu-devel] [PATCH v5 08/15] ssd0323: abort() instead of exit(1) on error.

2012-08-10 Thread Peter Crosthwaite
On Mon, Aug 6, 2012 at 7:41 PM, Peter Maydell wrote: > On 6 August 2012 03:16, Peter A. G. Crosthwaite > wrote: >> To be more consistent with the newer ways of error signalling. That and >> SIGABT >> is easier to debug with than exit(1). >> >> Si

Re: [Qemu-devel] Is the return address of get_page_addr_code guest physical address?

2012-08-10 Thread Peter Maydell
On 10 August 2012 19:53, Steven wrote: > On Fri, Aug 10, 2012 at 11:47 AM, Peter Maydell > wrote: >> On 10 August 2012 03:11, Steven wrote: >>> The function definition has a return address type tb_page_addr_t. >>> tb_page_addr_t get_page_addr_code(CPUArch

Re: [Qemu-devel] [PATCH] Fix QEMU

2012-08-10 Thread Peter Maydell
On 10 August 2012 20:48, Stefan Weil wrote: > One more... No problem with the patch but your commit message summary implies a rather wider effect than the patch actually has :-) -- PMM

[Qemu-devel] github mirror still stale

2012-08-11 Thread Peter Maydell
On 18 July 2012 10:28, Peter Maydell wrote: > On 12 March 2012 20:12, Stefan Weil wrote: >> We also need more resources for technical maintenance of the >> QEMU infrastructure. For example, the official mirror of the >> QEMU git repository (https://github.com/qemu/QEMU)

[Qemu-devel] building qemu on macos mountain lion

2012-08-11 Thread Peter Maydell
[Karl: I've cc'd you because I think you were the person asking about this on #qemu IRC yesterday. Apologies if I have the wrong person...] I just had a go at building qemu on macos X (mountain lion). The good news is I got something working, but I had to fiddle with stuff a bit: * block/raw-posi

Re: [Qemu-devel] [PATCH v2] configure: fix double check tests with Clang

2012-08-11 Thread Peter Maydell
lf [-Werror,-Wself-assign] > environ = environ; > > Avoid the errors by adjusting the tests. > > Signed-off-by: Blue Swirl Reviewed-by: Peter Maydell -- PMM

Re: [Qemu-devel] [PATCH v5 08/15] ssd0323: abort() instead of exit(1) on error.

2012-08-11 Thread Peter Maydell
On 11 August 2012 00:31, Peter Crosthwaite wrote: > On Mon, Aug 6, 2012 at 7:41 PM, Peter Maydell > wrote: >> On 6 August 2012 03:16, Peter A. G. Crosthwaite >> wrote: >>> To be more consistent with the newer ways of error signalling. That and >>> SIGABT &

Re: [Qemu-devel] [PATCH RFC for-1.2] arm: Move some ARM devices into libhw

2012-08-11 Thread Peter Maydell
On 10 August 2012 18:15, Andreas Färber wrote: > Am 02.08.2012 15:48, schrieb Peter Maydell: >> On 2 August 2012 02:16, Andreas Färber wrote: >>> +hw-obj-$(CONFIG_STELLARIS_ENET) += stellaris_enet.o >> >> Why just this stellaris device and not the others? > &g

[Qemu-devel] [PATCH] iov_send_recv(): Handle zero bytes case even if OS does not

2012-08-11 Thread Peter Maydell
. Signed-off-by: Peter Maydell --- This is what was causing 'make check' to fail on MacOS X. The other option was to declare that a zero bytecount was illegal, I guess. iov.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/iov.c b/iov.c index b333061..60705c7 100644 --- a/i

[Qemu-devel] [PATCH 2/2] Support using a different compiler for Objective-C files

2012-08-11 Thread Peter Maydell
default to clang if we have it, otherwise whatever CC is (since gcc might be the Apple gcc which does support Blocks). Signed-off-by: Peter Maydell --- configure | 12 rules.mak | 2 +- 2 files changed, 13 insertions(+), 1 deletion(-) diff --git a/configure b/configure index be4a2bb..

[Qemu-devel] [PATCH 1/2] configure: Define OS_OBJECT_USE_OBJC=0 for MacOSX builds

2012-08-11 Thread Peter Maydell
Frameworks/IOKit.framework/Headers/IOKitLib.h:56, from block/raw-posix.c:35: /System/Library/Frameworks/Foundation.framework/Headers/NSObjCRuntime.h:409:1: error: stray ‘@’ in program [with a large number of further run-on errors] Signed-off-by: Peter Maydell --- configure | 3 +++ 1 file

[Qemu-devel] [PATCH 0/2] Fix compilation on MacOS X 10.8 ("Mountain Lion")

2012-08-11 Thread Peter Maydell
n the cocoa ui frontend use the 'Blocks' Apple extension, so won't build except with clang or the (now rapidly aging) Apple gcc, so to do a build with a modern gcc we need to support specifying the Objective-C compiler separately. Peter Maydell (2): configure: Define OS_O

Re: [Qemu-devel] [PATCH] iov_send_recv(): Handle zero bytes case even if OS does not

2012-08-12 Thread Peter Maydell
On 12 August 2012 06:29, Michael Tokarev wrote: > On 12.08.2012 01:24, Peter Maydell wrote: >> POSIX allows sendmsg() and recvmsg() to fail EMSGSIZE if passed a zero >> msg.msg_iovlen (in particular the MacOS X implementation will do this). > >> Handle the case where iov

[Qemu-devel] [Bug 1035572] Re: Bug in Qemu User Mode

2012-08-12 Thread Peter Maydell
Yes, threading does not work for i386 guests; this is a long-standing issue. (See also bug 739785.) -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1035572 Title: Bug in Qemu User Mode Status in QEM

Re: [Qemu-devel] [PATCH] kvm-all.c: Move init of irqchip_inject_ioctl out of kvm_irqchip_create()

2012-08-12 Thread Peter Maydell
Ping? I don't think this one quite made it into Avi's pullreq... thanks -- PMM On 6 August 2012 18:05, Peter Maydell wrote: > Move the init of the irqchip_inject_ioctl field of KVMState out of > kvm_irqchip_create() and into kvm_init(), so that kvm_set_irq() > can be used e

Re: [Qemu-devel] [PATCH 4/7] compiler: add macro for GCC weak symbols

2012-08-12 Thread Peter Maydell
On 10 August 2012 17:04, Anthony Liguori wrote: > This lets us provide a default implementation of a symbol which targets can > override. > > Signed-off-by: Anthony Liguori I'm sure you'll be thrilled to hear that this doesn't seem to break MacOS builds :-) -- PMM

Re: [Qemu-devel] [PATCH] update-linux-headers.sh: Don't hard code list of architectures

2012-08-13 Thread Peter Maydell
Ping^2? On 3 August 2012 13:55, Peter Maydell wrote: > Ping? > > patchwork url: http://patchwork.ozlabs.org/patch/171628/ > > -- PMM > > On 18 July 2012 11:11, Peter Maydell wrote: >> Rather than hardcoding the list of architectures in the kernel >> header updat

Re: [Qemu-devel] [PATCH] update-linux-headers.sh: Pull in asm-generic/kvm_para.h

2012-08-13 Thread Peter Maydell
Ping^2 ? On 8 August 2012 13:34, Peter Maydell wrote: > Ping? > > patchwork url: http://patchwork.ozlabs.org/patch/173202/ > > -- PMM > > On 25 July 2012 16:29, Peter Maydell wrote: >> Add asm-generic/kvm_para.h to the set of non-architecture specific >> KVM

Re: [Qemu-devel] [PATCH v2 1/2] linux-user: Factor out guest space probing into a function

2012-08-13 Thread Peter Maydell
On 27 July 2012 03:50, Meador Inge wrote: > Signed-off-by: Meador Inge Reviewed-by: Peter Maydell -- PMM

Re: [Qemu-devel] [PATCH v2 2/2] linux-user: Use init_guest_space when -R and -B are specified

2012-08-13 Thread Peter Maydell
way we can allocate it. > + */ > +if (test_page_addr >= guest_base > + && test_page_addr <= (guest_base + guest_size)) { > + return -1; > +} The indent here is busted (hardcoded tabs), as checkpatch.pl will tell you. Otherwise Reviewed-by: Peter M

Re: [Qemu-devel] [PATCH for-1.2 v2] arm: Move some ARM devices into libhw

2012-08-13 Thread Peter Maydell
since most have implicit or explicit >> dependencies on the CPU. >> >> Signed-off-by: Andreas Färber > > Err sorry, should be SoB . (Muphry's law!) Reviewed-by: Peter Maydell ...last patch to make it under the wire for ARM for 1.2. Pullreq coming out later today. -- PMM

[Qemu-devel] [PATCH 05/10] hw/sd.c: introduce wrapper for conversion address to wp group

2012-08-13 Thread Peter Maydell
From: Mitsyanko Igor Add wrapper function sd_addr_to_wpnum() to replace long address-->wg_group conversion line. Signed-off-by: Igor Mitsyanko Signed-off-by: Peter Maydell --- hw/sd.c | 27 +-- 1 file changed, 13 insertions(+), 14 deletions(-) diff --git a/hw/s

[Qemu-devel] [PATCH 03/10] hw/sd.c: convert wp_groups in SDState to bitfield

2012-08-13 Thread Peter Maydell
From: Mitsyanko Igor Representing each group write protection flag with only one bit instead of int variable significantly reduces memory consumption. Signed-off-by: Igor Mitsyanko Signed-off-by: Peter Maydell --- hw/sd.c | 33 +++-- 1 file changed, 19

Re: [Qemu-devel] [PATCH] update-linux-headers.sh: Pull in asm-generic/kvm_para.h

2012-08-13 Thread Peter Maydell
On 13 August 2012 15:24, Anthony Liguori wrote: > Peter Maydell writes: >> [re patchwork url: http://patchwork.ozlabs.org/patch/173202/ ] >> Ping^2 ? > > In a previous thread, we all agreed that all changes to linux headers > would come in through uq/master to ensure that

[Qemu-devel] [PATCH 09/10] ssd0323: abort() instead of exit(1) on error.

2012-08-13 Thread Peter Maydell
From: "Peter A. G. Crosthwaite" To be more consistent with the newer ways of error signalling. That and SIGABT is easier to debug with than exit(1). Signed-off-by: Peter A. G. Crosthwaite Reviewed-by: Peter Maydell Signed-off-by: Peter Maydell --- hw/ssd0323.c |4 +++- 1 file

[Qemu-devel] [PATCH 01/10] hw/armv7m_nvic: Fix incorrect default for num-irqs property

2012-08-13 Thread Peter Maydell
parent's Property array, we define an instance_init function which runs after default setup but before user property setting and can just fix up the default value in the gic_state struct. Reported-by: Peter Crosthwaite Tested-by: Peter Crosthwaite Signed-off-by: Peter Maydell --- hw/armv7m_n

[Qemu-devel] [PATCH 04/10] hw/sd.c: make sd_wp_addr() accept 64 bit address argument

2012-08-13 Thread Peter Maydell
From: Mitsyanko Igor Currently sd_wp_addr() accepts 32 bit address arguments therefore implicitly restricting SD card address range. Change address argument type to uint64_t. Signed-off-by: Igor Mitsyanko Signed-off-by: Peter Maydell --- hw/sd.c |2 +- 1 file changed, 1 insertion(+), 1

[Qemu-devel] [PULL for-1.2 00/10] arm-devs queue

2012-08-13 Thread Peter Maydell
ept 64 bit address argument hw/sd.c: introduce wrapper for conversion address to wp group hw/sd.c: convert binary variables to bool hw/sd.c: make sd_dataready() return bool hw/sd.c: make sd_wp_addr() return bool Peter A. G. Crosthwaite (2): armv7m: Guard against no -kerne

[Qemu-devel] [PATCH 08/10] hw/sd.c: make sd_wp_addr() return bool

2012-08-13 Thread Peter Maydell
From: Mitsyanko Igor For the sake of code clarity Signed-off-by: Igor Mitsyanko Signed-off-by: Peter Maydell --- hw/sd.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/sd.c b/hw/sd.c index 209bc19..ec26407 100644 --- a/hw/sd.c +++ b/hw/sd.c @@ -542,7 +542,7

[Qemu-devel] [PATCH 06/10] hw/sd.c: convert binary variables to bool

2012-08-13 Thread Peter Maydell
From: Mitsyanko Igor Several members of SDState have type int when they actually are binary variables. Change type of these variables to bool to improve code readability. Change SD API to be in consistency with new variables type. Signed-off-by: Igor Mitsyanko Reviewed-by: Peter Maydell

[Qemu-devel] [PATCH 10/10] arm: Move some ARM devices into libhw

2012-08-13 Thread Peter Maydell
From: Andreas Färber Avoids some unnecessary dependencies on cpu.h and prepares for a future armeb-softmmu where most machines would not be built. Defer touching the SoC devices since most have implicit or explicit dependencies on the CPU. Signed-off-by: Andreas Färber Signed-off-by: Peter

[Qemu-devel] [PATCH 02/10] armv7m: Guard against no -kernel argument

2012-08-13 Thread Peter Maydell
From: "Peter A. G. Crosthwaite" A -kernel argument must be specified for this machine. Guard against no -kernel argument. Previously gave an unhelpful "bad address" error message. Signed-off-by: Peter A. G. Crosthwaite Tested-by: Markus Armbruster Signed-off-by: Pe

[Qemu-devel] [PATCH 07/10] hw/sd.c: make sd_dataready() return bool

2012-08-13 Thread Peter Maydell
From: Mitsyanko Igor For the sake of code clarity Signed-off-by: Igor Mitsyanko Reviewed-by: Peter Maydell Signed-off-by: Peter Maydell --- hw/sd.c |2 +- hw/sd.h |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/sd.c b/hw/sd.c index ebc4e7c..209bc19 100644

Re: [Qemu-devel] [PATCH] kvm-all.c: Move init of irqchip_inject_ioctl out of kvm_irqchip_create()

2012-08-13 Thread Peter Maydell
On 13 August 2012 21:45, Marcelo Tosatti wrote: > On Sun, Aug 12, 2012 at 02:13:52PM +0100, Peter Maydell wrote: >> Ping? I don't think this one quite made it into Avi's pullreq... > > Please post this with the rest of the code to support the new > s->irqchip_inj

Re: [Qemu-devel] [PATCH] kvm-all.c: Move init of irqchip_inject_ioctl out of kvm_irqchip_create()

2012-08-14 Thread Peter Maydell
On 14 August 2012 08:33, Jan Kiszka wrote: > Either you move both or none. OK. > KVM_IRQ_LINE is old-style, deprecated, KVM_IRQ_LINE_STATUS (i.e > injection with feedback to allow lost-tick compensation) is the current > standard that other archs should pick up. Can it be documented in the kern

Re: [Qemu-devel] [PATCH] kvm-all.c: Move init of irqchip_inject_ioctl out of kvm_irqchip_create()

2012-08-14 Thread Peter Maydell
On 14 August 2012 08:42, Jan Kiszka wrote: > On 2012-08-14 09:40, Peter Maydell wrote: >> On 14 August 2012 08:33, Jan Kiszka wrote: >>> KVM_IRQ_LINE is old-style, deprecated, KVM_IRQ_LINE_STATUS (i.e >>> injection with feedback to allow lost-tick compensation) is th

Re: [Qemu-devel] [PATCH] i2c: factor out VMSD to parent class

2012-08-14 Thread Peter Maydell
On 14 August 2012 09:27, Juan Quintela wrote: > "Peter A. G. Crosthwaite" wrote: >> Hi All. PMM raised a query on a recent series of mine (the SSI series) about >> handling VMSD for devices which define state at multiple levels of the QOM >> heirachy. >

[Qemu-devel] [PATCH 01/10] linux-user: Fix incorrect TARGET_BLKBSZGET, TARGET_BLKBSZSET

2012-08-14 Thread Peter Maydell
and so on an x86-64-to-x86-64 linux-user binary we were triggering the mismatch warning in syscall_init(). Signed-off-by: Peter Maydell --- linux-user/syscall_defs.h |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/linux-user/syscall_defs.h b/linux-user/syscall_defs.h

[Qemu-devel] [PATCH 10/10] linux-user: ARM: Ignore immediate value for svc in thumb mode

2012-08-14 Thread Peter Maydell
From: Alexander Graf When running in thumb mode, Linux doesn't evaluate the immediate value of the svc instruction, but instead just always assumes the syscall number to be in r7. This fixes executing go_bootstrap while building go for me. Signed-off-by: Alexander Graf Reviewed-by:

Re: [Qemu-devel] [Bug 1035572] Re: Bug in Qemu User Mode

2012-08-14 Thread Peter Maydell
On 14 August 2012 02:01, Dietmar Stölting wrote: > with this new syscall.c content above things are going in the right > direction:-). > I make a test with strace from the program testthread of the Qemu testsuite. > When I understand the result right, > threading works now with this new compiled

[Qemu-devel] [PATCH 06/10] linux-user: make host_to_target_cmsg support SO_TIMESTAMP cmsg_type

2012-08-14 Thread Peter Maydell
From: Jing Huang Signed-off-by: Jing Huang Reviewed-by: Peter Maydell Signed-off-by: Peter Maydell --- linux-user/syscall.c | 20 1 file changed, 16 insertions(+), 4 deletions(-) diff --git a/linux-user/syscall.c b/linux-user/syscall.c index 700163e..3fa5299 100644

[Qemu-devel] [PATCH 08/10] linux-user: Factor out guest space probing into a function

2012-08-14 Thread Peter Maydell
From: Meador Inge Signed-off-by: Meador Inge Reviewed-by: Peter Maydell Signed-off-by: Peter Maydell --- linux-user/elfload.c | 110 +++--- linux-user/qemu.h| 13 ++ 2 files changed, 90 insertions(+), 33 deletions(-) diff --git a/linux

[Qemu-devel] [PULL for-1.2 00/10] linux-user queue

2012-08-14 Thread Peter Maydell
r: Factor out guest space probing into a function linux-user: Use init_guest_space when -R and -B are specified Mike Frysinger (1): flatload: fix bss clearing Peter Maydell (3): linux-user: Fix incorrect TARGET_BLKBSZGET, TARGET_BLKBSZSET linux-user: Fix SNDCTL_DSP_MAP{IN, OU

[Qemu-devel] [PATCH 02/10] linux-user: Fix SNDCTL_DSP_MAP{IN, OUT}BUF ioctl definitions

2012-08-14 Thread Peter Maydell
Fix the SNDCTL_DSP_MAP{IN,OUT}BUF ioctl definitions so that they refer to a suitably defined target struct layout rather than hardcoding the ioctl number. This fixes complaints from the syscall_init() consistency check when running an x86_64-to-x86_64 linux-user qemu. Signed-off-by: Peter Maydell

[Qemu-devel] [PATCH 05/10] linux-user: make do_setsockopt support SOL_RAW ICMP_FILTER socket option

2012-08-14 Thread Peter Maydell
From: Jing Huang Signed-off-by: Jing Huang Reviewed-by: Peter Maydell Signed-off-by: Peter Maydell --- linux-user/syscall.c | 20 1 file changed, 20 insertions(+) diff --git a/linux-user/syscall.c b/linux-user/syscall.c index 47f0eb3..700163e 100644 --- a/linux-user

[Qemu-devel] [PATCH 04/10] linux-user: pass sockaddr from host to target

2012-08-14 Thread Peter Maydell
From: Jing Huang Signed-off-by: Jing Huang Reviewed-by: Peter Maydell Signed-off-by: Peter Maydell --- linux-user/syscall.c | 16 +--- 1 file changed, 13 insertions(+), 3 deletions(-) diff --git a/linux-user/syscall.c b/linux-user/syscall.c index 1af68d2..47f0eb3 100644 --- a

[Qemu-devel] [PATCH 09/10] linux-user: Use init_guest_space when -R and -B are specified

2012-08-14 Thread Peter Maydell
rrently done is not guaranteed to succeed since the host address space validation might fail. Signed-off-by: Meador Inge [PMM: Fixed minor whitespace errors.] Reviewed-by: Peter Maydell Signed-off-by: Peter Maydell --- linux-user/elfload.c | 59 ++---

[Qemu-devel] [PATCH 03/10] linux-user: Move target_to_host_errno_table[] setup out of ioctl loop

2012-08-14 Thread Peter Maydell
The code to initialise the target_to_host_errno_table[] array was accidentally inside the loop through checking and initialising all the supported ioctls. This was harmless but meant that we reinitialised the array several hundred times on startup. Signed-off-by: Peter Maydell --- linux-user

[Qemu-devel] [PATCH 07/10] flatload: fix bss clearing

2012-08-14 Thread Peter Maydell
From: Mike Frysinger The current bss clear logic assumes the target mmap address and host address are the same. Use g2h to translate from the target address space to the host so we can call memset on it. Signed-off-by: Mike Frysinger Reviewed-by: Peter Maydell Signed-off-by: Peter Maydell

Re: [Qemu-devel] [PATCH] kvm-all.c: Move init of irqchip_inject_ioctl out of kvm_irqchip_create()

2012-08-14 Thread Peter Maydell
On 14 August 2012 09:09, Jan Kiszka wrote: > On 2012-08-14 09:52, Peter Maydell wrote: >> Well, you appear to know what this variant ioctl does and why it's >> better than KVM_IRQ_LINE, whereas I don't. I just want to deliver >> an interrupt, KVM_IRQ_LINE lets me de

[Qemu-devel] [PATCH] configure: Don't override user's --cpu on MacOS and Solaris

2012-08-14 Thread Peter Maydell
with --cpu. This fixes a bug where the user's command line argument was being ignored. Signed-off-by: Peter Maydell --- The per-OS checks are broken for cross compilation, but this isn't a change introduced by this patch -- they were broken before; I've merely added a comment not

Re: [Qemu-devel] [PATCH 03/10] linux-user: Move target_to_host_errno_table[] setup out of ioctl loop

2012-08-14 Thread Peter Maydell
On 14 August 2012 19:27, Blue Swirl wrote: > On Tue, Aug 14, 2012 at 9:40 AM, Peter Maydell > wrote: >> The code to initialise the target_to_host_errno_table[] array was >> accidentally inside the loop through checking and initialising all >> the supported ioctls. Thi

Re: [Qemu-devel] [PATCH 03/10] linux-user: Move target_to_host_errno_table[] setup out of ioctl loop

2012-08-14 Thread Peter Maydell
On 14 August 2012 19:58, Blue Swirl wrote: > On Tue, Aug 14, 2012 at 6:38 PM, Peter Maydell > wrote: >> On 14 August 2012 19:27, Blue Swirl wrote: >>> On Tue, Aug 14, 2012 at 9:40 AM, Peter Maydell >>> wrote: >>>> +/* Bui

Re: [Qemu-devel] [PATCH 16/20] qidl: Add documentation

2012-08-14 Thread Peter Maydell
On 14 August 2012 17:27, Michael Roth wrote: > > Signed-off-by: Michael Roth > --- > docs/qidl.txt | 343 > + > 1 file changed, 343 insertions(+) > create mode 100644 docs/qidl.txt > > diff --git a/docs/qidl.txt b/docs/qidl.txt > new fil

Re: [Qemu-devel] [PATCH v8] kvm: notify host when the guest is panicked

2012-08-14 Thread Peter Maydell
On 14 August 2012 19:53, Anthony Liguori wrote: > Forget about !x86 platforms. They have their own way to do this sort of > thing. Think of this feature like a status LED on a motherboard. These > are very common and usually controlled by IO ports. Please don't forget !x86 platforms, we are cu

Re: [Qemu-devel] [PATCH 16/20] qidl: Add documentation

2012-08-14 Thread Peter Maydell
On 14 August 2012 23:15, Michael Roth wrote: > On Tue, Aug 14, 2012 at 08:41:56PM +0100, Peter Maydell wrote: >> On 14 August 2012 17:27, Michael Roth wrote: >> > +In our *SerialDevice* example, the *CharDriverState* pointer reflects the >> > host >> > +backe

Re: [Qemu-devel] [PATCH 0/4] [PULL] qemu-kvm.git uq/master queue

2012-08-15 Thread Peter Maydell
git repository at: > > git://git.kernel.org/pub/scm/virt/kvm/qemu-kvm.git uq/master > > Jan Kiszka (3): > kvm: i8254: Cache kernel clock offset in KVMPITState > kvm: i8254: Finish time conversion fix > kvmvapic: Disable if there is insufficient memory >

Re: [Qemu-devel] [Bug 1036987] [NEW] compilation error due to bug in savevm.c

2012-08-15 Thread Peter Maydell
On 15 August 2012 08:44, Evgeny Voevodin wrote: > Since > > 302dfbeb21fc5154c24ca50d296e865a3778c7da > > Add xbzrle_encode_buffer and xbzrle_decode_buffer functions > commit arrived into master barnch, I can't compile qemu at all: > > savevm.c:2476:13: error: overflow in implicit constant convers

Re: [Qemu-devel] [PATCH] savevm.c: Fix compilation error on 32bit host.

2012-08-15 Thread Peter Maydell
On 15 August 2012 10:10, Evgeny Voevodin wrote: > Casting of 0x0101010101010101ULL to long will truncate it to 32 > bits on 32bit hosts, and won't truncate on 64bit hosts. > > Signed-off-by: Evgeny Voevodin Dup of http://patchwork.ozlabs.org/patch/177217/ I'm afraid. -- PMM

[Qemu-devel] [PATCH v2] kvm-all.c: Move init of irqchip_inject_ioctl out of kvm_irqchip_create()

2012-08-15 Thread Peter Maydell
Move the init of the irqchip_inject_ioctl field of KVMState out of kvm_irqchip_create() and into kvm_init(), so that kvm_set_irq() can be used even when no irqchip is created (for architectures that support async interrupt notification even without an in kernel irqchip). Signed-off-by: Peter

Re: [Qemu-devel] [PATCH] Add support for pretty-printing response in qmp-shell

2012-08-15 Thread Peter Maydell
On 15 August 2012 11:33, Daniel P. Berrange wrote: > class QMPShell(qmp.QEMUMonitorProtocol): > -def __init__(self, address): > +def __init__(self, address, pp=None): > qmp.QEMUMonitorProtocol.__init__(self, self.__get_address(address)) > self._greeting = None >

[Qemu-devel] [PATCH v2] Makefile: Avoid explicit list of directories in clean target

2012-08-15 Thread Peter Maydell
Avoid having an explicit list of directories in the 'clean' target by using 'find' to remove all .o and .d files instead. Signed-off-by: Peter Maydell --- Changes v1->v2: use portable 'find -exec' rather than unsafe 'find | xargs' or unportable &

Re: [Qemu-devel] Hard freeze for 1.2 today

2012-08-15 Thread Peter Maydell
On 15 August 2012 15:22, wrote: > Today is the hard freeze for 1.2. If you have any pull requests and/or > patches targetted for the hard freeze, please send them by 3pm > US/Central time today and clearly mark them "for-1.2". > > If there are existing patches and/or pull requests on the mailing

Re: [Qemu-devel] [PATCH 2/2] Support using a different compiler for Objective-C files

2012-08-15 Thread Peter Maydell
On 15 August 2012 15:47, Andreas Färber wrote: > Am 11.08.2012 23:34, schrieb Peter Maydell: >> +# Default objcc to clang if available, otherwise use CC >> +if has clang; then >> + objcc=clang > > On IRC I had commented that I find defaulting to clang whenever clang is

Re: [Qemu-devel] [PATCH v2 for-1.2 00/27] Suppress unused default drives

2012-08-15 Thread Peter Maydell
On 15 August 2012 20:25, Alexander Graf wrote: > On 15.08.2012, at 21:17, Markus Armbruster wrote: > >> We create a number of default drives for machines to use: floppy, >> CD-ROM, SD card. Machines can suppress the ones they don't use, but >> few do. Fix that. >> v2: >> Make default drives op

Re: [Qemu-devel] [PATCH v2 for-1.2 00/27] Suppress unused default drives

2012-08-15 Thread Peter Maydell
On 15 August 2012 20:58, Anthony Liguori wrote: > Peter Maydell writes: >> On 15 August 2012 20:25, Alexander Graf wrote: >>> Nack from my POV. Too late for 1.2. Better get this in early for 1.3. > > No, it's not too late for 1.2. > > The release process is p

Re: [Qemu-devel] [PATCH v2 for-1.2 00/27] Suppress unused default drives

2012-08-15 Thread Peter Maydell
On 15 August 2012 21:57, Anthony Liguori wrote: > http://ozlabs.org/~rusty/index.cgi/tech/2007-05-04.html > > It's not that I disagree with you. I think this is good feedback for a > series like this. > > I just don't want people sending out single sentence "Nack" emails for > patch series just b

Re: [Qemu-devel] [PATCH 06/10] block: Enable qemu_open/close to work with fd sets

2012-08-15 Thread Peter Maydell
On 15 August 2012 14:56, Kevin Wolf wrote: > From: Corey Bryant > +/* Set/unset flags that we can with fcntl */ > +setfl_flags = O_APPEND | O_ASYNC | O_DIRECT | O_NOATIME | O_NONBLOCK; > +dup_flags &= ~setfl_flags; > +dup_flags |= (flags & setfl_flags); > +if (fcntl(ret, F_SET

Re: [Qemu-devel] Apparent USB assignment issue on 1.1+

2012-08-16 Thread Peter Maydell
On 16 August 2012 09:14, Gerd Hoffmann wrote: > On 08/16/12 09:45, Michael Tokarev wrote: >> This issue has been reported several times already, >> but I can't reproduce it locally. Gerd, can you >> please take a look, maybe you may ask better >> question to the OP(s) about what to try. >> >> htt

Re: [Qemu-devel] [PATCH] Documentation: Warn against qemu-img on active image

2012-08-16 Thread Peter Maydell
On 16 August 2012 10:00, Kevin Wolf wrote: > People have repeatedly expected that you can do things like snapshotting > an image with qemu-img while a qemu instance is running. Maybe we need > to consider locking the files while they are in use, but having a > warning in the qemu-img manpage is do

[Qemu-devel] [PATCH for-1.2] osdep: Fix compilation failure on BSD systems

2012-08-16 Thread Peter Maydell
error: ‘O_NOATIME’ undeclared (first use in this function) Signed-off-by: Peter Maydell --- PS: Do we care about O_DSYNC, O_RSYNC, O_SYNC? POSIX says those can be used via fcntl() too... osdep.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/osdep.c b/osdep.c index 5b

Re: [Qemu-devel] [PATCH 1/2] extract file_load() function from rom_add_file() for reusing

2012-08-16 Thread Peter Maydell
On 14 August 2012 08:49, Olivia Yin wrote: > Sanity check in rom_add_file() could be reused by other image loaders. > > Signed-off-by: Olivia Yin > --- > This patch is based on branch 'ppc-next' of Alex's upstream QEMU repo: > http://repo.or.cz/r/qemu/agraf.git > > hw/loader.c | 61 +++

Re: [Qemu-devel] [PATCH v2 for-1.2 00/27] Suppress unused default drives

2012-08-16 Thread Peter Maydell
On 15 August 2012 20:36, Peter Maydell wrote: > I also think we should follow up Paul Brook's suggestion > that we don't need to have any kind of "default sd card" flag > at all. Floppy is weird because we don't properly separate out > the drive and the co

Re: [Qemu-devel] [PATCH for-1.2] osdep: Fix compilation failure on BSD systems

2012-08-16 Thread Peter Maydell
On 16 August 2012 13:27, Stefan Weil wrote: > Am 16.08.2012 13:15, schrieb Peter Maydell: > >> Fix compilation failure on BSD systems (which don't have >> O_DIRECT or O_NOATIME: >> osdep.c:116: error: ‘O_DIRECT’ undeclared (first use in this function) >> o

Re: [Qemu-devel] [PATCH] Spelling fixes in comments and documentation

2012-08-16 Thread Peter Maydell
On 10 August 2012 21:03, Stefan Weil wrote: > diff --git a/docs/usb2.txt b/docs/usb2.txt > index d17e3c0..21f6d14 100644 > --- a/docs/usb2.txt > +++ b/docs/usb2.txt > @@ -58,11 +58,11 @@ try ... > xhci controller support > --- > > -There also is xhci host controller support a

Re: [Qemu-devel] [PATCH for-1.2] osdep: Fix compilation failure on BSD systems

2012-08-16 Thread Peter Maydell
On 16 August 2012 14:11, Corey Bryant wrote: > > > On 08/16/2012 07:15 AM, Peter Maydell wrote: >> >> Fix compilation failure on BSD systems (which don't have >> O_DIRECT or O_NOATIME: >> osdep.c:116: error: ‘O_DIRECT’ undeclared (first use in this

[Qemu-devel] [PATCH 2/3] pxa2xx: Get BlockDriverState* in mmc controller init, not board init

2012-08-16 Thread Peter Maydell
an SD controller with no card present if the user didn't ask for an SD card. Signed-off-by: Peter Maydell --- hw/pxa.h |2 +- hw/pxa2xx.c | 16 ++-- hw/pxa2xx_mmci.c |7 +-- 3 files changed, 8 insertions(+), 17 deletions(-) diff --git a/hw/pxa.h b/hw/p

[Qemu-devel] [PATCH 3/3] Drop default SD card creation

2012-08-16 Thread Peter Maydell
Now that all users of IF_SD drives can cope with there being no drive present (ie "controller exists but there is no card in it") we can drop the creation of the default IF_SD card in vl.c and the no_sdcard field in the QEMUMachine struct. Signed-off-by: Peter Maydell --- h

[Qemu-devel] [PATCH 0/3] Drop default SD card creation

2012-08-16 Thread Peter Maydell
controller with no card present This then allows us to drop the QEMUMachine no_sdcard flag and the vl.c code which creates a dummy IF_SD drive. Not intended for 1.2, obviously. Peter Maydell (3): omap: Get BlockDriverState* in mmc controller init, not board init pxa2xx: Get BlockDriverSta

[Qemu-devel] [PATCH 1/3] omap: Get BlockDriverState* in mmc controller init, not board init

2012-08-16 Thread Peter Maydell
an SD controller with no card present if the user didn't ask for an SD card. Signed-off-by: Peter Maydell --- hw/omap.h |3 +-- hw/omap1.c|8 +--- hw/omap2.c|8 +--- hw/omap_mmc.c | 12 4 files changed, 11 insertions(+), 20 deletions(-) diff --git a/h

Re: [Qemu-devel] [PATCH 0/3] Drop default SD card creation

2012-08-16 Thread Peter Maydell
On 16 August 2012 15:11, Markus Armbruster wrote: > Peter Maydell writes: >> As suggested in the recent discussion on Markus' patchset to suppress >> unused default drives, this patchset cleans up the omap and pxa2xx >> SD card controllers to behave like the other c

Re: [Qemu-devel] [PATCH 0/3] Drop default SD card creation

2012-08-16 Thread Peter Maydell
On 16 August 2012 16:17, Markus Armbruster wrote: > Paul Brook writes: >> I think this may be the wrong way to fix this. SD cards aren't really have >> removable media. In the same way that a SCSI HDD are generally not removable >> media - you hotplug the whole drive. > > If an SD card device d

Re: [Qemu-devel] qemu log function to print out the registers of the guest

2012-08-16 Thread Peter Maydell
On 16 August 2012 17:36, Steven wrote: > I would like to get a trace of guest memory access. So I can not use > "info registers". > What I want to do is that when tcg fetches a load instruction at > disas_insns(), the guest memory address should be calculated. You cannot calculate the guest memor

Re: [Qemu-devel] qemu log function to print out the registers of the guest

2012-08-16 Thread Peter Maydell
On 16 August 2012 18:13, Steven wrote: > So the run time function should be tcg_out_qemu_ld, right? No, tcg_out_qemu_ld is a translate time function, which emits the native (x86 in this case) instructions necessary to perform a guest load. -- PMM

Re: [Qemu-devel] [PATCH v2 for-1.2 18/27] microblaze: Suppress unused default drives

2012-08-16 Thread Peter Crosthwaite
On Thu, Aug 16, 2012 at 5:17 AM, Markus Armbruster wrote: > Cc: Peter Crosthwaite > > Suppress default floppy, CD-ROM and SD card drives for machines > petalogix-ml605 and petalogix-s3adsp1800. > > Signed-off-by: Markus Armbruster Reviewed-by: Peter Crosth

Re: [Qemu-devel] [PATCH v2 for-1.2 12/27] xilinx-zynq: Suppress unused default drives

2012-08-16 Thread Peter Crosthwaite
On Thu, Aug 16, 2012 at 5:17 AM, Markus Armbruster wrote: > Cc: Peter Crosthwaite > > Suppress default floppy and CD-ROM drives. SD card was already > suppressed. > > Signed-off-by: Markus Armbruster Reviewed-by: Peter Crosthwaite > --- > hw/xilinx_zynq.c | 2

Re: [Qemu-devel] How does ARM VFP is emulated?

2012-08-17 Thread Peter Maydell
On 17 August 2012 12:27, 陳韋任 (Wei-Ren Chen) wrote: > On Fri, Aug 17, 2012 at 10:29:24AM +0200, Laurent Desnogues wrote: >> On Thursday, August 16, 2012, Oi Khote wrote: >> > So how exactly does VFP is being emulated. >> >> QEMU uses a library for FP computations, based on the softfloat package. >

Re: [Qemu-devel] [PATCH] pl190: fix read of VECTADDR

2012-08-18 Thread Peter Maydell
On 18 August 2012 03:55, Brendan Fennell wrote: > Signed-off-by: Brendan Fennell > --- > hw/pl190.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/hw/pl190.c b/hw/pl190.c > index cb50afb..d69d5be 100644 > --- a/hw/pl190.c > +++ b/hw/pl190.c > @@ -133,7 +133,7 @@ s

Re: [Qemu-devel] qemu for android arm

2012-08-18 Thread Peter Maydell
On 18 August 2012 06:35, Xin Tong wrote: > Does QEMU have all the supports to boot android on arm ? You mean Android as a guest? The first question you should be asking is "android on ARM on what hardware?". If you can find an Android build for one of the machines QEMU supports (vexpress-a9 is pr

Re: [Qemu-devel] [PATCH] pl190: fix read of VECTADDR

2012-08-18 Thread Peter Maydell
On 18 August 2012 11:41, Brendan Fennell wrote: > > > On Sat, 18 Aug 2012, Peter Maydell wrote: > >> On 18 August 2012 03:55, Brendan Fennell wrote: >>> >>> Signed-off-by: Brendan Fennell >>> --- >>> hw/pl190.c |2 +- >>> 1 fi

Re: [Qemu-devel] Compilation Error with gcc 4.6

2012-08-18 Thread Peter Maydell
On 18 August 2012 17:54, MJ embd wrote: > Hi All, > I am trying to compile qemu for arm top of tree on ubuntu 12.04 and am > getting the following errors. Can anyone help > LINK qemu-ga > /usr/lib/gcc/arm-linux-gnueabi/4.6/../../../../arm-linux-gnueabi/bin/ld: > cannot find -lgthread-2.0 > /us

Re: [Qemu-devel] [PATCH] qapi: Fix memory leak

2012-08-19 Thread Peter Maydell
On 18 August 2012 22:01, Stefan Weil wrote: > valgrind reports a lot more memory leaks which are related to > function qemu_allocate_irqs. In many cases, its return value > should be free'd. g_malloc / g_free can be avoided by adding > a new function > > void qemu_init_irqs(qemu_irq_handler handle

Re: [Qemu-devel] memory: could we add extra input param for memory_region_init_io()?

2012-08-19 Thread Peter Maydell
can not work for such issue. > > IMO omap_mpu_timer_s should be a DeviceState. Peter? Ideally, yes, but qemu is full of devices that haven't yet made the leap to QOM. omap1 is particularly tricky because I don't actually have any test images for it, so refactoring it is a leap in the

Re: [Qemu-devel] memory: could we add extra input param for memory_region_init_io()?

2012-08-19 Thread Peter Maydell
On 19 August 2012 12:23, Peter Maydell wrote: > Ideally, yes, but qemu is full of devices that haven't yet made the leap > to QOM. > > omap1 is particularly tricky because I don't actually have any test images > for it, so refactoring it is a leap in the dark. [I'v

[Qemu-devel] [Bug 1035572] Re: Bug in Qemu User Mode

2012-08-19 Thread Peter Maydell
Thanks for doing this testing but I'm afraid it really isn't giving us any new information. We already know clone is broken for i386 targets; see my comment #9 in this bug. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.

Re: [Qemu-devel] [RFC v0] HACK: qom: object_property_set: abort on failure

2012-08-19 Thread Peter Crosthwaite
On Tue, Aug 14, 2012 at 10:50 PM, Anthony Liguori wrote: > "Peter A. G. Crosthwaite" writes: > >> Hi All. A couple of times now ive had debug issues due to silent failure of >> object_property_set. This function silently fails if the requested property >> does n

Re: [Qemu-devel] [PATCH] i2c: factor out VMSD to parent class

2012-08-19 Thread Peter Crosthwaite
On Tue, Aug 14, 2012 at 6:46 PM, Peter Maydell wrote: > On 14 August 2012 09:27, Juan Quintela wrote: >> "Peter A. G. Crosthwaite" wrote: >>> Hi All. PMM raised a query on a recent series of mine (the SSI series) about >>> handling VMSD for devices which d

[Qemu-devel] [PATCH for-1.2] linux-user: Clarify "Unable to reserve guest address space" error

2012-08-20 Thread Peter Maydell
-by: Peter Maydell --- I've had several people run into this and have no idea what the problem was (generally they were running with a ulimit -v setting), so I think it is worth putting this into 1.2. linux-user/main.c |5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/

<    1   2   3   4   5   6   7   8   9   10   >