On 18 August 2012 03:55, Brendan Fennell <bfenn...@skynet.ie> wrote: > Signed-off-by: Brendan Fennell <bfenn...@skynet.ie> > --- > hw/pl190.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/hw/pl190.c b/hw/pl190.c > index cb50afb..d69d5be 100644 > --- a/hw/pl190.c > +++ b/hw/pl190.c > @@ -133,7 +133,7 @@ static uint64_t pl190_read(void *opaque, > target_phys_addr_t offset, > s->priority = i; > pl190_update(s); > } > - return s->vect_addr[s->priority]; > + return s->vect_addr[s->priority - 1]; > case 13: /* DEFVECTADDR */ > return s->vect_addr[16]; > default:
This doesn't look right -- if s->priority is zero then we'll read off the beginning of the array. What's the actual bug you're trying to fix here? -- PMM
