On 27 July 2012 03:50, Meador Inge <mead...@codesourcery.com> wrote:
> Roll the code used to initialize the guest memory space when -R
> or -B is used into 'init_guest_space' and then call 'init_guest_space'
> from the driver. This way the reserved guest memory space can
> be probed for. Calling 'mmap' just once as is currently done is not
> guaranteed to succeed since the host address space validation might fail.
>
> Signed-off-by: Meador Inge <mead...@codesourcery.com>
> ---
> + /* If the commpage lies within the already allocated guest space,
> + * then there is no way we can allocate it.
> + */
> + if (test_page_addr >= guest_base
> + && test_page_addr <= (guest_base + guest_size)) {
> + return -1;
> + }
The indent here is busted (hardcoded tabs), as checkpatch.pl will
tell you. Otherwise
Reviewed-by: Peter Maydell <peter.mayd...@linaro.org>
I'm currently putting together a linux-user pullreq (with Riku's
agreement since he's currently a bit busy), so I'll just fix this
as I put this patch in, though.
-- PMM
