Re: [Qemu-devel] [PATCH 1/2] m48t59: drop obsolete address base arithmetic

2012-01-07 Thread Blue Swirl
On Thu, Jan 5, 2012 at 17:45, Andreas Färber wrote: > Am 15.10.2011 15:50, schrieb Blue Swirl: >> Remove now incorrect address base arithmetic, missed by >> 9936d6e42392f1440505dfa9df065eabd251cadf. Fixes Sparc64 boot. > > ...but breaks PReP boot: > > ERROR: BUG

Re: [Qemu-devel] [PATCH] Rename target_phys_addr_t to Phys

2012-01-07 Thread Blue Swirl
On Wed, Jan 4, 2012 at 22:09, Anthony Liguori wrote: > On 01/04/2012 01:50 PM, Peter Maydell wrote: >> >> On 4 January 2012 19:32, Avi Kivity  wrote: >>> >>> The name 'Phys' conveys exactly the same information as >>> 'target_phys_addr_t': >>> >>>  - it has to be a physical address (no such thing

Re: [Qemu-devel] [PATCH] sparc-linux-user: Fix missing symbols in .rel/.rela.plt sections

2012-01-07 Thread Blue Swirl
et undefined references to these when > linking statically to a multiarch enabled libc (using STT_GNU_IFUNC). > > Blue Swirl > Signed-off-by: Aurelien Jarno > --- >  sparc.ld |   16 ++-- >  1 files changed, 14 insertions(+), 2 deletions(-) > > diff --gi

Re: [Qemu-devel] Restarting my activity on QEMU

2012-01-07 Thread Blue Swirl
On Sat, Jan 7, 2012 at 19:43, Aurelien Jarno wrote: > Hi all, > > Just a few words to tell I totally disappeared from QEMU last summer due > to a burn-out. After successfully contributing back to some other > projects, I am going to slowly restart my activity on QEMU. I will try > to process the p

[Qemu-devel] [PATCH 0/6] AREG0 patches v4

2012-01-07 Thread Blue Swirl
In this version, I made basic AREG0 free load/store implementations for all targets. Only x86-64 is tested, others have probably problems, especially 64 bit guest (Sparc64 in this case) on 32 bit hosts. I think this should be committed as a starting point if there are no major objections. Blue

[Qemu-devel] [PATCH 1/6] TCG/i386: use iargs or oargs instead of register names

2012-01-07 Thread Blue Swirl
Don't use register names directly but iargs or oargs tables. Later it will be easier to shift the registers used. Signed-off-by: Blue Swirl --- tcg/i386/tcg-target.c | 75 +--- 1 files changed, 45 insertions(+), 30 deletions(-) diff --git

[Qemu-devel] [PATCH 2/6] TCG/sparc: use iargs or oargs instead of register names etc

2012-01-07 Thread Blue Swirl
Don't use register names (or temporary registers) for call arguments and return values directly but iargs or oargs tables. Later it will be easier to shift the registers used. Signed-off-by: Blue Swirl --- tcg/sparc/tcg-target.c | 44 ++-- 1

[Qemu-devel] [PATCH 3/6] TCG: add 5 arg helpers to def-helper.h

2012-01-07 Thread Blue Swirl
Signed-off-by: Blue Swirl --- def-helper.h | 26 ++ 1 files changed, 26 insertions(+), 0 deletions(-) diff --git a/def-helper.h b/def-helper.h index 8a822c7..a13310e 100644 --- a/def-helper.h +++ b/def-helper.h @@ -118,6 +118,8 @@ DEF_HELPER_FLAGS_3(name, 0, ret

[Qemu-devel] [PATCH 6/6] Sparc: avoid AREG0 wrappers for memory access helpers

2012-01-07 Thread Blue Swirl
Adjust generation of load and store templates so that the functions take a parameter for CPUState instead of relying on global env. Remove wrappers. Move remaining memory helpers to ldst_helper.c. Signed-off-by: Blue Swirl --- Makefile.target| 12 ++- configure

Re: [Qemu-devel] [PATCH 1/2] m48t59: drop obsolete address base arithmetic

2012-01-08 Thread Blue Swirl
On Sun, Jan 8, 2012 at 02:48, Andreas Färber wrote: > Am 07.01.2012 18:29, schrieb Blue Swirl: >> On Thu, Jan 5, 2012 at 17:45, Andreas Färber wrote: >>> Am 15.10.2011 15:50, schrieb Blue Swirl: >>>> Remove now incorrect addr

Re: [Qemu-devel] [PATCH 0/6] AREG0 patches v4

2012-01-08 Thread Blue Swirl
On Sun, Jan 8, 2012 at 00:52, Aurelien Jarno wrote: > On Sat, Jan 07, 2012 at 10:24:09PM +0000, Blue Swirl wrote: >> In this version, I made basic AREG0 free load/store implementations >> for all targets. Only x86-64 is tested, others have probably problems, >> especially 64

[Qemu-devel] [PATCH v4 0/4] VGA patches

2012-01-08 Thread Blue Swirl
I'm holding the patch for checking dirty range. Perhaps the original non-iterative version was better approach, the callers need less changes. Then 6/6 which lets Cirrus VGA compile only once is also held. These should be ready for committing. Blue Swirl (4): vga: improve VGA logic m

[Qemu-devel] [PATCH 1/4] vga: improve VGA logic

2012-01-08 Thread Blue Swirl
Improve VGA selection logic, push check for device availabilty to vl.c. Create the devices at board level unconditionally. Remove now unused pci_try_create*() functions. Make PCI VGA devices optional. Signed-off-by: Blue Swirl --- hw/alpha_pci.c |6 +--- hw/boards.h |1 - hw

[Qemu-devel] [PATCH 2/4] memory: change dirty setting APIs to take a size

2012-01-08 Thread Blue Swirl
Instead of each target knowing or guessing the guest page size, just pass the desired size of dirtied memory area. This should also improve performance due to memset() optimizations. Signed-off-by: Blue Swirl --- arch_init.c |2 +- exec-obsolete.h | 14 ++ hw/cirrus_vga.c

[Qemu-devel] [PATCH 3/4] vga: make Cirrus ISA device optional

2012-01-08 Thread Blue Swirl
Signed-off-by: Blue Swirl --- Makefile.target | 13 +++--- default-configs/alpha-softmmu.mak|2 + default-configs/arm-softmmu.mak |1 + default-configs/i386-softmmu.mak |2 + default-configs/mips-softmmu.mak |2 + default-configs/mips64

[Qemu-devel] [PATCH 4/4] sga: fix copypasta

2012-01-08 Thread Blue Swirl
Signed-off-by: Blue Swirl --- hw/sga.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/sga.c b/hw/sga.c index 7ef750a..ea11937 100644 --- a/hw/sga.c +++ b/hw/sga.c @@ -35,7 +35,7 @@ typedef struct ISAGAState { ISADevice dev; } ISASGAState; -static int

Re: [Qemu-devel] [PATCH 3/4] vga: make Cirrus ISA device optional

2012-01-21 Thread Blue Swirl
On Fri, Jan 13, 2012 at 22:16, Andreas Färber wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > Am 13.01.2012 21:09, schrieb Jan Kiszka: >> This actually also converts it to a proper ISADevice - a value of >> its own. > > Could this by any chance help with eliminating the global > isa_m

Re: [Qemu-devel] [PULL 00/26] ppc patch queue 2012-01-21

2012-01-21 Thread Blue Swirl
On Sat, Jan 21, 2012 at 04:18, Alexander Graf wrote: > Hi Anthony / Aurelien / Blue, > > This is my current patch queue for ppc. Please pull. Thanks, pulled. > Alex > > > The following changes since commit 515689235c4c3d9c3f0406ddcdd21ed8da77062b: >  Anthony Liguori (1): >        Merge remote-tr

Re: [Qemu-devel] [PATCH v2 07/10] block: add a transfer rate for floppy types

2012-01-21 Thread Blue Swirl
On Mon, Jan 16, 2012 at 10:18, Kevin Wolf wrote: > Am 15.01.2012 08:51, schrieb Hervé Poussineau: >> Floppies must be read at a specific transfer rate, depending of its own >> format. >> Update floppy description table to include required transfer rate. >> >> Signed-off-by: Hervé Poussineau >> -

Re: [Qemu-devel] [PATCH 0/6] AREG0 patches v4

2012-01-21 Thread Blue Swirl
On Mon, Jan 9, 2012 at 23:04, Aurelien Jarno wrote: > On Sun, Jan 08, 2012 at 12:27:39PM +0000, Blue Swirl wrote: >> On Sun, Jan 8, 2012 at 00:52, Aurelien Jarno wrote: >> > On Sat, Jan 07, 2012 at 10:24:09PM +, Blue Swirl wrote: >> >> In this version, I ma

Re: [Qemu-devel] [PATCH 02/14] target-sparc: Fix mixup of uint64 and uint64_t

2012-01-21 Thread Blue Swirl
rd Henderson > Cc: Blue Swirl Good catch, Reviewed-by: Blue Swirl > --- >  target-sparc/vis_helper.c |    2 +- >  1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/target-sparc/vis_helper.c b/target-sparc/vis_helper.c > index a992c29..9d2edb0 100644 > ---

Re: [Qemu-devel] [PATCH 8/8] PPC: booke206: Implement tlbilx

2012-01-21 Thread Blue Swirl
On Sat, Jan 21, 2012 at 04:15, Alexander Graf wrote: > The PowerPC 2.06 BookE ISA defines an opcode called "tlbilx" which is used > to flush TLB entries. It's the recommended way of flushing in virtualized > environments. > > So far we got away without implementing it, but Linux for e500mc uses th

Re: [Qemu-devel] [PATCH] sparc-linux-user: Fix missing symbols in .rel/.rela.plt sections

2012-01-21 Thread Blue Swirl
On Tue, Jan 10, 2012 at 17:38, Aurelien Jarno wrote: > On Sat, Jan 07, 2012 at 10:01:09PM +0100, Aurelien Jarno wrote: >> On Sat, Jan 07, 2012 at 08:36:12PM +0000, Blue Swirl wrote: >> > On Sat, Jan 7, 2012 at 20:16, Aurelien Jarno wrote: >> > > Fix .rel.plt sect

Re: [Qemu-devel] [PATCH 2/4] memory: change dirty setting APIs to take a size

2012-01-21 Thread Blue Swirl
On Mon, Jan 9, 2012 at 12:11, Avi Kivity wrote: > On 01/08/2012 11:10 PM, Blue Swirl wrote: >> Instead of each target knowing or guessing the guest page size, >> just pass the desired size of dirtied memory area. This should also >> improve performance due to memset() opti

Re: [Qemu-devel] [PATCH 02/14] target-sparc: Fix mixup of uint64 and uint64_t

2012-01-22 Thread Blue Swirl
On Sun, Jan 22, 2012 at 02:03, Andreas Färber wrote: > Am 21.01.2012 19:51, schrieb Blue Swirl: >> On Mon, Jan 16, 2012 at 00:46, Andreas Färber wrote: >>> Commit 793a137a41ad4125011c7022cf16a1baa40a5ab6 (target-sparc: >>> Implement BMASK/BSHUFFLE.) introduced a stra

Re: [Qemu-devel] [PATCH 02/14] target-sparc: Fix mixup of uint64 and uint64_t

2012-01-22 Thread Blue Swirl
On Mon, Jan 16, 2012 at 00:46, Andreas Färber wrote: > Commit 793a137a41ad4125011c7022cf16a1baa40a5ab6 (target-sparc: > Implement BMASK/BSHUFFLE.) introduced a stray usage of softfloat uint64 > type. > > Use uint64_t instead. > > Signed-off-by: Andreas Färber > Cc: Richa

[Qemu-devel] [PATCH v5 0/3] VGA patches

2012-01-22 Thread Blue Swirl
Let's compile Cirrus in hwlib. http://repo.or.cz/r/qemu/blueswirl.git Blue Swirl (3): memory: fix dirty mask function length handling memory: change dirty setting APIs to take a size vga: compile cirrus_vga in hwlib Makefile.objs |1 + Makefile.target |1 - arch_i

[Qemu-devel] [PATCH 1/3] memory: fix dirty mask function length handling

2012-01-22 Thread Blue Swirl
Fix handling of cases like start = 0xfff, length = 2. Change length to ram_addr_t to handle larger lengths. Signed-off-by: Blue Swirl --- exec-obsolete.h | 11 ++- 1 files changed, 6 insertions(+), 5 deletions(-) diff --git a/exec-obsolete.h b/exec-obsolete.h index c412be9..22e0ba5

[Qemu-devel] [PATCH 2/3] memory: change dirty setting APIs to take a size

2012-01-22 Thread Blue Swirl
Instead of each target knowing or guessing the guest page size, just pass the desired size of dirtied memory area. Signed-off-by: Blue Swirl --- arch_init.c |2 +- exec-obsolete.h | 16 hw/cirrus_vga.c | 16 ++-- hw/g364fb.c | 11 +++ hw

[Qemu-devel] [PATCH 3/3] vga: compile cirrus_vga in hwlib

2012-01-22 Thread Blue Swirl
Remove target dependencies and compile Cirrus VGA in hwlib. Address masking can be removed since memory API handles that now. Signed-off-by: Blue Swirl --- Makefile.objs |1 + Makefile.target |1 - hw/cirrus_vga.c |3 --- 3 files changed, 1 insertions(+), 4 deletions(-) diff

Re: [Qemu-devel] [PATCH 2/3] memory: change dirty setting APIs to take a size

2012-01-22 Thread Blue Swirl
On Sun, Jan 22, 2012 at 13:07, Blue Swirl wrote: > Instead of each target knowing or guessing the guest page size, > just pass the desired size of dirtied memory area. > > Signed-off-by: Blue Swirl > --- >  arch_init.c     |    2 +- >  exec-obsolete.h |   16 ++

Re: [Qemu-devel] We need more reviewers/maintainers!!

2012-03-14 Thread Blue Swirl
On Tue, Mar 13, 2012 at 01:01, Andreas Färber wrote: > Am 13.03.2012 01:16, schrieb Anthony Liguori: >> On 03/12/2012 06:32 PM, Andreas Färber wrote: >>> Take Blue's recent target-ppc fix >>> 9d4df9c02866f39d3eef105033091f367cc7c29e for example: After applying >>> patches on day one of FOSDEM he p

Re: [Qemu-devel] We need more reviewers/maintainers!!

2012-03-14 Thread Blue Swirl
On Tue, Mar 13, 2012 at 13:40, Avi Kivity wrote: > On 03/12/2012 10:27 PM, Anthony Liguori wrote: >>> I agree that more maintainers would be good, but we also need >>> more people with commit rights. >> >> I disagree strongly.  Having multiple pushers makes things difficult >> and encourages peopl

Re: [Qemu-devel] We need more reviewers/maintainers!!

2012-03-14 Thread Blue Swirl
On Tue, Mar 13, 2012 at 14:41, Anthony Liguori wrote: > On 03/13/2012 09:38 AM, Avi Kivity wrote: >> >> On 03/13/2012 04:00 PM, Anthony Liguori wrote: >>> >>> On 03/13/2012 08:40 AM, Avi Kivity wrote: On 03/12/2012 10:27 PM, Anthony Liguori wrote: >> >> I agree that more maintain

Re: [Qemu-devel] [PATCH 0/7] QOM'ify UniCore32 CPU

2012-03-14 Thread Blue Swirl
On Wed, Mar 14, 2012 at 01:39, Andreas Färber wrote: > Hello, > > Based on qom-cpu v4 and object_class_get_list() v2, this series converts > the UniCore32 CPU to QOM. Code-wise, target-unicore32 is pretty close to > target-arm and faces a similar issue of CPU-dependent init code, so let's > tackle

Re: [Qemu-devel] [PATCH 2/7] target-unicore32: Relicense to GPLv2+

2012-03-14 Thread Blue Swirl
ff-by: Stefan Weil > Signed-off-by: Blue Swirl Ack. > Signed-off-by: Dor Laor > --- >  target-unicore32/cpu.h       |    5 ++--- >  target-unicore32/helper.h    |    5 ++--- >  target-unicore32/op_helper.c |    5 ++--- >  target-unicore32/translate.c |    5 ++--- >  4 fi

Re: [Qemu-devel] [PATCH] vga: disable default VGA if appropriate -device is used

2012-03-15 Thread Blue Swirl
; option, independent of the order. > Since commit c5bd4f3 QEMU -nodefaults will override a previous -vga > option. > > I did not reintroduce machine->no_vga.  Boards can simply ignore the > vga_interface_type variable, and most will indeed do so. > > Cc: Blue Swirl I have

Re: [Qemu-devel] [PATCH 3/3] build: check if libm is needed in configure

2012-03-17 Thread Blue Swirl
On Wed, Feb 22, 2012 at 04:55, Roger Pau Monne wrote: > Remove the hardcoded use of libm and instead rely on configure to > check for it. It is needed at least for qemu-ga and qemu-system. This would break linux-user build, linker can't find 'sin' etc. > > Signed-off-by: Roger Pau Monne > --- >

Re: [Qemu-devel] [PATCH 1/1] Fix large memory chunks allocation with tcg_malloc.

2012-03-17 Thread Blue Swirl
Thanks, applied. On Fri, Mar 2, 2012 at 09:22, Kirill Batuzov wrote: > An attempt to allocate a large memory chunk after a small one resulted in > circular links in list of pools.  It caused the same memory being > allocated twice for different arrays. > > Now pools for large memory chunks are ke

Re: [Qemu-devel] [PATCH] Fix build on FreeBSD

2012-03-17 Thread Blue Swirl
On Sat, Mar 3, 2012 at 16:34, Nathan Whitehorn wrote: > Fix a missing header required to build on recent FreeBSD. > > Signed-off-by: Nathan Whitehorn > --- >  os-posix.c |    4 >  1 files changed, 4 insertions(+), 0 deletions(-) > > diff --git a/os-posix.c b/os-posix.c > index dbf3b24..83b14

Re: [Qemu-devel] [RESEND PATCH] vmstate: fix varrays with uint32_t indexes

2012-03-17 Thread Blue Swirl
Thanks, applied. On Tue, Mar 13, 2012 at 06:05, Amos Kong wrote: > VMSTATE_VARRAY_UINT32() is used in hw/ds1225y.c, and we checked > VMS_VARRAY_UINT32 bit of field->flags in vmstate_load_state(), > but we don't check this bit in vmstate_save_state(). > > Signed-off-by: Amos Kong > --- >  savevm.

Re: [Qemu-devel] [PULL 00/16] ppc patch queue 2012-03-15

2012-03-17 Thread Blue Swirl
On Thu, Mar 15, 2012 at 12:14, Alexander Graf wrote: > Hi Blue / Aurelien, > > This is my current patch queue for ppc. Please pull. Thanks, pulled. > Alex > > > The following changes since commit ae7d54d489540b49b7c13a7df7ddc220588a2ced: >  Andreas Färber (1): >        target-lm32/microblaze: Dr

Re: [Qemu-devel] [PULL] Malta patches

2012-03-17 Thread Blue Swirl
On Thu, Mar 15, 2012 at 20:16, Stefan Weil wrote: > Am 25.02.2012 15:43, schrieb Stefan Weil: >> >> Hi Aurelien, >> >> could you please pull some Malta patches which I had sent in January? >> >> http://patchwork.ozlabs.org/patch/138394/ >> http://patchwork.ozlabs.org/patch/138392/ >> http://patchw

Re: [Qemu-devel] [PULL 0/4] arm-devs queue

2012-03-17 Thread Blue Swirl
On Fri, Mar 16, 2012 at 18:12, Peter Maydell wrote: > Hi; this is a pullreq for the arm-devs queue; nothing hugely exciting > here unless you count the final part of the -dtb support. Please pull. Thanks, pulled. > thanks > -- PMM > > The following changes since commit 7c51c1aa03a52b9fd75ed1ade2

Re: [Qemu-devel] [PULL 0/3] target-arm queue

2012-03-17 Thread Blue Swirl
On Fri, Mar 16, 2012 at 18:21, Peter Maydell wrote: > Hi; this is a pullreq for my target-arm queue. Just three fairly > minor bug fixes this time. Please pull. Thanks, pulled. > Thanks > -- PMM > > The following changes since commit ae7d54d489540b49b7c13a7df7ddc220588a2ced: > >  target-lm32/mic

Re: [Qemu-devel] [PATCH] softfloat: fix for C99

2012-03-17 Thread Blue Swirl
Thanks, applied. On Tue, Dec 27, 2011 at 15:11, Avi Kivity wrote: > C99 appears to consider compound literals as non-constants, and complains > when they are used in static initializers.  Switch to ordinary initializer > syntax. > > Signed-off-by: Avi Kivity > --- >  fpu/softfloat-specialize.h |

Re: [Qemu-devel] [PATCH] w64: Fix data type of next_tb and tcg_qemu_tb_exec

2012-03-17 Thread Blue Swirl
Thanks, applied. On Fri, Mar 16, 2012 at 22:50, Stefan Weil wrote: > next_tb is the numeric value of a tcg target (= QEMU host) address. > > Using tcg_target_ulong instead of unsigned long shows this and makes > the code portable for hosts with an unusual size of long (w64). > > The type cast '(l

Re: [Qemu-devel] SPARC64: immediate segfault on startup with git mastervery

2012-03-18 Thread Blue Swirl
On Sun, Mar 18, 2012 at 09:44, Avi Kivity wrote: > On 03/18/2012 04:01 AM, Mark Cave-Ayland wrote: >> Hi Avi/Blue, >> >> I've just updated to git master and found that SPARC64 is broken >> again; a git bisect shows the following commit causes this: >> >> >> commit f3705d53296d78b14f5823472ae2add16

Re: [Qemu-devel] SPARC64: immediate segfault on startup with git mastervery

2012-03-18 Thread Blue Swirl
On Sun, Mar 18, 2012 at 09:44, Avi Kivity wrote: > On 03/18/2012 04:01 AM, Mark Cave-Ayland wrote: >> Hi Avi/Blue, >> >> I've just updated to git master and found that SPARC64 is broken >> again; a git bisect shows the following commit causes this: >> >> >> commit f3705d53296d78b14f5823472ae2add16

Re: [Qemu-devel] SPARC64: immediate segfault on startup with git mastervery

2012-03-18 Thread Blue Swirl
On Sun, Mar 18, 2012 at 10:31, Avi Kivity wrote: > On 03/18/2012 11:51 AM, Blue Swirl wrote: >> On Sun, Mar 18, 2012 at 09:44, Avi Kivity wrote: >> > On 03/18/2012 04:01 AM, Mark Cave-Ayland wrote: >> >> Hi Avi/Blue, >> >> >> >> I've

Re: [Qemu-devel] SPARC64: immediate segfault on startup with git mastervery

2012-03-18 Thread Blue Swirl
On Sun, Mar 18, 2012 at 11:03, Mark Cave-Ayland wrote: > On 18/03/12 10:51, Blue Swirl wrote: > >>>> (except Sparc32, Sparc64 >>>> and PPC displays are still not refreshed correctly). >>> >>> >>> Details about this please. >> >&

[Qemu-devel] [PATCH] sparc: pass page aligned addresses to tlb_set_page

2012-03-18 Thread Blue Swirl
Mask incoming page address early so that resolved addresses are page aligned. Remove further address masking. Signed-off-by: Blue Swirl --- target-sparc/mmu_helper.c | 19 --- 1 files changed, 8 insertions(+), 11 deletions(-) diff --git a/target-sparc/mmu_helper.c b/target

[Qemu-devel] [PATCH 1/2] ioport: use INT64_MAX for IO ranges

2012-03-18 Thread Blue Swirl
Expression UINT64_MAX + 1 will make the range bigger than what can be represented with a 64 bit type. This would trigger an assert in int128_get64() after the next patch. Signed-off-by: Blue Swirl --- ioport.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/ioport.c b

[Qemu-devel] [PATCH v2 2/2] memory: print aliased IO ranges in info mtree

2012-03-18 Thread Blue Swirl
Print also I/O ports behind bridges and other aliases. Signed-off-by: Blue Swirl --- memory.c | 14 +++--- 1 files changed, 7 insertions(+), 7 deletions(-) diff --git a/memory.c b/memory.c index 22b0352..a3f5b59 100644 --- a/memory.c +++ b/memory.c @@ -1621,6 +1621,13 @@ void

Re: [Qemu-devel] SPARC64: immediate segfault on startup with git mastervery

2012-03-18 Thread Blue Swirl
On Sun, Mar 18, 2012 at 12:08, Avi Kivity wrote: > On 03/18/2012 12:51 PM, Blue Swirl wrote: >> > >> > IMO, my patch is better.  tlb_set_page() should not deal with offsets >> > within a page. >> >> It looks like all targets except Sparc32/64 mask the a

Re: [Qemu-devel] SPARC64: immediate segfault on startup with git mastervery

2012-03-18 Thread Blue Swirl
On Sun, Mar 18, 2012 at 12:13, Avi Kivity wrote: > On 03/18/2012 02:10 PM, Blue Swirl wrote: >> On Sun, Mar 18, 2012 at 12:08, Avi Kivity wrote: >> > On 03/18/2012 12:51 PM, Blue Swirl wrote: >> >> > >> >> > IMO, my patch is better.  tlb_set_page

Re: [Qemu-devel] [PATCH 0/5] AREG0 patches v6

2012-03-18 Thread Blue Swirl
On Sun, Mar 11, 2012 at 22:23, Blue Swirl wrote: > In this version I rebased the series on REGPARM removal, without > splitting i386 and x86_64. > > I've also made some simple performance tests on i386. It looks like > REGPARM removal accounts for 2.5% performance loss and t

[Qemu-devel] [PATCH 0/6] ARM: AREG0 conversion

2012-03-19 Thread Blue Swirl
Convert ARM to AREG0 free operation. Survives simple tests. URL git://repo.or.cz/qemu/blueswirl.git http://repo.or.cz/r/qemu/blueswirl.git Blue Swirl (6): arm: move neon_tbl to neon_helper.c arm: move saturating arithmetic to helper.c arm: move other arithmetic to helper.c

[Qemu-devel] [PATCH 1/6] arm: move neon_tbl to neon_helper.c

2012-03-19 Thread Blue Swirl
Add an explicit CPUARMState parameter instead of relying on AREG0 and move neon_tbl to neon_helper.c. Signed-off-by: Blue Swirl --- target-arm/helper.h |2 +- target-arm/neon_helper.c | 22 ++ target-arm/op_helper.c | 22 -- target-arm

[Qemu-devel] [PATCH 2/6] arm: move saturating arithmetic to helper.c

2012-03-19 Thread Blue Swirl
Add an explicit CPUARMState parameter instead of relying on AREG0 and move saturating arithmetic to helper.c. Signed-off-by: Blue Swirl --- target-arm/helper.c| 133 +++ target-arm/helper.h| 20 target-arm/op_helper.c | 134

[Qemu-devel] [PATCH 4/6] arm: move cpsr and banked register access to helper.c

2012-03-19 Thread Blue Swirl
Add an explicit CPUARMState parameter instead of relying on AREG0 and move cpsr and banked register access to helper.c. Signed-off-by: Blue Swirl --- target-arm/helper.c| 42 ++ target-arm/helper.h|8 target-arm/op_helper.c | 42

[Qemu-devel] [PATCH 5/6] arm: move exception and wfi helpers to helper.c

2012-03-19 Thread Blue Swirl
Add an explicit CPUARMState parameter instead of relying on AREG0 and move exception and wfi helpers to helper.c. Merge raise_exception() and helper_exception(). Signed-off-by: Blue Swirl --- target-arm/helper.c| 13 + target-arm/helper.h|4 ++-- target-arm/op_helper.c

[Qemu-devel] [PATCH 3/6] arm: move other arithmetic to helper.c

2012-03-19 Thread Blue Swirl
Add an explicit CPUARMState parameter instead of relying on AREG0 and move rest of the arithmetic to helper.c. Signed-off-by: Blue Swirl --- target-arm/helper.c| 146 target-arm/helper.h| 24 target-arm/op_helper.c | 140

[Qemu-devel] [PATCH 6/6] arm: move load and store helpers, switch to AREG0 free mode

2012-03-19 Thread Blue Swirl
Add an explicit CPUARMState parameter instead of relying on AREG0 and move load and store helpers to helper.c. Remove AREG0 swapping in tlb_fill(). Remove now empty op_helper.c. Switch to AREG0 free mode. Use cpu_ld{l,uw}_code in translation and interrupt handling. Signed-off-by: Blue Swirl

Re: [Qemu-devel] [PATCH 16/36] vmstate: port sparc cpu

2012-03-24 Thread Blue Swirl
On Wed, Mar 21, 2012 at 22:46, Michael Roth wrote: > On Mon, Mar 19, 2012 at 11:57:44PM +0100, Juan Quintela wrote: >> Signed-off-by: Juan Quintela >> --- >>  hw/sun4u.c             |   20 -- >>  target-sparc/cpu.h     |    9 +- >>  target-sparc/machine.c |  474 >> --

Re: [Qemu-devel] [PATCH 0/9] Alpha updates

2012-03-24 Thread Blue Swirl
On Fri, Mar 23, 2012 at 15:22, Richard Henderson wrote: > Patch 1 has been seen before but not picked up. > > Patches 2-8 convert the target away from areg0. Cool. Could you fix style issues while moving code around? I used a three phase patching approach in Sparc: 1) fix style 2) split and move

Re: [Qemu-devel] [PATCH 6/6] arm: move load and store helpers, switch to AREG0 free mode

2012-03-24 Thread Blue Swirl
On Fri, Mar 23, 2012 at 15:25, Richard Henderson wrote: > On 03/19/12 14:57, Blue Swirl wrote: >> Add an explicit CPUARMState parameter instead of relying on AREG0 >> and move load and store helpers to helper.c. Remove AREG0 swapping in >> tlb_fill(). Remove now empty op_help

Re: [Qemu-devel] [PATCH v2] Basic Illumos support

2012-03-24 Thread Blue Swirl
On Sat, Mar 17, 2012 at 08:04, Lee Essen wrote: > (third email attempt, apologies if you get duplicates) The patch does not apply: git am: Applying: Basic Illumos support fatal: corrupt patch at line 19 Patch failed at 0001 Basic Illumos support patch: patching file configure patch: malform

Re: [Qemu-devel] [RFC 11/12] target-sparc: QOM'ify CPU

2012-03-24 Thread Blue Swirl
On Fri, Mar 23, 2012 at 17:27, Andreas Färber wrote: > Am 14.03.2012 21:16, schrieb Blue Swirl: >> On Wed, Mar 14, 2012 at 17:53, Andreas Färber wrote: >>> diff --git a/target-sparc/cpu-qom.h b/target-sparc/cpu-qom.h >>> new file mode 100644 >>> index 000.

Re: [Qemu-devel] [PATCH 1/2] w64: Fix data type of tb_next and other variables used for host addresses

2012-03-24 Thread Blue Swirl
On Mon, Mar 19, 2012 at 21:12, Stefan Weil wrote: > QEMU host addresses must use uintptr_t to be portable for hosts with > an unusual size of long (w64). > > tb_jmp_offset is an uint16_t value, therefore the local variable offset > in function tb_set_jmp_target was changed from unsigned long to ui

Re: [Qemu-devel] [PATCH] scripts: add gdb support script

2012-03-24 Thread Blue Swirl
Thanks, applied. On Sun, Mar 18, 2012 at 14:48, Avi Kivity wrote: > Add a script that enhances gdb to be aware of QEMU data structures. > > This patch adds a single gdb command, 'qemu mtree'.  The command is > similar to the monitor's 'info mtree', except that it prints MemoryRegion > addresses,

Re: [Qemu-devel] [PATCH] fix screendump

2012-03-24 Thread Blue Swirl
Thanks, applied. On Thu, Mar 1, 2012 at 07:34, Gerd Hoffmann wrote: > Commit 45efb16124efef51de5157afc31984b5a47700f9 optimized a bit too > much.  We can skip the vga_invalidate_display() in case no console > switch happened because we don't need a full redraw then.  We can *not* > skip vga_hw_up

Re: [Qemu-devel] [PATCH] tcg: Use the GDB JIT debugging interface.

2012-03-24 Thread Blue Swirl
Thanks, applied. On Mon, Mar 19, 2012 at 19:25, Richard Henderson wrote: > This allows us to generate unwind info for the dynamicly generated > code in the code_gen_buffer.  Only i386 is converted at this point. > > Signed-off-by: Richard Henderson > --- >  elf.h                 |    1 + >  exec

Re: [Qemu-devel] [PATCH] Support utf8 chars in pod docs

2012-03-24 Thread Blue Swirl
Thanks, applied. On Mon, Mar 19, 2012 at 22:25, Michael Tokarev wrote: > We've at least one UTF8 char in the qemu texi doc: > >  $ grep Tibor qemu-doc.texi >  by Tibor "TS" Schütz. >  $ man ./qemu.1 | grep Tibor >        by Tibor "TS" SchA~Xtz. > > This patch allows utf8 in man/pod docs. > > Init

Re: [Qemu-devel] [PATCH] gdbserver: Don't send a GDB syscall until the system CPU is stopped

2012-03-24 Thread Blue Swirl
Thanks, applied. On Thu, Mar 15, 2012 at 17:49, Peter Maydell wrote: > From: Meador Inge > > Fix an issue where the GDB server implementation was sending GDB syscall > requests while the system CPU was still running.  Syscall requests must > be sent while the CPU is stopped otherwise replies fro

Re: [Qemu-devel] [PATCH v2 00/10] Alpha updates

2012-03-24 Thread Blue Swirl
Thanks, applied all. On Sat, Mar 24, 2012 at 16:51, Richard Henderson wrote: > Changes v1->v2: >  * Formatting fixed during the move to new files.  It might have been >    cleaner to fix it before the move, but it was easier to run the >    existing patches through checkpatch.pl. > >  * Add noret

Re: [Qemu-devel] [PATCH 0/4] GDB Jit interface, v4

2012-03-24 Thread Blue Swirl
On Sat, Mar 24, 2012 at 17:47, Richard Henderson wrote: > Blue applied v2, not v3. Sorry! >  This rebases against master, and also > adds support in the sparc and hppa backends. > > I've tested sparc32.  I've not been able to try the sparc64 version; > I'm having trouble getting glib2 compiled f

[Qemu-devel] [PATCH v2 0/6] ARM: AREG0 conversion

2012-03-24 Thread Blue Swirl
v2: fix patch 1, tweak patch 2 and rebase to master. URL git://repo.or.cz/qemu/blueswirl.git http://repo.or.cz/r/qemu/blueswirl.git Blue Swirl (6): arm: move neon_tbl to neon_helper.c arm: move saturating arithmetic to helper.c arm: move other arithmetic to helper.c arm: move

[Qemu-devel] [PATCH 1/6] arm: move neon_tbl to neon_helper.c

2012-03-24 Thread Blue Swirl
Add an explicit CPUARMState parameter instead of relying on AREG0 and move neon_tbl to neon_helper.c. Signed-off-by: Blue Swirl --- target-arm/helper.h |2 +- target-arm/neon_helper.c | 22 ++ target-arm/op_helper.c | 22 -- target-arm

[Qemu-devel] [PATCH 2/6] arm: move saturating arithmetic to helper.c

2012-03-24 Thread Blue Swirl
Add an explicit CPUARMState parameter instead of relying on AREG0 and move saturating arithmetic to helper.c. Remove unused SIGNBIT64. Signed-off-by: Blue Swirl --- target-arm/helper.c| 132 +++ target-arm/helper.h| 20 target-arm

[Qemu-devel] [PATCH 3/6] arm: move other arithmetic to helper.c

2012-03-24 Thread Blue Swirl
Add an explicit CPUARMState parameter instead of relying on AREG0 and move rest of the arithmetic to helper.c. Reviewed-by: Richard Henderson Signed-off-by: Blue Swirl --- target-arm/helper.c| 146 target-arm/helper.h| 24

[Qemu-devel] [PATCH 4/6] arm: move cpsr and banked register access to helper.c

2012-03-24 Thread Blue Swirl
Add an explicit CPUARMState parameter instead of relying on AREG0 and move cpsr and banked register access to helper.c. Reviewed-by: Richard Henderson Signed-off-by: Blue Swirl --- target-arm/helper.c| 42 ++ target-arm/helper.h|8

[Qemu-devel] [PATCH 5/6] arm: move exception and wfi helpers to helper.c

2012-03-24 Thread Blue Swirl
Add an explicit CPUARMState parameter instead of relying on AREG0 and move exception and wfi helpers to helper.c. Merge raise_exception() and helper_exception(). Reviewed-by: Richard Henderson Signed-off-by: Blue Swirl --- target-arm/helper.c| 13 + target-arm/helper.h

[Qemu-devel] [PATCH 6/6] arm: move load and store helpers, switch to AREG0 free mode

2012-03-24 Thread Blue Swirl
Signed-off-by: Blue Swirl --- Makefile.target|6 +--- configure |2 +- target-arm/helper.c| 54 +--- target-arm/op_helper.c | 71 target-arm/translate.c |6 ++-- 5 files

Re: [Qemu-devel] [PATCH 0/4] GDB Jit interface, v4

2012-03-24 Thread Blue Swirl
Thanks, applied all. On Sat, Mar 24, 2012 at 19:23, Richard Henderson wrote: > On 03/24/2012 11:41 AM, Blue Swirl wrote: >> Patches 2 to 4 lack the SoB. I can add them by hand if that's OK? > > Oops.  Yes please. > > > r~

Re: [Qemu-devel] [PATCH 08/15] Avoid declaring the env variable at all if CONFIG_TCG_PASS_AREG0.

2012-03-26 Thread Blue Swirl
On Sun, Mar 25, 2012 at 22:27, Richard Henderson wrote: > > Signed-off-by: Richard Henderson > --- >  dyngen-exec.h |    5 + >  user-exec.c   |   17 ++--- >  2 files changed, 19 insertions(+), 3 deletions(-) > > diff --git a/dyngen-exec.h b/dyngen-exec.h > index cfeef99..65fcb43 1

Re: [Qemu-devel] [PATCH 09/15] tcg-sparc: Do not use a global register for AREG0.

2012-03-26 Thread Blue Swirl
On Sun, Mar 25, 2012 at 22:27, Richard Henderson wrote: > > Signed-off-by: Richard Henderson > --- >  dyngen-exec.h |   20 +++- >  exec.c        |   16 ++-- >  2 files changed, 25 insertions(+), 11 deletions(-) > > diff --git a/dyngen-exec.h b/dyngen-exec.h > index 65f

Re: [Qemu-devel] [PATCH 13/15] tcg-sparc: Use defines for temporaries.

2012-03-26 Thread Blue Swirl
On Sun, Mar 25, 2012 at 22:27, Richard Henderson wrote: > And change from %i4 to %g1 to remove a v8plus fixme. > > Signed-off-by: Richard Henderson > --- >  tcg/sparc/tcg-target.c |  110 --- >  1 files changed, 56 insertions(+), 54 deletions(-) > > diff

Re: [Qemu-devel] [PATCH v2 0/6] ARM: AREG0 conversion

2012-03-26 Thread Blue Swirl
On Mon, Mar 26, 2012 at 13:05, Paul Brook wrote: >> On 24 March 2012 18:58, Blue Swirl wrote: >> > v2: fix patch 1, tweak patch 2 and rebase to master. >> > >> > URL     git://repo.or.cz/qemu/blueswirl.git >> >        http://repo.or.cz/r/qemu/blueswi

Re: [Qemu-devel] Build broken -- qemu-ga: add guest-network-get-interfaces command

2012-03-26 Thread Blue Swirl
builds >> on linux/w32. Send anyway or wait for confirmation? > > > Brad/Michal, > > Can you confirm the fix? Fixes build. Tested-by: Blue Swirl > Regards, > > Anthony Liguori > >> >>> >>> Regards, >>> >>> Anthony Liguori >>> >>>> >>>>> >>>>> Michal >>>>> >>>> >>> > >

Re: [Qemu-devel] [PATCH 0/6] refactor PC machine, i440fx and piix3 to take advantage of QOM

2012-03-26 Thread Blue Swirl
On Mon, Mar 26, 2012 at 02:06, Wanpeng Li wrote: > > From: Anthony Liguori > > > This series aggressively refactors the PC machine initialization to be more > modelled and less ad-hoc.  The highlights of this series are: Please fix coding style while moving. >  1) Things like -m and -bios-name

Re: [Qemu-devel] [PATCH 0/6] refactor PC machine, i440fx and piix3 to take advantage of QOM

2012-03-26 Thread Blue Swirl
On Mon, Mar 26, 2012 at 12:20, Jan Kiszka wrote: > On 2012-03-26 04:06, Wanpeng Li wrote: >> From: Anthony Liguori >> >> >> This series aggressively refactors the PC machine initialization to be more >> modelled and less ad-hoc.  The highlights of this series are: >> >>  1) Things like -m and -bi

Re: [Qemu-devel] [PATCH 09/15] tcg-sparc: Do not use a global register for AREG0.

2012-03-26 Thread Blue Swirl
On Mon, Mar 26, 2012 at 16:52, Richard Henderson wrote: > On 03/26/12 09:31, Blue Swirl wrote: >>> > +/* In dyngen-exec.h, without AREG0, we fall back to an alias to >>> > cpu_single_env. >>> > +   We can't actually tell from here whether that'

Re: [Qemu-devel] [PATCH 0/6] refactor PC machine, i440fx and piix3 to take advantage of QOM

2012-03-26 Thread Blue Swirl
On Mon, Mar 26, 2012 at 17:35, Anthony Liguori wrote: > On 03/26/2012 12:09 PM, Blue Swirl wrote: >> >> On Mon, Mar 26, 2012 at 02:06, Wanpeng Li  wrote: >>> >>> >>> From: Anthony Liguori >>> >>> >>> This series aggressively re

Re: [Qemu-devel] [PATCH 0/6] refactor PC machine, i440fx and piix3 to take advantage of QOM

2012-03-26 Thread Blue Swirl
On Mon, Mar 26, 2012 at 17:45, Anthony Liguori wrote: > On 03/26/2012 12:43 PM, Blue Swirl wrote: >> >> On Mon, Mar 26, 2012 at 17:35, Anthony Liguori >>  wrote: >>> >>> On 03/26/2012 12:09 PM, Blue Swirl wrote: >>>> >>>

Re: [Qemu-devel] [PATCH 0/6] refactor PC machine, i440fx and piix3 to take advantage of QOM

2012-03-26 Thread Blue Swirl
On Mon, Mar 26, 2012 at 18:07, Anthony Liguori wrote: > On 03/26/2012 01:01 PM, Blue Swirl wrote: >> >> On Mon, Mar 26, 2012 at 17:45, Anthony Liguori >>  wrote: >>> >>> >>> >>> Is this something we universally want to do?  What would we

Re: [Qemu-devel] [PATCH v2 0/6] ARM: AREG0 conversion

2012-03-27 Thread Blue Swirl
On Tue, Mar 27, 2012 at 13:40, Laurent Desnogues wrote: > On Mon, Mar 26, 2012 at 7:02 PM, Blue Swirl wrote: > [...] >> At least stack protector is protecting more code than before (for >> example TLB miss handler), but could overhead from that amount to 5%? >> >>

Re: [Qemu-devel] [PATCH 1/4] Add socket/xnet libs to configure for Solaris

2012-03-27 Thread Blue Swirl
On Tue, Mar 27, 2012 at 13:14, Andreas Färber wrote: > Am 27.03.2012 14:01, schrieb Lee Essen: >> On 27/03/2012 12:31, Andreas Färber wrote: >>> Am 27.03.2012 09:23, schrieb Stefan Hajnoczi: On Sat, Mar 24, 2012 at 04:26:27PM +, Lee Essen wrote: > libsocket and libxnet are required fo

Re: [Qemu-devel] [PATCH 1/4] Add socket/xnet libs to configure for Solaris

2012-03-27 Thread Blue Swirl
On Tue, Mar 27, 2012 at 13:56, Andreas Färber wrote: > Am 27.03.2012 15:06, schrieb Stefan Hajnoczi: >> On Tue, Mar 27, 2012 at 1:01 PM, Lee Essen wrote: >>> On 27/03/2012 12:31, Andreas Färber wrote: Am 27.03.2012 09:23, schrieb Stefan Hajnoczi: > > On Sat, Mar 24, 2012 at 04:2

Re: [Qemu-devel] [PATCH 3/3] sparc64: implement PCI and ISA irqs

2012-03-27 Thread Blue Swirl
On Tue, Mar 27, 2012 at 18:19, Artyom Tarasenko wrote: > On Sun, Mar 11, 2012 at 12:02 PM, Blue Swirl wrote: >> Generate correct trap for external interrupts. Map PCI and ISA IRQs to >> RIC/UltraSPARC-IIi interrupt vectors. >> >> Signed-off-by: Blue Swi

<    5   6   7   8   9   10   11   12   13   14   >