On Sun, Mar 18, 2012 at 12:08, Avi Kivity <a...@redhat.com> wrote: > On 03/18/2012 12:51 PM, Blue Swirl wrote: >> > >> > IMO, my patch is better. tlb_set_page() should not deal with offsets >> > within a page. >> >> It looks like all targets except Sparc32/64 mask the addresses before >> passing to tlb_set_page(), so I agree. > > Ok. Commit my patch then?
I sent a different patch which masks incoming address earlier and removes unnecessary masking in other places. >> > If you prefer your approach, I suggest masking the address up front in >> > the beginning of tlb_set_page() instead. >> > >> >> (except Sparc32, Sparc64 >> >> and PPC displays are still not refreshed correctly). >> > >> > Details about this please. >> >> Screen is not updated correctly, there are lines from previous >> screenful. Pressing ctrl-alt-1 refreshes the display. Perhaps dirty >> tracking is broken? VGA in x86 works. > > Ok, I see it. Will investigate. > > -- > error compiling committee.c: too many arguments to function >
