On Fri, Jan 13, 2012 at 22:16, Andreas Färber <afaer...@suse.de> wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > Am 13.01.2012 21:09, schrieb Jan Kiszka: >> This actually also converts it to a proper ISADevice - a value of >> its own. > > Could this by any chance help with eliminating the global > isa_mem_base? Don't see that in this patch.
Not really. For that, memory API should be used to instead of a global variable. > Andreas > > $ grep -r isa_mem_base . > ./hw/ppc_prep.c: isa_mem_base = 0xc0000000; > ./hw/bonito.c: isa_mem_base = s->bonito_pciio_start; > ./hw/vga.c: base += isa_mem_base; > ./hw/vga.c: isa_mem_base + > 0x000a0000, > ./hw/isa-bus.c:target_phys_addr_t isa_mem_base = 0; > ./hw/cirrus_vga.c: isa_mem_base > + 0x000a0000, > ./hw/isa.h:extern target_phys_addr_t isa_mem_base; > ./hw/mips_jazz.c: isa_mem_base = 0x11000000; > ./hw/mips_r4k.c: isa_mem_base = 0x10000000; > ./hw/vga-isa.c: isa_mem_base + > 0x000a0000, > ./hw/gt64xxx.c: isa_mem_base = s->PCI0IO_start; > ./hw/gt64xxx.c: isa_mem_base = 0x10000000; > > - -- > SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany > GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg > -----BEGIN PGP SIGNATURE----- > Version: GnuPG v2.0.18 (GNU/Linux) > > iQIcBAEBAgAGBQJPEK1HAAoJEPou0S0+fgE/9bYQAIMXlirZrps7KCArjbTiZHea > azvsPvLcNDPUbhN7GL4F26ahJV5cRnkHUD/pc6yQdil5sEK2TsPzncfPOQxhx0O0 > FIgaaQhgYSYo9vDLJBQ5yKHmy2bv1sYTtUdvVszVKcyMzOPo8rLPwNr57PO8WmR8 > fUzAjoL/bhA7w+j/N09phSE1xOTdxwye4fPmrJ7+1Ii+8muKa6mpvtHYM6stFNa4 > DIM2x9lRx9qrdPJdRmBUkwTd5CkKk37jisdNUDQjFl6zRGBlHr3P/78m7MrB9I2Q > fBzcSjr6tcUS7TZWpkwkFlmVctwNHU8RFb9a6bMtiWs3+L6r5mDYNIQ0fV0oY7J7 > UNNtoEo7B46WKx4xxG8bGa+Bs4V8U+v487XTvZpWZ1Xuap2y/fALE1SXLtdWVBGE > oE8mfCwtxh6c1c7w+l18LYCaSliGaZGj37cwdCsF0yy5LRYC6ypcMR6+INJwCGDV > CFbsxZdg08Ht1XGjQsNbwtT5LAUF4N1gGwjDScFB7I0Mx3nCER5wJCvd2GdKo9Km > nRzl4yyTdTAWT3GTyccc+XZ7I/TJdGT4GOE6vnjL5wn9hl5O+DHC5eCrCleKvZ97 > AdJWFtocudZzlnEKtMsNV8EfrKWckejLoRcSRFgXVsUZkAkOOPSuWyQ4sAxcTK96 > XqidOb4932mcJZZjjyXx > =kcX1 > -----END PGP SIGNATURE-----
