Re: [PATCH RESEND v2 1/3] target/riscv/cpu.c: add 'sdtrig' in riscv, isa

2025-06-04 Thread Alistair Francis
On Thu, Jun 5, 2025 at 3:45 AM Daniel Henrique Barboza wrote: > > We have support for sdtrig for awhile but we are not advertising it. It > is enabled by default via the 'debug' flag. Use the same flag to also > advertise sdtrig. > > Add an exception in disable_priv_spec_isa_exts() to avoid spammi

Re: [PATCH v2 2/3] target/riscv/tcg: decouple profile enablement from user prop

2025-06-04 Thread Alistair Francis
On Thu, Jun 5, 2025 at 3:40 AM Daniel Henrique Barboza wrote: > > We have code in riscv_cpu_add_profiles() to enable a profile right away > in case a CPU chose the profile during its cpu_init(). But we're using > the user callback option to do so, setting profile->user_set. > > Create a new helper

Re: [PATCH RESEND v2 3/3] target/riscv/cpu.c: do better with 'named features' doc

2025-06-04 Thread Alistair Francis
On Thu, Jun 5, 2025 at 3:45 AM Daniel Henrique Barboza wrote: > > Most of the named features are added directly in isa_edata_arr[], some > of them are also added in riscv_cpu_named_features(). There is a reason > for that, and the existing docs can do better explaining it. > > Signed-off-by: Danie

Re: [PATCH v6 4/5] ram-block-attributes: Introduce RamBlockAttributes to manage RAMBlock with guest_memfd

2025-06-04 Thread Chenyi Qiang
On 6/5/2025 8:35 AM, Alexey Kardashevskiy wrote: > > > On 4/6/25 21:04, Alexey Kardashevskiy wrote: >> >> >> On 30/5/25 18:32, Chenyi Qiang wrote: >>> Commit 852f0048f3 ("RAMBlock: make guest_memfd require uncoordinated >>> discard") highlighted that subsystems like VFIO may disable RAM block

Re: [PATCH v2] target/riscv: support atomic instruction fetch (Ziccif)

2025-06-04 Thread Alistair Francis
On Thu, May 8, 2025 at 7:49 PM Jim Shu wrote: > > Support 4-byte atomic instruction fetch when instruction is natural > aligned. > > Current implementation is not atomic because it loads instruction twice > for first and last 2 bytes. We load 4 bytes at once to keep the > atomicity. This instructi

Re: [PATCH 0/2] ui: fix VNC endian regression & improve tracing

2025-06-04 Thread Philippe Mathieu-Daudé
On 4/6/25 18:22, Daniel P. Berrangé wrote: Daniel P. Berrangé (2): ui: fix setting client_endian field defaults ui: add trace events for all client messages Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH 00/11] SVM API declaration for emulated devices

2025-06-04 Thread CLEMENT MATHIEU--DRIF
Just cc'ing riscv team Thanks >cmd On 20/05/2025 9:18 am, CLEMENT MATHIEU--DRIF wrote: > This patch set belongs to a list of series that add SVM support in VT-d. > > Here we focus on introducing a common PCI-level API for ATS and PRI to be > used by virtual devices. > > The API introduced in thi

Re: [PATCH 0/8] hw/i386/pc: Remove deprecated 2.10, 2.11 and 2.12 PC machines

2025-06-04 Thread Xiaoyao Li
On 6/4/2025 3:14 PM, Philippe Mathieu-Daudé wrote: On 4/6/25 09:07, Philippe Mathieu-Daudé wrote: On 4/6/25 03:30, Xiaoyao Li wrote: On 5/2/2025 6:35 AM, Philippe Mathieu-Daudé wrote: The versioned 'pc' and 'q35' machines up to 2.12 been marked as deprecated two releases ago, and are older tha

Re: [PATCH v1] ramfb: Add property to control if load the romfile

2025-06-04 Thread Philippe Mathieu-Daudé
Hi Shaoqin, On 5/6/25 05:03, Shaoqin Huang wrote: Now the ramfb will load the vgabios-ramfb.bin unconditionally, but only the x86 need the vgabios-ramfb.bin, this can cause that when use the release package on arm64 it can't find the vgabios-ramfb.bin. So add a new property ramfb-romfile in bot

Re: [PATCH v4 2/2] target/riscv: Make PMP region count configurable

2025-06-04 Thread Jay Chang
*Hi Daniel,* You're absolutely right — thanks for pointing it out and providing the fix! Would you like me to send out a v5 patch incorporating your changes? Best Regards Jay Chang On Thu, Jun 5, 2025 at 2:20 AM Daniel Henrique Barboza < dbarb...@ventanamicro.com> wrote: > It seems like this

RE: [PATCH v5 0/7] ui/spice: Enable gl=on option for non-local or remote clients

2025-06-04 Thread Kasireddy, Vivek
Hi Marc-André, > Subject: Re: [PATCH v5 0/7] ui/spice: Enable gl=on option for non-local or > remote clients > > > > > To address the limitation that this option is incompatible with > > remote clients, this patch series adds an option to select a > > preferred codec and also enable gl=on option

Re: [PATCH v6 4/5] ram-block-attributes: Introduce RamBlockAttributes to manage RAMBlock with guest_memfd

2025-06-04 Thread Chenyi Qiang
On 6/4/2025 7:04 PM, Alexey Kardashevskiy wrote: > > > On 30/5/25 18:32, Chenyi Qiang wrote: >> Commit 852f0048f3 ("RAMBlock: make guest_memfd require uncoordinated >> discard") highlighted that subsystems like VFIO may disable RAM block >> discard. However, guest_memfd relies on discard opera

[PATCH] accel/tcg: Make round-robin kick period configurable

2025-06-04 Thread Ethan Chen via
This change introduces a configurable round-robin kick period, giving users the flexibility to balance SMP simulation accuracy and performance according to their specific needs. The round-robin kick period is the time one vCPU can run before scheduler switches to another vCPU when using a single t

Re: [PATCH 06/14] rust: qemu-api: add bindings to Error

2025-06-04 Thread Markus Armbruster
Paolo Bonzini writes: > On 6/4/25 07:01, Markus Armbruster wrote: >> This is what your FOO_or_propagate() functions are for. >> >> The rule glosses over a subtle detail: the difference between >> error_setg() and error_propagate() isn't just create a new error vs. use >> an existing one, namely

Re: [PATCH v5 4/6] python: add qapi static analysis tests

2025-06-04 Thread Markus Armbruster
John Snow writes: [...] > diff --git a/python/tests/qapi-flake8.sh b/python/tests/qapi-flake8.sh > new file mode 100755 > index 000..2211b6c7f41 > --- /dev/null > +++ b/python/tests/qapi-flake8.sh > @@ -0,0 +1,6 @@ > +#!/bin/sh -e > +# SPDX-License-Identifier: LGPL-2.1-or-later Why not

Re: [PATCH v5 4/6] python: add qapi static analysis tests

2025-06-04 Thread Markus Armbruster
John Snow writes: > Update the python tests to also check QAPI and the QAPI Sphinx [Lovingly crafted commit message snipped...] > Signed-off-by: John Snow > > add licenses or whatever > > Signed-off-by: John Snow Oops!

Re: [PATCH v5 0/6] python: add QAPI and qapidoc et al to python tests

2025-06-04 Thread Markus Armbruster
John Snow writes: > Hiya, this series turns on automated linting for scripts/qapi, > docs/sphinx/qapidoc.py and docs/sphinx/qapi_domain.py. > > This includes flake8/isort/pylint/mypy for scripts/qapi, but omits mypy > from the Sphinx plugins owing to my inability to strictly type the > extensions

ppc kvm: support of 64K guest page size with 4K host pagesize?

2025-06-04 Thread Michael Tokarev
There's a bug report filed in debian against qemu, https://bugs.debian.org/1107288 - saying kvm on ppc does not work on debian (anymore) due to qemu requesting unrealistic (non-existing) page size of 64K on a host which only has 4K. I don't know much about PPC, - what's the issue here? Should qem

Re: [PATCH v2] target/riscv: support atomic instruction fetch (Ziccif)

2025-06-04 Thread Alistair Francis
On Thu, May 8, 2025 at 7:49 PM Jim Shu wrote: > > Support 4-byte atomic instruction fetch when instruction is natural > aligned. > > Current implementation is not atomic because it loads instruction twice > for first and last 2 bytes. We load 4 bytes at once to keep the > atomicity. This instructi

Re: [PATCH v4 2/2] target/riscv: Make PMP region count configurable

2025-06-04 Thread Alistair Francis
On Thu, Jun 5, 2025 at 3:34 PM Jay Chang wrote: > > Hi Daniel, > > You're absolutely right — thanks for pointing it out and providing the fix! > > Would you like me to send out a v5 patch incorporating your changes? Yes please Alistair > > > Best Regards > Jay Chang > > > On Thu, Jun 5, 2025 at

Re: ppc kvm: support of 64K guest page size with 4K host pagesize?

2025-06-04 Thread Thomas Huth
On 05/06/2025 08.34, Michael Tokarev wrote: There's a bug report filed in debian against qemu, https://bugs.debian.org/1107288 - saying kvm on ppc does not work on debian (anymore) due to qemu requesting unrealistic (non-existing) page size of 64K on a host which only has 4K. I don't know much a

Re: [PATCH 0/8] hw/i386/pc: Remove deprecated 2.10, 2.11 and 2.12 PC machines

2025-06-04 Thread Philippe Mathieu-Daudé
On 4/6/25 03:30, Xiaoyao Li wrote: On 5/2/2025 6:35 AM, Philippe Mathieu-Daudé wrote: The versioned 'pc' and 'q35' machines up to 2.12 been marked as deprecated two releases ago, and are older than 6 years, so according to our support policy we can remove them. This series includes the 2.10 to

Re: [PATCH V4 16/43] pci: skip reset during cpr

2025-06-04 Thread Cédric Le Goater
On 6/2/25 14:36, Steven Sistare wrote: On 6/1/2025 3:07 PM, Michael S. Tsirkin wrote: On Sun, Jun 01, 2025 at 06:38:43PM +0200, Cédric Le Goater wrote: On 5/29/25 21:24, Steve Sistare wrote: Do not reset a vfio-pci device during CPR. Signed-off-by: Steve Sistare ---    include/hw/pci/pci_dev

Re: [PATCH] tests/functional: Speed up the avr_mega2560 test

2025-06-04 Thread Philippe Mathieu-Daudé
On 3/6/25 20:47, Thomas Huth wrote: From: Thomas Huth We can simply check for the expected pattern on the console, no need to wait for two seconds here to search for the pattern in the log at the end. IIRC this was due to problem with console reader, now fixed. While we're at it, also remov

Re: [PATCH v3 0/4] VFIO and IOMMU prerequisite stuff for IOMMU nesting support

2025-06-04 Thread Cédric Le Goater
On 6/4/25 08:21, Zhenzhong Duan wrote: Hi, The first 6 patches of [1] are all VFIO or IOMMUFD related additions. Split them out per Cédric and seek for quick acceptance. I didn't copy changelog from [1] as it's a mix of the whole nesting series. For who want a quick view of the whole nesting s

Re: [PATCH v3 3/3] docs: define policy forbidding use of AI code generators

2025-06-04 Thread Daniel P . Berrangé
On Wed, Jun 04, 2025 at 08:17:27AM +0200, Markus Armbruster wrote: > Stefan Hajnoczi writes: > > > On Tue, Jun 3, 2025 at 10:25 AM Markus Armbruster wrote: > >> > >> From: Daniel P. Berrangé >> + > >> +The increasing prevalence of AI code generators, most notably but not > >> limited > > > >

Re: [PATCH 0/2] hw/nvme: stable fixes

2025-06-04 Thread Michael Tokarev
On 03.06.2025 15:59, Klaus Jensen wrote: Two fixes for stable. See commits. What do you mean "for stable"? Are these not for master but for stable *only*? Usually changes for qemu-stable are picked up *from* master branch, unless there are major changes in stable already. Thanks, /mjt

Re: [PATCH v5 0/7] ui/spice: Enable gl=on option for non-local or remote clients

2025-06-04 Thread Marc-André Lureau
Hi Vivek On Thu, May 29, 2025 at 9:16 AM Vivek Kasireddy wrote: > > To address the limitation that this option is incompatible with > remote clients, this patch series adds an option to select a > preferred codec and also enable gl=on option for clients that > are connected via the network. In ot

Re: [PATCH 0/8] hw/i386/pc: Remove deprecated 2.10, 2.11 and 2.12 PC machines

2025-06-04 Thread Philippe Mathieu-Daudé
On 4/6/25 09:07, Philippe Mathieu-Daudé wrote: On 4/6/25 03:30, Xiaoyao Li wrote: On 5/2/2025 6:35 AM, Philippe Mathieu-Daudé wrote: The versioned 'pc' and 'q35' machines up to 2.12 been marked as deprecated two releases ago, and are older than 6 years, so according to our support policy we can

Re: [PATCH v3 1/3] docs: introduce dedicated page about code provenance / sign-off

2025-06-04 Thread Daniel P . Berrangé
On Wed, Jun 04, 2025 at 08:44:55AM +0200, Markus Armbruster wrote: > Alex Bennée writes: > > > Markus Armbruster writes: > > > >> From: Daniel P. Berrangé > >> > >> Currently we have a short paragraph saying that patches must include > >> a Signed-off-by line, and merely link to the kernel docu

Re: [PATCH 0/2] hw/nvme: stable fixes

2025-06-04 Thread Klaus Jensen
On Jun 4 10:21, Michael Tokarev wrote: > On 03.06.2025 15:59, Klaus Jensen wrote: > > Two fixes for stable. See commits. > > What do you mean "for stable"? > Are these not for master but for stable *only*? > > Usually changes for qemu-stable are picked up *from* > master branch, unless there are

Re: [PATCH] target/riscv/kvm: implement SBI debug console (DBCN) calls

2025-06-04 Thread Philippe Mathieu-Daudé
On 3/6/25 20:04, Daniel Henrique Barboza wrote: On 6/3/25 10:19 AM, Philippe Mathieu-Daudé wrote: Hi Daniel, (now merged as commit a6b53378f537) On 25/4/24 17:50, Daniel Henrique Barboza wrote: SBI defines a Debug Console extension "DBCN" that will, in time, replace the legacy console putch

Re: [PATCH v3 1/3] docs: introduce dedicated page about code provenance / sign-off

2025-06-04 Thread Philippe Mathieu-Daudé
On 4/6/25 08:44, Markus Armbruster wrote: Alex Bennée writes: Markus Armbruster writes: From: Daniel P. Berrangé Currently we have a short paragraph saying that patches must include a Signed-off-by line, and merely link to the kernel documentation. The linked kernel docs have a lot of con

Re: [PATCH v3 1/3] docs: introduce dedicated page about code provenance / sign-off

2025-06-04 Thread Gerd Hoffmann
Hi, > > If we do want to mention the editors we should probably also mention b4. > > Can do if somebody contributes a suitable configuration snippet. Nothing to configure ;) Simplest usage is 'b4 shazam $msgid' and b4 will go fetch the complete thread from lore.kernel.org, collect all the rev

Re: [PATCH v3 3/3] docs: define policy forbidding use of AI code generators

2025-06-04 Thread Daniel P . Berrangé
On Wed, Jun 04, 2025 at 09:54:33AM +0200, Philippe Mathieu-Daudé wrote: > On 4/6/25 09:15, Daniel P. Berrangé wrote: > > On Wed, Jun 04, 2025 at 08:17:27AM +0200, Markus Armbruster wrote: > > > Stefan Hajnoczi writes: > > > > > > > On Tue, Jun 3, 2025 at 10:25 AM Markus Armbruster > > > > wrote

[PATCH] virtio-mem: Fix definition of VirtIOMEMClass

2025-06-04 Thread Zhenzhong Duan
Parent of VirtIOMEMClass is VirtioDeviceClass rather than VirtIODevice. Fixes: 910b25766b33 ("virtio-mem: Paravirtualized memory hot(un)plug") Signed-off-by: Zhenzhong Duan --- include/hw/virtio/virtio-mem.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/hw/virtio/vi

Re: [PATCH] virtio-mem: Fix definition of VirtIOMEMClass

2025-06-04 Thread David Hildenbrand
On 04.06.25 10:47, Zhenzhong Duan wrote: Parent of VirtIOMEMClass is VirtioDeviceClass rather than VirtIODevice. Fixes: 910b25766b33 ("virtio-mem: Paravirtualized memory hot(un)plug") Signed-off-by: Zhenzhong Duan --- include/hw/virtio/virtio-mem.h | 2 +- 1 file changed, 1 insertion(+), 1 d

Re: [PATCH] virtio-mem: Fix definition of VirtIOMEMClass

2025-06-04 Thread David Hildenbrand
On 04.06.25 10:47, Zhenzhong Duan wrote: Parent of VirtIOMEMClass is VirtioDeviceClass rather than VirtIODevice. Fixes: 910b25766b33 ("virtio-mem: Paravirtualized memory hot(un)plug") Signed-off-by: Zhenzhong Duan --- include/hw/virtio/virtio-mem.h | 2 +- 1 file changed, 1 insertion(+), 1 d

Re: [PATCH 0/2] hw/loongarch/virt: Small enhancement about big endian host

2025-06-04 Thread Alireza Sanaee via
On Wed, 4 Jun 2025 14:55:00 +0800 Bibo Mao wrote: > On big endian host machine such as S390, bios-table-test fails to run. > And also linux kernel fails to boot. > > This patches solves these two issues. > > Bibo Mao (2): > hw/loongarch/virt: Fix big endian support with MCFG table > hw/intc

Re: [PATCH v3 3/3] docs: define policy forbidding use of AI code generators

2025-06-04 Thread Daniel P . Berrangé
On Tue, Jun 03, 2025 at 02:25:42PM -0400, Stefan Hajnoczi wrote: > On Tue, Jun 3, 2025 at 10:25 AM Markus Armbruster wrote: > > > > From: Daniel P. Berrangé > > > > There has been an explosion of interest in so called AI code > > generators. Thus far though, this is has not been matched by a broa

Re: [PATCH] virtio-mem: Fix definition of VirtIOMEMClass

2025-06-04 Thread Philippe Mathieu-Daudé
On 4/6/25 10:47, Zhenzhong Duan wrote: Parent of VirtIOMEMClass is VirtioDeviceClass rather than VirtIODevice. Fixes: 910b25766b33 ("virtio-mem: Paravirtualized memory hot(un)plug") Signed-off-by: Zhenzhong Duan --- include/hw/virtio/virtio-mem.h | 2 +- 1 file changed, 1 insertion(+), 1 del

Re: [PATCH v3 3/3] docs: define policy forbidding use of AI code generators

2025-06-04 Thread Markus Armbruster
Daniel P. Berrangé writes: > On Wed, Jun 04, 2025 at 08:17:27AM +0200, Markus Armbruster wrote: >> Stefan Hajnoczi writes: >> >> > On Tue, Jun 3, 2025 at 10:25 AM Markus Armbruster >> > wrote: >> >> >> >> From: Daniel P. Berrangé > >> + >> >> +The increasing prevalence of AI code generators

Re: [PATCH v3 3/3] docs: define policy forbidding use of AI code generators

2025-06-04 Thread Philippe Mathieu-Daudé
On 4/6/25 10:40, Daniel P. Berrangé wrote: On Wed, Jun 04, 2025 at 09:54:33AM +0200, Philippe Mathieu-Daudé wrote: On 4/6/25 09:15, Daniel P. Berrangé wrote: On Wed, Jun 04, 2025 at 08:17:27AM +0200, Markus Armbruster wrote: Stefan Hajnoczi writes: On Tue, Jun 3, 2025 at 10:25 AM Markus Arm

Re: [PATCH] tests/functional: Add a test for the Arduino UNO machine

2025-06-04 Thread Mark Cave-Ayland
On 03/06/2025 19:40, Thomas Huth wrote: From: Thomas Huth Check whether we can run a kernel that prints something to the serial console. Signed-off-by: Thomas Huth --- MAINTAINERS | 3 ++- tests/functional/meson.build | 1 + tests/functional/test_avr_uno.py | 3

Re: [PATCH] tests/functional: Speed up the avr_mega2560 test

2025-06-04 Thread Mark Cave-Ayland
On 03/06/2025 19:47, Thomas Huth wrote: From: Thomas Huth We can simply check for the expected pattern on the console, no need to wait for two seconds here to search for the pattern in the log at the end. While we're at it, also remove the obsolete "timeout" variable from this test. Signed-o

Re: [PATCH] target/riscv/kvm: implement SBI debug console (DBCN) calls

2025-06-04 Thread Philippe Mathieu-Daudé
(+Marc-André and Paolo who I forgot to Cc first) On 4/6/25 11:17, Daniel Henrique Barboza wrote: On 6/4/25 4:32 AM, Philippe Mathieu-Daudé wrote: On 3/6/25 20:04, Daniel Henrique Barboza wrote: On 6/3/25 10:19 AM, Philippe Mathieu-Daudé wrote: Hi Daniel, (now merged as commit a6b53378f53

Re: [PATCH v3 1/3] docs: introduce dedicated page about code provenance / sign-off

2025-06-04 Thread Markus Armbruster
Alex Bennée writes: > Markus Armbruster writes: > >> From: Daniel P. Berrangé >> >> Currently we have a short paragraph saying that patches must include >> a Signed-off-by line, and merely link to the kernel documentation. >> The linked kernel docs have a lot of content beyond the part about >>

[PATCH v2] Add RISCV ZALASR extension

2025-06-04 Thread Roan Richmond
This is based on version v0.8.3 of the ZALASR specification [1]. The specification is listed as in Frozen state [2]. [1]: https://github.com/riscv/riscv-zalasr/tree/v0.8.3 [2]: https://lf-riscv.atlassian.net/wiki/spaces/HOME/pages/16154882/All+RISC-V+Specifications+Under+Active+Development Signe

Re: [PATCH v5] target/loongarch: fix vldi/xvldi raise wrong error

2025-06-04 Thread Philippe Mathieu-Daudé
On 4/6/25 10:40, Song Gao wrote: on qemu we got an aborted error ** ERROR:../target/loongarch/tcg/insn_trans/trans_vec.c.inc:3574:vldi_get_value: code should not be reached Bail out! ERROR:../target/loongarch/tcg/insn_trans/trans_vec.c.inc:3574:vldi_get_value: code should not be reached Aborte

Re: [PATCH v3 3/3] docs: define policy forbidding use of AI code generators

2025-06-04 Thread Markus Armbruster
Daniel P. Berrangé writes: > On Wed, Jun 04, 2025 at 10:58:38AM +0200, Markus Armbruster wrote: >> Daniel P. Berrangé writes: >> >> > On Wed, Jun 04, 2025 at 08:17:27AM +0200, Markus Armbruster wrote: >> >> Stefan Hajnoczi writes: >> >> >> >> > On Tue, Jun 3, 2025 at 10:25 AM Markus Armbruste

Re: [PATCH v3 3/3] docs: define policy forbidding use of AI code generators

2025-06-04 Thread Daniel P . Berrangé
On Wed, Jun 04, 2025 at 10:58:38AM +0200, Markus Armbruster wrote: > Daniel P. Berrangé writes: > > > On Wed, Jun 04, 2025 at 08:17:27AM +0200, Markus Armbruster wrote: > >> Stefan Hajnoczi writes: > >> > >> > On Tue, Jun 3, 2025 at 10:25 AM Markus Armbruster > >> > wrote: > >> >> > >> >> Fro

Re: [PATCH] target/riscv/kvm: implement SBI debug console (DBCN) calls

2025-06-04 Thread Daniel Henrique Barboza
On 6/4/25 4:32 AM, Philippe Mathieu-Daudé wrote: On 3/6/25 20:04, Daniel Henrique Barboza wrote: On 6/3/25 10:19 AM, Philippe Mathieu-Daudé wrote: Hi Daniel, (now merged as commit a6b53378f537) On 25/4/24 17:50, Daniel Henrique Barboza wrote: SBI defines a Debug Console extension "DBCN"

Re: [PULL 36/58] pc-bios: Move device tree files in their own subdir

2025-06-04 Thread Bernhard Beschow
Am 3. Juni 2025 11:38:59 UTC schrieb Thomas Huth : >On 03/06/2025 08.39, Bernhard Beschow wrote: >> >> >> Am 2. Juni 2025 08:12:39 UTC schrieb "Philippe Mathieu-Daudé" >> : >>> On 30/5/25 02:54, BALATON Zoltan wrote: On Thu, 29 May 2025, Bernhard Beschow wrote: > Am 25. April 2025 15

RE: [PATCH] virtio-mem: Fix definition of VirtIOMEMClass

2025-06-04 Thread Duan, Zhenzhong
>-Original Message- >From: David Hildenbrand >Subject: Re: [PATCH] virtio-mem: Fix definition of VirtIOMEMClass > >On 04.06.25 10:47, Zhenzhong Duan wrote: >> Parent of VirtIOMEMClass is VirtioDeviceClass rather than VirtIODevice. >> >> Fixes: 910b25766b33 ("virtio-mem: Paravirtualized m

RE: [PATCH] virtio-mem: Fix definition of VirtIOMEMClass

2025-06-04 Thread Duan, Zhenzhong
>-Original Message- >From: David Hildenbrand >Subject: Re: [PATCH] virtio-mem: Fix definition of VirtIOMEMClass > >On 04.06.25 10:47, Zhenzhong Duan wrote: >> Parent of VirtIOMEMClass is VirtioDeviceClass rather than VirtIODevice. >> >> Fixes: 910b25766b33 ("virtio-mem: Paravirtualized m

Re: [PATCH 1/3] i386/cpu: Rename enable_cpuid_0x1f to force_cpuid_0x1f

2025-06-04 Thread Zhao Liu
On Tue, Jun 03, 2025 at 01:03:03AM -0400, Xiaoyao Li wrote: > Date: Tue, 3 Jun 2025 01:03:03 -0400 > From: Xiaoyao Li > Subject: [PATCH 1/3] i386/cpu: Rename enable_cpuid_0x1f to force_cpuid_0x1f > X-Mailer: git-send-email 2.43.0 > > The name of "enable_cpuid_0x1f" isn't right to its behavior be

Re: [PATCH v3 1/3] docs: introduce dedicated page about code provenance / sign-off

2025-06-04 Thread Markus Armbruster
Philippe Mathieu-Daudé writes: > On 4/6/25 08:44, Markus Armbruster wrote: >> Alex Bennée writes: >> >>> Markus Armbruster writes: >>> From: Daniel P. Berrangé Currently we have a short paragraph saying that patches must include a Signed-off-by line, and merely link to the

Re: [PATCH 2/3] i386/tdx: Fix the typo of the comment of struct TdxGuest

2025-06-04 Thread Zhao Liu
On Tue, Jun 03, 2025 at 01:03:04AM -0400, Xiaoyao Li wrote: > Date: Tue, 3 Jun 2025 01:03:04 -0400 > From: Xiaoyao Li > Subject: [PATCH 2/3] i386/tdx: Fix the typo of the comment of struct > TdxGuest > X-Mailer: git-send-email 2.43.0 > > Change sha348 to sha384. > > Signed-off-by: Xiaoyao Li

Re: [PATCH 3/3] i386/tdx: Clarify the error message of mrconfigid/mrowner/mrownerconfig

2025-06-04 Thread Zhao Liu
On Tue, Jun 03, 2025 at 01:03:05AM -0400, Xiaoyao Li wrote: > Date: Tue, 3 Jun 2025 01:03:05 -0400 > From: Xiaoyao Li > Subject: [PATCH 3/3] i386/tdx: Clarify the error message of > mrconfigid/mrowner/mrownerconfig > X-Mailer: git-send-email 2.43.0 > > The error message is misleading - we succe

Re: [PATCH 15/16] hw/pci-host/raven: Do not map regions in init method

2025-06-04 Thread Philippe Mathieu-Daudé
(+Mark for Grackle) On 3/6/25 15:50, BALATON Zoltan wrote: On Tue, 3 Jun 2025, Philippe Mathieu-Daudé wrote: On 4/5/25 18:01, BALATON Zoltan wrote: Export memory regions as sysbus mmio regions and let the board code map them. Why? The mapping belong to the host bridge, not the board... I

Re: apparent race condition in mttcg memory handling

2025-06-04 Thread Michael Tokarev
Here's a typical output with ASan enabled, fwiw: $ ./qemu-system-x86_64 -smp 16 -m 256 -vga none -display none -kernel /boot/vmlinuz-6.12.29-amd64 -append "console=ttyS0" -serial file:/dev/tty -monitor stdio -initrd ~/debvm/initrd ==368707==WARNING: ASan doesn't fully support makecontext/swapco

Re: [PULL 00/27] Functional tests, Microblaze endianness & pc/q35 cleanups

2025-06-04 Thread Alexandr Moshkov
On 5/29/25 01:12, Thomas Huth wrote: On 28/05/2025 21.23, Stefan Hajnoczi wrote: On Wed, May 28, 2025 at 6:12 AM Thomas Huth wrote:   Hi! The following changes since commit 80db93b2b88f9b3ed8927ae7ac74ca30e643a83e:    Merge tag 'pull-aspeed-20250526' of https://github.com/legoater/qemu

Re: [PATCH] target/riscv/kvm: implement SBI debug console (DBCN) calls

2025-06-04 Thread Daniel P . Berrangé
On Wed, Jun 04, 2025 at 09:32:21AM +0200, Philippe Mathieu-Daudé wrote: > On 3/6/25 20:04, Daniel Henrique Barboza wrote: > > > > > > On 6/3/25 10:19 AM, Philippe Mathieu-Daudé wrote: > > > Hi Daniel, > > > > > > (now merged as commit a6b53378f537) > > > > > > On 25/4/24 17:50, Daniel Henrique

Re: [PATCH] target/riscv/kvm: implement SBI debug console (DBCN) calls

2025-06-04 Thread Daniel Henrique Barboza
On 6/4/25 6:38 AM, Philippe Mathieu-Daudé wrote: (+Marc-André and Paolo who I forgot to Cc first) On 4/6/25 11:17, Daniel Henrique Barboza wrote: On 6/4/25 4:32 AM, Philippe Mathieu-Daudé wrote: On 3/6/25 20:04, Daniel Henrique Barboza wrote: On 6/3/25 10:19 AM, Philippe Mathieu-Daudé

RE: [PATCH v3 00/10] kvm/arm: Introduce a customizable aarch64 KVM host model

2025-06-04 Thread Shameerali Kolothum Thodi via
> -Original Message- > From: Cornelia Huck > Sent: Tuesday, June 3, 2025 4:15 PM > To: Shameerali Kolothum Thodi > ; eric.auger@gmail.com; > eric.au...@redhat.com; qemu-devel@nongnu.org; qemu-...@nongnu.org; > kvm...@lists.linux.dev; peter.mayd...@linaro.org; > richard.hender...@lin

Re: [PATCH v3 3/3] docs: define policy forbidding use of AI code generators

2025-06-04 Thread Stefan Hajnoczi
On Wed, Jun 4, 2025, 05:10 Daniel P. Berrangé wrote: > On Tue, Jun 03, 2025 at 02:25:42PM -0400, Stefan Hajnoczi wrote: > > On Tue, Jun 3, 2025 at 10:25 AM Markus Armbruster > wrote: > > > > > > From: Daniel P. Berrangé > > > > > > There has been an explosion of interest in so called AI code >

Re: [PATCH v6 5/5] physmem: Support coordinated discarding of RAM with guest_memfd

2025-06-04 Thread Alexey Kardashevskiy
On 30/5/25 18:32, Chenyi Qiang wrote: A new field, attributes, was introduced in RAMBlock to link to a RamBlockAttributes object, which centralizes all guest_memfd related information (such as fd and shared bitmap) within a RAMBlock. Create and initialize the RamBlockAttributes object upon ra

Re: [PATCH v6 4/5] ram-block-attributes: Introduce RamBlockAttributes to manage RAMBlock with guest_memfd

2025-06-04 Thread Alexey Kardashevskiy
On 30/5/25 18:32, Chenyi Qiang wrote: Commit 852f0048f3 ("RAMBlock: make guest_memfd require uncoordinated discard") highlighted that subsystems like VFIO may disable RAM block discard. However, guest_memfd relies on discard operations for page conversion between private and shared memory, pot

Re: [PATCH v5] target/loongarch: fix vldi/xvldi raise wrong error

2025-06-04 Thread Richard Henderson
On 6/4/25 09:40, Song Gao wrote: on qemu we got an aborted error ** ERROR:../target/loongarch/tcg/insn_trans/trans_vec.c.inc:3574:vldi_get_value: code should not be reached Bail out! ERROR:../target/loongarch/tcg/insn_trans/trans_vec.c.inc:3574:vldi_get_value: code should not be reached Aborte

Re: [PATCH v5] target/loongarch: fix vldi/xvldi raise wrong error

2025-06-04 Thread Michael Tokarev
On 04.06.2025 11:40, Song Gao wrote: +static bool check_vldi_mode(arg_vldi *a) +{ + return (a->imm >>8 & 0xf) <= 12; +} static bool gen_vldi(DisasContext *ctx, arg_vldi *a, uint32_t oprsz) { An empty line can be added here between two functions during patch apply ;) /mjt

[PATCH v3 2/2] net/af-xdp: Fix up cleanup path upon failure in queue creation

2025-06-04 Thread Daniel Borkmann via
While testing, it turned out that upon error in the queue creation loop, we never trigger the af_xdp_cleanup() handler. This is because we pass errp instead of a local err pointer into the various AF_XDP setup functions instead of a scheme like: bool fn(..., Error **errp) { Error *

Re: [PATCH v6 5/5] physmem: Support coordinated discarding of RAM with guest_memfd

2025-06-04 Thread David Hildenbrand
On 30.05.25 10:32, Chenyi Qiang wrote: A new field, attributes, was introduced in RAMBlock to link to a RamBlockAttributes object, which centralizes all guest_memfd related information (such as fd and shared bitmap) within a RAMBlock. Create and initialize the RamBlockAttributes object upon ram_

[PATCH v3 1/2] net/af-xdp: Support pinned map path for AF_XDP sockets

2025-06-04 Thread Daniel Borkmann via
Extend 'inhibit=on' setting with the option to specify a pinned XSK map path along with a starting index (default 0) to push the created XSK sockets into. Example usage: # ./build/qemu-system-x86_64 [...] \ -netdev af-xdp,ifname=enp2s0f0np0,id=net0,mode=native,queues=2,start-queue=14,inhibit

Re: [PATCH v3 3/3] docs: define policy forbidding use of AI code generators

2025-06-04 Thread Philippe Mathieu-Daudé
On 4/6/25 09:15, Daniel P. Berrangé wrote: On Wed, Jun 04, 2025 at 08:17:27AM +0200, Markus Armbruster wrote: Stefan Hajnoczi writes: On Tue, Jun 3, 2025 at 10:25 AM Markus Armbruster wrote: From: Daniel P. Berrangé >> + +The increasing prevalence of AI code generators, most notably b

[PATCH v6 0/4] Building PPTT with root node and identical implementation flag

2025-06-04 Thread Alireza Sanaee via
OS like Linux is using PPTT processor node's identical implementation flag [1] to infer whether the whole system or a certain CPU cluster is homogeneous or not [2]. QEMU currently only support building homogeneous system, set the flag to indicate the fact. Build a root node in PPTT for indicates th

[PATCH v6 1/4] tests: virt: Allow changes to PPTT test table

2025-06-04 Thread Alireza Sanaee via
From: Yicong Yang Allow changes to PPTT test table, preparing for adding identical implementation flags support and for adding a root node for all the system. Signed-off-by: Yicong Yang Reviewed-by: Jonathan Cameron Signed-off-by: Alireza Sanaee --- tests/qtest/bios-tables-test-allowed-diff.

[PATCH v6 2/4] hw/acpi/aml-build: Set identical implementation flag for PPTT processor nodes

2025-06-04 Thread Alireza Sanaee via
From: Yicong Yang Per ACPI 6.5 Table 5.158: Processor Structure Flags, the identical implementation flag indicates whether all the children processors of this node share the same identical implementation revision. Currently Linux support parsing this field [1] and maybe used to identify the heter

[PATCH v6 3/4] hw/acpi/aml-build: Build a root node in the PPTT table

2025-06-04 Thread Alireza Sanaee via
From: Yicong Yang Currently we build the PPTT starting from the socket node and each socket will be a separate tree. For a multi-socket system it'll be hard for the OS to know the whole system is homogeneous or not (actually we're in the current implementation) since no parent node to telling the

[PATCH v6 4/4] tests: virt: Update expected ACPI tables for virt test

2025-06-04 Thread Alireza Sanaee via
From: Yicong Yang Update the ACPI tables according to the acpi aml_build change, also empty bios-tables-test-allowed-diff.h. The disassembled differences between actual and expected PPTT shows below. Only about the root node adding and identification flag set as expected. /* * Intel ACPI Com

[PATCH v2 0/5] Fix definition of classes with wrong parent

2025-06-04 Thread Zhenzhong Duan
Hi, This fix definition of some classes with wrong parent. Used below script to get a list, hoping all are addressed. find "$directory" -type d \( -name "roms" -o -name "build" \) -prune -o -type f \( -name "*.c" -o -name "*.h" \) -print | while read -r file; do awk '/^(struct |typedef struc

[PATCH v2 4/5] hw/char/sh_serial: Remove dummy definition of SH_SERIAL class

2025-06-04 Thread Zhenzhong Duan
SH_SERIAL is declared with OBJECT_DECLARE_SIMPLE_TYPE but defined with OBJECT_DEFINE_TYPE, SHSerialStateClass is also a dummy class which missed its parent. Change to use OBJECT_DEFINE_SIMPLE_TYPE and remove SHSerialStateClass. Fixes: beeb520925d5 ("hw/char/sh_serial: QOM-ify") Suggested-by: Davi

[PATCH v2 1/5] virtio-mem: Fix definition of VirtIOMEMClass

2025-06-04 Thread Zhenzhong Duan
Parent of VirtIOMEMClass is VirtioDeviceClass rather than VirtIODevice. Fixes: 910b25766b33 ("virtio-mem: Paravirtualized memory hot(un)plug") Signed-off-by: Zhenzhong Duan Reviewed-by: David Hildenbrand Reviewed-by: Philippe Mathieu-Daudé --- include/hw/virtio/virtio-mem.h | 2 +- 1 file chan

[PATCH v2 2/5] virtio-pmem: Fix definition of VirtIOPMEMClass

2025-06-04 Thread Zhenzhong Duan
VirtIOPMEMClass's parent is VirtioDeviceClass rather than VirtIODevice. Fixes: 5f503cd9f388 ("virtio-pmem: add virtio device") Suggested-by: David Hildenbrand Signed-off-by: Zhenzhong Duan --- include/hw/virtio/virtio-pmem.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/in

[PATCH v2 5/5] hw/riscv/riscv-iommu: Remove definition of RISCVIOMMU[Pci|Sys]Class

2025-06-04 Thread Zhenzhong Duan
RISCVIOMMUPciClass and RISCVIOMMUSysClass are defined with missed parent class, this may lead to corruption of parent class fields. It's lucky enough that parent_realize and parent_phases are not initialized or used until now, so just remove the definitions. They can be added back when really nece

[PATCH v2 3/5] hw/gpio/aspeed: Fix definition of AspeedGPIOClass

2025-06-04 Thread Zhenzhong Duan
AspeedGPIOClass's parent is SysBusDeviceClass rather than SysBusDevice. Fixes: 4b7f956862dc ("hw/gpio: Add basic Aspeed GPIO model for AST2400 and AST2500") Suggested-by: David Hildenbrand Signed-off-by: Zhenzhong Duan --- include/hw/gpio/aspeed_gpio.h | 2 +- 1 file changed, 1 insertion(+), 1

Re: [PATCH V4 16/43] pci: skip reset during cpr

2025-06-04 Thread Cédric Le Goater
On 6/4/25 09:09, Cédric Le Goater wrote: On 6/2/25 14:36, Steven Sistare wrote: On 6/1/2025 3:07 PM, Michael S. Tsirkin wrote: On Sun, Jun 01, 2025 at 06:38:43PM +0200, Cédric Le Goater wrote: On 5/29/25 21:24, Steve Sistare wrote: Do not reset a vfio-pci device during CPR. Signed-off-by: St

Re: [PATCH v2 3/5] hw/gpio/aspeed: Fix definition of AspeedGPIOClass

2025-06-04 Thread Cédric Le Goater
On 6/4/25 13:53, Zhenzhong Duan wrote: AspeedGPIOClass's parent is SysBusDeviceClass rather than SysBusDevice. Fixes: 4b7f956862dc ("hw/gpio: Add basic Aspeed GPIO model for AST2400 and AST2500") Suggested-by: David Hildenbrand Signed-off-by: Zhenzhong Duan omg. This is super old ... versio

Re: [PATCH v2 2/5] virtio-pmem: Fix definition of VirtIOPMEMClass

2025-06-04 Thread David Hildenbrand
On 04.06.25 13:53, Zhenzhong Duan wrote: VirtIOPMEMClass's parent is VirtioDeviceClass rather than VirtIODevice. Fixes: 5f503cd9f388 ("virtio-pmem: add virtio device") Suggested-by: David Hildenbrand Reported-by: might be better, with Closes: linking to my mail Signed-off-by: Zhenzhong Du

[PATCH 2/4] block-coroutine-wrapper: mark generated co-wrapper as GRAPH_UNLOCKED

2025-06-04 Thread Fiona Ebner
Generated co-wrappers poll, so they need to be called with the graph unlocked. Signed-off-by: Fiona Ebner --- Unfortunately, it's not clear how to achieve something similar for the mixed wrappers, which would've caught the issue fixed in the following patch. scripts/block-coroutine-wrapper.py

[PATCH 1/4] block/graph-lock: fix typo in comment

2025-06-04 Thread Fiona Ebner
Signed-off-by: Fiona Ebner --- include/block/graph-lock.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/block/graph-lock.h b/include/block/graph-lock.h index 2c26c72108..67c8d04867 100644 --- a/include/block/graph-lock.h +++ b/include/block/graph-lock.h @@ -169,7 +16

[PATCH 3/4] block: make calling bdrv_refresh_limits() safe while holding graph lock

2025-06-04 Thread Fiona Ebner
The bdrv_refresh_limits() function and driver implementations are called with the graph lock held. The implementation for the 'compress' filter calls bdrv_get_info(), which is a generated coroutine wrapper and thus polls. This can lead to a deadlock when issuing a blockdev-snapshot QMP command, whe

[PATCH 4/4] iotests: add test for snapshot on top of node with compress filter

2025-06-04 Thread Fiona Ebner
Signed-off-by: Fiona Ebner --- tests/qemu-iotests/085 | 18 ++ tests/qemu-iotests/085.out | 21 + 2 files changed, 39 insertions(+) diff --git a/tests/qemu-iotests/085 b/tests/qemu-iotests/085 index 3fb7b0b5c8..5063e3e8d2 100755 --- a/tests/qemu-iotests/08

Re: [PATCH v3 0/4] VFIO and IOMMU prerequisite stuff for IOMMU nesting support

2025-06-04 Thread Jason Gunthorpe
On Wed, Jun 04, 2025 at 08:59:37AM +0200, Cédric Le Goater wrote: > b4 complained for a couple of trailers : He re-reviewed patches he contributed to making :) > Reviewed-by: Nicolin Chen (✗ DKIM/nvidia.com) But why do you have an X? The messages are properly formed leaving the nvidia serv

Re: [PATCH 3/4] block: make calling bdrv_refresh_limits() safe while holding graph lock

2025-06-04 Thread Klaus Jensen
On Jun 4 14:07, Fiona Ebner wrote: > The bdrv_refresh_limits() function and driver implementations are > called with the graph lock held. The implementation for the 'compress' > filter calls bdrv_get_info(), which is a generated coroutine wrapper > and thus polls. This can lead to a deadlock when

Re: [PATCH v3 0/4] VFIO and IOMMU prerequisite stuff for IOMMU nesting support

2025-06-04 Thread Cédric Le Goater
On 6/4/25 14:08, Jason Gunthorpe wrote: On Wed, Jun 04, 2025 at 08:59:37AM +0200, Cédric Le Goater wrote: b4 complained for a couple of trailers : He re-reviewed patches he contributed to making :) Reviewed-by: Nicolin Chen (✗ DKIM/nvidia.com) But why do you have an X? The messages

Re: [PATCH v3 0/4] VFIO and IOMMU prerequisite stuff for IOMMU nesting support

2025-06-04 Thread Jason Gunthorpe
On Wed, Jun 04, 2025 at 02:20:23PM +0200, Cédric Le Goater wrote: > NOTE: some trailers ignored due to from/email mismatches: > ! Trailer: Reviewed-by: Nicolin Chen > Msg From: Nicolin Chen via Oh this is some some mailman dysfunction causing this :( mailman starts mangling messages wh

Re: [PATCH] iotests: fix 240

2025-06-04 Thread Kevin Wolf
Am 29.05.2025 um 22:31 hat Stefan Hajnoczi geschrieben: > Commit 2e8e18c2e463 ("virtio-scsi: add iothread-vq-mapping parameter") > removed the limitation that virtio-scsi devices must successfully set > the AioContext on their BlockBackends. This was made possible thanks to > the QEMU multi-queue b

Re: [PATCH v2 2/5] virtio-pmem: Fix definition of VirtIOPMEMClass

2025-06-04 Thread Philippe Mathieu-Daudé
On 4/6/25 13:53, Zhenzhong Duan wrote: VirtIOPMEMClass's parent is VirtioDeviceClass rather than VirtIODevice. Fixes: 5f503cd9f388 ("virtio-pmem: add virtio device") Suggested-by: David Hildenbrand Signed-off-by: Zhenzhong Duan --- include/hw/virtio/virtio-pmem.h | 2 +- 1 file changed, 1 i

Re: [PATCH v3 3/3] docs: define policy forbidding use of AI code generators

2025-06-04 Thread Yan Vugenfirer
On Wed, Jun 4, 2025 at 12:23 PM Daniel P. Berrangé wrote: > On Wed, Jun 04, 2025 at 10:58:38AM +0200, Markus Armbruster wrote: > > Daniel P. Berrangé writes: > > > > > On Wed, Jun 04, 2025 at 08:17:27AM +0200, Markus Armbruster wrote: > > >> Stefan Hajnoczi writes: > > >> > > >> > On Tue, Jun 3

Re: [PATCH v2 3/5] hw/gpio/aspeed: Fix definition of AspeedGPIOClass

2025-06-04 Thread Philippe Mathieu-Daudé
On 4/6/25 13:53, Zhenzhong Duan wrote: AspeedGPIOClass's parent is SysBusDeviceClass rather than SysBusDevice. Fixes: 4b7f956862dc ("hw/gpio: Add basic Aspeed GPIO model for AST2400 and AST2500") Suggested-by: David Hildenbrand Signed-off-by: Zhenzhong Duan --- include/hw/gpio/aspeed_gpio.h

  1   2   3   >