>-----Original Message----- >From: David Hildenbrand <da...@redhat.com> >Subject: Re: [PATCH] virtio-mem: Fix definition of VirtIOMEMClass > >On 04.06.25 10:47, Zhenzhong Duan wrote: >> Parent of VirtIOMEMClass is VirtioDeviceClass rather than VirtIODevice. >> >> Fixes: 910b25766b33 ("virtio-mem: Paravirtualized memory hot(un)plug") >> Signed-off-by: Zhenzhong Duan <zhenzhong.d...@intel.com> >> --- >> include/hw/virtio/virtio-mem.h | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/include/hw/virtio/virtio-mem.h b/include/hw/virtio/virtio-mem.h >> index bc4f787772..93fdf9e432 100644 >> --- a/include/hw/virtio/virtio-mem.h >> +++ b/include/hw/virtio/virtio-mem.h >> @@ -134,7 +134,7 @@ struct VirtioMemSystemReset { >> >> struct VirtIOMEMClass { >> /* private */ >> - VirtIODevice parent; >> + VirtioDeviceClass parent; > >Reviewed-by: David Hildenbrand <da...@redhat.com> > >I assume it's not currently a real problem because VirtIODevice is >bigger than VirtioDeviceClass?
Yes, that's why we missed it. > >Or are you aware of any existing problems with that? No. Zhenzhong