Re: [PATCH v3 07/14] arm/cpu: Store aa64dfr0/1 into the idregs array

2025-03-11 Thread Richard Henderson
On 3/11/25 09:28, Cornelia Huck wrote: From: Eric Auger Signed-off-by: Eric Auger Signed-off-by: Cornelia Huck --- target/arm/cpu-features.h | 16 target/arm/cpu.c | 15 +-- target/arm/cpu.h | 2 -- target/arm/cpu64.c| 4 ++-- target

Re: [PATCH v3 06/14] arm/cpu: Store aa64mmfr0-3 into the idregs array

2025-03-11 Thread Richard Henderson
On 3/11/25 09:28, Cornelia Huck wrote: From: Eric Auger Signed-off-by: Eric Auger Signed-off-by: Cornelia Huck --- target/arm/cpu-features.h | 74 +++ target/arm/cpu.h | 4 --- target/arm/cpu64.c| 8 ++--- target/arm/helper.c | 8

Re: [PATCH v2] vfio: Add property documentation

2025-03-11 Thread Cédric Le Goater
On 3/11/25 17:44, Joao Martins wrote: On 05/03/2025 13:13, Cédric Le Goater wrote: Joao, On 3/5/25 12:16, Joao Martins wrote: On 14/02/2025 13:05, Cédric Le Goater wrote: +Kirti +Joao On 2/13/25 22:45, Alex Williamson wrote: + +    /* + * Migration support + */ +    object_class_pro

Re: [PATCH v2] hw/rtc: Add RTC PCF8563 module

2025-03-11 Thread Ilya Chichkov
Hi Phil and Bernhard, I would like to apologize for not including you in the initial email regarding the RTC PCF8563 patch. This was an oversight on my part, and I regret any inconvenience this may have caused. От: Ilya Chichkov Отправлено: 10 марта 2025 г. 14:

Re: [PATCH 04/12] rust: timer: wrap QEMUTimer with Opaque<> and express pinning requirements

2025-03-11 Thread Paolo Bonzini
On 3/4/25 10:13, Zhao Liu wrote: -const fn as_mut_ptr(&self) -> *mut Self { -self as *const Timer as *mut _ +/// Create a `Timer` struct without initializing it. +/// +/// # Safety +/// +/// The timer must be initialized before it is armed with +/// [`modify`](

Re: [PATCH v2 6/6] hw/riscv: microchip_pfsoc: Rework documentation

2025-03-11 Thread Alistair Francis
On Tue, Feb 25, 2025 at 10:55 AM Sebastian Huber wrote: > > Mention that running the HSS no longer works. Document the changed boot > options. Reorder documentation blocks. Update URLs. > > Signed-off-by: Sebastian Huber Acked-by: Alistair Francis Alistair > --- > docs/system/riscv/microc

[PATCH v3 09/63] docs/qapi-domain: add compatibility node classes

2025-03-11 Thread John Snow
Sphinx prior to v4.0 uses different classes for rendering elements of documentation objects; add some compatibility classes to use the right node classes conditionally. Signed-off-by: John Snow --- docs/sphinx/compat.py | 17 - 1 file changed, 16 insertions(+), 1 deletion(-) dif

Re: [PATCH] pci-ids.rst: Add Red Hat pci-id for AMD IOMMU device

2025-03-11 Thread Suthikulpanit, Suravee
On 3/9/2025 8:44 PM, Michael S. Tsirkin wrote: On Tue, Mar 04, 2025 at 06:37:47PM +, Suravee Suthikulpanit wrote: The QEMU-emulated AMD IOMMU PCI device is implemented based on the AMD I/O Virtualization Technology (IOMMU) Specification [1]. The PCI id for this device is platform-specific

[PATCH 15/16] system/memory: make compilation unit common

2025-03-11 Thread Pierrick Bouvier
Signed-off-by: Pierrick Bouvier --- system/memory.c| 22 +++--- system/meson.build | 2 +- 2 files changed, 16 insertions(+), 8 deletions(-) diff --git a/system/memory.c b/system/memory.c index 4c829793a0a..b401be8b5f1 100644 --- a/system/memory.c +++ b/system/memory.c @@ -3

Re: [PATCH v5 8/8] ppc/pnv: Update skiboot to support Power11

2025-03-11 Thread Aditya Gupta
On 11/03/25 14:09, Nicholas Piggin wrote: On Tue Mar 11, 2025 at 1:33 AM AEST, Cédric Le Goater wrote: On 3/10/25 15:59, Aditya Gupta wrote: On 10/03/25 17:15, Cédric Le Goater wrote: On 3/10/25 11:31, Aditya Gupta wrote: <...snip...>   pc-bios/skiboot.lid | Bin 2527328 -> 2527424 bytes  

Re: [PATCH v7 5/5] migration: add MULTIFD_RECV_SYNC migration command

2025-03-11 Thread Prasad Pandit
Hi, On Tue, 11 Mar 2025 at 01:28, Fabiano Rosas wrote: > They occur when cleanup code is allowed to run when resources have not > yet been allocated or while the resources are still being accessed. > > Having the shutdown routine at a single point when it's clear everything > else is ready for sh

[PATCH v2 1/6] 9pfs: local : Introduce local_fid_fd() helper

2025-03-11 Thread Greg Kurz
Factor out duplicated code to a single helper. More users to come. Signed-off-by: Greg Kurz v2: - simplified local_fid_fd() --- hw/9pfs/9p-local.c | 23 ++- 1 file changed, 10 insertions(+), 13 deletions(-) diff --git a/hw/9pfs/9p-local.c b/hw/9pfs/9p-local.c index 928523af

[PATCH v2 3/6] 9pfs: Introduce ftruncate file op

2025-03-11 Thread Greg Kurz
Add an ftruncate operation to the fs driver and use if when a fid has a valid file descriptor. This is required to support more cases where the client wants to do an action on an unlinked file which it still has an open file decriptor for. Only 9P2000.L was considered. Reviewed-by: Christian Scho

[PATCH v2 4/6] 9pfs: Introduce futimens file op

2025-03-11 Thread Greg Kurz
Add an futimens operation to the fs driver and use if when a fid has a valid file descriptor. This is required to support more cases where the client wants to do an action on an unlinked file which it still has an open file decriptor for. Only 9P2000.L was considered. Reviewed-by: Christian Schoe

[PATCH v2 0/6] 9pfs: Fix ftruncate-after-unlink

2025-03-11 Thread Greg Kurz
QEMU 9.2 already fixed the long standing limitation of failing fstat() on unlinked files. This series does something similar for ftruncate(). The following program can be straced inside the guest with a shared fs in passthrough mode over 9p2000.L. int main(void) { struct stat st;

[PATCH v2 2/6] 9pfs: Don't use file descriptors in core code

2025-03-11 Thread Greg Kurz
v9fs_getattr() currently peeks into V9fsFidOpenState to know if a fid has a valid file descriptor or directory stream. Even though the fields are accessible, this is an implementation detail of the local backend that should not be manipulated directly by the server code. Abstract that with a new h

[PATCH v2 5/6] tests/9p: add 'Tsetattr' request to test client

2025-03-11 Thread Greg Kurz
From: Christian Schoenebeck Add and implement functions to 9pfs test client for sending a 9p2000.L 'Tsetattr' request and receiving its 'Rsetattr' response counterpart. Signed-off-by: Christian Schoenebeck Signed-off-by: Greg Kurz --- tests/qtest/libqos/virtio-9p-client.c | 49 +++

Re: [PATCH v2] vfio: Add property documentation

2025-03-11 Thread Joao Martins
On 11/03/2025 17:43, Cédric Le Goater wrote: > On 3/11/25 17:44, Joao Martins wrote: >> On 05/03/2025 13:13, Cédric Le Goater wrote: >>> Joao, >>> >>> On 3/5/25 12:16, Joao Martins wrote: On 14/02/2025 13:05, Cédric Le Goater wrote: > +Kirti > +Joao > > On 2/13/25 22:45, Alex W

[PATCH] vfio/pci: Drop debug comentary from x-device-dirty-page-tracking

2025-03-11 Thread Joao Martins
The intent behind the x-device-dirty-page-tracking option is twofold: 1) development/testing in the presence of VFs with VF dirty page tracking 2) deliberately choosing platform dirty tracker over the VF one. Item 2) scenario is useful when VF dirty tracker is not as fast as IOMMU, or there's so

Re: [PATCH v3 09/14] arm/cpu: Store id_isar0-7 into the idregs array

2025-03-11 Thread Richard Henderson
On 3/11/25 09:28, Cornelia Huck wrote: From: Eric Auger Signed-off-by: Eric Auger Signed-off-by: Cornelia Huck --- hw/intc/armv7m_nvic.c | 12 ++-- target/arm/cpu-features.h | 36 +- target/arm/cpu.c | 24 +++ target/arm/cpu.h | 7 -- target/arm/cpu64

Re: [PATCH v3 08/14] arm/cpu: Store aa64smfr0 into the idregs array

2025-03-11 Thread Richard Henderson
On 3/11/25 09:28, Cornelia Huck wrote: From: Eric Auger Signed-off-by: Eric Auger Signed-off-by: Cornelia Huck --- target/arm/cpu-features.h | 6 +++--- target/arm/cpu.h | 1 - target/arm/cpu64.c| 7 ++- target/arm/helper.c | 2 +- target/arm/kvm.c | 3 +

Re: [PATCH v2 04/16] exec/memory_ldst_phys: extract memory_ldst_phys declarations from cpu-all.h

2025-03-11 Thread Richard Henderson
On 3/10/25 21:08, Pierrick Bouvier wrote: They are now accessible through exec/memory.h instead, and we make sure all variants are available for common or target dependent code. Move stl_phys_notdirty function as well. Cached endianness agnostic version rely on st/ld*_p, which is available throu

[PATCH 3/4] 9pfs: Introduce ftruncate file op

2025-03-11 Thread Greg Kurz
Add an ftruncate operation to the fs driver and use if when a fid has a valid file descriptor. This is required to support more cases where the client wants to do an action on an unlinked file which it still has an open file decriptor for. Only 9P2000.L was considered. Signed-off-by: Greg Kurz -

Re: [PATCH v5 14/14] hw/sd/sdhci: Remove unnecessary 'endianness' property

2025-03-11 Thread Guenter Roeck
On 3/10/25 08:27, Philippe Mathieu-Daudé wrote: On 10/3/25 15:09, BALATON Zoltan wrote: On Mon, 10 Mar 2025, Philippe Mathieu-Daudé wrote: The previous commit removed the single use of instance setting the "endianness" property. Since classes can register their io_ops with correct endianness,

[PULL 49/54] target/riscv: Declare RISCVCPUClass::misa_mxl_max as RISCVMXL

2025-03-11 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Message-Id: <20250210133134.90879-5-phi...@linaro.org> --- target/riscv/cpu.h | 2 +- target/riscv/cpu.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/target/riscv/cpu.h b/target/riscv/cpu.h index 616c3

[PATCH 08/16] gdbstub: Expose GDBRegisterState

2025-03-11 Thread Mario Fleischmann
Signed-off-by: Mario Fleischmann --- gdbstub/gdbstub.c | 7 --- include/exec/gdbstub.h | 8 +++- 2 files changed, 7 insertions(+), 8 deletions(-) diff --git a/gdbstub/gdbstub.c b/gdbstub/gdbstub.c index 282e13e163..8166510f06 100644 --- a/gdbstub/gdbstub.c +++ b/gdbstub/gdbstub.c @@

Re: [PATCH v2 05/16] exec/memory.h: make devend_memop "target defines" agnostic

2025-03-11 Thread Richard Henderson
On 3/10/25 21:08, Pierrick Bouvier wrote: Will allow to make system/memory.c common later. Signed-off-by: Pierrick Bouvier --- include/exec/memory.h | 16 1 file changed, 4 insertions(+), 12 deletions(-) Reviewed-by: Richard Henderson r~ diff --git a/include/exec/mem

Re: [PATCH v2 03/16] exec/memory_ldst: extract memory_ldst declarations from cpu-all.h

2025-03-11 Thread Richard Henderson
On 3/10/25 21:08, Pierrick Bouvier wrote: They are now accessible through exec/memory.h instead, and we make sure all variants are available for common or target dependent code. Signed-off-by: Pierrick Bouvier --- include/exec/cpu-all.h | 12 include/exec/memory_ldst.h.in

Re: [PATCH v4] spapr: nested: Add support for reporting Hostwide state counter

2025-03-11 Thread Harsh Prateek Bora
On 2/21/25 21:24, Vaibhav Jain wrote: Add support for reporting Hostwide state counters for nested KVM pseries guests running with 'cap-nested-papr' on Qemu-TCG acting as L0-hypervisor. The Hostwide state counters are statistics about state that L0-hypervisor maintains for the L2-guests and re

Re: [PATCH v2 18/18] hw/rtc: Add Ricoh RS5C372 RTC emulation

2025-03-11 Thread Bernhard Beschow
Am 7. März 2025 19:18:34 UTC schrieb Bernhard Beschow : > > >Am 4. März 2025 18:53:10 UTC schrieb Bernhard Beschow : >> >> >>Am 23. Februar 2025 11:47:08 UTC schrieb Bernhard Beschow : >>>The implementation just allows Linux to determine date and time. >>> >>>Signed-off-by: Bernhard Beschow >>>

Re: [PATCH v2 12/14] pnv/xive: Support ESB Escalation

2025-03-11 Thread Nicholas Piggin
On Tue Dec 10, 2024 at 10:05 AM AEST, Michael Kowal wrote: > From: Glenn Miles > > END notification processing has an escalation path. The escalation is > not always an END escalation but can be an ESB escalation. > > Also added a check for 'resume' processing which log a message stating it > nee

[PATCH v3 1/4] hw/s390x/skeys: Declare QOM types using DEFINE_TYPES() macro

2025-03-11 Thread Philippe Mathieu-Daudé
When multiple QOM types are registered in the same file, it is simpler to use the the DEFINE_TYPES() macro. In particular because type array declared with such macro are easier to review. Signed-off-by: Philippe Mathieu-Daudé --- hw/s390x/s390-skeys.c | 39 +--

Re: [PATCH v3 10/14] arm/cpu: Store id_pfr0/1/2 into the idregs array

2025-03-11 Thread Richard Henderson
On 3/11/25 09:28, Cornelia Huck wrote: From: Eric Auger Signed-off-by: Eric Auger Signed-off-by: Cornelia Huck --- hw/intc/armv7m_nvic.c | 5 +- target/arm/cpu-features.h | 10 ++-- target/arm/cpu.c | 8 +-- target/arm/cpu.h | 3 - target/arm/cpu64.c|

Re: [PATCH v3 11/14] arm/cpu: Store id_dfr0/1 into the idregs array

2025-03-11 Thread Richard Henderson
On 3/11/25 09:28, Cornelia Huck wrote: From: Eric Auger Signed-off-by: Eric Auger Signed-off-by: Cornelia Huck --- hw/intc/armv7m_nvic.c | 2 +- target/arm/cpu-features.h | 16 target/arm/cpu.c | 13 + target/arm/cpu.h | 2 -- target/arm

Re: [PATCH v3 12/14] arm/cpu: Store id_mmfr0-5 into the idregs array

2025-03-11 Thread Richard Henderson
On 3/11/25 09:28, Cornelia Huck wrote: From: Eric Auger Signed-off-by: Eric Auger Signed-off-by: Cornelia Huck --- hw/intc/armv7m_nvic.c | 8 ++-- target/arm/cpu-features.h | 18 target/arm/cpu.h | 6 --- target/arm/cpu64.c| 16 +++ target/arm/helper.c

[PATCH v11 04/10] virtio-gpu: Support asynchronous fencing

2025-03-11 Thread Dmitry Osipenko
Support asynchronous fencing feature of virglrenderer. It allows Qemu to handle fence as soon as it's signalled instead of periodically polling the fence status. This feature is required for enabling DRM context support in Qemu because legacy fencing mode isn't supported for DRM contexts in virglre

Re: [PATCH v2 3/3] qapi/machine: Make @dump-skeys command generic

2025-03-11 Thread Daniel P . Berrangé
On Mon, Mar 10, 2025 at 02:31:18PM +0100, Philippe Mathieu-Daudé wrote: > Reduce misc-target.json by one target specific command. > > Signed-off-by: Philippe Mathieu-Daudé > --- > qapi/machine.json | 18 ++ > qapi/misc-target.json | 19 --- > hw/core

Re: [PATCH v2 02/16] exec/tswap: implement {ld,st}.*_p as functions instead of macros

2025-03-11 Thread Richard Henderson
On 3/10/25 21:08, Pierrick Bouvier wrote: Defining functions allows to use them from common code, by not depending on TARGET_BIG_ENDIAN. Remove previous macros from exec/cpu-all.h. By moving them out of cpu-all.h, we'll be able to break dependency on cpu.h for memory related functions coming in n

Re: [RFC PATCH 04/18] qemu: Introduce 'qemu/legacy_binary_info.h'

2025-03-11 Thread Thomas Huth
On 05/03/2025 17.59, Pierrick Bouvier wrote: On 3/5/25 07:39, Philippe Mathieu-Daudé wrote: Introduce an API to get information specific to a binary from the binary name (argv[0]). Initialize it from qemu_init() on system emulation. What we want here is more a include/qemu/target_info.h, whi

Re: [PATCH v3 00/63] docs: Add new QAPI transmogrifier

2025-03-11 Thread Markus Armbruster
John Snow writes: > This series is a "minimum viable" version of the new QAPI documentation > system. It does the bare minimum under the new framework, saving the > fancy features like the inliner for later. This version does add > cross-references for all QAPI definitions and a shiny new QAPI In

Re: [PATCH v2 14/16] include/exec/memory: extract devend_big_endian from devend_memop

2025-03-11 Thread Richard Henderson
On 3/10/25 21:08, Pierrick Bouvier wrote: we'll use it in system/memory.c. Signed-off-by: Pierrick Bouvier --- include/exec/memory.h | 18 -- 1 file changed, 12 insertions(+), 6 deletions(-) Reviewed-by: Richard Henderson r~

[PULL 14/14] hw/sd/sdhci: Remove need for SDHCI_VENDOR_FSL definition

2025-03-11 Thread Philippe Mathieu-Daudé
All instances of TYPE_IMX_USDHC set vendor=SDHCI_VENDOR_IMX. No need to special-case it. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: BALATON Zoltan Reviewed-by: Bernhard Beschow Message-Id: <20250308213640.13138-3-phi...@linaro.org> --- include/hw/sd/sdhci.h | 1 - hw/arm/fsl-imx25.c

[PULL 12/14] hw/virtio/virtio-mem: Remove CONFIG_DEVICES include

2025-03-11 Thread Philippe Mathieu-Daudé
Rather than checking ACPI availability at compile time by checking the CONFIG_ACPI definition from CONFIG_DEVICES, check at runtime via acpi_builtin(). Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: David Hildenbrand Reviewed-by: Pierrick Bouvier Message-Id: <20250307223949.54040-5-phi...@l

[PULL 04/14] hw/net/smc91c111: Sanitize packet length on tx

2025-03-11 Thread Philippe Mathieu-Daudé
From: Peter Maydell When the smc91c111 transmits a packet, it must read a control byte which is at the end of the data area and CRC. However, we don't sanitize the length field in the packet buffer, so if the guest sets the length field to something large we will try to read past the end of the

[PULL 01/14] hw/sd/sdhci: Set reset value of interrupt registers

2025-03-11 Thread Philippe Mathieu-Daudé
From: BALATON Zoltan The interrupt enable registers are not reset to 0 on Freescale eSDHC but some bits are enabled on reset. At least some U-Boot versions seem to expect this and not initialise these registers before expecting interrupts. Use existing vendor property for Freescale eSDHC and set

[PULL 10/14] hw/acpi: Introduce acpi_builtin() helper

2025-03-11 Thread Philippe Mathieu-Daudé
acpi_builtin() can be used to check at runtime whether the ACPI subsystem is built in a qemu-system binary. Reviewed-by: Ani Sinha Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20250307223949.54040-3-phi...@linaro.org> --- include/hw/acpi/acpi.h | 3 +++ hw/acpi/acpi-stub.c| 5 + h

Re: [PATCH v2] QIOChannelSocket: Flush zerocopy socket error queue on ENOBUF failure for sendmsg

2025-03-11 Thread Peter Xu
On Tue, Mar 11, 2025 at 03:33:23PM +, Daniel P. Berrangé wrote: > On Tue, Mar 11, 2025 at 11:20:50AM -0400, Peter Xu wrote: > > On Tue, Mar 11, 2025 at 08:13:16AM +, Daniel P. Berrangé wrote: > > > On Mon, Mar 10, 2025 at 04:03:26PM -0400, Peter Xu wrote: > > > > On Mon, Mar 10, 2025 at 07:

Re: [PATCH 2/2] vfio/migration: Use BE byte order for device state wire packets

2025-03-11 Thread Maciej S. Szmigiero
On 10.03.2025 10:23, Cédric Le Goater wrote: On 3/10/25 09:17, Avihai Horon wrote: On 07/03/2025 12:57, Maciej S. Szmigiero wrote: External email: Use caution opening links or attachments From: "Maciej S. Szmigiero" Wire data commonly use BE byte order (including in the existing migration

Re: [PATCH v2 0/5] Building PPTT with root node and identical implementation flag

2025-03-11 Thread Alireza Sanaee via
On Thu, 6 Mar 2025 02:33:37 + Alireza Sanaee via wrote: Hi everyone, v1 -> v2: I just rebased this patchset which initially was posted in Sep 2024. Thanks, Alireza > OS like Linux is using PPTT processor node's identical implementation > flag [1] to infer whether the whole system or a cert

[PATCH v3 01/17] exec/tswap: target code can use TARGET_BIG_ENDIAN instead of target_words_bigendian()

2025-03-11 Thread Pierrick Bouvier
Reviewed-by: Richard Henderson Signed-off-by: Pierrick Bouvier --- include/exec/tswap.h | 11 ++- cpu-target.c | 1 + 2 files changed, 7 insertions(+), 5 deletions(-) diff --git a/include/exec/tswap.h b/include/exec/tswap.h index ecd4faef015..2683da0adb7 100644 --- a/include/ex

Re: [PATCH 03/16] include: move target_words_bigendian() from tswap to bswap

2025-03-11 Thread Richard Henderson
On 3/9/25 21:58, Pierrick Bouvier wrote: This is needed for next commits (especially when implementing st/ld primitives which will use this function). As well, remove reference to TARGET_BIG_ENDIAN, as we are about to remove this dependency. Where is the TARGET_BIG_ENDIAN reference being remove

[PATCH 16/16] system/ioport: make compilation unit common

2025-03-11 Thread Pierrick Bouvier
Signed-off-by: Pierrick Bouvier --- system/ioport.c| 1 - system/meson.build | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/system/ioport.c b/system/ioport.c index 55c2a752396..89daae9d602 100644 --- a/system/ioport.c +++ b/system/ioport.c @@ -26,7 +26,6 @@ */ #inc

[PATCH 04/10] linux-user/arm: Remove unused get_put_user macros

2025-03-11 Thread Peter Maydell
In linux-user/arm/cpu_loop.c we define a full set of get/put macros for both code and data (since the endianness handling is different between the two). However the only one we actually use is get_user_code_u32(). Remove the rest. We leave a comment noting how data-side accesses should be handled

From ce9a42483c23c32cee233f648101a160b6604b45 Mon Sep 17 00:00:00 2001

2025-03-11 Thread Peter Maydell
Newer Arm CPUs need not implement AArch32 at all exception levels (and Armv9 forbids implementing AArch32 at any EL except EL0). All our current CPU models implement both AArch32 and AArch64 at every exception levels, so we currently get away with failing to enforce that the guest isn't trying to d

[PULL 06/14] hw/net/smc91c111: Don't allow data register access to overrun buffer

2025-03-11 Thread Philippe Mathieu-Daudé
From: Peter Maydell For accesses to the 91c111 data register, the address within the packet's data frame is determined by a combination of the pointer register and the offset used to access the data register, so that you can access data at effectively wider than byte width. The pointer register'

[PULL 08/14] system: Extract target-specific globals to their own compilation unit

2025-03-11 Thread Philippe Mathieu-Daudé
We shouldn't use target specific globals for machine properties. These ones could be desugarized, as explained in [*]. While certainly doable, not trivial nor my priority for now. Just move them to a different file to clarify they are *globals*, like the generic globals residing in system/globals.c

[PULL 07/14] hw/xen/hvm: Fix Aarch64 typo

2025-03-11 Thread Philippe Mathieu-Daudé
There is no TARGET_ARM_64 definition. Luckily enough, when TARGET_AARCH64 is defined, TARGET_ARM also is. Fixes: 733766cd373 ("hw/arm: introduce xenpvh machine") Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Pierrick Bouvier Reviewed-by: Richard Henderson Message-Id: <20250305153929.43687-

[PATCH v3 04/17] exec/memory_ldst_phys: extract memory_ldst_phys declarations from cpu-all.h

2025-03-11 Thread Pierrick Bouvier
They are now accessible through exec/memory.h instead, and we make sure all variants are available for common or target dependent code. Move stl_phys_notdirty function as well. Cached endianness agnostic version rely on st/ld*_p, which is available through tswap.h. Reviewed-by: Richard Henderson

[PATCH v3 03/17] exec/memory_ldst: extract memory_ldst declarations from cpu-all.h

2025-03-11 Thread Pierrick Bouvier
They are now accessible through exec/memory.h instead, and we make sure all variants are available for common or target dependent code. Reviewed-by: Richard Henderson Signed-off-by: Pierrick Bouvier --- include/exec/cpu-all.h | 12 include/exec/memory_ldst.h.inc | 4

[PATCH v3 17/17] system/ioport: make compilation unit common

2025-03-11 Thread Pierrick Bouvier
Reviewed-by: Richard Henderson Signed-off-by: Pierrick Bouvier --- system/ioport.c| 1 - system/meson.build | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/system/ioport.c b/system/ioport.c index 55c2a752396..89daae9d602 100644 --- a/system/ioport.c +++ b/system/ioport.

[PATCH v3 05/17] exec/memory.h: make devend_memop "target defines" agnostic

2025-03-11 Thread Pierrick Bouvier
Will allow to make system/memory.c common later. Reviewed-by: Richard Henderson Signed-off-by: Pierrick Bouvier --- include/exec/memory.h | 16 1 file changed, 4 insertions(+), 12 deletions(-) diff --git a/include/exec/memory.h b/include/exec/memory.h index da21e9150b5..069021

[PATCH v3 00/17] make system memory API available for common code

2025-03-11 Thread Pierrick Bouvier
The main goal of this series is to be able to call any memory ld/st function from code that is *not* target dependent. As a positive side effect, we can turn related system compilation units into common code. The first 5 patches remove dependency of memory API to cpu headers and remove dependency

[PATCH v3 02/17] exec/tswap: implement {ld, st}.*_p as functions instead of macros

2025-03-11 Thread Pierrick Bouvier
Defining functions allows to use them from common code, by not depending on TARGET_BIG_ENDIAN. Remove previous macros from exec/cpu-all.h. By moving them out of cpu-all.h, we'll be able to break dependency on cpu.h for memory related functions coming in next commits. Reviewed-by: Richard Henderson

[PATCH v3 08/17] exec/memory-internal: remove dependency on cpu.h

2025-03-11 Thread Pierrick Bouvier
Needed so compilation units including it can be common. Reviewed-by: Richard Henderson Signed-off-by: Pierrick Bouvier --- include/exec/memory-internal.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/include/exec/memory-internal.h b/include/exec/memory-internal.h index 100c1237ac2..b729f

Re: [RFC PATCH v2 03/20] hw/arm/smmuv3-accel: Add initial infrastructure for smmuv3-accel device

2025-03-11 Thread Nicolin Chen
On Tue, Mar 11, 2025 at 02:10:28PM +, Shameer Kolothum wrote: > +/* > + * Copyright (c) 2025 Huawei Technologies R & D (UK) Ltd > + * Copyright (C) 2025 NVIDIA + * Copyright (C) 2025 NVIDIA CORPORATION & AFFILIATES > + * Written by Nicolin Chen, Shameer Kolothum (Thanks for adding my name!)

Re: [PATCH 2/5] block/io: Ignore FUA with cache.no-flush=on

2025-03-11 Thread Stefan Hajnoczi
On Fri, Mar 07, 2025 at 11:16:31PM +0100, Kevin Wolf wrote: > For block drivers that don't advertise FUA support, we already call > bdrv_co_flush(), which considers BDRV_O_NO_FLUSH. However, drivers that > do support FUA still see the FUA flag with BDRV_O_NO_FLUSH and get the > associated performan

[PULL 07/61] docs/qapi-domain: add compatibility node classes

2025-03-11 Thread Markus Armbruster
From: John Snow Sphinx prior to v4.0 uses different classes for rendering elements of documentation objects; add some compatibility classes to use the right node classes conditionally. Signed-off-by: John Snow Message-ID: <20250311034303.75779-10-js...@redhat.com> Acked-by: Markus Armbruster S

Re: [PATCH v5 25/29] tests/functional/aspeed: Introduce start_ast2700_test API

2025-03-11 Thread Cédric Le Goater
On 3/6/25 11:38, Jamin Lin wrote: Added a new method "start_ast2700_test" to the "AST2x00MachineSDK" class and this method centralizes the logic for starting the AST2700 test, making it reusable for different test cases. Signed-off-by: Jamin Lin Reviewed-by: Cédric Le Goater Thanks, C.

[PATCH 06/16] mcd: Implement core connection control

2025-03-11 Thread Mario Fleischmann
In MCD, core-specific operations require an open connection to the core. This commit implements the necessary operations to open and close the connection to cores. Signed-off-by: Mario Fleischmann --- mcd/mcdserver.c | 176 --- mcd/mcdstub_qapi.c| 11

[PULL 53/54] system: Open-code qemu_init_arch_modules() using target_name()

2025-03-11 Thread Philippe Mathieu-Daudé
Mostly revert commit c80cafa0c73 ("system: Add qemu_init_arch_modules") but using target_name() instead of the target specific 'TARGET_NAME' definition. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Message-Id: <20250305005225.95051-3-phi...@linaro.org> --- include/system

Re: [PATCH 11/16] system/kvm: make kvm_flush_coalesced_mmio_buffer() accessible for common code

2025-03-11 Thread Richard Henderson
On 3/9/25 21:58, Pierrick Bouvier wrote: This function is used by system/physmem.c will be turn into common code in next commit. Signed-off-by: Pierrick Bouvier --- include/system/kvm.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) Reviewed-by: Richard Henderson r~

[PATCH-for-10.0 v3 2/8] hw/vfio/spapr: Do not include

2025-03-11 Thread Philippe Mathieu-Daudé
is already included by "system/kvm.h" in the next line. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Pierrick Bouvier Reviewed-by: Richard Henderson Reviewed-by: Cédric Le Goater Reviewed-by: Eric Auger Message-Id: <20250307180337.14811-3-phi...@linaro.org> --- hw/vfio/spapr.c | 3 ---

Re: [PATCH v3 07/10] vfio/igd: Decouple common quirks from legacy mode

2025-03-11 Thread Tomita Moeko
On 2025/3/10 15:13, Cédric Le Goater wrote: > Tomita, > > On 3/7/25 19:37, Tomita Moeko wrote: >> On 2025/3/7 6:49, Alex Williamson wrote: >>> On Fri,  7 Mar 2025 02:01:27 +0800 >>> Tomita Moeko wrote: >>> So far, IGD-specific quirks all require enabling legacy mode, which is toggled by

Re: [PATCH v3 54/63] docs/qapidoc: implement transmogrify() method

2025-03-11 Thread Markus Armbruster
John Snow writes: > This is the true top-level processor for the new transmogrifier; > responsible both for generating the intermediate rST and then running > the nested parse on that generated document to produce the final > docutils tree that is then - very finally - postprocessed by sphinx for

[PATCH v9 04/10] virtio-gpu: Support asynchronous fencing

2025-03-11 Thread Dmitry Osipenko
Support asynchronous fencing feature of virglrenderer. It allows Qemu to handle fence as soon as it's signalled instead of periodically polling the fence status. This feature is required for enabling DRM context support in Qemu because legacy fencing mode isn't supported for DRM contexts in virglre

[PATCH v3 10/17] system/kvm: make kvm_flush_coalesced_mmio_buffer() accessible for common code

2025-03-11 Thread Pierrick Bouvier
This function is used by system/physmem.c will be turn into common code in next commit. Reviewed-by: Richard Henderson Signed-off-by: Pierrick Bouvier --- include/system/kvm.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/include/system/kvm.h b/include/system/kvm.h i

[PATCH v3 07/17] exec/exec-all: remove dependency on cpu.h

2025-03-11 Thread Pierrick Bouvier
Previous commit changed files relying transitively on it. Reviewed-by: Richard Henderson Signed-off-by: Pierrick Bouvier --- include/exec/exec-all.h | 1 - 1 file changed, 1 deletion(-) diff --git a/include/exec/exec-all.h b/include/exec/exec-all.h index dd5c40f2233..19b0eda44a7 100644 --- a/i

Re: [RFC PATCH v2 08/20] hw/arm/smmuv3-accel: Provide get_address_space callback

2025-03-11 Thread Nicolin Chen
On Tue, Mar 11, 2025 at 02:10:33PM +, Shameer Kolothum wrote: > diff --git a/include/hw/arm/smmuv3-accel.h b/include/hw/arm/smmuv3-accel.h > index 56fe376bf4..86c0523063 100644 > --- a/include/hw/arm/smmuv3-accel.h > +++ b/include/hw/arm/smmuv3-accel.h > @@ -16,6 +16,10 @@ > #define TYPE_ARM_S

Re: [PATCH 01/16] exec/memory_ldst: extract memory_ldst declarations from cpu-all.h

2025-03-11 Thread Pierrick Bouvier
On 3/10/25 08:17, Richard Henderson wrote: On 3/9/25 21:58, Pierrick Bouvier wrote: They are now accessible through exec/memory.h instead, and we make sure all variants are available for common or target dependent code. ... diff --git a/include/exec/memory_ldst.h.inc b/include/exec/memory_ldst

[PATCH 1/5] hw/intc/loongarch_ipi: Add reset support

2025-03-11 Thread Bibo Mao
Add reset support with ipi object, register reset callback and clear internal registers when virt machine resets. Signed-off-by: Bibo Mao --- hw/intc/loongarch_ipi.c | 29 + include/hw/intc/loongarch_ipi.h | 1 + 2 files changed, 30 insertions(+) diff --git

[PULL 01/10] docs/about/build-platforms: Correct minimum supported Python version

2025-03-11 Thread Markus Armbruster
Fixes: ca056f4499c2 (Python: Drop support for Python 3.7) Signed-off-by: Markus Armbruster Message-ID: <20250227080757.3978333-2-arm...@redhat.com> Reviewed-by: Daniel P. Berrangé --- docs/about/build-platforms.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/about/bu

Re: [v5,1/6] hw/misc/aspeed_scu: Skipping dram_init in u-boot

2025-03-11 Thread Cédric Le Goater
Nabih, On 3/6/25 01:04, Nabih Estefan wrote: Setting BIT6 in VGA0 SCRATCH register will indicate that the ddr traning is done, therefore skipping the u-boot-spl dram_init() process. Signed-off-by: Jamin Lin Signed-off-by: Troy Lee Reviewed-by: Cédric Le Goater Tested-by: Nabih Estefan Th

[PULL 08/61] docs/qapi-domain: Add QAPIDescription abstract class

2025-03-11 Thread Markus Armbruster
From: John Snow This class is a generic, top-level directive for documenting some kind of QAPI thingamajig that we expect to go into the Index. This class doesn't do much by itself, and it isn't yet associated with any particular directive. handle_signature(), _object_hierarchy_parts() and _toc_

[PATCH 13/16] mcd: Implement register/memory access

2025-03-11 Thread Mario Fleischmann
In MCD, all accesses to register or memory are issued over transaction lists. This commit implements three types of transactions: * register access * logical memory access (with MMU) * physical memory access (no MMU) Signed-off-by: Mario Fleischmann --- mcd/libmcd_qapi.c | 128

Re: [PATCH 00/16] make system memory API available for common code

2025-03-11 Thread Pierrick Bouvier
Hi Zoltan, On 3/10/25 06:23, BALATON Zoltan wrote: On Sun, 9 Mar 2025, Pierrick Bouvier wrote: The main goal of this series is to be able to call any memory ld/st function from code that is *not* target dependent. Why is that needed? this series belongs to the "single binary" topic, where

RE: [PATCH 31/38] target/hexagon: Add {TLB, k0}lock, cause code, wait_next_pc

2025-03-11 Thread ltaylorsimpson
> -Original Message- > From: Brian Cain > Sent: Friday, February 28, 2025 11:26 PM > To: qemu-devel@nongnu.org > Cc: brian.c...@oss.qualcomm.com; richard.hender...@linaro.org; > phi...@linaro.org; quic_mathb...@quicinc.com; a...@rev.ng; a...@rev.ng; > quic_mlie...@quicinc.com; ltaylorsi

RE: [PATCH 32/38] target/hexagon: Add stubs for modify_ssr/get_exe_mode

2025-03-11 Thread ltaylorsimpson
> -Original Message- > From: Brian Cain > Sent: Friday, February 28, 2025 11:26 PM > To: qemu-devel@nongnu.org > Cc: brian.c...@oss.qualcomm.com; richard.hender...@linaro.org; > phi...@linaro.org; quic_mathb...@quicinc.com; a...@rev.ng; a...@rev.ng; > quic_mlie...@quicinc.com; ltaylorsi

RE: [PATCH 30/38] target/hexagon: Add a TLB count property

2025-03-11 Thread ltaylorsimpson
> -Original Message- > From: Brian Cain > Sent: Friday, February 28, 2025 11:26 PM > To: qemu-devel@nongnu.org > Cc: brian.c...@oss.qualcomm.com; richard.hender...@linaro.org; > phi...@linaro.org; quic_mathb...@quicinc.com; a...@rev.ng; a...@rev.ng; > quic_mlie...@quicinc.com; ltaylorsi

[PATCH] target/i386: Fix #GP error code for INT instructions

2025-03-11 Thread Andrew Cooper
While the (intno << shift) expression is correct for indexing the IDT based on whether Long Mode is active, the error code itself was unchanged with AMD64, and is still the index with 3 bits of metadata in the bottom. Found when running a Xen unit test, all under QEMU. The unit test objected to b

Re: [PATCH v2 08/10] target/i386/kvm: reset AMD PMU registers during VM reset

2025-03-11 Thread Dongli Zhang
Hi Zhao, On 3/11/25 6:51 AM, Zhao Liu wrote: > Hi Dongli, > +/* + * If KVM_CAP_PMU_CAPABILITY is not supported, there is no way to + * disable the AMD pmu virtualization. + * + * If KVM_CAP_PMU_CAPABILITY is supported !cpu->enable_pmu + * indi

[PULL 05/14] hw/net/smc91c111: Use MAX_PACKET_SIZE instead of magic numbers

2025-03-11 Thread Philippe Mathieu-Daudé
From: Peter Maydell Now we have a constant for the maximum packet size, we can use it to replace various hardcoded 2048 values. Signed-off-by: Peter Maydell Reviewed-by: Philippe Mathieu-Daudé Message-ID: <20250228174802.1945417-4-peter.mayd...@linaro.org> Signed-off-by: Philippe Mathieu-Daudé

[PULL 1/3] xen/passthrough: use gsi to map pirq when dom0 is PVH

2025-03-11 Thread Anthony PERARD
From: Jiqian Chen In PVH dom0, when passthrough a device to domU, QEMU code xen_pt_realize->xc_physdev_map_pirq wants to use gsi, but in current codes the gsi number is got from file /sys/bus/pci/devices//irq, that is wrong, because irq is not equal with gsi, they are in different spaces, so pirq

[PATCH v8 4/6] hw/acpi/aml-build.c: add cache hierarchy to pptt table

2025-03-11 Thread Alireza Sanaee via
Add cache topology to PPTT table. With this patch, both ACPI PPTT table and device tree will represent the same cache topology given users input. Signed-off-by: Alireza Sanaee Co-developed-by: Jonathan Cameron Signed-off-by: Jonathan Cameron --- hw/acpi/aml-build.c| 205 +++

[PULL 00/14] Misc HW patches for 2025-03-11

2025-03-11 Thread Philippe Mathieu-Daudé
gs/hw-misc-20250311 for you to fetch changes up to a5368f2e00c81c8c2b5dd0318293b11f8ed7c7c8: hw/sd/sdhci: Remove need for SDHCI_VENDOR_FSL definition (2025-03-11 20:03:30 +0100) Misc HW patches - Set correct values for MPC8569E'

[PULL 09/14] system: Replace arch_type global by qemu_arch_available() helper

2025-03-11 Thread Philippe Mathieu-Daudé
qemu_arch_available() is a bit simpler to understand while reviewing than the undocumented arch_type variable. Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20250305005225.95051-5-phi...@linaro.org> --- include/system/arch_init.h | 2 +- hw/scsi/scsi-disk.c

[PULL 03/14] hw/net/smc91c111: Sanitize packet numbers

2025-03-11 Thread Philippe Mathieu-Daudé
From: Peter Maydell The smc91c111 uses packet numbers as an index into its internal s->data[][] array. Valid packet numbers are between 0 and 3, but the code does not generally check this, and there are various places where the guest can hand us an arbitrary packet number and cause an out-of-boun

[PATCH v3 14/17] include/exec/memory: extract devend_big_endian from devend_memop

2025-03-11 Thread Pierrick Bouvier
we'll use it in system/memory.c. Reviewed-by: Richard Henderson Signed-off-by: Pierrick Bouvier --- include/exec/memory.h | 18 -- 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/include/exec/memory.h b/include/exec/memory.h index 069021ac3ff..70177304a92 100644 -

[PATCH v3 11/17] exec/ram_addr: call xen_hvm_modified_memory only if xen is enabled

2025-03-11 Thread Pierrick Bouvier
Reviewed-by: Richard Henderson Signed-off-by: Pierrick Bouvier --- include/exec/ram_addr.h | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/include/exec/ram_addr.h b/include/exec/ram_addr.h index 7c011fadd11..098fccb5835 100644 --- a/include/exec/ram_addr.h +++ b/inclu

Re: [PATCH 11/12] virtio-scsi: add iothread-vq-mapping parameter

2025-03-11 Thread Peter Krempa
On Mon, Mar 10, 2025 at 15:33:02 +0100, Kevin Wolf wrote: > Am 13.02.2025 um 19:00 hat Stefan Hajnoczi geschrieben: > > Allow virtio-scsi virtqueues to be assigned to different IOThreads. This > > makes it possible to take advantage of host multi-queue block layer > > scalability by assigning virtq

Re: [PATCH] pci-ids.rst: Add Red Hat pci-id for AMD IOMMU device

2025-03-11 Thread Jonathan Cameron via
On Tue, 4 Mar 2025 18:37:47 + Suravee Suthikulpanit wrote: > The QEMU-emulated AMD IOMMU PCI device is implemented based on the AMD I/O > Virtualization Technology (IOMMU) Specification [1]. The PCI id for this > device is platform-specific. > > Currently, the QEMU-emulated AMD IOMMU device

<    1   2   3   4   5   6   7   8   >