[PATCH v5] arm/kvm: Enable support for KVM_ARM_VCPU_PMU_V3_FILTER

The KVM_ARM_VCPU_PMU_V3_FILTER provides the ability to let the VMM decide which PMU events are provided to the guest. Add a new option `kvm-pmu-filter` as -cpu sub-option to set the PMU Event Filtering. Without the filter, all PMU events are exposed from host to guest by default. The usage of the n

Re: [RFC PATCH v3 00/30] migration: File based migration with multifd and fixed-ram

On Mon, Jan 15, 2024 at 02:22:47PM +0800, Peter Xu wrote: > On Thu, Jan 11, 2024 at 03:38:31PM -0300, Fabiano Rosas wrote: > > Peter Xu writes: > > > > > On Mon, Nov 27, 2023 at 05:25:42PM -0300, Fabiano Rosas wrote: > > >> Hi, > > >> > > >> In this v3: > > >> > > >> Added support for the "file

Re: [PATCH] tests/qtest/meson.build: Bump the boot-serial-test timeout to 4 minutes

On Mon, Jan 15, 2024 at 08:11:46AM +0100, Thomas Huth wrote: > When running with TCI, the boot-serial-test can take longer than 3 minutes: > > https://gitlab.com/qemu-project/qemu/-/jobs/5890481086#L4774 > > Bump the timeout to 4 minutes to avoid CI failures here. > > Signed-off-by: Thomas Huth

RE: Possible race condition in aspeed ast2600 smp boot on TCG QEMU

Hi Stephen and Cedric, This issue haven't been found in real platform but sometime happens in emulator, e.g. Simic. > Adding Aspeed Engineers. This reminds me of a discussion a while ago. > > On 1/11/24 18:38, Stephen Longfield wrote: > > We’ve noticed inconsistent behavior when running a large

Re: [RFC PATCH v3 00/30] migration: File based migration with multifd and fixed-ram

On Mon, Jan 15, 2024 at 08:11:40AM +, Daniel P. Berrangé wrote: > On Mon, Jan 15, 2024 at 02:22:47PM +0800, Peter Xu wrote: > > On Thu, Jan 11, 2024 at 03:38:31PM -0300, Fabiano Rosas wrote: > > > Peter Xu writes: > > > > > > > On Mon, Nov 27, 2023 at 05:25:42PM -0300, Fabiano Rosas wrote: >

[PATCH] target/loongarch: Set cpuid CSR register only once with kvm mode

CSR cpuid register is used for routing irq to different vcpus, its value is kept unchanged since poweron. So it is not necessary to set CSR cpuid register after system resets, and it is only set at vm creation stage. Signed-off-by: Bibo Mao --- target/loongarch/kvm/kvm.c | 9 ++--- 1 file ch

Re: [RFC PATCH v3 04/30] io: fsync before closing a file channel

On Thu, Jan 11, 2024 at 03:46:02PM -0300, Fabiano Rosas wrote: > > (2) Why metadata doesn't matter (v.s. fsync(), when CONFIG_FDATASYNC=y)? > > Syncing the inode information is not critical, it's mostly timestamp > information (man inode). And fdatasync makes sure to sync any metadata > that would

Re: [RFC PATCH v3 07/30] migration: Add fixed-ram URI compatibility check

On Mon, Nov 27, 2023 at 05:25:49PM -0300, Fabiano Rosas wrote: > The fixed-ram migration format needs a channel that supports seeking > to be able to write each page to an arbitrary offset in the migration > stream. > > Signed-off-by: Fabiano Rosas > Reviewed-by: Daniel P. Berrangé > --- > - avo

Re: [RFC PATCH v3 04/30] io: fsync before closing a file channel

On Mon, Jan 15, 2024 at 04:57:42PM +0800, Peter Xu wrote: > On Thu, Jan 11, 2024 at 03:46:02PM -0300, Fabiano Rosas wrote: > > > (2) Why metadata doesn't matter (v.s. fsync(), when CONFIG_FDATASYNC=y)? > > > > Syncing the inode information is not critical, it's mostly timestamp > > information (ma

Re: [PATCH v7 08/16] i386: Expose module level in CPUID[0x1F]

On Mon, Jan 15, 2024 at 03:20:37PM +0800, Zhao Liu wrote: > On Mon, Jan 15, 2024 at 02:57:30PM +0800, Yuan Yao wrote: > > Date: Mon, 15 Jan 2024 14:57:30 +0800 > > From: Yuan Yao > > Subject: Re: [PATCH v7 08/16] i386: Expose module level in CPUID[0x1F] > > > > On Mon, Jan 15, 2024 at 02:20:20PM +

Re: [PATCH 03/12] tests/plugin: add test plugin for inline operations

Pierrick Bouvier writes: > On 1/13/24 21:16, Alex Bennée wrote: >> Pierrick Bouvier writes: >> >>> On 1/12/24 21:20, Alex Bennée wrote: Pierrick Bouvier writes: > On 1/11/24 19:57, Philippe Mathieu-Daudé wrote: >> Hi Pierrick, >> On 11/1/24 15:23, Pierrick Bouvier wrote:

Re: [PATCH 00/33] hw/cpu/arm: Remove one use of qemu_get_cpu() in A7/A15 MPCore priv

On 1/12/24 20:54, Fabiano Rosas wrote: Cédric Le Goater writes: On 1/10/24 14:19, Fabiano Rosas wrote: Markus Armbruster writes: Peter Xu writes: On Tue, Jan 09, 2024 at 10:22:31PM +0100, Philippe Mathieu-Daudé wrote: Hi Fabiano, On 9/1/24 21:21, Fabiano Rosas wrote: Cédric Le Goater

[PATCH 0/2] i386/cpu: Two minor fixes for x86_cpu_enable_xsave_components()

The two bugs were introduced when xsaves feature was added by commit 301e90675c3f ("target/i386: Enable support for XSAVES based features"). Xiaoyao Li (2): i386/cpu: Clear FEAT_XSAVE_XSS_LO/HI leafs when CPUID_EXT_XSAVE is not available i386/cpu: Mask with XCR0/XSS mask for FEAT_XSAVE_XCR

[PATCH 1/2] i386/cpu: Clear FEAT_XSAVE_XSS_LO/HI leafs when CPUID_EXT_XSAVE is not available

Leaf FEAT_XSAVE_XSS_LO and FEAT_XSAVE_XSS_HI also need to be cleared when CPUID_EXT_XSAVE is not set. Fixes: 301e90675c3f ("target/i386: Enable support for XSAVES based features") Signed-off-by: Xiaoyao Li --- target/i386/cpu.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/target/i386/cp

[PATCH 2/2] i386/cpu: Mask with XCR0/XSS mask for FEAT_XSAVE_XCR0_HI and FEAT_XSAVE_XSS_HI leafs

The value of FEAT_XSAVE_XCR0_HI leaf and FEAT_XSAVE_XSS_HI leaf also need to be masked by XCR0 and XSS mask respectively, to make it logically correct. Fixes: 301e90675c3f ("target/i386: Enable support for XSAVES based features") Signed-off-by: Xiaoyao Li --- target/i386/cpu.c | 4 ++-- 1 file c

[PATCH v3] load_elf: fix iterator's type for elf file processing

j is used while loading an ELF file to byteswap segments' data. If data is larger than 2GB an overflow may happen. So j should be elf_word. This commit fixes a minor bug, maybe even a typo. Found by Linux Verification Center (linuxtesting.org) with SVACE. Fixes: 7ef295ea5b ("loader: Add data swa

Re: [RFC PATCH v3 08/30] migration/ram: Add outgoing 'fixed-ram' migration

On Mon, Nov 27, 2023 at 05:25:50PM -0300, Fabiano Rosas wrote: > From: Nikolay Borisov > > Implement the outgoing migration side for the 'fixed-ram' capability. > > A bitmap is introduced to track which pages have been written in the > migration file. Pages are written at a fixed location for ev

Re: [RFC PATCH v3 04/30] io: fsync before closing a file channel

On Mon, Jan 15, 2024 at 09:03:20AM +, Daniel P. Berrangé wrote: > On Mon, Jan 15, 2024 at 04:57:42PM +0800, Peter Xu wrote: > > On Thu, Jan 11, 2024 at 03:46:02PM -0300, Fabiano Rosas wrote: > > > > (2) Why metadata doesn't matter (v.s. fsync(), when CONFIG_FDATASYNC=y)? > > > > > > Syncing th

[PATCH 10/11] hw/core: Cleanup unused included headers in numa.c

From: Zhao Liu Remove unused header in numa.c: * sysemu/hostmem.h * exec/cpu-common.h * exec/ramlist.h * qemu/bitmap.h * hw/core/cpu.h * hw/mem/pc-dimm.h * migration/vmstate.h Though sysemu/numa.h has been included by sysemu/hostmem.h which is included by hw/boards.h, to keep the dependency clea

[PATCH 00/11] hw/core: Cleanup and reorder headers

From: Zhao Liu Identify unused headers by full compilation (tested by "./configure" and then "make") and reorder headers in alphabetical order. In addition, update a file entry in MAINTAINERS file. Zhao Liu (11): MAINTAINERS: Update hw/core/cpu.c entry hw/core: Cleanup unused included heade

[PATCH 07/11] hw/core: Reorder included header in machine.c

From: Zhao Liu Reorder the header files (except qemu/osdep.h) in alphabetical order. Tested by "./configure" and then "make". Signed-off-by: Zhao Liu --- hw/core/machine.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/hw/core/machine.c b/hw/core/ma

[PATCH 01/11] MAINTAINERS: Update hw/core/cpu.c entry

From: Zhao Liu The hw/core/cpu.c was split as hw/core/cpu-common.c and hw/core/cpu-sysemu.c in the commit df4fd7d5c8a3 ("cpu: Split as cpu-common / cpu-sysemu"). Update the related entry. Signed-off-by: Zhao Liu --- MAINTAINERS | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --g

[PATCH 05/11] hw/core: Cleanup unused included headers in machine-qmp-cmds.c

From: Zhao Liu Remove unused headers in machine-qmp-cmds.c: * qemu/main-loop.h * qemu/uuid.h * sysemu/hostmem.h Tested by "./configure" and then "make". Signed-off-by: Zhao Liu --- hw/core/machine-qmp-cmds.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/hw/core/machin

[PATCH 04/11] hw/core: Reorder included headers in cpu-sysemu.c

From: Zhao Liu Reorder the header files (except qemu/osdep.h) in alphabetical order. Tested by "./configure" and then "make". Signed-off-by: Zhao Liu --- hw/core/cpu-sysemu.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/core/cpu-sysemu.c b/hw/core/cpu-sysemu.c inde

[PATCH 02/11] hw/core: Cleanup unused included headers in cpu-common.c

From: Zhao Liu Remove unused headers in cpu-common.c: * qemu/notify.h * qemu/log.h * qemu/main-loop.h * exec/cpu-common.h * qemu/error-report.h * qemu/qemu-print.h Though hw/core/cpu.h has been included by sysemu/hw_accel.h, to keep the dependency clear, still directly include hw/core/cpu.h in t

[PATCH 11/11] hw/core: Reorder included headers in numa.c

From: Zhao Liu Reorder the header files (except qemu/osdep.h) in alphabetical order. Tested by "./configure" and then "make". Signed-off-by: Zhao Liu --- hw/core/numa.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/hw/core/numa.c b/hw/core/numa.c index ab3f2

[PATCH 08/11] hw/core: Cleanup unnecessary included header in null-machine.c

From: Zhao Liu Remove the unnecessary header (hw/core/cpu.h) since the hw/boards.h has already included that header. Signed-off-by: Zhao Liu --- hw/core/null-machine.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/core/null-machine.c b/hw/core/null-machine.c index f586

[PATCH 03/11] hw/core: Reorder included headers in cpu-common.c

From: Zhao Liu Reorder the header files (except qemu/osdep.h) in alphabetical order. Tested by "./configure" and then "make". Signed-off-by: Zhao Liu --- hw/core/cpu-common.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/hw/core/cpu-common.c b/hw/core/cpu-comm

[PATCH 09/11] hw/core: Reorder included headers in null-machine.c

From: Zhao Liu Reorder the header files (except qemu/osdep.h) in alphabetical order. Tested by "./configure" and then "make". Signed-off-by: Zhao Liu --- hw/core/null-machine.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/core/null-machine.c b/hw/core/null-machin

[PATCH 06/11] hw/core: Cleanup unused included header in machine.c

From: Zhao Liu Remove unused header in cpu-common.c: * qapi/error.h Tested by "./configure" and then "make". Signed-off-by: Zhao Liu --- hw/core/machine.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/core/machine.c b/hw/core/machine.c index fb5afdcae4cc..554c4f5df2da

Re: [RFC PATCH v3 09/30] migration/ram: Add incoming 'fixed-ram' migration

On Mon, Nov 27, 2023 at 05:25:51PM -0300, Fabiano Rosas wrote: > Add the necessary code to parse the format changes for the 'fixed-ram' > capability. > > One of the more notable changes in behavior is that in the 'fixed-ram' > case ram pages are restored in one go rather than constantly looping >

[PATCH] ui: reject extended clipboard message if not activated

The extended clipboard message protocol requires that the client activate the extension by requesting a psuedo encoding. If this is not done, then any extended clipboard messages from the client should be considered invalid and the client dropped. Signed-off-by: Daniel P. Berrangé --- The need f

Re: [PATCH] linux-user/riscv: Fix sizeof_reg typo in vdso unwind info

On 12/1/24 23:03, Richard Henderson wrote: Fixes: 468c1bb5ca ("linux-user/riscv: Add vdso") Reported-by: Vineet Gupta Signed-off-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé --- linux-user/riscv/vdso-32.so | Bin 2900 -> 2900 bytes linux-user/riscv/vdso-64.so | Bin 3856 -

Re: [PATCH 0/2] Added the ability to delegate LCOFI to VS

This functionality turns out to have already been added by commit 40336d5b1d4c6b8b8b38c77fda254457d44fe90b Vadim От: Alistair Francis Отправлено: 4 января 2024 г. 6:54:27 Кому: Vadim Shakirov Копия: qemu-devel@nongnu.org; Palmer Dabbelt; Alistair Francis; Bin Me

Re: [RFC PATCH v3 10/30] tests/qtest: migration-test: Add tests for fixed-ram file-based migration

On Mon, Nov 27, 2023 at 05:25:52PM -0300, Fabiano Rosas wrote: > From: Nikolay Borisov > > Add basic tests for 'fixed-ram' migration. > > Signed-off-by: Nikolay Borisov > Signed-off-by: Fabiano Rosas Reviewed-by: Peter Xu -- Peter Xu

Re: [PATCH] ui: reject extended clipboard message if not activated

On Mon, Jan 15, 2024 at 1:52 PM Daniel P. Berrangé wrote: > > The extended clipboard message protocol requires that the client > activate the extension by requesting a psuedo encoding. If this > is not done, then any extended clipboard messages from the client > should be considered invalid and th

Re: [PATCH 1/2] gitlab: Introduce Loongarch64 runner

在 2024/1/12 下午5:52, gaosong 写道: 在 2024/1/11 下午4:26, Thomas Huth 写道: On 11/01/2024 08.25, gaosong wrote: Hi, 在 2024/1/11 下午3:08, Thomas Huth 写道: On 02/01/2024 18.22, Philippe Mathieu-Daudé wrote: Full build config to run CI tests on a Loongarch64 host. Forks might enable this by setting LOON

[PATCH rfcv1 0/6] Check and sync host IOMMU cap/ecap with vIOMMU

Hi, This introduces a framework for vIOMMU to get hw IOMMU cap/ecap information through IOMMUFD interface and check or sync with vIOMMU's own cap/ecap config. This framework works by having device side, i.e. VFIO, register a IOMMUFDDevice to vIOMMU, IOMMUFDDevice includes necessary data to archiv

[PATCH rfcv1 2/6] hw/pci: introduce pci_device_set/unset_iommu_device()

From: Yi Liu This adds pci_device_set/unset_iommu_device() to set/unset IOMMUFDDevice for a given PCIe device. Caller of set should fail if set operation fails. Extract out pci_device_get_iommu_bus_devfn() to facilitate implementation of pci_device_set/unset_iommu_device(). Signed-off-by: Yi Li

[PATCH rfcv1 1/6] backends/iommufd_device: introduce IOMMUFDDevice

IOMMUFDDevice represents a device in iommufd and can be used as a communication interface between devices (i.e., VFIO, VDPA) and vIOMMU. Currently it includes iommufd handler and device id information which could be used by vIOMMU to get hw IOMMU information. In future nested translation support,

[PATCH rfcv1 3/6] intel_iommu: add set/unset_iommu_device callback

From: Yi Liu This adds set/unset_iommu_device() implementation in Intel vIOMMU. In set call, IOMMUFDDevice is recorded in hash table indexed by PCI BDF. Signed-off-by: Yi Liu Signed-off-by: Yi Sun Signed-off-by: Zhenzhong Duan --- include/hw/i386/intel_iommu.h | 10 + hw/i386/intel_iommu

[PATCH rfcv1 4/6] vfio: initialize IOMMUFDDevice and pass to vIOMMU

Initialize IOMMUFDDevice in vfio and pass to vIOMMU, so that vIOMMU could get hw IOMMU information. In VFIO legacy backend mode, we still pass a NULL IOMMUFDDevice to vIOMMU, in case vIOMMU needs some processing for VFIO legacy backend mode. Originally-by: Yi Liu Signed-off-by: Nicolin Chen Sig

[PATCH rfcv1 5/6] intel_iommu: extract out vtd_cap_init to initialize cap/ecap

This is a prerequisite for host cap/ecap sync. No functional change intended. Signed-off-by: Zhenzhong Duan --- hw/i386/intel_iommu.c | 92 +++ 1 file changed, 50 insertions(+), 42 deletions(-) diff --git a/hw/i386/intel_iommu.c b/hw/i386/intel_iommu.c i

[PATCH rfcv1 6/6] intel_iommu: add a framework to check and sync host IOMMU cap/ecap

From: Yi Liu Add a framework to check and synchronize host IOMMU cap/ecap with vIOMMU cap/ecap. Currently only stage-2 translation is supported which is backed by shadow page table on host side. So we don't need exact matching of each bit of cap/ecap between vIOMMU and host. However, we can stil

Re: [PATCH 0/6] net: fix non-deterministic failures of the 'netdev-socket' qtest

On Mon, 15 Jan 2024 at 02:37, Jason Wang wrote: > > On Fri, Jan 5, 2024 at 12:45 AM Stefan Hajnoczi wrote: > > > > On Thu, 4 Jan 2024 at 11:30, Daniel P. Berrangé wrote: > > > > > > We've previously bumped up the timeouts in the netdev-socket qtest > > > to supposedly fix non-deterministic failu

Re: Re: Re: [PULL 0/6] Firmware/edk2 20231213 patches

Hi, > PS: when are we likely to be able to update to a proper released > EDK2 ? Running with a git snapshot isn't ideal, so if we can > move to an EDK2 release version within this QEMU cycle that would > be nice. Next release should be tagged by end of February, so if the qemu 9.0 schedule is s

Re: [PATCH V2] Handle wrap around in limit calculation

On Mon, 15 Jan 2024 at 05:58, Shlomo Pongratz wrote: > > Thank you. > Please see comments inline. > > On Fri, Jan 12, 2024 at 7:03 PM Peter Maydell > wrote: > > > > On Tue, 9 Jan 2024 at 12:45, Shlomo Pongratz > > wrote: > > > > Hi; thanks for this patch. > > > > > Hanlde wrap around caused by

[PATCH rfcv1 03/23] backends/iommufd_device: introduce IOMMUFDDevice targeted interface

With IOMMUFDDevice passed to vIOMMU, we can query hw IOMMU information and allocate hwpt for a device, but still need an extensible interface for vIOMMU usage. This introduces an IOMMUFDDevice targeted interface for vIOMMU. Currently this interface includes two callbacks attach_hwpt/detach_hwpt fo

[PATCH rfcv1 05/23] intel_iommu: add a placeholder variable for scalable modern mode

Add an new element scalable_mode in IntelIOMMUState to mark scalable modern mode, this element will be exposed as an intel_iommu property finally. For now, it's only a placehholder and used for cap/ecap initialization, parameter compatibility check, etc. No need to zero this element separately as

[PATCH rfcv1 10/23] intel_iommu: bind/unbind guest page table to host

This captures the guest PASID table entry modifications and propagates the changes to host to attach a hwpt with type determined per guest PGTT configuration. When PGTT is Pass-through(100b), the hwpt on host side is a stage-2 page table(GPA->HPA). When PGTT is First-stage Translation only(001b),

[PATCH rfcv1 09/23] vfio/iommufd_device: Add ioas_id in IOMMUFDDevice and pass to vIOMMU

Sometimes vIOMMU needs to re-attach device to ioas id of vfio, i.e., when vIOMMU is disabled by guest. This is a prerequisite patch for following one. Signed-off-by: Zhenzhong Duan --- include/sysemu/iommufd_device.h | 3 ++- backends/iommufd_device.c | 3 ++- hw/vfio/iommufd.c

[PATCH rfcv1 06/23] intel_iommu: check and sync host IOMMU cap/ecap in scalable modern mode

When vIOMMU is configured in scalable modern mode, stage-1 page table is supported. We need to check and sync host side cap/ecap with vIOMMU cap/ecap. This happens when PCIe device (i.e., VFIO case) sets IOMMUFDDevice to vIOMMU. Some of the bits in cap/ecap is user controllable, then user setting

[PATCH rfcv1 02/23] backends/iommufd: add helpers for allocating user-managed HWPT

Include helper to allocate user-managed hwpt and helper for cache invalidation as user-managed HWPT needs to sync cache per modifications. Signed-off-by: Nicolin Chen Signed-off-by: Zhenzhong Duan --- include/sysemu/iommufd.h | 7 + backends/iommufd.c | 61 +++

[PATCH rfcv1 04/23] vfio: implement IOMMUFDDevice interface callbacks

Implement IOMMUFDDevice interface callbacks attach_hwpt/detach_hwpt for vIOMMU usage. vIOMMU utilizes them to attach to or detach from hwpt on host side. Signed-off-by: Yi Liu Signed-off-by: Zhenzhong Duan --- hw/vfio/iommufd.c | 36 +++- 1 file changed, 35 inser

[PATCH rfcv1 20/23] intel_iommu: piotlb invalidation should notify unmap

From: Yi Sun This is used by some emulated devices which caches address translation result. When piotlb invalidation issued in guest, those caches should be refreshed. Signed-off-by: Yi Sun Signed-off-by: Zhenzhong Duan --- hw/i386/intel_iommu.c | 56 ++

[PATCH rfcv1 23/23] intel_iommu: modify x-scalable-mode to be string option

From: Yi Liu Intel VT-d 3.0 introduces scalable mode, and it has a bunch of capabilities related to scalable mode translation, thus there are multiple combinations. While this vIOMMU implementation wants to simplify it for user by providing typical combinations. User could config it by "x-scalabl

[PATCH rfcv1 17/23] intel_iommu: implement firt level translation

From: Yi Liu This adds stage-1 page table walking to support stage-1 only transltion in scalable mode. Signed-off-by: Yi Liu Signed-off-by: Yi Sun Signed-off-by: Zhenzhong Duan --- hw/i386/intel_iommu_internal.h | 16 +++ hw/i386/intel_iommu.c | 242

[PATCH rfcv1 11/23] intel_iommu: ERRATA_772415 workaround

On a system influenced by ERRATA_772415, IOMMU_HW_INFO_VTD_ERRATA_772415_SPR17 is repored by IOMMU_DEVICE_GET_HW_INFO. Due to this errata, even the readonly range mapped on stage-2 page table could still be written. Reference from 4th Gen Intel Xeon Processor Scalable Family Specification Update,

[PATCH rfcv1 12/23] intel_iommu: replay pasid binds after context cache invalidation

From: Yi Liu This replays guest pasid attachments after context cache invalidation. This is a behavior to ensure safety. Actually, programmer should issue pasid cache invalidation with proper granularity after issuing a context cache invalidation. Signed-off-by: Yi Liu Signed-off-by: Yi Sun Si

[PATCH rfcv1 22/23] intel_iommu: refresh pasid bind after pasid cache force reset

From: Yi Liu The force reset clears the vtd_pasid_as and also unbinds the pasid on host side. This is bad when the reset is triggered after some pasid binding is setup. e.g. gcmd.TE enabling will reset cache, but wishes to keep the pasid #0 (gIOVA) binding. So needs to refresh the pasid bind per

[PATCH rfcv1 19/23] intel_iommu: introduce pasid iotlb cache

From: Yi Liu To accelerate stage-1 translation, introduce pasid iotlb cache. Signed-off-by: Yi Liu Signed-off-by: Yi Sun Signed-off-by: Zhenzhong Duan --- hw/i386/intel_iommu_internal.h | 1 + include/hw/i386/intel_iommu.h | 1 + hw/i386/intel_iommu.c | 126

[PATCH rfcv1 15/23] intel_iommu: process PASID-based Device-TLB invalidation

From: Yi Liu This adds an empty handling for PASID-based Device-TLB invalidation. For now it is enough as it is not necessary to propagate it to host for passthrough device. The reason for an empty device tlb invalidation handling is that iommufd's intel vt-d cache invalidation uapi indicates al

[PATCH rfcv1 18/23] intel_iommu: fix the fault reason report

From: Yu Zhang Currently we use only VTD_FR_PASID_TABLE_INV as fault reaon. Fix this with correct fault reasons listed in VT-d spec 7.2.3. Signed-off-by: Yu Zhang Signed-off-by: Zhenzhong Duan --- hw/i386/intel_iommu_internal.h | 8 ++- hw/i386/intel_iommu.c | 42 +++

[PATCH rfcv1 08/23] intel_iommu: add PASID cache management infrastructure

From: Yi Liu This adds a PASID cache management infrastructure based on new added structure VTDPASIDAddressSpace, which is used to track the PASID usage and future PASID tagged DMA address translation support in vIOMMU. struct VTDPASIDAddressSpace { PCIBus *bus; uint8_t devfn

[PATCH rfcv1 01/23] Update linux header to support nested hwpt alloc

Repo: https://github.com/yiliu1765/iommufd/tree/iommufd_nesting commit id: 7c22f835c4c9b Placeholder, not for upstream. Signed-off-by: Zhenzhong Duan --- include/standard-headers/drm/drm_fourcc.h | 2 + include/standard-headers/linux/fuse.h | 10 +- include/standard-headers/linux

[PATCH rfcv1 14/23] intel_iommu: propagate PASID-based iotlb invalidation to host

From: Yi Liu This traps the guest PASID-based iotlb invalidation request and propagate it to host. Intel VT-d 3.0 supports nested translation in PASID granular. Guest SVA support could be implemented by configuring nested translation on specific PASID. This is also known as dual stage DMA transl

[PATCH rfcv1 16/23] intel_iommu: rename slpte in iotlb_entry to pte

From: Yi Liu Because we support both FST and SST translation, rename slpte in iotlb_entry to pte to make it generic. Signed-off-by: Yi Liu Signed-off-by: Yi Sun Signed-off-by: Zhenzhong Duan --- include/hw/i386/intel_iommu.h | 2 +- hw/i386/intel_iommu.c | 10 +- 2 files cha

[PATCH rfcv1 07/23] intel_iommu: process PASID cache invalidation

From: Yi Liu This adds PASID cache invalidation handling. When guest updated a pasid entry in scalable mode, guest software should issue a proper PASID cache invalidation when caching-mode is exposed. This can happen even when pasid is disabled as rid_pasid will still be used. This only adds a b

[PATCH rfcv1 21/23] intel_iommu: invalidate piotlb when flush pasid

From: Yi Sun When bind/unbind emulated devices, we should invalidate QEMU piotlb. Host will flush piotlb for passthrough devices so we don't handle passthrough devices. Signed-off-by: Yi Sun Signed-off-by: Zhenzhong Duan --- hw/i386/intel_iommu.c | 27 +-- 1 file chang

Re: [PATCH 02/11] hw/core: Cleanup unused included headers in cpu-common.c

On Mon, 15 Jan 2024 at 09:37, Zhao Liu wrote: > > From: Zhao Liu > > Remove unused headers in cpu-common.c: > * qemu/notify.h > * qemu/log.h > * qemu/main-loop.h > * exec/cpu-common.h > * qemu/error-report.h > * qemu/qemu-print.h > > Though hw/core/cpu.h has been included by sysemu/hw_accel.h, to

[PATCH rfcv1 00/23] intel_iommu: Enable stage-1 translation

Hi, This series enables stage-1 translation support in intel iommu which we called "modern" mode. In this mode, we don't do shadowing of guest page table for passthrough device but pass stage-1 page table to host side to construct a nested domain; we also support emulated device by translating the

[PATCH rfcv1 13/23] intel_iommu: process PASID-based iotlb invalidation

From: Yi Liu PASID-based iotlb (piotlb) is used during walking Intel VT-d stage-1 page table. This adds the basic framework for piotlb invalidation, detailed handling will be added in next patch. Signed-off-by: Yi Liu Signed-off-by: Zhenzhong Duan --- hw/i386/intel_iommu_internal.h | 13

Re: [PATCH] ui/clipboard: avoid crash upon request when clipboard peer is not initialized

Am 14.01.24 um 14:51 schrieb Marc-André Lureau: >> >> diff --git a/ui/clipboard.c b/ui/clipboard.c >> index 3d14bffaf8..c13b54d2e9 100644 >> --- a/ui/clipboard.c >> +++ b/ui/clipboard.c >> @@ -129,7 +129,8 @@ void qemu_clipboard_request(QemuClipboardInfo *info, >> if (info->types[type].data ||

Re: [PATCH V2 00/11] allow cpr-reboot for vfio

On 12.01.24 16:04, Steve Sistare wrote: Allow cpr-reboot for vfio if the guest is in the suspended runstate. The guest drivers' suspend methods flush outstanding requests and re-initialize the devices, and thus there is no device state to save and restore. The user is responsible for suspending

Re: [PATCH V2 00/11] allow cpr-reboot for vfio

On 15.01.24 11:48, David Hildenbrand wrote: On 12.01.24 16:04, Steve Sistare wrote: Allow cpr-reboot for vfio if the guest is in the suspended runstate. The guest drivers' suspend methods flush outstanding requests and re-initialize the devices, and thus there is no device state to save and res

Re: [PATCH 1/3] hw/arm: Add EHCI/OHCI controllers to Allwinner R40 and Bananapi board

Hi, On 13/1/24 20:16, Guenter Roeck wrote: Allwinner R40 supports two USB host ports shared between a USB 2.0 EHCI host controller and a USB 1.1 OHCI host controller. Add support for both of them. If machine USB support is not enabled, create unimplemented devices for the USB memory ranges to a

Re: [PATCH 2/3] hw/arm: Add AHCI/SATA controller to Allwinner R40 and Bananapi board

On 13/1/24 20:16, Guenter Roeck wrote: Allwinner R40 supports an AHCI compliant SATA controller. Add support for it. Signed-off-by: Guenter Roeck --- docs/system/arm/bananapi_m2u.rst | 1 + hw/arm/Kconfig | 1 + hw/arm/allwinner-r40.c | 12 +++- includ

Re: [PATCH] virtio-iommu: Use qemu_real_host_page_mask as default page_size_mask

Hi, On 12/21/23 14:45, Eric Auger wrote: > We used to set default page_size_mask to qemu_target_page_mask() but > with VFIO assignment it makes more sense to use the actual host page mask > instead. > > So from now on qemu_real_host_page_mask() will be used as a default. > To be able to migrate ol

Re: [PATCH 1/3] hw/arm: Refactor struct arm_boot_info::get_dtb()

On 15/1/24 05:34, Bin Meng wrote: At present we expect struct arm_boot_info::get_dtb() to return the device tree pointer as well as the device tree size. However, this is not necessary as we can get the device tree size via the device tree header directly. Change get_dtb() signature to drop the *

Re: [PATCH] tests/qtest/npcm7xx_watchdog_timer: Only test the corner cases by default

On 15/1/24 08:02, Thomas Huth wrote: The test_prescaler() part in the npcm7xx_watchdog_timer test is quite repetive, testing all possible combinations of the WTCLK and WTIS bitfields. Since each test spins up a new instance of QEMU, this is rather an expensive test, especially on loaded host syst

Re: [PATCH 01/11] MAINTAINERS: Update hw/core/cpu.c entry

On 15/1/24 10:48, Zhao Liu wrote: From: Zhao Liu The hw/core/cpu.c was split as hw/core/cpu-common.c and hw/core/cpu-sysemu.c in the commit df4fd7d5c8a3 ("cpu: Split as cpu-common / cpu-sysemu"). Update the related entry. Signed-off-by: Zhao Liu --- MAINTAINERS | 3 ++- 1 file changed, 2

Re: [PATCH] ui/clipboard: avoid crash upon request when clipboard peer is not initialized

Hi On Mon, Jan 15, 2024 at 2:45 PM Fiona Ebner wrote: > > Am 14.01.24 um 14:51 schrieb Marc-André Lureau: > >> > >> diff --git a/ui/clipboard.c b/ui/clipboard.c > >> index 3d14bffaf8..c13b54d2e9 100644 > >> --- a/ui/clipboard.c > >> +++ b/ui/clipboard.c > >> @@ -129,7 +129,8 @@ void qemu_clipboar

Re: [PATCH] ui/clipboard: avoid crash upon request when clipboard peer is not initialized

Am 15.01.24 um 12:15 schrieb Marc-André Lureau: > Hi > > On Mon, Jan 15, 2024 at 2:45 PM Fiona Ebner wrote: >> >> Am 14.01.24 um 14:51 schrieb Marc-André Lureau: diff --git a/ui/clipboard.c b/ui/clipboard.c index 3d14bffaf8..c13b54d2e9 100644 --- a/ui/clipboard.c +++ b/ui

Re: [PATCH] tests/qtest/npcm7xx_watchdog_timer: Only test the corner cases by default

Thomas Huth writes: > The test_prescaler() part in the npcm7xx_watchdog_timer test is quite > repetive, testing all possible combinations of the WTCLK and WTIS > bitfields. Since each test spins up a new instance of QEMU, this is > rather an expensive test, especially on loaded host systems. I'm

Re: [PATCH] ui/clipboard: avoid crash upon request when clipboard peer is not initialized

Hi On Mon, Jan 15, 2024 at 3:26 PM Fiona Ebner wrote: > > Am 15.01.24 um 12:15 schrieb Marc-André Lureau: > > Hi > > > > On Mon, Jan 15, 2024 at 2:45 PM Fiona Ebner wrote: > >> > >> Am 14.01.24 um 14:51 schrieb Marc-André Lureau: > > diff --git a/ui/clipboard.c b/ui/clipboard.c >

Re: [PATCH] tests/qtest/npcm7xx_watchdog_timer: Only test the corner cases by default

On 15/01/2024 12.32, Alex Bennée wrote: Thomas Huth writes: The test_prescaler() part in the npcm7xx_watchdog_timer test is quite repetive, testing all possible combinations of the WTCLK and WTIS bitfields. Since each test spins up a new instance of QEMU, this is rather an expensive test, espe

Re: [PATCH 3/3] tests/acpi: Update virt/SSDT.memhp

Bin Meng writes: > The Arm dtb changes caused an address change: > > DefinitionBlock ("", "SSDT", 1, "BOCHS ", "NVDIMM", 0x0001) > { > [ ... ] > -Name (MEMA, 0x43C8) > +Name (MEMA, 0x43D8) > } I'm confused by why this changes. Isn't this declaring the size of a NVDIMM

Re: [PATCH] tests/qtest/npcm7xx_watchdog_timer: Only test the corner cases by default

Thomas Huth writes: > On 15/01/2024 12.32, Alex Bennée wrote: >> Thomas Huth writes: >> >>> The test_prescaler() part in the npcm7xx_watchdog_timer test is quite >>> repetive, testing all possible combinations of the WTCLK and WTIS >>> bitfields. Since each test spins up a new instance of QEMU,

Re: [PATCH] ui/clipboard: avoid crash upon request when clipboard peer is not initialized

Am 15.01.24 um 12:33 schrieb Marc-André Lureau: > Hi > > On Mon, Jan 15, 2024 at 3:26 PM Fiona Ebner wrote: >> >> Am 15.01.24 um 12:15 schrieb Marc-André Lureau: >>> Hi >>> >>> On Mon, Jan 15, 2024 at 2:45 PM Fiona Ebner wrote: Am 14.01.24 um 14:51 schrieb Marc-André Lureau: >> >>>

Re: [RFC PATCH v3 11/30] migration/multifd: Allow multifd without packets

On Mon, Nov 27, 2023 at 05:25:53PM -0300, Fabiano Rosas wrote: > For the upcoming support to the new 'fixed-ram' migration stream > format, we cannot use multifd packets because each write into the > ramblock section in the migration file is expected to contain only the > guest pages. They are writ

Re: [PATCH v2 23/43] target/riscv: Remove misa_mxl validation

Alex Bennée writes: > Alistair Francis writes: > >> On Tue, Jan 9, 2024 at 1:43 AM Alex Bennée wrote: >>> >>> Alex Bennée writes: >>> >>> > From: Akihiko Odaki >>> > >>> > It is initialized with a simple assignment and there is little room for >>> > error. In fact, the validation is even more

Re: [PATCH] ui/clipboard: avoid crash upon request when clipboard peer is not initialized

Hi On Mon, Jan 15, 2024 at 3:48 PM Fiona Ebner wrote: > > Am 15.01.24 um 12:33 schrieb Marc-André Lureau: > > Hi > > > > On Mon, Jan 15, 2024 at 3:26 PM Fiona Ebner wrote: > >> > >> Am 15.01.24 um 12:15 schrieb Marc-André Lureau: > >>> Hi > >>> > >>> On Mon, Jan 15, 2024 at 2:45 PM Fiona Ebner

Re: [RFC PATCH v3 12/30] migration/multifd: Allow QIOTask error reporting without an object

On Mon, Nov 27, 2023 at 05:25:54PM -0300, Fabiano Rosas wrote: > The only way for the channel backend to report an error to the multifd > core during creation is by setting the QIOTask error. We must allow > the channel backend to set the error even if the QIOChannel has failed > to be created, whi

Re: [PATCH v2 01/19] qapi: sort pylint suppressions

John Snow writes: > Suggested-by: Markus Armbruster > Signed-off-by: John Snow > --- > scripts/qapi/pylintrc | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/scripts/qapi/pylintrc b/scripts/qapi/pylintrc > index 90546df5345..78b63af4df6 100644 > --- a/scripts/qapi

Re: [PATCH v2] ppc/pnv: Add QME region for P10

On 7/7/23 22:16, Nicholas Piggin wrote: On Fri Jul 7, 2023 at 5:12 PM AEST, Joel Stanley wrote: The Quad Management Engine (QME) manages power related settings for its quad. The xscom region is separate from the quad xscoms, therefore a new region is added. The xscoms in a QME select a given

Re: [PATCH v4 11/45] Introduce Raspberry PI 4 machine

On Fri, 8 Dec 2023 at 02:33, Sergey Kambalin wrote: > > Signed-off-by: Sergey Kambalin > --- > @@ -329,11 +330,24 @@ void bcm_soc_peripherals_common_realize(DeviceState > *dev, Error **errp) > return; > } > > -if (!object_property_set_uint(OBJECT(&s->fb), "vcram-base", > -

Re: [PATCH v4 12/45] Temporarily disable unimplemented rpi4b devices

On Fri, 8 Dec 2023 at 02:33, Sergey Kambalin wrote: > > This commit adds RPi4B device tree modifications: > - disable pcie, rng200, thermal sensor and genet devices > (they're going to be re-enabled in the following commits) > - create additional memory region in device tree > if RAM amount ex

Re: [PATCH v4 13/45] Add memory region for BCM2837 RPiVid ASB

On Fri, 8 Dec 2023 at 02:33, Sergey Kambalin wrote: > > Signed-off-by: Sergey Kambalin > --- > hw/arm/bcm2838_peripherals.c | 3 +++ > include/hw/arm/bcm2838_peripherals.h | 3 ++- > include/hw/arm/raspi_platform.h | 1 + > 3 files changed, 6 insertions(+), 1 deletion(-) > > diff --

Re: [PATCH] configure: Add linux header compile support for LoongArch

On 15/1/24 08:31, Bibo Mao wrote: When compiling qemu with system KVM mode for LoongArch, header files in directory linux-headers/asm-loongarch should be used firstly. Otherwise it fails to find kvm.h on system with old glibc, since latest kernel header files are not installed. This patch adds l

Re: [PATCH v3 4/4] [NOT FOR MERGE] tests/qtest/migration: Adapt tests to use older QEMUs

Peter Xu writes: > On Thu, Jan 11, 2024 at 10:58:49AM -0300, Fabiano Rosas wrote: >> Peter Xu writes: >> >> > On Wed, Jan 10, 2024 at 11:42:18AM -0300, Fabiano Rosas wrote: >> >> Peter Xu writes: >> >> >> >> > On Tue, Jan 09, 2024 at 11:46:32AM -0300, Fabiano Rosas wrote: >> >> >> Hm, it woul

  1   2   3   >