On Mon, 15 Jan 2024 at 09:37, Zhao Liu <zhao1....@linux.intel.com> wrote: > > From: Zhao Liu <zhao1....@intel.com> > > Remove unused headers in cpu-common.c: > * qemu/notify.h > * qemu/log.h > * qemu/main-loop.h > * exec/cpu-common.h > * qemu/error-report.h > * qemu/qemu-print.h > > Though hw/core/cpu.h has been included by sysemu/hw_accel.h, to keep > the dependency clear, still directly include hw/core/cpu.h in this file. > > Tested by "./configure" and then "make". > > Signed-off-by: Zhao Liu <zhao1....@intel.com> > --- > hw/core/cpu-common.c | 7 +------ > 1 file changed, 1 insertion(+), 6 deletions(-)
Something seems to be wrong with your analysis of what includes it is OK to drop. For instance, this file uses the function qemu_log(), which is why it includes qemu/log.h. thanks -- PMM
