This only adds a limited set of s390x instructions for initial testing.
More instructions will be added later.
Signed-off-by: Thomas Huth
---
s390x.risu | 48
1 file changed, 48 insertions(+)
create mode 100644 s390x.risu
diff --git a/s390x.risu
With these changes, it is now possible to compile the "risu" binary
for s390x hosts.
Signed-off-by: Thomas Huth
---
risu_reginfo_s390x.c | 142 +++
risu_reginfo_s390x.h | 23 +++
risu_s390x.c | 48 +++
test_s390x.S | 32 +
On 8/30/23 11:38, marcandre.lur...@redhat.com wrote:
-if get_option('vnc').allowed() and have_system
+if get_option('vnc') \
+ .disable_auto_if(not pixman.found()) \
+ .require(pixman.found()) \
+ .allowed() and have_system
".disable_auto_if()" is not needed, because ".require()" handles it.
Hi Peter!
Here are some patches that add basic support for s390x to RISU.
It's still quite limited, e.g. no support for load/store memory
operations yet, but the basics with simple 16-bit or 32-bit
instructions work already fine.
(In the long run, we'd need to support instructions with 48-bit
le
Auto-detect s390x hosts and add s390x information to the help text.
Signed-off-by: Thomas Huth
---
configure | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/configure b/configure
index ca2d7db..2f7c580 100755
--- a/configure
+++ b/configure
@@ -58,6 +58,8 @@ guess_arch() {
Richard Henderson writes:
> Update from clfs 5.0 to clfs 8.1, which includes updates
> to binutils 2.41, gcc 13.2, and glibc 2.38.
>
> See https://github.com/loongson/build-tools
>
> Signed-off-by: Richard Henderson
Reviewed-by: Alex Bennée
Do you want this queued ahead of a vdso series?
-
On 8/30/23 11:38, marcandre.lur...@redhat.com wrote:
diff --git a/ui/meson.build b/ui/meson.build
index b3525ef064..08d845d43a 100644
--- a/ui/meson.build
+++ b/ui/meson.build
@@ -133,7 +133,7 @@ if sdl.found()
ui_modules += {'sdl' : sdl_ss}
endif
-if spice.found()
+if spice.found() and
On 8/30/23 11:38, marcandre.lur...@redhat.com wrote:
From: Marc-André Lureau
SM501 is going to depend on PIXMAN next.
Signed-off-by: Marc-André Lureau
---
configs/devices/ppc-softmmu/default.mak | 2 +-
hw/ppc/Kconfig | 2 ++
2 files changed, 3 insertions(+), 1 dele
On 1/9/23 12:46, Peter Maydell wrote:
On Thu, 31 Aug 2023 at 23:56, Philippe Mathieu-Daudé wrote:
Fix:
target/arm/tcg/translate-m-nocp.c:509:18: error: declaration shadows a local
variable [-Werror,-Wshadow]
TCGv_i32 tmp = load_cpu_field(v7m.fpdscr[M_REG_NS]);
^
On Mon, 4 Sep 2023 15:06:21 +0400
Marc-André Lureau wrote:
> Hi
>
> On Thu, Aug 17, 2023 at 8:29 PM Kim, Dongwon wrote:
> >
> > Ok, this regression happened not just because of renaming. Originally
> > width and height were representing the size of whole surface that guest
> > shares while scan
On Mon, 2023-09-04 at 16:00 +0200, Thomas Huth wrote:
> With these changes, it is now possible to compile the "risu" binary
> for s390x hosts.
>
> Signed-off-by: Thomas Huth
> ---
> risu_reginfo_s390x.c | 142
> +++
> risu_reginfo_s390x.h | 23 +++
>
On Mon, 2023-09-04 at 16:00 +0200, Thomas Huth wrote:
> This only adds a limited set of s390x instructions for initial
> testing.
> More instructions will be added later.
>
> Signed-off-by: Thomas Huth
> ---
> s390x.risu | 48
> 1 file changed, 48
On 8/31/23 09:01, Andrew Jones wrote:
On Fri, Aug 25, 2023 at 10:08:49AM -0300, Daniel Henrique Barboza wrote:
All code related to MISA TCG properties is also moved.
At this point, all TCG properties handling is done in tcg-cpu.c, all KVM
properties handling is done in kvm-cpu.c.
Signed-off
Hi Philippe,
On 9/4/23 10:18, Philippe Mathieu-Daudé wrote:
> On 4/9/23 10:03, Eric Auger wrote:
>> This helper reverses an array of regions, turning original
>> regions into holes and original holes into actual regions,
>> covering the whole UINT64_MAX span.
>>
>> Signed-off-by: Eric Auger
>> ---
On 9/4/23 10:12, Philippe Mathieu-Daudé wrote:
> On 4/9/23 10:03, Eric Auger wrote:
>> A reserved region is a range tagged with a type. Let's directly use
>> the Range type in the prospect to reuse some of the library helpers
>> shipped with the Range type.
>>
>> Signed-off-by: Eric Auger
>> --
On 4/9/23 16:00, Thomas Huth wrote:
Auto-detect s390x hosts and add s390x information to the help text.
Signed-off-by: Thomas Huth
---
configure | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
Reviewed-by: Philippe Mathieu-Daudé
Richard Henderson writes:
> Introduced and initialized, but not yet really used.
> These will tidy the current tests vs BPRM_BUF_SIZE.
>
> Reviewed-by: Philippe Mathieu-Daudé
> Signed-off-by: Richard Henderson
Reviewed-by: Alex Bennée
--
Alex Bennée
Virtualisation Tech Lead @ Linaro
On 04/09/2023 16.19, Ilya Leoshkevich wrote:
On Mon, 2023-09-04 at 16:00 +0200, Thomas Huth wrote:
With these changes, it is now possible to compile the "risu" binary
for s390x hosts.
Signed-off-by: Thomas Huth
---
risu_reginfo_s390x.c | 142
+++
risu
On Mon, 2023-09-04 at 16:00 +0200, Thomas Huth wrote:
> Hi Peter!
>
> Here are some patches that add basic support for s390x to RISU.
> It's still quite limited, e.g. no support for load/store memory
> operations yet, but the basics with simple 16-bit or 32-bit
> instructions work already fine.
>
From: Stefan Hajnoczi
Process zoned requests in the current thread's AioContext instead of in
the BlockBackend's AioContext.
There is no need to use the BlockBackend's AioContext thanks to CoMutex
bs->wps->colock, which protects zone metadata.
Signed-off-by: Stefan Hajnoczi
Message-ID: <202308
From: Dmitry Frolov
bdrv_open_child() may return NULL.
Usually return value is checked for this function.
Check for return value is more reliable.
Fixes: 24bc15d1f6 ("vmdk: Use BdrvChild instead of BDS for references to
extents")
Signed-off-by: Dmitry Frolov
Message-ID: <20230831125926.796205
From: Hanna Czenczek
For image creation code, we have central fallback code for protocols
that do not support creating new images (like NBD or iscsi). So for
them, you can only specify existing paths/exports that are overwritten
to make clean new images. In such a case, if the given path cannot
From: Stefan Hajnoczi
Switch blk_aio_*() APIs over to multi-queue by using
qemu_get_current_aio_context() instead of blk_get_aio_context(). This
change will allow devices to process I/O in multiple IOThreads in the
future.
I audited existing blk_aio_*() callers:
- migration/block.c: blk_mig_lock
From: Stefan Hajnoczi
Signed-off-by: Stefan Hajnoczi
Message-ID: <20230808155852.2745350-2-stefa...@redhat.com>
Reviewed-by: Eric Blake
Reviewed-by: Kevin Wolf
Signed-off-by: Kevin Wolf
---
block/io.c | 8 +++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/block/io.c b/blo
From: Philippe Mathieu-Daudé
Use autofree heap allocation instead of variable-length array on the
stack. Here we don't expect the bitmap size to be enormous, and
since we're about to read/write it to disk the overhead of the
allocation should be fine.
The codebase has very few VLAs, and if we ca
From: Stefan Hajnoczi
The synchronous bdrv_aio_cancel() function needs the acb's AioContext so
it can call aio_poll() to wait for cancellation.
It turns out that all users run under the BQL in the main AioContext, so
this callback is not needed.
Remove the callback, mark bdrv_aio_cancel() GLOBA
From: Fabiano Rosas
The commit 5d8813593f ("block/qapi: Let bdrv_query_image_info()
recurse") removed the loop where we set the 'bs0' variable, so now it
is just the same as 'bs'.
Signed-off-by: Fabiano Rosas
Reviewed-by: Philippe Mathieu-Daudé
Message-ID: <20230901184605.32260-3-faro...@suse.
From: Fabiano Rosas
The last call site of this function has been removed by commit
c04d0ab026 ("qemu-img: Let info print block graph").
Reviewed-by: Claudio Fontana
Signed-off-by: Fabiano Rosas
Message-ID: <20230901184605.32260-2-faro...@suse.de>
Reviewed-by: Kevin Wolf
Signed-off-by: Kevin W
From: Fiona Ebner
Since commit ca2a5e630d ("qemu_cleanup: begin drained section after
vm_shutdown()"), there will be an additional pause for jobs during
qemu_cleanup(). The reason is that the bdrv_drain_all() call in
do_vm_stop() is not inside the drained section used by qemu_cleanup()
anymore. I
Document the 'compression_type' option for qcow2, and mention that
streamOptimized vmdk supports compression, too.
Reported-by: Richard W.M. Jones
Signed-off-by: Kevin Wolf
Message-ID: <20230901102430.23856-1-kw...@redhat.com>
Reviewed-by: Richard W.M. Jones
Signed-off-by: Kevin Wolf
---
docs
From: Stefan Hajnoczi
CoMutex has poor performance when lock contention is high. The tracked
requests list is accessed frequently and performance suffers in QEMU
multi-queue block layer scenarios.
It is not necessary to use CoMutex for the requests lock. The lock is
always released across corout
From: Peter Maydell
In block/iscsi.c we use a raw malloc() call, which is unusual
given the project standard is to use the glib memory allocation
functions. Document why we do so, to avoid it being converted
to g_malloc() by mistake.
Signed-off-by: Peter Maydell
Message-ID: <20230727150705.2664
From: Michael Tokarev
I'm getting io-qcow2-244 test failure on mips*
due to output mismatch:
Take an internal snapshot:
-qemu-img: Could not create snapshot 'test': -95 (Operation not supported)
+qemu-img: Could not create snapshot 'test': -122 (Operation not supported)
No errors were foun
The following changes since commit 17780edd81d27fcfdb7a802efc870a99788bd2fc:
Merge tag 'quick-fix-pull-request' of https://gitlab.com/bsdimp/qemu into
staging (2023-08-31 10:06:29 -0400)
are available in the Git repository at:
https://repo.or.cz/qemu/kevin.git tags/for-upstream
for you to
All callers of qio_net_listener_set_name() already add some sort of
"listen" or "listener" suffix.
For intance, we currently have "migration-socket-listener-listen" and
"vnc-listen-listen" as ioc names.
Signed-off-by: Fabiano Rosas
---
io/net-listener.c | 4 +---
1 file changed, 1 insertion(+),
Il mer 30 ago 2023, 17:21 Philippe Mathieu-Daudé ha
scritto:
> On 30/8/23 11:38, marcandre.lur...@redhat.com wrote:
> > From: Marc-André Lureau
> >
> > Signed-off-by: Marc-André Lureau
> > ---
> > hw/display/Kconfig | 2 +-
> > ui/meson.build | 12 ++--
> > 2 files changed, 7 i
Having a name in the source helps with debugging core dumps when one
might not have access to TLS data to cross-reference AioContexts with
their addresses.
Signed-off-by: Fabiano Rosas
---
iothread.c | 13 +
1 file changed, 9 insertions(+), 4 deletions(-)
diff --git a/iothread.c b/i
Richard Henderson writes:
> Reorg the if cases to reduce indentation.
> Test for 4 bytes in the file before checking the signatures.
>
> Reviewed-by: Philippe Mathieu-Daudé
> Signed-off-by: Richard Henderson
Reviewed-by: Alex Bennée
--
Alex Bennée
Virtualisation Tech Lead @ Linaro
Richard Henderson writes:
> Rearrange the allocation of storage for ehdr between load_elf_image
> and load_elf_binary. The same set of copies are done, but we don't
> modify bprm_buf, which will be important later.
>
> Reviewed-by: Philippe Mathieu-Daudé
> Signed-off-by: Richard Henderson
R
Richard Henderson writes:
> Signed-off-by: Richard Henderson
> ---
> linux-user/s390x/vdso-asmoffset.h | 2 +
> linux-user/elfload.c | 3 ++
> linux-user/s390x/signal.c | 4 +-
> linux-user/s390x/meson.build | 24 +++
> linux-user/s390x/vdso.S
When the discard-no-unref flag is enabled, we keep the reference for
normal discard requests.
But when a discard is executed on a snapshot/qcow2 image with backing,
the discards are saved as zero clusters in the snapshot image.
When committing the snapshot to the backing file, not
discard_in_l2_sl
On 29.08.23 20:58, Eric Blake wrote:
The upcoming patches for 64-bit extensions requires various points in
the protocol to make decisions based on what was negotiated. While we
could easily add a 'bool extended_headers' alongside the existing
'bool structured_reply', this does not scale well if
Akihiko Odaki writes:
> On 2023/08/31 0:08, Alex Bennée wrote:
>> Akihiko Odaki writes:
>>
>>> This demonstrates how a register can be read from a plugin.
>>>
>>> Signed-off-by: Akihiko Odaki
>>> ---
>>> docs/devel/tcg-plugins.rst | 10 ++-
>>> contrib/plugins/execlog.c | 140 ++
On 4/9/23 16:48, Fabiano Rosas wrote:
Having a name in the source helps with debugging core dumps when one
might not have access to TLS data to cross-reference AioContexts with
their addresses.
Signed-off-by: Fabiano Rosas
---
iothread.c | 13 +
1 file changed, 9 insertions(+), 4
Fix:
target/m68k/translate.c:828:18: error: declaration shadows a local variable
[-Werror,-Wshadow]
TCGv tmp = tcg_temp_new();
^
target/m68k/translate.c:801:15: note: previous declaration is here
TCGv reg, tmp, result;
^
Signed-off-by: Philippe
Fix:
target/tricore/translate.c:5016:18: warning: declaration of ‘temp’ shadows a
previous local [-Wshadow=compatible-local]
5016 | TCGv temp = tcg_constant_i32(const9);
| ^~~~
target/tricore/translate.c:4958:10: note: shadowed declaration is here
49
Since v1:
- Addressed review comments
- Added R-b tags
- More patches
For rational see Markus cover on
https://lore.kernel.org/qemu-devel/20230831132546.3525721-1-arm...@redhat.com/
This series contains few more, my take.
Based-on: <20230831132546.3525721-1-arm...@redhat.com>
Philippe Mathieu-D
Fix:
hw/arm/armv7m.c: In function ‘armv7m_realize’:
hw/arm/armv7m.c:520:27: warning: declaration of ‘sbd’ shadows a previous
local [-Wshadow=compatible-local]
520 | SysBusDevice *sbd = SYS_BUS_DEVICE(&s->bitband[i]);
| ^~~
hw/arm/armv7m.c:27
Fix:
target/arm/tcg/translate-m-nocp.c: In function ‘gen_M_fp_sysreg_read’:
target/arm/tcg/translate-m-nocp.c:509:18: warning: declaration of ‘tmp’
shadows a previous local [-Wshadow=compatible-local]
509 | TCGv_i32 tmp = load_cpu_field(v7m.fpdscr[M_REG_NS]);
|
hw/ide/ahci.c:1577:23: error: declaration shadows a local variable
[-Werror,-Wshadow]
IDEState *s = &ad->port.ifs[j];
^
hw/ide/ahci.c:1569:29: note: previous declaration is here
void ahci_uninit(AHCIState *s)
^
Signed-off-b
Fix:
hw/arm/allwinner-r40.c:412:14: error: declaration shadows a local variable
[-Werror,-Wshadow]
for (int i = 0; i < AW_R40_NUM_MMCS; i++) {
^
hw/arm/allwinner-r40.c:299:14: note: previous declaration is here
unsigned i;
^
Signed-off-by: Philippe Mathieu-D
Fix:
hw/microblaze/petalogix_ml605_mmu.c: In function ‘petalogix_ml605_init’:
hw/microblaze/petalogix_ml605_mmu.c:186:24: warning: declaration of ‘dinfo’
shadows a previous local [-Wshadow=compatible-local]
186 | DriveInfo *dinfo = drive_get(IF_MTD, 0, i);
|
Fix:
hw/arm/aspeed_ast2600.c:391:18: error: declaration shadows a local variable
[-Werror,-Wshadow]
qemu_irq irq = aspeed_soc_get_irq(s, ASPEED_DEV_TIMER1 + i);
^
hw/arm/aspeed_ast2600.c:283:14: note: previous declaration is here
qemu_irq irq;
^
hw
Fix:
hw/arm/virt.c:821:22: error: declaration shadows a local variable
[-Werror,-Wshadow]
qemu_irq irq = qdev_get_gpio_in(vms->gic,
^
hw/arm/virt.c:803:13: note: previous declaration is here
int irq;
^
Signed-off-by: Philippe Mathieu-Daudé
Fix:
util/vhost-user-server.c: In function ‘set_watch’:
util/vhost-user-server.c:274:20: warning: declaration of ‘vu_fd_watch’
shadows a previous local [-Wshadow=compatible-local]
274 | VuFdWatch *vu_fd_watch = g_new0(VuFdWatch, 1);
|^~~
util/
Fix:
linux-user/strace.c: In function ‘print_sockaddr’:
linux-user/strace.c:370:17: warning: declaration of ‘i’ shadows a previous
local [-Wshadow=compatible-local]
370 | int i;
| ^
linux-user/strace.c:361:9: note: shadowed declaration is here
361
Fix:
hw/m68k/virt.c:263:13: error: declaration shadows a local variable
[-Werror,-Wshadow]
BOOTINFOSTR(param_ptr, BI_COMMAND_LINE,
^
hw/m68k/bootinfo.h:47:13: note: expanded from macro 'BOOTINFOSTR'
int i; \
^
hw/m68k/virt.c:130:9: note: previous
Fix:
softmmu/physmem.c: In function ‘cpu_physical_memory_snapshot_and_clear_dirty’:
softmmu/physmem.c:916:27: warning: declaration of ‘offset’ shadows a
parameter [-Wshadow=compatible-local]
916 | unsigned long offset = page % DIRTY_MEMORY_BLOCK_SIZE;
|
Fix:
tcg/tcg.c:2551:27: error: declaration shadows a local variable
[-Werror,-Wshadow]
MemOp op = get_memop(oi);
^
tcg/tcg.c:2437:12: note: previous declaration is here
TCGOp *op;
^
accel/tcg/tb-maint.c:245:18: error: declaration
Fix:
softmmu/memory.c: In function ‘mtree_print_mr’:
softmmu/memory.c:3236:27: warning: declaration of ‘ml’ shadows a previous
local [-Wshadow=compatible-local]
3236 | MemoryRegionList *ml;
| ^~
softmmu/memory.c:3213:32: note: shadowed declaratio
The loads-and-stores documentation includes git grep regexes to find
occurrences of the various functions. Some of these regexes have
errors, typically failing to escape the '?', '(' and ')' when they
should be metacharacters (since these are POSIX basic REs). We also
weren't consistent about whet
On 29.08.23 20:58, Eric Blake wrote:
Widen the length field of NBDRequest to 64-bits, although we can
assert that all current uses are still under 32 bits: either because
of NBD_MAX_BUFFER_SIZE which is even smaller (and where size_t can
still be appropriate, even on 32-bit platforms), or because
Per Peter Maydell analysis [*]:
The hvf_vcpu_exec() function is not documented, but in practice
its caller expects it to return either EXCP_DEBUG (for "this was
a guest debug exception you need to deal with") or something else
(presumably the intention being 0 for OK).
The hvf_sysreg_re
Fix:
semihosting/arm-compat-semi.c: In function ‘do_common_semihosting’:
semihosting/arm-compat-semi.c:379:13: warning: declaration of ‘ret’ shadows a
previous local [-Wshadow=local]
379 | int ret, err = 0;
| ^~~
semihosting/arm-compat-semi.c:370:14: note: sh
Fix:
hw/mips/boston.c:472:5: error: declaration shadows a local variable
[-Werror,-Wshadow]
qemu_fdt_setprop_cells(fdt, name, "reg", reg_base, reg_size);
^
include/sysemu/device_tree.h:129:13: note: expanded from macro
'qemu_fdt_setprop_cells'
int i;
^
hw/mips/b
Fix:
In file included from crypto/cipher.c:140:
crypto/cipher-gnutls.c.inc: In function ‘qcrypto_gnutls_cipher_encrypt’:
crypto/cipher-gnutls.c.inc:116:17: warning: declaration of ‘err’ shadows a
previous local [-Wshadow=compatible-local]
116 | int err = gnutls_cipher_init(&
Fix:
target/mips/tcg/nanomips_translate.c.inc:4410:33: error: declaration shadows
a local variable [-Werror,-Wshadow]
int32_t imm = extract32(ctx->opcode, 1, 13) |
^
target/mips/tcg/nanomips_translate.c.inc:3577:9: note: previous declara
Fix:
net/eth.c:435:20: error: declaration shadows a local variable
[-Werror,-Wshadow]
size_t input_size = iov_size(pkt, pkt_frags);
^
net/eth.c:413:16: note: previous declaration is here
size_t input_size = iov_size(pkt, pkt_frags);
^
Sug
Fix:
hw/nios2/10m50_devboard.c: In function ‘nios2_10m50_ghrd_init’:
hw/nios2/10m50_devboard.c:101:22: warning: declaration of ‘dev’ shadows a
previous local [-Wshadow=compatible-local]
101 | DeviceState *dev = qdev_new(TYPE_NIOS2_VIC);
| ^~~
hw/nios
v2 updates:
- Edit of patch description to not confuse matters by mentioning
switches.
- Associated ACPI test updates.
CXL platforms may support the concept of QoS Thottling groups (QTG).
Typically you want to associate devices with similar performance
with the same QTG. As there is no standard
Addition of QTG in following patch requires an update to the test
data.
Signed-off-by: Jonathan Cameron
---
tests/qtest/bios-tables-test-allowed-diff.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/tests/qtest/bios-tables-test-allowed-diff.h
b/tests/qtest/bios-tables-test-allowed-diff.h
i
From: Dave Jiang
Add a simple _DSM call support for the ACPI0017 device to return a fake QTG
ID value of 0 in all cases. The enabling is for _DSM plumbing testing
from the OS.
Following edited for readbility only
Device (CXLM)
{
Name (_HID, "ACPI0017") // _HID: Hardware ID
...
Method (
Description of change in previous patch.
Signed-off-by: Jonathan Cameron
---
tests/qtest/bios-tables-test-allowed-diff.h | 1 -
tests/data/acpi/q35/DSDT.cxl| Bin 9655 -> 9723 bytes
2 files changed, 1 deletion(-)
diff --git a/tests/qtest/bios-tables-test-allowed-diff.h
b/test
On 8/30/23 14:34, BALATON Zoltan wrote:
From: Marc-André Lureau
SM501 is going to depend on PIXMAN next.
Why is this patch needed when SM501 is the one that depends on PIXMAN
and should pull in the dependency? Also what's the change in
default.mak?
The change in default.mak is needed be
By the time of the 8.2.0 release, it will have been 2 years and 6
releases since we accidentally broke setting of array properties
for user creatable devices:
https://gitlab.com/qemu-project/qemu/-/issues/1090
Some context:
* Initial identification / report on the mailing list
https://list
DEFINE_PROP_ARRAY() creates a property 'len-$ARRAY-PROP-NAME'
which, when set, will create a sequence of '$ARRAY-PROP-NAME[N]'
properties.
This only works if the 'len-$ARRAY-PROP-NAME' property is
set first, and the array elements afterwards. Historically
this required the user to set correct orde
On 4/9/23 18:17, Peter Maydell wrote:
The loads-and-stores documentation includes git grep regexes to find
occurrences of the various functions. Some of these regexes have
errors, typically failing to escape the '?', '(' and ')' when they
should be metacharacters (since these are POSIX basic REs
On Mon, Sep 04, 2023 at 06:12:28PM +0200, Philippe Mathieu-Daudé wrote:
> Fix:
>
> In file included from crypto/cipher.c:140:
> crypto/cipher-gnutls.c.inc: In function ‘qcrypto_gnutls_cipher_encrypt’:
> crypto/cipher-gnutls.c.inc:116:17: warning: declaration of ‘err’ shadows a
> previous lo
Fix:
tests/qtest/pflash-cfi02-test.c: In function ‘test_geometry’:
tests/qtest/pflash-cfi02-test.c:409:22: warning: declaration of ‘byte_addr’
shadows a previous local [-Wshadow=compatible-local]
409 | uint64_t byte_addr = (uint64_t)i * c->sector_len[region];
|
Current checks on writing pmpcfg for ePMP follows ePMP version 0.9.1.
However, ePMP specification has already been ratified, and there are
some differences between version 0.9.1 and 1.0. In this commit we update
the checks of writing pmpcfg to follow ePMP version 1.0.
When mseccfg.MML is set, the
Fix:
hw/core/machine.c: In function ‘machine_initfn’:
hw/core/machine.c:1081:17: warning: declaration of ‘obj’ shadows a parameter
[-Wshadow=compatible-local]
1081 | Object *obj = OBJECT(ms);
| ^~~
hw/core/machine.c:1065:36: note: shadowed declaration is h
Fix:
hw/intc/openpic.c: In function ‘openpic_gbl_write’:
hw/intc/openpic.c:614:17: warning: declaration of ‘idx’ shadows a previous
local [-Wshadow=compatible-local]
614 | int idx;
| ^~~
hw/intc/openpic.c:568:9: note: shadowed declaration is here
Just missed while posting v2 eh :/
(https://lore.kernel.org/qemu-devel/20230904161235.84651-1-phi...@linaro.org/)
Philippe Mathieu-Daudé (3):
hw/core/machine: Clean up local variable shadowing
hw/intc/openpic: Clean up local variable shadowing
tests/qtest/pflash: Clean up local variable shad
On 4/9/23 18:27, Daniel P. Berrangé wrote:
On Mon, Sep 04, 2023 at 06:12:28PM +0200, Philippe Mathieu-Daudé wrote:
Fix:
In file included from crypto/cipher.c:140:
crypto/cipher-gnutls.c.inc: In function ‘qcrypto_gnutls_cipher_encrypt’:
crypto/cipher-gnutls.c.inc:116:17: warning: declar
On Mon, Sep 04, 2023 at 06:12:34PM +0200, Philippe Mathieu-Daudé wrote:
> Fix:
>
> softmmu/physmem.c: In function
> ‘cpu_physical_memory_snapshot_and_clear_dirty’:
> softmmu/physmem.c:916:27: warning: declaration of ‘offset’ shadows a
> parameter [-Wshadow=compatible-local]
> 916 |
On Mon, 4 Sept 2023 at 17:28, Philippe Mathieu-Daudé wrote:
>
> Fix:
>
> hw/core/machine.c: In function ‘machine_initfn’:
> hw/core/machine.c:1081:17: warning: declaration of ‘obj’ shadows a
> parameter [-Wshadow=compatible-local]
>1081 | Object *obj = OBJECT(ms);
> |
On Mon, 4 Sept 2023 at 17:28, Philippe Mathieu-Daudé wrote:
>
> Fix:
>
> hw/intc/openpic.c: In function ‘openpic_gbl_write’:
> hw/intc/openpic.c:614:17: warning: declaration of ‘idx’ shadows a previous
> local [-Wshadow=compatible-local]
> 614 | int idx;
> |
On Mon, 4 Sept 2023 at 17:30, Philippe Mathieu-Daudé wrote:
>
> Fix:
>
> tests/qtest/pflash-cfi02-test.c: In function ‘test_geometry’:
> tests/qtest/pflash-cfi02-test.c:409:22: warning: declaration of ‘byte_addr’
> shadows a previous local [-Wshadow=compatible-local]
> 409 | u
On Sat, Sep 02, 2023 at 05:40:40PM +0800, William Tsai wrote:
> Changing the structure of qdict so that it can preserve order when
> iterating qdict. This will fix array_properties as it relies on `len-`
> prefixed argument to be set first.
>
> Resolves: https://gitlab.com/qemu-project/qemu/-/issu
For initial CXL emulation / kernel driver bring up a single Host-managed
Device Memory (HDM) decoder instance was sufficient as it let us test the
basic region creation code etc. More complex testing appropriate today
requires a more realistic configuration with multiple decoders.
The Linux kernel
Support these decoders in CXL host bridges (pxb-cxl), CXL Switch USP
and CXL Type 3 end points.
Signed-off-by: Jonathan Cameron
---
Note there is a fix in here for a wrong increment that had
no impact when there was only one HDM decoder.
include/hw/cxl/cxl_component.h | 7 +++
hw/cxl/cxl-compo
As an encoded version of these key configuration parameters is
a register, provide functions to extract it again so as to avoid
the need for duplicating the storage.
Signed-off-by: Jonathan Cameron
---
include/hw/cxl/cxl_component.h | 14 ++
hw/cxl/cxl-component-utils.c | 17 ++
On 29.08.23 20:58, Eric Blake wrote:
Upcoming additions to support NBD 64-bit effect lengths will add a new
command flag NBD_CMD_FLAG_PAYLOAD_LEN that needs to be considered in
our sanity checks of the client's messages (that is, more than just
CMD_WRITE have the potential to carry a client paylo
On Thu, 31 Aug 2023 21:29:11 -0400
Gregory Price wrote:
> Call CXL_TYPE3 once at top of function to avoid multiple invocations.
>
> Signed-off-by: Gregory Price
Good cleanup on it's own.
I'll queue this one up on the backend of the sanitize set that
introduces the second use in each of these
Hi
On Mon, Sep 4, 2023 at 6:11 PM Alex Williamson
wrote:
>
> On Mon, 4 Sep 2023 15:06:21 +0400
> Marc-André Lureau wrote:
>
> > Hi
> >
> > On Thu, Aug 17, 2023 at 8:29 PM Kim, Dongwon wrote:
> > >
> > > Ok, this regression happened not just because of renaming. Originally
> > > width and height
On Thu, 31 Aug 2023 21:29:13 -0400
Gregory Price wrote:
> When memory accesses are made, some MHSLD's would validate the address
> is within the scope of allocated sections. To do this, the base device
> must call an optional function set by inherited devices.
>
> Signed-off-by: Gregory Price
Will be needed so there is a defined serial number for
information queries via the Switch CCI.
Signed-off-by: Jonathan Cameron
---
No ordering dependencies wrt to other CXL patch sets.
Whilst we 'need' it for the Switch CCI set it is valid without
it and aligns with existing EP serial number sup
On Fri, 2023-09-01 at 17:57 +0200, Nina Schoetterl-Glausch wrote:
> From: Pierre Morel
>
> On interception of STSI(15.1.x) the System Information Block
> (SYSIB) is built from the list of pre-ordered topology entries.
>
> Signed-off-by: Pierre Morel
> Co-developed-by: Nina Schoetterl-Glausch
>
On 4/9/23 18:47, Jonathan Cameron wrote:
As an encoded version of these key configuration parameters is
a register, provide functions to extract it again so as to avoid
the need for duplicating the storage.
Signed-off-by: Jonathan Cameron
---
include/hw/cxl/cxl_component.h | 14 ++
Hi Jonathan,
Few style comments inlined.
On 4/9/23 18:47, Jonathan Cameron wrote:
Support these decoders in CXL host bridges (pxb-cxl), CXL Switch USP
and CXL Type 3 end points.
Signed-off-by: Jonathan Cameron
---
Note there is a fix in here for a wrong increment that had
no impact when there
101 - 200 of 332 matches
Mail list logo
