Re: [PATCH-for-8.0 4/7] hw/mips/gt64xxx_pci: Add a 'cpu-little-endian' qdev property

2022-12-20 Thread Philippe Mathieu-Daudé
On 20/12/22 01:52, Richard Henderson wrote: On 12/9/22 07:15, Philippe Mathieu-Daudé wrote: +static Property gt64120_properties[] = { +    DEFINE_PROP_BIT("cpu-little-endian", GT64120State, +    features, FEAT_CPU_LE, !TARGET_BIG_ENDIAN), Unless you're really planning on more f

Re: Should -overcommit cpu-pm=on|off be converted to some machine sugar property?

2022-12-20 Thread Paolo Bonzini
It's implemented only for x86, but it is not architecture-dependent. For example on ARM you would implement it by mapping guest WFx to the host instructions. Paolo Il lun 19 dic 2022, 17:11 Philippe Mathieu-Daudé ha scritto: > Hi Paolo, > > I just noticed 'enable_cpu_pm' which seems architectur

Re: [PATCH 01/11] contrib/gitdm: add C-Sky to the domain map

2022-12-20 Thread Alex Bennée
LIU Zhiwei writes: > The c-sky domain mail is no longer being used for Guo Ren and me. > > C-SKY company and C-SKY arch is still existing, but its website domain > has been moved to https://www.t-head.cn/. Is this the new corporate entity for the C-SKY architecture? I can change the domain-map

Re: [PATCH-for-8.0 5/7] hw/mips/malta: Explicit GT64120 endianness upon device creation

2022-12-20 Thread Philippe Mathieu-Daudé
+Eduardo/Markus for QOM/QDEV clarification. On 20/12/22 01:52, Richard Henderson wrote: On 12/9/22 07:15, Philippe Mathieu-Daudé wrote: Propagate the controller endianess from the machine, setting the "cpu-little-endian" property. Signed-off-by: Philippe Mathieu-Daudé ---   hw/mips/malta.c |

Re: [PATCH v10 1/9] mm: Introduce memfd_restricted system call to create restricted user memory

2022-12-20 Thread Huang, Kai
On Tue, 2022-12-20 at 15:22 +0800, Chao Peng wrote: > On Mon, Dec 19, 2022 at 08:48:10AM +, Huang, Kai wrote: > > On Mon, 2022-12-19 at 15:53 +0800, Chao Peng wrote: > > > > > > > > [...] > > > > > > > > > + > > > > > + /* > > > > > + * These pages are currently unmovable so don't pl

Re: [PATCH v2 2/3] hvf: implement guest debugging on Apple Silicon hosts

2022-12-20 Thread Alex Bennée
Francesco Cagnin writes: > Hi, > indeed, the patch doesn't keep separate copies of debug registers and > just directly sets cp15.* values, as I was not aware of the issue—thanks > for the detailed explanation. > > I remain available to implement the required fixes, but I'd need > some guidance

[PATCH v2] pflash: Only read non-zero parts of backend image

2022-12-20 Thread Gerd Hoffmann
From: Xiang Zheng Currently we fill the VIRT_FLASH memory space with two 64MB NOR images when using persistent UEFI variables on virt board. Actually we only use a very small(non-zero) part of the memory while the rest significant large(zero) part of memory is wasted. So this patch checks the bl

[PATCH v3 10/18] ui: Factor out qmp_add_client() parts and move to ui/ui-qmp-cmds.c

2022-12-20 Thread Markus Armbruster
Signed-off-by: Markus Armbruster Reviewed-by: Philippe Mathieu-Daudé --- include/monitor/qmp-helpers.h | 26 monitor/qmp-cmds.c| 74 --- ui/ui-qmp-cmds.c | 41 +++ 3 files changed, 100 insertions(+), 41 deletio

[PATCH v3 05/18] ui/spice: Require spice-server >= 0.14.0

2022-12-20 Thread Markus Armbruster
Version 0.14.0 is now old enough to have made it into the major distributions: Debian 11: 0.14.3 RHEL-8: 0.14.3 FreeBSD (ports): 0.15.0 Fedora 35: 0.15.0 Ubuntu 20.04: 0.14.2 OpenSUSE Leap 15.3: 0.14.3 Requiring it lets us drop a number of version checks. The next c

[PATCH v3 14/18] ui: Factor out hmp_change_vnc(), and move to ui/ui-hmp-cmds.c

2022-12-20 Thread Markus Armbruster
Signed-off-by: Markus Armbruster Reviewed-by: Daniel P. Berrangé Reviewed-by: Philippe Mathieu-Daudé --- include/monitor/hmp.h | 5 + monitor/hmp-cmds.c| 30 ++ monitor/qmp-cmds.c| 2 +- ui/ui-hmp-cmds.c | 35 ++- 4

[PATCH v3 18/18] ui: Simplify control flow in qemu_mouse_set()

2022-12-20 Thread Markus Armbruster
Signed-off-by: Markus Armbruster --- ui/input.c | 22 ++ 1 file changed, 10 insertions(+), 12 deletions(-) diff --git a/ui/input.c b/ui/input.c index 99e52c938e..df2f54cb9a 100644 --- a/ui/input.c +++ b/ui/input.c @@ -595,26 +595,24 @@ MouseInfoList *qmp_query_mice(Error **er

[PATCH v3 03/18] ui/spice: Require spice-protocol >= 0.14.0

2022-12-20 Thread Markus Armbruster
Version 0.14.0 is now old enough to have made it into the major distributions: Debian 11: 0.14.3 RHEL-8: 0.14.2 FreeBSD (ports): 0.14.4 Fedora 35: 0.14.0 Ubuntu 20.04: 0.14.0 OpenSUSE Leap 15.3: 0.14.3 Requiring it lets us drop two version checks in ui/vdagent.c. It also enable

[PATCH v3 07/18] ui/spice: Give hmp_info_spice()'s channel_names[] static linkage

2022-12-20 Thread Markus Armbruster
Suggested-by: Philippe Mathieu-Daudé Signed-off-by: Markus Armbruster Reviewed-by: Philippe Mathieu-Daudé --- monitor/hmp-cmds.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/monitor/hmp-cmds.c b/monitor/hmp-cmds.c index 664b3454bb..4d57520f82 100644 --- a/monitor/hmp-cmds

[PATCH v3 02/18] ui: Fix silent truncation of numeric keys in HMP sendkey

2022-12-20 Thread Markus Armbruster
Keys are int. HMP sendkey assigns them from the value strtoul(), silently truncating values greater than INT_MAX. Fix to reject them. While there, use qemu_strtoul() instead of strtoul() so checkpatch.pl won't complain. Signed-off-by: Markus Armbruster Reviewed-by: Daniel P. Berrangé --- mon

[PATCH v3 06/18] ui/spice: QXLInterface method set_mm_time() is now dead, drop

2022-12-20 Thread Markus Armbruster
SPICE_NEEDS_SET_MM_TIME is now always off. Bury the dead code. Signed-off-by: Markus Armbruster Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Daniel P. Berrangé --- include/ui/qemu-spice.h | 2 -- hw/display/qxl.c| 19 --- ui/spice-display.c | 10 -- h

[PATCH v3 00/18] ui: Move and clean up monitor command code

2022-12-20 Thread Markus Armbruster
This is mainly about splitting off monitor-related code. There's also a minimum Spice version bump, and a few UI improvements to HMP commands sendkey, change vnc, and info spice. The only reason for keeping new PATCH 12 separate from old PATCH 11 is preserving PATCH 11's R-bys. I might squash th

[PATCH v3 08/18] ui: Clean up a few things checkpatch.pl would flag later on

2022-12-20 Thread Markus Armbruster
Fix a few style violations so that checkpatch.pl won't complain when I move this code. Signed-off-by: Markus Armbruster Reviewed-by: Daniel P. Berrangé --- monitor/hmp-cmds.c | 7 --- monitor/qmp-cmds.c | 21 +++-- 2 files changed, 15 insertions(+), 13 deletions(-) diff --

[PATCH v3 17/18] ui: Don't check for mode change after mouse_set error

2022-12-20 Thread Markus Armbruster
hmp_mouse_set() doesn't bail out when it can't find a mouse. Harmless, since qemu_input_check_mode_change() should be a no-op then. Clean it up anyway. Signed-off-by: Markus Armbruster --- ui/input.c | 1 + 1 file changed, 1 insertion(+) diff --git a/ui/input.c b/ui/input.c index 7bece94e79..99

Re: [PATCH v3 12/18] ui: Move more HMP commands from monitor to ui/

2022-12-20 Thread Daniel P . Berrangé
On Tue, Dec 20, 2022 at 10:06:39AM +0100, Markus Armbruster wrote: > This moves these commands from MAINTAINERS section "Human > Monitor (HMP)" to "Graphics". > > Signed-off-by: Markus Armbruster > --- > include/monitor/hmp.h | 2 ++ > monitor/misc.c| 66

[PATCH v3 12/18] ui: Move more HMP commands from monitor to ui/

2022-12-20 Thread Markus Armbruster
This moves these commands from MAINTAINERS section "Human Monitor (HMP)" to "Graphics". Signed-off-by: Markus Armbruster --- include/monitor/hmp.h | 2 ++ monitor/misc.c| 66 --- ui/ui-hmp-cmds.c | 66 +

[PATCH v3 11/18] ui: Move HMP commands from monitor to new ui/ui-hmp-cmds.c

2022-12-20 Thread Markus Armbruster
This moves these commands from MAINTAINERS section "Human Monitor (HMP)" to "Graphics". Signed-off-by: Markus Armbruster Reviewed-by: Daniel P. Berrangé Reviewed-by: Philippe Mathieu-Daudé --- monitor/hmp-cmds.c | 339 -- ui/ui-hmp-cmds.c | 357 +++

[PATCH v3 15/18] ui: Reduce nesting in hmp_change_vnc() slightly

2022-12-20 Thread Markus Armbruster
Transform if (good) { do stuff } else { handle error } to if (!good) { handle error return; } do stuff Signed-off-by: Markus Armbruster Reviewed-by: Daniel P. Berrangé Reviewed-by: Philippe Mathieu-Daudé --- ui/ui-hmp-cmds.c | 17 +

[PATCH v3 01/18] ui: Check numeric part of expire_password argument @time properly

2022-12-20 Thread Markus Armbruster
When argument @time isn't 'now' or 'never', we parse it as an integer, optionally prefixed with '+'. If parsing fails, we silently assume zero. Report an error and fail instead. While there, use qemu_strtou64() instead of strtoull() so checkpatch.pl won't complain. Aside: encoding numbers in st

[PATCH v3 09/18] ui: Move QMP commands from monitor to new ui/ui-qmp-cmds.c

2022-12-20 Thread Markus Armbruster
This moves these commands from MAINTAINERS section "QMP" to "Graphics". Command add-client applies to socket character devices in addition to display devices. Move it anyway. Aside: the way @protocol character device IDs and display types is bad design. Signed-off-by: Markus Armbruster Reviewe

[PATCH v3 16/18] ui: Split hmp_mouse_set() and move the HMP part to ui/

2022-12-20 Thread Markus Armbruster
Signed-off-by: Markus Armbruster --- include/monitor/hmp.h | 1 + include/ui/console.h | 2 +- monitor/misc.c| 1 - ui/input.c| 5 + ui/ui-hmp-cmds.c | 8 5 files changed, 11 insertions(+), 6 deletions(-) diff --git a/include/monitor/hmp.h b/include/monitor

[PATCH v3 04/18] Revert "hmp: info spice: take out webdav"

2022-12-20 Thread Markus Armbruster
This reverts commit 7c6044a94e52db8aef9a71d616c7a0914adb71ab. We had to take it out because SPICE_CHANNEL_WEBDAV requires spice-protocol 0.12.7, but we had only 0.12.3. We have 0.14.0 now, so put it back in. Signed-off-by: Markus Armbruster Reviewed-by: Daniel P. Berrangé --- monitor/hmp-cmds

Re: [PATCH v3 18/18] ui: Simplify control flow in qemu_mouse_set()

2022-12-20 Thread Daniel P . Berrangé
On Tue, Dec 20, 2022 at 10:06:45AM +0100, Markus Armbruster wrote: > Signed-off-by: Markus Armbruster > --- > ui/input.c | 22 ++ > 1 file changed, 10 insertions(+), 12 deletions(-) Reviewed-by: Daniel P. Berrangé With regards, Daniel -- |: https://berrange.com -o-

Re: [PATCH v2] pflash: Only read non-zero parts of backend image

2022-12-20 Thread Philippe Mathieu-Daudé
[Extending to people using UEFI VARStore on Virt machines] On 20/12/22 09:42, Gerd Hoffmann wrote: From: Xiang Zheng Currently we fill the VIRT_FLASH memory space with two 64MB NOR images when using persistent UEFI variables on virt board. Actually we only use a very small(non-zero) part of th

[PATCH RESEND v5 0/3] Fix the virtio features negotiation flaw

2022-12-20 Thread huangy81
From: Hyman Huang(黄勇) v5(resend): -rebase on master v5: -fix the assert statement in [PATCH v4 3/3], reported by xiangdong. v4: -rebase on master -add stub function to fix build errors -code clean on [PATCH v2 1/2]: drop 'cleanup' parameter in vhost_user_save_acked_features. -code clean on [

[PATCH v3 13/18] ui: Improve "change vnc" error reporting

2022-12-20 Thread Markus Armbruster
Switch from monitor_printf() to error_setg() and hmp_handle_error(). This makes "this is an error" more obvious both in the source and in the monitor, where hmp_handle_error() prefixes the message with "Error: ". Signed-off-by: Markus Armbruster Reviewed-by: Daniel P. Berrangé --- monitor/hmp-c

Re: [PATCH 01/11] contrib/gitdm: add C-Sky to the domain map

2022-12-20 Thread LIU Zhiwei
On 2022/12/20 16:23, Alex Bennée wrote: LIU Zhiwei writes: The c-sky domain mail is no longer being used for Guo Ren and me. C-SKY company and C-SKY arch is still existing, but its website domain has been moved tohttps://www.t-head.cn/. Is this the new corporate entity for the C-SKY archite

[PATCH RESEND v5 1/3] vhost-user: Refactor vhost acked features saving

2022-12-20 Thread huangy81
From: Hyman Huang(黄勇) Abstract vhost acked features saving into vhost_user_save_acked_features, export it as util function. Signed-off-by: Hyman Huang(黄勇) Signed-off-by: Guoyi Tu --- include/net/vhost-user.h | 1 + net/vhost-user.c | 21 +++-- 2 files changed, 16 inse

Re: [PATCH v10 3/9] KVM: Extend the memslot to support fd-based private memory

2022-12-20 Thread Borislav Petkov
On Tue, Dec 20, 2022 at 03:43:18PM +0800, Chao Peng wrote: > RESTRICTEDMEM is needed by TDX_HOST, not TDX_GUEST. Which basically means that RESTRICTEDMEM should simply depend on KVM. Because you can't know upfront whether KVM will run a TDX guest or a SNP guest and so on. Which then means that RE

Re: [PATCH v2] pflash: Only read non-zero parts of backend image

2022-12-20 Thread Daniel P . Berrangé
On Tue, Dec 20, 2022 at 09:42:46AM +0100, Gerd Hoffmann wrote: > From: Xiang Zheng > > Currently we fill the VIRT_FLASH memory space with two 64MB NOR images > when using persistent UEFI variables on virt board. Actually we only use > a very small(non-zero) part of the memory while the rest signi

[PATCH RESEND v5 2/3] vhost-user: Refactor the chr_closed_bh

2022-12-20 Thread huangy81
From: Hyman Huang(黄勇) Use vhost_user_save_acked_features to implemente acked features saving. Signed-off-by: Hyman Huang(黄勇) Signed-off-by: Guoyi Tu --- net/vhost-user.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/net/vhost-user.c b/net/vhost-user.c index f5cb095.

[PATCH RESEND v5 3/3] vhost-user: Fix the virtio features negotiation flaw

2022-12-20 Thread huangy81
From: Hyman Huang(黄勇) This patch aims to fix unexpected negotiation features for vhost-user netdev interface. When openvswitch reconnect Qemu after an unexpected disconnection and Qemu therefore start the vhost_dev, acked_features field in vhost_dev is initialized with value fetched from acked_f

Re: [PATCH v3 01/18] ui: Check numeric part of expire_password argument @time properly

2022-12-20 Thread Daniel P . Berrangé
On Tue, Dec 20, 2022 at 10:06:28AM +0100, Markus Armbruster wrote: > When argument @time isn't 'now' or 'never', we parse it as an integer, > optionally prefixed with '+'. If parsing fails, we silently assume > zero. Report an error and fail instead. > > While there, use qemu_strtou64() instead

Re: [PATCH v3 16/18] ui: Split hmp_mouse_set() and move the HMP part to ui/

2022-12-20 Thread Daniel P . Berrangé
On Tue, Dec 20, 2022 at 10:06:43AM +0100, Markus Armbruster wrote: > Signed-off-by: Markus Armbruster > --- > include/monitor/hmp.h | 1 + > include/ui/console.h | 2 +- > monitor/misc.c| 1 - > ui/input.c| 5 + > ui/ui-hmp-cmds.c | 8 > 5 files changed, 11

Re: [PATCH 2/4] target/loongarch: Restrict 'qapi-commands-machine.h' to system emulation

2022-12-20 Thread Philippe Mathieu-Daudé
On 20/12/22 00:58, Richard Henderson wrote: On 12/19/22 13:10, Philippe Mathieu-Daudé wrote: Since commit a0e61807a3 ("qapi: Remove QMP events and commands from user-mode builds") we don't generate the "qapi-commands-machine.h" header in a user-emulation-only build. Extract the QMP functions fr

Re: [PATCH v3 17/18] ui: Don't check for mode change after mouse_set error

2022-12-20 Thread Daniel P . Berrangé
On Tue, Dec 20, 2022 at 10:06:44AM +0100, Markus Armbruster wrote: > hmp_mouse_set() doesn't bail out when it can't find a mouse. > Harmless, since qemu_input_check_mode_change() should be a no-op then. > Clean it up anyway. > > Signed-off-by: Markus Armbruster > --- > ui/input.c | 1 + > 1 file

Re: [PATCH v3 1/5] dump: Include missing "cpu.h" header for tswap32/tswap64() declarations

2022-12-20 Thread Daniel Henrique Barboza
On 12/16/22 18:55, Philippe Mathieu-Daudé wrote: Signed-off-by: Philippe Mathieu-Daudé --- Reviewed-by: Daniel Henrique Barboza dump/dump.c | 1 + 1 file changed, 1 insertion(+) diff --git a/dump/dump.c b/dump/dump.c index 279b07f09b..c62dc94213 100644 --- a/dump/dump.c +++ b/dump/

Re: [PATCH] gdbstub: move update guest debug to accel ops

2022-12-20 Thread Mads Ynddal
> It will do. You could just call it update_guest_debug as it is an > internal static function although I guess that makes grepping a bit of a > pain. I agree. It should preferably be something unique, to ease grep'ing. > Is something being accidentally linked with linux-user and softmmu? Good

Re: [PATCH v3 00/18] ui: Move and clean up monitor command code

2022-12-20 Thread Philippe Mathieu-Daudé
On 20/12/22 10:06, Markus Armbruster wrote: This is mainly about splitting off monitor-related code. There's also a minimum Spice version bump, and a few UI improvements to HMP commands sendkey, change vnc, and info spice. Possibly related, use of InputEvent in replay: https://lore.kernel.org/

[PATCH v2 4/5] target/mips: Restrict 'qapi-commands-machine.h' to system emulation

2022-12-20 Thread Philippe Mathieu-Daudé
Since commit a0e61807a3 ("qapi: Remove QMP events and commands from user-mode builds") we don't generate the "qapi-commands-machine.h" header in a user-emulation-only build. Extract the QMP functions from cpu.c (which is always compiled) to the new 'sysemu/monitor.c' unit (which is only compiled w

[PATCH v2 1/5] target/arm: Restrict 'qapi-commands-machine.h' to system emulation

2022-12-20 Thread Philippe Mathieu-Daudé
Since commit a0e61807a3 ("qapi: Remove QMP events and commands from user-mode builds") we don't generate the "qapi-commands-machine.h" header in a user-emulation-only build. Move the QMP functions from helper.c (which is always compiled) to monitor.c (which is only compiled when system-emulation i

[PATCH v2 3/5] target/loongarch: Restrict 'qapi-commands-machine.h' to system emulation

2022-12-20 Thread Philippe Mathieu-Daudé
Since commit a0e61807a3 ("qapi: Remove QMP events and commands from user-mode builds") we don't generate the "qapi-commands-machine.h" header in a user-emulation-only build. Extract the QMP functions from cpu.c (which is always compiled) to the new 'monitor.c' unit (which is only compiled when sys

[PATCH v2 2/5] target/i386: Restrict 'qapi-commands-machine.h' to system emulation

2022-12-20 Thread Philippe Mathieu-Daudé
From: Philippe Mathieu-Daude Since commit a0e61807a3 ("qapi: Remove QMP events and commands from user-mode builds") we don't generate the "qapi-commands-machine.h" header in a user-emulation-only build. Guard qmp_query_cpu_definitions() within CONFIG_USER_ONLY; move x86_cpu_class_check_missing_f

[PATCH v2 5/5] target/ppc: Restrict 'qapi-commands-machine.h' to system emulation

2022-12-20 Thread Philippe Mathieu-Daudé
Since commit a0e61807a3 ("qapi: Remove QMP events and commands from user-mode builds") we don't generate the "qapi-commands-machine.h" header in a user-emulation-only build. Move the QMP functions from cpu_init.c (which is always compiled) to monitor.c (which is only compiled when system-emulation

[PATCH v2 0/5] target: Restrict 'qapi-commands-machine.h' to system emulation

2022-12-20 Thread Philippe Mathieu-Daudé
All series reviewed, can patches be picked by corresponding maintainers? The "qapi-commands-machine.h" header is not generated in user-only emulation. This series removes its use in user-emu code by moving the QMP code depending on this header into a separate sysemu unit. Since v1: - renamed cpu-

[PATCH RESEND v2 2/5] target/i386: Restrict 'qapi-commands-machine.h' to system emulation

2022-12-20 Thread Philippe Mathieu-Daudé
Since commit a0e61807a3 ("qapi: Remove QMP events and commands from user-mode builds") we don't generate the "qapi-commands-machine.h" header in a user-emulation-only build. Guard qmp_query_cpu_definitions() within CONFIG_USER_ONLY; move x86_cpu_class_check_missing_features() closer since it is on

Re: [PATCH v3 08/18] ui: Clean up a few things checkpatch.pl would flag later on

2022-12-20 Thread Philippe Mathieu-Daudé
On 20/12/22 10:06, Markus Armbruster wrote: Fix a few style violations so that checkpatch.pl won't complain when I move this code. Signed-off-by: Markus Armbruster Reviewed-by: Daniel P. Berrangé --- monitor/hmp-cmds.c | 7 --- monitor/qmp-cmds.c | 21 +++-- 2 files ch

Re: [PATCH v3 16/18] ui: Split hmp_mouse_set() and move the HMP part to ui/

2022-12-20 Thread Philippe Mathieu-Daudé
On 20/12/22 10:06, Markus Armbruster wrote: Signed-off-by: Markus Armbruster --- include/monitor/hmp.h | 1 + include/ui/console.h | 2 +- monitor/misc.c| 1 - ui/input.c| 5 + ui/ui-hmp-cmds.c | 8 5 files changed, 11 insertions(+), 6 deletions(-)

[PATCH RESEND v2 3/5] target/loongarch: Restrict 'qapi-commands-machine.h' to system emulation

2022-12-20 Thread Philippe Mathieu-Daudé
Since commit a0e61807a3 ("qapi: Remove QMP events and commands from user-mode builds") we don't generate the "qapi-commands-machine.h" header in a user-emulation-only build. Extract the QMP functions from cpu.c (which is always compiled) to the new 'monitor.c' unit (which is only compiled when sys

Re: [PATCH v3 12/18] ui: Move more HMP commands from monitor to ui/

2022-12-20 Thread Philippe Mathieu-Daudé
On 20/12/22 10:06, Markus Armbruster wrote: This moves these commands from MAINTAINERS section "Human Monitor (HMP)" to "Graphics". Signed-off-by: Markus Armbruster --- include/monitor/hmp.h | 2 ++ monitor/misc.c| 66 --- ui/ui-hmp-cmds.c

[PATCH RESEND v2 4/5] target/mips: Restrict 'qapi-commands-machine.h' to system emulation

2022-12-20 Thread Philippe Mathieu-Daudé
Since commit a0e61807a3 ("qapi: Remove QMP events and commands from user-mode builds") we don't generate the "qapi-commands-machine.h" header in a user-emulation-only build. Extract the QMP functions from cpu.c (which is always compiled) to the new 'sysemu/monitor.c' unit (which is only compiled w

Re: [PATCH v3 16/18] ui: Split hmp_mouse_set() and move the HMP part to ui/

2022-12-20 Thread Markus Armbruster
Daniel P. Berrangé writes: > On Tue, Dec 20, 2022 at 10:06:43AM +0100, Markus Armbruster wrote: >> Signed-off-by: Markus Armbruster >> --- >> include/monitor/hmp.h | 1 + >> include/ui/console.h | 2 +- >> monitor/misc.c| 1 - >> ui/input.c| 5 + >> ui/ui-hmp-cmds.c

[PATCH RESEND v2 5/5] target/ppc: Restrict 'qapi-commands-machine.h' to system emulation

2022-12-20 Thread Philippe Mathieu-Daudé
Since commit a0e61807a3 ("qapi: Remove QMP events and commands from user-mode builds") we don't generate the "qapi-commands-machine.h" header in a user-emulation-only build. Move the QMP functions from cpu_init.c (which is always compiled) to monitor.c (which is only compiled when system-emulation

Re: [PATCH v3 1/2] target/ppc: Implement the DEXCR and HDEXCR

2022-12-20 Thread Daniel Henrique Barboza
On 12/20/22 01:23, Nicholas Miehlbradt wrote: Define the DEXCR and HDEXCR as special purpose registers. Each register occupies two SPR indicies, one which can be read in an unprivileged state and one which can be modified in the appropriate priviliged state, however both indicies refer to the

[PATCH v2 0/7] hw/mips: Make gt64xxx_pci.c endian-agnostic

2022-12-20 Thread Philippe Mathieu-Daudé
Patches missing review: 3 & 4 Respining an old/unfinished series... Add the 'cpu-little-endian' qdev property to the GT64120 north bridge so [target-specific] machines can set its endianness, allowing it to be endian agnostic. Since v1: - use DEFINE_PROP_BOOL (Richard) - use R_GT_CPU_Endianness_M

[PATCH v2 1/7] hw/mips/Kconfig: Introduce CONFIG_GT64120 to select gt64xxx_pci.c

2022-12-20 Thread Philippe Mathieu-Daudé
From: Philippe Mathieu-Daudé Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Bernhard Beschow Message-Id: <20221209151533.69516-2-phi...@linaro.org> Reviewed-by: Richard Henderson --- hw/mips/Kconfig | 6 ++ hw/mips/meson.build | 3 ++- 2 files changed, 8 insertions(+), 1 deletion(

Re: [PATCH v3 13/18] ui: Improve "change vnc" error reporting

2022-12-20 Thread Philippe Mathieu-Daudé
On 20/12/22 10:06, Markus Armbruster wrote: Switch from monitor_printf() to error_setg() and hmp_handle_error(). This makes "this is an error" more obvious both in the source and in the monitor, where hmp_handle_error() prefixes the message with "Error: ". Signed-off-by: Markus Armbruster Revie

[PATCH v2 3/7] hw/mips/gt64xxx_pci: Manage endian bits with the RegisterFields API

2022-12-20 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20221209151533.69516-4-phi...@linaro.org> --- hw/mips/gt64xxx_pci.c | 38 +++--- 1 file changed, 23 insertions(+), 15 deletions(-) diff --git a/hw/mips/gt64xxx_pci.c b/hw/mips/gt64xxx_pci.c index 1b9ac7f792..f6fa3

[PATCH v2 4/7] hw/mips/gt64xxx_pci: Add a 'cpu-little-endian' qdev property

2022-12-20 Thread Philippe Mathieu-Daudé
From: Philippe Mathieu-Daudé This device does not have to be TARGET-dependent. Add a 'cpu_big_endian' property which sets the byte-swapping options if required. Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20221209151533.69516-5-phi...@linaro.org> --- hw/mips/gt64xxx_pci.c | 22 +

[PATCH v2 2/7] hw/mips/gt64xxx_pci: Let the GT64120 manage the lower 512MiB hole

2022-12-20 Thread Philippe Mathieu-Daudé
From: Philippe Mathieu-Daudé Per the comment in the Malta board, the [0x.-0x2000.] range is decoded by the GT64120, so move the "empty_slot" there. Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20221209151533.69516-3-phi...@linaro.org> Reviewed-by: Richard Henderson --- confi

Re: [PATCH v3 0/2] target/ppc: Implement Dynamic Execution Control Registers

2022-12-20 Thread Daniel Henrique Barboza
Queued in gitlab.com/danielhb/qemu/tree/ppc-next. Thanks, Daniel On 12/20/22 01:23, Nicholas Miehlbradt wrote: Implements the Dynamic Execution Control Register (DEXCR) and the Hypervisor Dynamic Execution Control Register (HDEXCR) in TCG as defined in Power ISA 3.1B. Only aspects 5 (Non-privi

[PATCH v2 7/7] hw/mips/gt64xxx_pci: Move it to hw/pci-host/

2022-12-20 Thread Philippe Mathieu-Daudé
From: Philippe Mathieu-Daudé The GT-64120 is a north-bridge, and it is not MIPS specific. Move it with the other north-bridge devices. Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20221209151533.69516-8-phi...@linaro.org> Reviewed-by: Richard Henderson --- MAINTAINERS

[PATCH RESEND v2 1/5] target/arm: Restrict 'qapi-commands-machine.h' to system emulation

2022-12-20 Thread Philippe Mathieu-Daudé
Since commit a0e61807a3 ("qapi: Remove QMP events and commands from user-mode builds") we don't generate the "qapi-commands-machine.h" header in a user-emulation-only build. Move the QMP functions from helper.c (which is always compiled) to monitor.c (which is only compiled when system-emulation i

[PATCH RESEND v2 0/5] target: Restrict 'qapi-commands-machine.h' to system emulation

2022-12-20 Thread Philippe Mathieu-Daudé
[resend fixing my last name typography...] All series reviewed, can patches be picked by corresponding maintainers? The "qapi-commands-machine.h" header is not generated in user-only emulation. This series removes its use in user-emu code by moving the QMP code depending on this header into a sep

[PATCH v2 6/7] hw/mips/meson: Make gt64xxx_pci.c endian-agnostic

2022-12-20 Thread Philippe Mathieu-Daudé
From: Philippe Mathieu-Daudé The single machine using this device explicitly sets its endianness. We don't need to set a default. This allow us to remove the target specificity from the build system. Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20221209151533.69516-7-phi...@linaro.org> Re

Re: [PATCH v3 00/18] ui: Move and clean up monitor command code

2022-12-20 Thread Markus Armbruster
Philippe Mathieu-Daudé writes: > On 20/12/22 10:06, Markus Armbruster wrote: >> This is mainly about splitting off monitor-related code. There's also >> a minimum Spice version bump, and a few UI improvements to HMP >> commands sendkey, change vnc, and info spice. > > Possibly related, use of In

Re: [PATCH-for-8.0 5/7] hw/mips/malta: Explicit GT64120 endianness upon device creation

2022-12-20 Thread Philippe Mathieu-Daudé
On 20/12/22 09:30, Philippe Mathieu-Daudé wrote: +Eduardo/Markus for QOM/QDEV clarification. On 20/12/22 01:52, Richard Henderson wrote: On 12/9/22 07:15, Philippe Mathieu-Daudé wrote: Propagate the controller endianess from the machine, setting the "cpu-little-endian" property. Signed-off-by

[PATCH v2 5/7] hw/mips/malta: Explicit GT64120 endianness upon device creation

2022-12-20 Thread Philippe Mathieu-Daudé
Propagate the controller endianess from the machine, setting the "cpu-little-endian" property. Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20221209151533.69516-6-phi...@linaro.org> Reviewed-by: Richard Henderson --- hw/mips/malta.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)

Re: [PATCH v3 12/18] ui: Move more HMP commands from monitor to ui/

2022-12-20 Thread Markus Armbruster
Philippe Mathieu-Daudé writes: > On 20/12/22 10:06, Markus Armbruster wrote: >> This moves these commands from MAINTAINERS section "Human >> Monitor (HMP)" to "Graphics". >> Signed-off-by: Markus Armbruster >> --- >> include/monitor/hmp.h | 2 ++ >> monitor/misc.c| 66 ---

[PATCH] qom/object_interfaces: Fix QAPI headers included

2022-12-20 Thread Philippe Mathieu-Daudé
Since commit a0e61807a3 ("qapi: Remove QMP events and commands from user-mode builds") we don't generate the "qapi-commands-qom.h" header in a user-emulation-only build. Commit f375026606 ("qom: Factor out user_creatable_process_cmdline") incorrectly added a dependency on this "qapi/qapi-commands-

Re: [PATCH v3 12/18] ui: Move more HMP commands from monitor to ui/

2022-12-20 Thread Philippe Mathieu-Daudé
On 20/12/22 12:49, Markus Armbruster wrote: Philippe Mathieu-Daudé writes: On 20/12/22 10:06, Markus Armbruster wrote: This moves these commands from MAINTAINERS section "Human Monitor (HMP)" to "Graphics". Signed-off-by: Markus Armbruster --- include/monitor/hmp.h | 2 ++ monitor/misc

Re: [PULL 00/21] Hexagon update: bug fixes, performance, idef-parser

2022-12-20 Thread Alessandro Di Federico via
On Mon, 19 Dec 2022 18:54:22 + Taylor Simpson wrote: > > Applied, thanks. > > Thanks!! Thanks from our side too! :) We started this project back in 2015, I'm really happy we finally got it in! -- Alessandro Di Federico rev.ng Labs

Re: [PULL 00/21] Hexagon update: bug fixes, performance, idef-parser

2022-12-20 Thread Alessandro Di Federico via
On Tue, 20 Dec 2022 08:30:02 +0100 Philippe Mathieu-Daudé wrote: > Do we really need this level? IIUC the problem with -Wextra is using a > newer compiler toolchain it can include warnings we haven't fixed. > Maybe worthwhile but it can break from times to times. I think we just wanted to be ove

Re: [PATCH v3 0/2] arm: enable MTE for QEMU + kvm

2022-12-20 Thread Cornelia Huck
On Wed, Oct 26 2022, Cornelia Huck wrote: > After wayyy too long (last version was sent in *July*), a respin of my > kvm/mte series. Still no migration support. I've been hacking around on > a device for transferring tags while stopped, but don't really have anything > to show, probably because I

Re: [PATCH v2 1/2] vhost: configure all host notifiers in a single MR transaction

2022-12-20 Thread Michael S. Tsirkin
On Wed, Dec 07, 2022 at 08:22:18AM +0800, Longpeng (Mike, Cloud Infrastructure Service Product Dept.) wrote: > > > And we must commit before invoking virtio_bus_cleanup_host_notifier. > > > > ... but with that info on top, finally your original patch is simpler. > > Yes, I'll try in next version

Re: [PULL 00/13] Monitor patches for 2022-12-19

2022-12-20 Thread Peter Maydell
On Mon, 19 Dec 2022 at 15:51, Markus Armbruster wrote: > > The following changes since commit 562d4af32ec2213061f844b3838223fd7711b56a: > > Merge tag 'pull-loongarch-20221215' of https://gitlab.com/gaosong/qemu into > staging (2022-12-18 13:53:29 +) > > are available in the Git repository a

Re: [PATCH v2 2/4] virtio_net: copy VIRTIO_NET_S_ANNOUNCE if device model has it

2022-12-20 Thread Michael S. Tsirkin
On Wed, Nov 30, 2022 at 02:58:35PM +0800, Jason Wang wrote: > On Fri, Nov 25, 2022 at 1:33 AM Eugenio Pérez wrote: > > > > Status part of the emulated feature. It will follow device model, so we > > must copy it as long as NIC device model has it set. > > > > Signed-off-by: Eugenio Pérez > > ---

[PULL 04/15] hw/ppc/e500: Add Freescale eSDHC to e500plat

2022-12-20 Thread Daniel Henrique Barboza
From: Philippe Mathieu-Daudé Adds missing functionality to e500plat machine which increases the chance of given "real" firmware images to access SD cards. Signed-off-by: Bernhard Beschow Message-Id: <20221018210146.193159-8-shen...@gmail.com> [PMD: Simplify using create_unimplemented_device("es

[PULL 12/15] hw/ppc/e500: Resolve variable shadowing

2022-12-20 Thread Daniel Henrique Barboza
From: Bernhard Beschow Assign to the outer variable instead which even saves some code. Signed-off-by: Bernhard Beschow Reviewed-by: Cédric Le Goater Message-Id: <20221216145709.271940-6-shen...@gmail.com> Signed-off-by: Daniel Henrique Barboza --- hw/ppc/e500.c | 4 +--- 1 file changed, 1 i

[PULL 03/15] hw/sd/sdhci: Support big endian SD host controller interfaces

2022-12-20 Thread Daniel Henrique Barboza
From: Philippe Mathieu-Daudé Some SDHCI IP can be synthetized in various endianness: https://github.com/u-boot/u-boot/blob/v2021.04/doc/README.fsl-esdhc - CONFIG_SYS_FSL_ESDHC_BE ESDHC IP is in big-endian mode. Accessing ESDHC registers can be determined by ESDHC IP's endian mode or proc

[PULL 14/15] target/ppc: Implement the DEXCR and HDEXCR

2022-12-20 Thread Daniel Henrique Barboza
From: Nicholas Miehlbradt Define the DEXCR and HDEXCR as special purpose registers. Each register occupies two SPR indicies, one which can be read in an unprivileged state and one which can be modified in the appropriate priviliged state, however both indicies refer to the same underlying value.

Re: [PATCH v2 2/4] virtio_net: copy VIRTIO_NET_S_ANNOUNCE if device model has it

2022-12-20 Thread Eugenio Perez Martin
On Wed, Nov 30, 2022 at 7:58 AM Jason Wang wrote: > > On Fri, Nov 25, 2022 at 1:33 AM Eugenio Pérez wrote: > > > > Status part of the emulated feature. It will follow device model, so we > > must copy it as long as NIC device model has it set. > > > > Signed-off-by: Eugenio Pérez > > --- > > hw

[PULL 13/15] hw/ppc/e500: Move comment to more appropriate place

2022-12-20 Thread Daniel Henrique Barboza
From: Bernhard Beschow The TLB entries are set up in mmubooke_create_initial_mapping(), not in booke206_page_size_to_tlb(). Signed-off-by: Bernhard Beschow Reviewed-by: Cédric Le Goater Message-Id: <20221216145709.271940-7-shen...@gmail.com> Signed-off-by: Daniel Henrique Barboza --- hw/ppc/

Re: [PATCH 0/3] Fix UNMAP notifier for intel-iommu

2022-12-20 Thread Michael S. Tsirkin
On Tue, Nov 29, 2022 at 04:10:34PM +0800, Jason Wang wrote: > Hi All: > > According to ATS, device should work if ATS is disabled. This is not > correctly implemented in the current intel-iommu since it doesn't > handle the UNMAP notifier correctly. This breaks the vhost-net + > vIOMMU without dt.

[PULL 02/15] hw/sd/sdhci: MMIO region is implemented in 32-bit accesses

2022-12-20 Thread Daniel Henrique Barboza
From: Philippe Mathieu-Daudé Tested-by: Bernhard Beschow Reviewed-by: Bernhard Beschow Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20221101222934.52444-2-phi...@linaro.org> Signed-off-by: Daniel Henrique Barboza --- hw/sd/sdhci.c | 4 1 file changed, 4 insertions(+) diff --git a

[PULL 11/15] hw/ppc/e500: Prefer local variable over qdev_get_machine()

2022-12-20 Thread Daniel Henrique Barboza
From: Bernhard Beschow Signed-off-by: Bernhard Beschow Reviewed-by: Cédric Le Goater Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20221216145709.271940-5-shen...@gmail.com> Signed-off-by: Daniel Henrique Barboza --- hw/ppc/e500.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

Re: [RFC PATCH v2 20/22] i386/xen: HVMOP_set_param / HVM_PARAM_CALLBACK_IRQ

2022-12-20 Thread Paul Durrant
On 15/12/2022 20:54, David Woodhouse wrote: On Mon, 2022-12-12 at 16:39 +, Paul Durrant wrote: On 12/12/2022 16:26, David Woodhouse wrote: On Mon, 2022-12-12 at 16:16 +, Paul Durrant wrote: On 09/12/2022 09:56, David Woodhouse wrote: From: Ankur Arora The HVM_PARAM_CALLBACK_IRQ param

[PULL 06/15] hw/ppc/vof: Do not include the full "cpu.h"

2022-12-20 Thread Daniel Henrique Barboza
From: Philippe Mathieu-Daudé "vof.h" doesn't need the full "cpu.h" to get the target_ulong definition, including "exec/cpu-defs.h" is enough. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Daniel Henrique Barboza Message-Id: <20221213123550.39302-3-phi...@linaro.org> Signed-off-by: Daniel

[PULL 05/15] target/ppc/kvm: Add missing "cpu.h" and "exec/hwaddr.h"

2022-12-20 Thread Daniel Henrique Barboza
From: Philippe Mathieu-Daudé kvm_ppc.h is missing various declarations from "cpu.h": target/ppc/kvm_ppc.h:128:40: error: unknown type name 'CPUPPCState'; did you mean 'CPUState'? static inline int kvmppc_get_hypercall(CPUPPCState *env, ^~~

[PULL 15/15] target/ppc: Check DEXCR on hash{st, chk} instructions

2022-12-20 Thread Daniel Henrique Barboza
From: Nicholas Miehlbradt Adds checks to the hashst and hashchk instructions to only execute if enabled by the relevant aspect in the DEXCR and HDEXCR. This behaviour is guarded behind TARGET_PPC64 since Power10 is currently the only implementation which has the DEXCR. Reviewed-by: Daniel Henri

[PULL 01/15] MAINTAINERS: downgrade PPC KVM/TCG CPUs and pSeries to 'Odd Fixes'

2022-12-20 Thread Daniel Henrique Barboza
The maintainer is no longer being paid to maintain these components. All maintainership work is being done in his personal time since the middle of the 7.2 development cycle. Change the status of PPC KVM CPUs, PPC TCG CPUs and the pSeries machine to 'Odd Fixes', reflecting that the maintainer no l

Re: [PATCH 1/5] target/arm: only build psci for TCG

2022-12-20 Thread Fabiano Rosas
Alexander Graf writes: > Hey Fabiano, > > On 19.12.22 12:42, Fabiano Rosas wrote: >> Claudio Fontana writes: >> >>> Ciao Alex, >>> >>> On 12/19/22 11:47, Alexander Graf wrote: Hey Claudio, On 19.12.22 09:37, Claudio Fontana wrote: > On 12/16/22 22:59, Alexander Graf wrote: >>>

[PULL 07/15] hw/ppc/spapr: Reduce "vof.h" inclusion

2022-12-20 Thread Daniel Henrique Barboza
From: Philippe Mathieu-Daudé Currently objects including "hw/ppc/spapr.h" are forced to be target specific due to the inclusion of "vof.h" in "spapr.h". "spapr.h" only uses a Vof pointer, so doesn't require the structure declaration. The only place where Vof structure is accessed is in spapr.c,

[PULL 10/15] hw/ppc/virtex_ml507: Prefer local over global variable

2022-12-20 Thread Daniel Henrique Barboza
From: Bernhard Beschow Signed-off-by: Bernhard Beschow Reviewed-by: Edgar E. Iglesias Reviewed-by: Cédric Le Goater Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20221216145709.271940-4-shen...@gmail.com> Signed-off-by: Daniel Henrique Barboza --- hw/ppc/virtex_ml507.c | 2 +- 1 file cha

[PULL 09/15] target/ppc/mmu_common: Fix table layout of "info tlb" HMP command

2022-12-20 Thread Daniel Henrique Barboza
From: Bernhard Beschow Starting with the URWX columns the columns didn't line up. Before: QEMU 7.2.50 monitor - type 'help' for more information (qemu) info tlb TLB0: Effective Physical Size TID TS SRWX URWX WIMGE U0123 0x00a8 0x0105d000 4K 1

[PULL 00/15] ppc queue

2022-12-20 Thread Daniel Henrique Barboza
The following changes since commit 33698d3abf8ce65c38bb4b12b600b130d2682c79: Merge tag 'pull-monitor-2022-12-19' of https://repo.or.cz/qemu/armbru into staging (2022-12-19 16:12:59 +) are available in the Git repository at: https://gitlab.com/danielhb/qemu.git tags/pull-pp

  1   2   3   4   >