Daniel P. Berrangé <berra...@redhat.com> writes:
> On Tue, Dec 20, 2022 at 10:06:43AM +0100, Markus Armbruster wrote:
>> Signed-off-by: Markus Armbruster <arm...@redhat.com>
>> ---
>> include/monitor/hmp.h | 1 +
>> include/ui/console.h | 2 +-
>> monitor/misc.c | 1 -
>> ui/input.c | 5 +----
>> ui/ui-hmp-cmds.c | 8 ++++++++
>> 5 files changed, 11 insertions(+), 6 deletions(-)
>
>>
>> -void hmp_mouse_set(Monitor *mon, const QDict *qdict)
>> +void qemu_mouse_set(int index, Error **err)
>
> This is adding a Error parameter, nit s/err/errp/
Yes.
>> {
>> QemuInputHandlerState *s;
>> - int index = qdict_get_int(qdict, "index");
>> int found = 0;
>>
>> QTAILQ_FOREACH(s, &handlers, node) {
>
> But not changing either error_report() call to error_setg(),
> so the errp is unused.
I suspect I some distraction hit my flu-addled brain in just the right
moment, and I forgot to flip to error_setg(). Will fix, thanks!
