Re: [PATCH v5] acpi/tests/avocado/bits: some misc fixes

2022-11-17 Thread Thomas Huth
On 17/11/2022 06.36, Ani Sinha wrote: Most of the changes are trivial. The bits test timeout has now been increased to 200 seconds in order to accommodate slower systems and fewer unnecessary failures. Removed of the reference to non-existent README file in docs. Some minor corrections in the doc

Re: [PATCH maybe-7.2 1/3] hw/i2c: only schedule pending master when bus is idle

2022-11-17 Thread Cédric Le Goater
On 11/17/22 08:37, Klaus Jensen wrote: On Nov 17 07:56, Cédric Le Goater wrote: On 11/17/22 07:40, Klaus Jensen wrote: On Nov 16 16:58, Cédric Le Goater wrote: On 11/16/22 09:43, Klaus Jensen wrote: From: Klaus Jensen It is not given that the current master will release the bus after a tran

Re: [PATCH 2/2] Do not access /dev/mem in MSI-X PCI passthrough on Xen

2022-11-17 Thread Jan Beulich
On 17.11.2022 04:34, Marek Marczykowski-Górecki wrote: > Ok, I found what is wrong. Enabling MSI-X is refused, because INTx isn't > disabled at this point yet. And apparently I was testing this with > permissive=1... > > Linux does this: > https://github.com/torvalds/linux/blob/master/drivers/pci/

Re: [PATCH for 8.0 v7 10/10] vdpa: Always start CVQ in SVQ mode if possible

2022-11-17 Thread Eugenio Perez Martin
On Thu, Nov 17, 2022 at 8:43 AM Eugenio Perez Martin wrote: > > On Thu, Nov 17, 2022 at 7:52 AM Jason Wang wrote: > > > > > > 在 2022/11/16 23:05, Eugenio Pérez 写道: > > > Isolate control virtqueue in its own group, allowing to intercept control > > > commands but letting dataplane run totally pass

Re: [PATCH] target/ppc: Fix build warnings when building with 'disable-tcg'

2022-11-17 Thread Thomas Huth
On 16/11/2022 16.30, Philippe Mathieu-Daudé wrote: On 16/11/22 16:20, Greg Kurz wrote: Hi Vaibhav, Nice to see some people are still building QEMU at IBM ;-) On Wed, 16 Nov 2022 18:47:43 +0530 Vaibhav Jain wrote: Kowshik reported that building qemu with GCC 12.2.1 for 'ppc64-softmmu' target

Re: [PATCH v11 04/11] s390x/cpu topology: reporting the CPU topology to the guest

2022-11-17 Thread Cédric Le Goater
On 11/3/22 18:01, Pierre Morel wrote: The guest can use the STSI instruction to get a buffer filled with the CPU topology description. Let us implement the STSI instruction for the basis CPU topology level, level 2. Signed-off-by: Pierre Morel --- include/hw/s390x/cpu-topology.h | 6 ++ t

Re: [PATCH] acpi/tests/avocado/bits: don't remove the work directory when V is in env

2022-11-17 Thread Daniel P . Berrangé
On Thu, Nov 17, 2022 at 01:16:29PM +0530, Ani Sinha wrote: > Debugging bits issue often involves running the QEMU command line manually > outside of the avocado environment with the generated ISO. Hence, its > inconvenient if the iso gets cleaned up after the test has finished. This > change > mak

Re: [PATCH] qga: Add initial OpenBSD and NetBSD support

2022-11-17 Thread Konstantin Kostiuk
Reviewed-by: Konstantin Kostiuk On Sun, Nov 13, 2022 at 9:32 PM Philippe Mathieu-Daudé wrote: > On 12/11/22 12:40, Brad Smith wrote: > > qga: Add initial OpenBSD and NetBSD support > > > > Signed-off-by: Brad Smith > > --- > > meson.build | 2 +- > > qga/commands-bsd.c | 5 +

Re: [PATCH 1/2] qga: Move FS TRIM code to commands-linux.c

2022-11-17 Thread Konstantin Kostiuk
Reviewed-by: Konstantin Kostiuk On Tue, Nov 15, 2022 at 8:46 PM Alexander Ivanov < alexander.iva...@virtuozzo.com> wrote: > In the next patch ZFS TRIM support for FreeBSD will be added. Move > Linux-specific TRIM code to commands-linux.c file. > > Signed-off-by: Alexander Ivanov > --- > qga/co

Re: [PATCH v3 1/9] target/riscv: add cfg properties for Zc* extension

2022-11-17 Thread Richard Henderson
On 11/16/22 23:03, Weiwei Li wrote: Add properties for Zca,Zcb,Zcf,Zcd,Zcmp,Zcmt extension Add check for these properties Signed-off-by: Weiwei Li Signed-off-by: Junqiang Wang Cc: Alistair Francis --- target/riscv/cpu.c | 43 +++ target/riscv/cpu.h | 6

Re: [PATCH 2/2] qga: Add ZFS TRIM support for FreeBSD

2022-11-17 Thread Konstantin Kostiuk
Reviewed-by: Konstantin Kostiuk On Tue, Nov 15, 2022 at 8:46 PM Alexander Ivanov < alexander.iva...@virtuozzo.com> wrote: > Use zpool tool for ZFS pools trimming in FreeBSD. > > Signed-off-by: Alexander Ivanov > --- > qga/commands-bsd.c| 109 ++ > qg

Re: [PATCH v3 2/9] target/riscv: add support for Zca extension

2022-11-17 Thread Richard Henderson
On 11/16/22 23:03, Weiwei Li wrote: Modify the check for C extension to Zca (C implies Zca) Signed-off-by: Weiwei Li Signed-off-by: Junqiang Wang --- target/riscv/insn_trans/trans_rvi.c.inc | 4 ++-- target/riscv/translate.c| 8 ++-- 2 files changed, 8 insertions(+), 4 de

Re: [PATCH v3 3/9] target/riscv: add support for Zcf extension

2022-11-17 Thread Richard Henderson
On 11/16/22 23:03, Weiwei Li wrote: Separate c_flw/c_fsw from flw/fsw to add check for Zcf extension Signed-off-by: Weiwei Li Signed-off-by: Junqiang Wang --- target/riscv/insn16.decode | 8 target/riscv/insn_trans/trans_rvf.c.inc | 18 ++ 2 files chang

Re: [PATCH] ci: replace x86_64 macos-11 with aarch64 macos-12

2022-11-17 Thread Thomas Huth
On 16/11/2022 18.50, Daniel P. Berrangé wrote: The Cirrus CI service has announced the intent to discontinue support for x86_64 macOS CI runners. They already have aarch64 runners available and require all projects to switch to these images before Jan 1st 2023. The different architecture is merel

[PULL 3/4] ci: replace x86_64 macos-11 with aarch64 macos-12

2022-11-17 Thread Thomas Huth
From: Daniel P. Berrangé The Cirrus CI service has announced the intent to discontinue support for x86_64 macOS CI runners. They already have aarch64 runners available and require all projects to switch to these images before Jan 1st 2023. The different architecture is merely determined by the im

[PULL 1/4] s390x: Fix spelling errors

2022-11-17 Thread Thomas Huth
Fix typos (discovered with the 'codespell' utility). Note: Though "migrateable" still seems to be a valid spelling, we change it to "migratable" since this is the way more common spelling here. Message-Id: <2022182828.282251-1-th...@redhat.com> Reviewed-by: Stefan Weil Reviewed-by: Ilya Leosh

Re: [PATCH v3 5/9] target/riscv: add support for Zcb extension

2022-11-17 Thread Richard Henderson
On 11/16/22 23:03, Weiwei Li wrote: Add encode and trans* functions support for Zcb instructions Signed-off-by: Weiwei Li Signed-off-by: Junqiang Wang --- target/riscv/insn16.decode| 24 ++ target/riscv/insn_trans/trans_rvzce.c.inc | 100 ++ target/ri

[PULL 4/4] acpi/tests/avocado/bits: some misc fixes

2022-11-17 Thread Thomas Huth
From: Ani Sinha Most of the changes are trivial. The bits test timeout has now been increased to 200 seconds in order to accommodate slower systems and fewer unnecessary failures. Removed of the reference to non-existent README file in docs. Some minor corrections in the doc file. Signed-off-by:

[PULL 0/4] Some small s390x and testing fixes

2022-11-17 Thread Thomas Huth
Hi Stefan! The following changes since commit 2c8311241d1f7377bb4ff76064b1d1fe15166413: Update VERSION for v7.2.0-rc1 (2022-11-15 18:56:38 -0500) are available in the Git repository at: https://gitlab.com/thuth/qemu.git tags/pull-request-2022-11-17 for you to fetch changes up to 1b7a07c44

[PULL 2/4] docs/system/s390x: Document the "loadparm" machine property

2022-11-17 Thread Thomas Huth
The "loadparm" machine property is useful for selecting alternative kernels on the disk of the guest, but so far we do not tell the users yet how to use it. Add some documentation to fill this gap. Buglink: https://bugzilla.redhat.com/show_bug.cgi?id=2128235 Message-Id: <20221114132502.110213-1-th

Re: [PATCH v9 00/10] s390x: CPU Topology

2022-11-17 Thread Pierre Morel
On 11/16/22 17:51, Christian Borntraeger wrote: Am 02.09.22 um 09:55 schrieb Pierre Morel: Hi, The implementation of the CPU Topology in QEMU has been drastically modified since the last patch series and the number of LOCs has been greatly reduced. Unnecessary objects have been removed, onl

Re: [PATCH v11 04/11] s390x/cpu topology: reporting the CPU topology to the guest

2022-11-17 Thread Pierre Morel
On 11/17/22 09:40, Cédric Le Goater wrote: On 11/3/22 18:01, Pierre Morel wrote: The guest can use the STSI instruction to get a buffer filled with the CPU topology description. Let us implement the STSI instruction for the basis CPU topology level, level 2. Signed-off-by: Pierre Morel ---

Re: [PATCH] MAINTAINERS: Inherit from nanoMIPS

2022-11-17 Thread Milica Lazarevic
6 months ago Stefan Pejic stepped in as nanoMIPS maintainer (see commit a 8e0e23445a "target/mips: Undeprecate nanoMIPS ISA support in QEMU"), however today his email is bouncing: ** Message blocked ** Your message to stefan.pe...@syrmia.com has been blocked. See technical details below for mor

Re: [PATCH v3 6/9] target/riscv: add support for Zcmp extension

2022-11-17 Thread Richard Henderson
On 11/16/22 23:03, Weiwei Li wrote: Add encode, trans* functions for Zcmp instructions Signed-off-by: Weiwei Li Signed-off-by: Junqiang Wang --- target/riscv/insn16.decode| 18 ++ target/riscv/insn_trans/trans_rvzce.c.inc | 242 +- target/riscv/translat

Re: [PATCH v2 01/10] qga: Remove platform GUID definitions

2022-11-17 Thread Konstantin Kostiuk
Reviewed-by: Konstantin Kostiuk Will merge this patch in QGA series On Thu, Nov 10, 2022 at 12:06 PM Akihiko Odaki wrote: > GUID_DEVINTERFACE_DISK and GUID_DEVINTERFACE_STORAGEPORT are already > defined by MinGW-w64. They are not only unnecessary, but can lead to > duplicate definition errors

Re: [PATCH v3 7/9] target/riscv: add support for Zcmt extension

2022-11-17 Thread Richard Henderson
On 11/16/22 23:03, Weiwei Li wrote: +target_ulong HELPER(cm_jalt)(CPURISCVState *env, target_ulong index, + target_ulong next_pc) +{ +target_ulong target = next_pc; +target_ulong val = 0; +int xlen = riscv_cpu_xlen(env); + +val = env->jvt; + +uint8_

Re: [PATCH for-8.0 1/1] target/ppc: Use tcg_gen_atomic_cmpxchg_i128 for STQCX

2022-11-17 Thread Daniel Henrique Barboza
On 11/16/22 23:48, Richard Henderson wrote: I think you missed the Based-on tag. r~ Duh. Sorry about that. Let me try it again. Daniel On Wed, 16 Nov 2022, 05:38 Daniel Henrique Barboza, mailto:danielhb...@gmail.com>> wrote: Richard, I believe the ppc64-linux-user target di

Re: [PATCH] target/ppc: Fix build warnings when building with 'disable-tcg'

2022-11-17 Thread Daniel Henrique Barboza
Queued in gitlab.com/danielhb/qemu/tree/ppc-next with the following tags: Reported-by: Kowshik Jois B S Fixes: 61bd1d2942 ("target/ppc: Convert to tcg_ops restore_state_to_opc") Fixes: 670f1da374 ("target/ppc: Implement hashst and hashchk") Resolves: https://gitlab.com/qemu-proj

Re: [PATCH] target/ppc: Fix build warnings when building with 'disable-tcg'

2022-11-17 Thread Vaibhav Jain
Hi Daniel, Thanks for quick turnaround on this, Minor correction to the commit tags below: Daniel Henrique Barboza writes: > Queued in gitlab.com/danielhb/qemu/tree/ppc-next with the following tags: > > > Reported-by: Kowshik Jois B S > Fixes: 61bd1d2942 ("target/ppc: Convert to t

Re: [PATCH] target/ppc: Fix build warnings when building with 'disable-tcg'

2022-11-17 Thread Greg Kurz
On Thu, 17 Nov 2022 07:11:51 -0300 Daniel Henrique Barboza wrote: > Queued in gitlab.com/danielhb/qemu/tree/ppc-next with the following tags: > You are planning a PR before 7.2-rc2, right ? > > Reported-by: Kowshik Jois B S > Fixes: 61bd1d2942 ("target/ppc: Convert to tcg_ops resto

Re: [PATCH for-7.2] rtl8139: honor large send MSS value

2022-11-17 Thread Stefan Hajnoczi
On Wed, 16 Nov 2022 at 21:49, Tobias Fiebig wrote: > > Heho, > Ok, I just learned more C than I ever wanted to. There is a bit more amiss > here (ll from 7d7238c72b983cff5064734349d2d45be9c6282c): > > In line 1916 of rtl8139.c we set txdw0; If we calculate the MSS at this > point, it is consiste

Re: [PATCH for-7.2] rtl8139: honor large send MSS value

2022-11-17 Thread Stefan Hajnoczi
After looking more closely at txdw0 it seems that the code mixes "Tx command mode 0", "Tx command mode 1", and "Tx status mode". The bits have different meanings in each mode, so this leads to confusion :). Stefan

Re: [PATCH 2/2] Do not access /dev/mem in MSI-X PCI passthrough on Xen

2022-11-17 Thread Marek Marczykowski-Górecki
On Thu, Nov 17, 2022 at 09:04:40AM +0100, Jan Beulich wrote: > On 17.11.2022 04:34, Marek Marczykowski-Górecki wrote: > > Ok, I found what is wrong. Enabling MSI-X is refused, because INTx isn't > > disabled at this point yet. And apparently I was testing this with > > permissive=1... > > > > Linu

[PATCH for-7.2] tests/avocado/boot_linux.py: Bump aarch64 virt test timeout to 720s

2022-11-17 Thread Peter Maydell
The two tests tests/avocado/boot_linux.py:BootLinuxAarch64.test_virt_tcg_gicv2 tests/avocado/boot_linux.py:BootLinuxAarch64.test_virt_tcg_gicv3 take quite a long time to run, and the current timeout of 240s is not enough for the tests to complete on slow machines: we've seen these tests time out i

RE: [PATCH for-7.2] rtl8139: honor large send MSS value

2022-11-17 Thread Tobias Fiebig
Heho, Ok, that explains a lot. I was also thinking that the vlan bit seem to overlap with the MTU field, and wanted to look at that later today. Re the 12b: IIRC, the standard 1500 MTU for ethernet is already without the ethernet header; That can have up to 26b (18b basis, 4b 802.1q, 4b 802.1ad)

[PATCH v2] acpi/tests/avocado/bits: keep the work directory when BITS_DEBUG is set in env

2022-11-17 Thread Ani Sinha
Debugging bits issue often involves running the QEMU command line manually outside of the avocado environment with the generated ISO. Hence, its inconvenient if the iso gets cleaned up after the test has finished. This change makes sure that the work directory is kept after the test finishes if the

Re: [PATCH] acpi/tests/avocado/bits: don't remove the work directory when V is in env

2022-11-17 Thread Ani Sinha
On Thu, Nov 17, 2022 at 2:18 PM Daniel P. Berrangé wrote: > > On Thu, Nov 17, 2022 at 01:16:29PM +0530, Ani Sinha wrote: > > Debugging bits issue often involves running the QEMU command line manually > > outside of the avocado environment with the generated ISO. Hence, its > > inconvenient if the

Re: [PATCH v3 6/9] target/riscv: add support for Zcmp extension

2022-11-17 Thread weiwei
Thanks for your detail comments! On 2022/11/17 17:44, Richard Henderson wrote: On 11/16/22 23:03, Weiwei Li wrote: Add encode, trans* functions for Zcmp instructions Signed-off-by: Weiwei Li Signed-off-by: Junqiang Wang ---   target/riscv/insn16.decode    |  18 ++   target/riscv/

Re: [PATCH v3 7/9] target/riscv: add support for Zcmt extension

2022-11-17 Thread weiwei
On 2022/11/17 17:56, Richard Henderson wrote: On 11/16/22 23:03, Weiwei Li wrote: +target_ulong HELPER(cm_jalt)(CPURISCVState *env, target_ulong index, + target_ulong next_pc) +{ +    target_ulong target = next_pc; +    target_ulong val = 0; +    int xlen = riscv_cp

Re: [PATCH maybe-7.2 1/3] hw/i2c: only schedule pending master when bus is idle

2022-11-17 Thread Klaus Jensen
On Nov 17 09:01, Cédric Le Goater wrote: > On 11/17/22 08:37, Klaus Jensen wrote: > > On Nov 17 07:56, Cédric Le Goater wrote: > > > On 11/17/22 07:40, Klaus Jensen wrote: > > > > On Nov 16 16:58, Cédric Le Goater wrote: > > > > > On 11/16/22 09:43, Klaus Jensen wrote: > > > > > > From: Klaus Jense

Re: [PATCH for-7.2] tests/avocado/boot_linux.py: Bump aarch64 virt test timeout to 720s

2022-11-17 Thread Thomas Huth
On 17/11/2022 12.16, Peter Maydell wrote: The two tests tests/avocado/boot_linux.py:BootLinuxAarch64.test_virt_tcg_gicv2 tests/avocado/boot_linux.py:BootLinuxAarch64.test_virt_tcg_gicv3 take quite a long time to run, and the current timeout of 240s is not enough for the tests to complete on slow

[RFC PATCH] tests/avocado: move aarch64 boot_linux tcg tests and slim down

2022-11-17 Thread Alex Bennée
The boot_linux tests download and run a full cloud image boot and start a full distro. While the ability to test the full boot chain is worthwhile it is perhaps a little too heavy weight and causes issues in CI. Fix this by dropping the TCG tests in boot_linux and replacing them with a alpine linux

Re: [RFC PATCH] tests/avocado: move aarch64 boot_linux tcg tests and slim down

2022-11-17 Thread Philippe Mathieu-Daudé
On 17/11/22 13:19, Alex Bennée wrote: The boot_linux tests download and run a full cloud image boot and start a full distro. While the ability to test the full boot chain is worthwhile it is perhaps a little too heavy weight and causes issues in CI. Fix this by dropping the TCG tests in boot_linu

RE: [PATCH v3] block/rbd: Add support for layered encryption

2022-11-17 Thread Or Ozeri
> -Original Message- > From: Daniel P. Berrangé > Sent: 16 November 2022 13:15 > To: Or Ozeri ; qemu-devel@nongnu.org; qemu- > bl...@nongnu.org; Danny Harnik ; > idryo...@gmail.com > Subject: [EXTERNAL] Re: [PATCH v3] block/rbd: Add support for layered > encryption > > On Wed, Nov 16, 2

[PATCH for-7.2] tests/avocado/boot_linux: Increase the timeout of the ppc64 test

2022-11-17 Thread Thomas Huth
The BootLinuxPPC64.test_pseries_tcg test currently times out in the gitlab-CI or when building QEMU with --enable-debug. It takes way more than 300 seconds to finish the test in such environments, so let's bump the timeout to a more appropriate value. Signed-off-by: Thomas Huth --- tests/avocado

Re: [PATCH v3] block/rbd: Add support for layered encryption

2022-11-17 Thread Daniel P . Berrangé
On Thu, Nov 17, 2022 at 12:42:04PM +, Or Ozeri wrote: > > > > -Original Message- > > From: Daniel P. Berrangé > > Sent: 16 November 2022 13:15 > > To: Or Ozeri ; qemu-devel@nongnu.org; qemu- > > bl...@nongnu.org; Danny Harnik ; > > idryo...@gmail.com > > Subject: [EXTERNAL] Re: [PATC

Re: [PATCH for-7.2] tests/avocado/boot_linux: Increase the timeout of the ppc64 test

2022-11-17 Thread Peter Maydell
On Thu, 17 Nov 2022 at 12:46, Thomas Huth wrote: > > The BootLinuxPPC64.test_pseries_tcg test currently times out in > the gitlab-CI or when building QEMU with --enable-debug. It takes > way more than 300 seconds to finish the test in such environments, > so let's bump the timeout to a more approp

Re: UI layer threading and locking strategy; memory_region_snapshot_and_clear_dirty() races

2022-11-17 Thread Peter Maydell
On Tue, 1 Nov 2022 at 14:17, Peter Maydell wrote: > > Hi; I'm trying to find out what the UI layer's threading and > locking strategy is, at least as far as it applies to display > device models. Ping! :-) I'm still looking for information about this, and about what threads call_rcu() callbacks m

Re: [PATCH] target/ppc: Fix build warnings when building with 'disable-tcg'

2022-11-17 Thread Cédric Le Goater
On 11/17/22 11:50, Greg Kurz wrote: On Thu, 17 Nov 2022 07:11:51 -0300 Daniel Henrique Barboza wrote: Queued in gitlab.com/danielhb/qemu/tree/ppc-next with the following tags: You are planning a PR before 7.2-rc2, right ? Reported-by: Kowshik Jois B S Fixes: 61bd1d2942 ("tar

Re: [PATCH v9 5/8] KVM: Register/unregister the guest private memory regions

2022-11-17 Thread Chao Peng
On Wed, Nov 16, 2022 at 10:24:11PM +, Sean Christopherson wrote: > On Tue, Oct 25, 2022, Chao Peng wrote: > > +static int kvm_vm_ioctl_set_mem_attr(struct kvm *kvm, gpa_t gpa, gpa_t > > size, > > +bool is_private) > > +{ > > + gfn_t start, end; > > + unsigne

Re: [PATCH 12/13] block: Don't poll in bdrv_replace_child_noperm()

2022-11-17 Thread Kevin Wolf
Am 14.11.2022 um 21:22 hat Hanna Reitz geschrieben: > On 08.11.22 13:37, Kevin Wolf wrote: > > In order to make sure that bdrv_replace_child_noperm() doesn't have to > > poll any more, get rid of the bdrv_parent_drained_begin_single() call. > > > > This is possible now because we can require that

Re: [PATCH v9 7/8] KVM: Handle page fault for private memory

2022-11-17 Thread Chao Peng
On Wed, Nov 16, 2022 at 10:13:07PM +, Sean Christopherson wrote: > On Wed, Nov 16, 2022, Ackerley Tng wrote: > > >@@ -4173,6 +4203,22 @@ static int kvm_faultin_pfn(struct kvm_vcpu *vcpu, > > >struct kvm_page_fault *fault) > > > return RET_PF_EMULATE; > > > } > > > > > >+ i

Re: [PATCH v2 02/12] tests/avocado: improve behaviour waiting for login prompts

2022-11-17 Thread Cédric Le Goater
Hello Alex, On 11/11/22 15:55, Alex Bennée wrote: This attempts to deal with the problem of login prompts not being guaranteed to be terminated with a newline. The solution to this is to peek at the incoming data looking to see if we see an up-coming match before we fall back to the old readline

Re: [PATCH maybe-7.2 1/3] hw/i2c: only schedule pending master when bus is idle

2022-11-17 Thread Cédric Le Goater
On 11/17/22 12:58, Klaus Jensen wrote: On Nov 17 09:01, Cédric Le Goater wrote: On 11/17/22 08:37, Klaus Jensen wrote: On Nov 17 07:56, Cédric Le Goater wrote: On 11/17/22 07:40, Klaus Jensen wrote: On Nov 16 16:58, Cédric Le Goater wrote: On 11/16/22 09:43, Klaus Jensen wrote: From: Klaus

Re: [PATCH for-7.2] tests/avocado/boot_linux: Increase the timeout of the ppc64 test

2022-11-17 Thread Thomas Huth
On 17/11/2022 13.55, Peter Maydell wrote: On Thu, 17 Nov 2022 at 12:46, Thomas Huth wrote: The BootLinuxPPC64.test_pseries_tcg test currently times out in the gitlab-CI or when building QEMU with --enable-debug. It takes way more than 300 seconds to finish the test in such environments, so let

Re: [PATCH v9 3/8] KVM: Add KVM_EXIT_MEMORY_FAULT exit

2022-11-17 Thread Chao Peng
On Wed, Nov 16, 2022 at 06:48:43PM +, Sean Christopherson wrote: > On Wed, Nov 16, 2022, Andy Lutomirski wrote: > > > > > > On Tue, Oct 25, 2022, at 8:13 AM, Chao Peng wrote: > > > diff --git a/Documentation/virt/kvm/api.rst > > > b/Documentation/virt/kvm/api.rst > > > index f3fa75649a78..97

Re: [PATCH v9 3/8] KVM: Add KVM_EXIT_MEMORY_FAULT exit

2022-11-17 Thread Chao Peng
On Wed, Nov 16, 2022 at 07:03:49PM +, Alex Bennée wrote: > > Chao Peng writes: > > > On Tue, Nov 15, 2022 at 04:56:12PM +, Alex Bennée wrote: > >> > >> Chao Peng writes: > >> > >> > This new KVM exit allows userspace to handle memory-related errors. It > >> > indicates an error happen

Re: [PATCH v2 02/12] tests/avocado: improve behaviour waiting for login prompts

2022-11-17 Thread Peter Maydell
On Thu, 17 Nov 2022 at 13:39, Cédric Le Goater wrote: > > Hello Alex, > > On 11/11/22 15:55, Alex Bennée wrote: > > This attempts to deal with the problem of login prompts not being > > guaranteed to be terminated with a newline. The solution to this is to > > peek at the incoming data looking to

Re: [PATCH 3/4] hw/cxl: Multi-Region CXL Type-3 Devices (Volatile and Persistent)

2022-11-17 Thread Jonathan Cameron via
On Mon, 14 Nov 2022 18:00:59 -0500 Gregory Price wrote: > On Mon, Nov 14, 2022 at 05:53:41PM +, Jonathan Cameron wrote: > > Hi Gregory, > > > > I've not been rushing on this purely because we are after the feature > > freeze for this QEMU cycle so no great rush to line up new features > > (a

Re: [PATCH v2 3/3] hvf: handle writes of MDSCR_EL1 and DBG*_EL1

2022-11-17 Thread Mads Ynddal
> On 16 Nov 2022, at 18.47, francesco.cag...@gmail.com wrote: > > From: Francesco Cagnin > > This proved to be required when debugging the Linux kernel's initial > code, as the Hypervisor framework was triggering 'EC_SYSTEMREGISTERTRAP' > VM exits after enabling trap exceptions with > 'hv_vcpu

Re: [PATCH v2 2/3] hvf: implement guest debugging on Apple Silicon hosts

2022-11-17 Thread Mads Ynddal
> On 16 Nov 2022, at 18.47, francesco.cag...@gmail.com wrote: > > From: Francesco Cagnin > > Support is added for single-stepping, software breakpoints, hardware > breakpoints and watchpoints. The code has been structured like the KVM > counterpart (and many parts are basically identical). >

Re: [PATCH v2 02/12] tests/avocado: improve behaviour waiting for login prompts

2022-11-17 Thread Alex Bennée
Cédric Le Goater writes: > Hello Alex, > > On 11/11/22 15:55, Alex Bennée wrote: >> This attempts to deal with the problem of login prompts not being >> guaranteed to be terminated with a newline. The solution to this is to >> peek at the incoming data looking to see if we see an up-coming matc

Re: [PATCH v9 0/8] KVM: mm: fd-based approach for supporting KVM

2022-11-17 Thread Chao Peng
On Wed, Nov 16, 2022 at 09:40:23AM +, Alex Bennée wrote: > > Chao Peng writes: > > > On Mon, Nov 14, 2022 at 11:43:37AM +, Alex Bennée wrote: > >> > >> Chao Peng writes: > >> > >> > >> > Introduction > >> > > >> > KVM userspace being able to crash the host is horrible. U

Re: [PATCH] target/ppc: Fix build warnings when building with 'disable-tcg'

2022-11-17 Thread Daniel Henrique Barboza
On 11/17/22 07:35, Vaibhav Jain wrote: Hi Daniel, Thanks for quick turnaround on this, Minor correction to the commit tags below: Daniel Henrique Barboza writes: Queued in gitlab.com/danielhb/qemu/tree/ppc-next with the following tags: Reported-by: Kowshik Jois B S Fixes:

Re: [PATCH] target/ppc: Fix build warnings when building with 'disable-tcg'

2022-11-17 Thread Kowshik Jois B S
Hello Vaibhav, Thanks for the quick resolution. I have applied and tested the patch. Everything is smooth. Thank you. Regards, Kowshik Jois On 16/11/22 18:47, Vaibhav Jain wrote: Kowshik reported that building qemu with GCC 12.2.1 for 'ppc64-softmmu' target is failing due to following build

[PATCH] riscv: Add RISCVCPUConfig.satp_mode to set sv48, sv57, etc.

2022-11-17 Thread Alexandre Ghiti
RISC-V specifies multiple sizes for addressable memory and Linux probes for the machine's support at startup via the satp CSR register (done in csr.c:validate_vm). As per the specification, sv64 must support sv57, which in turn must support sv48...etc. So we can restrict machine support by simply

Re: [PATCH] target/ppc: Fix build warnings when building with 'disable-tcg'

2022-11-17 Thread Daniel Henrique Barboza
On 11/17/22 07:50, Greg Kurz wrote: On Thu, 17 Nov 2022 07:11:51 -0300 Daniel Henrique Barboza wrote: Queued in gitlab.com/danielhb/qemu/tree/ppc-next with the following tags: You are planning a PR before 7.2-rc2, right ? I'll send it today. Reported-by: Kowshik Jois B S

Re: [PATCH] ci: replace x86_64 macos-11 with aarch64 macos-12

2022-11-17 Thread Philippe Mathieu-Daudé
On 16/11/22 18:50, Daniel P. Berrangé wrote: The Cirrus CI service has announced the intent to discontinue support for x86_64 macOS CI runners. They already have aarch64 runners available and require all projects to switch to these images before Jan 1st 2023. The different architecture is merely

Re: [PATCH v2] capstone: use instead of

2022-11-17 Thread Paolo Bonzini
On 11/15/22 09:11, Daniel P. Berrangé wrote: On Mon, Nov 14, 2022 at 02:49:39PM +0100, Paolo Bonzini wrote: Queued, thanks. I presume you have unqueued this patch again after the discussion yesterday ? Yes, of course. Paolo

Re: [PATCH v9 3/8] KVM: Add KVM_EXIT_MEMORY_FAULT exit

2022-11-17 Thread Alex Bennée
Chao Peng writes: > On Wed, Nov 16, 2022 at 07:03:49PM +, Alex Bennée wrote: >> >> Chao Peng writes: >> >> > On Tue, Nov 15, 2022 at 04:56:12PM +, Alex Bennée wrote: >> >> >> >> Chao Peng writes: >> >> >> >> > This new KVM exit allows userspace to handle memory-related errors. It

[PATCH] target/arm: added cortex-a55 CPU support for qemu-virt

2022-11-17 Thread Daniel Baluta
Patch looks good to me. Maybe you might add some references to chapters from RM where this numbers come from. Similar with aarch64_a76_initfn function for example.

[PULL 0/1] ppc queue

2022-11-17 Thread Daniel Henrique Barboza
The following changes since commit 2c8311241d1f7377bb4ff76064b1d1fe15166413: Update VERSION for v7.2.0-rc1 (2022-11-15 18:56:38 -0500) are available in the Git repository at: https://gitlab.com/danielhb/qemu.git tags/pull-ppc-20221117 for you to fetch changes up to

[PULL 1/1] target/ppc: Fix build warnings when building with 'disable-tcg'

2022-11-17 Thread Daniel Henrique Barboza
From: Vaibhav Jain Kowshik reported that building qemu with GCC 12.2.1 for 'ppc64-softmmu' target is failing due to following build warnings: ../target/ppc/cpu_init.c:7018:13: error: 'ppc_restore_state_to_opc' defined but not used [-Werror=unused-function] 7018 | static void ppc_restore_stat

Re: [PATCH v3 2/2] nvme: Add physical writes/reads from OCP log

2022-11-17 Thread Joel Granados
On Thu, Nov 17, 2022 at 08:30:46AM +0100, Klaus Jensen wrote: > On Nov 16 18:14, Joel Granados wrote: > > In order to evaluate write amplification factor (WAF) within the storage > > stack it is important to know the number of bytes written to the > > controller. The existing SMART log value of Dat

[PATCH] pc: q35: Bump max_cpus to 1024

2022-11-17 Thread Dario Faggioli
Keep the old limit of 288 for machine versions 7.2 and earlier. Signed-off-by: Dario Faggioli --- Cc: Paolo Bonzini Cc: Richard Henderson Cc: Eduardo Habkost Cc: "Michael S. Tsirkin" Cc: Marcel Apfelbaum --- This is related to: https://lore.kernel.org/qemu-devel/c705d0d8d6ed1a520b1ff92cb2f8

[PATCH for-8.0] MAINTAINERS: downgrade PPC KVM/TCG CPUs and pSeries to 'Odd Fixes'

2022-11-17 Thread Daniel Henrique Barboza
The maintainer is no longer being paid to maintain these components. All maintainership work is being done in his personal time since the middle of the 7.2 development cycle. Change the status of PPC KVM CPUs, PPC TCG CPUs and the pSeries machine to 'Odd Fixes', reflecting that the maintainer no l

qtest failure mode

2022-11-17 Thread Patrick Venture
Hi; Recently I was debugging why a patch broke all my qtests, and the issue it turns out was that qemu was dying in runtime. The qtests complaint was that the assertion failure on not having valid sockets. I was curious if anyone else has experienced this, and if there's a plan (or a different t

Re: [PATCH] target/arm: added cortex-a55 CPU support for qemu-virt

2022-11-17 Thread Peter Maydell
On Thu, 10 Nov 2022 at 09:04, Timofey Kutergin wrote: > > cortex-a55 is one of newer armv8.2+ CPUs supporting native > Privileged Access Never (PAN) feature. Hi; thanks for this patch. There are a few missing ID register values below, but otherwise it looks good. > Using this CPU > provide

Re: [PATCH v2 07/19] hw/9pfs: Implement Windows specific utilities functions for 9pfs

2022-11-17 Thread Christian Schoenebeck
On Friday, November 11, 2022 5:22:13 AM CET Bin Meng wrote: > From: Guohuai Shi > > Windows POSIX API and MinGW library do not provide the NO_FOLLOW > flag, and do not allow opening a directory by POSIX open(). This > causes all xxx_at() functions cannot work directly. However, we > can provide W

Re: [PATCH for-8.0] MAINTAINERS: downgrade PPC KVM/TCG CPUs and pSeries to 'Odd Fixes'

2022-11-17 Thread Cédric Le Goater
On 11/17/22 16:32, Daniel Henrique Barboza wrote: The maintainer is no longer being paid to maintain these components. All maintainership work is being done in his personal time since the middle of the 7.2 development cycle. Thanks to you, Daniel. It was great work ! Change the status of PPC

[PATCH] target/avr: fix long address calculation

2022-11-17 Thread Pavel Dovgalyuk
AVR ELPMX instruction (and some others) use three registers to form long 24-bit address from RAMPZ and two 8-bit registers. RAMPZ stores shifted 8 bits like ff to simplify address calculation. This patch fixes full address calculation in function gen_get_addr by changing the mess in offsets of

Re: [PATCH] target/arm: Limit LPA2 effective output address when TCR.DS == 0

2022-11-17 Thread Peter Maydell
On Thu, 17 Nov 2022 at 03:14, Richard Henderson wrote: > > On 11/16/22 09:03, Ard Biesheuvel wrote: > > diff --git a/target/arm/ptw.c b/target/arm/ptw.c > > index 3745ac9723474332..9a6277d862fac229 100644 > > --- a/target/arm/ptw.c > > +++ b/target/arm/ptw.c > > @@ -1222,6 +1222,14 @@ static bool

Re: [PATCH v9 00/10] s390x: CPU Topology

2022-11-17 Thread Pierre Morel
On 11/17/22 10:31, Pierre Morel wrote: On 11/16/22 17:51, Christian Borntraeger wrote: Am 02.09.22 um 09:55 schrieb Pierre Morel: Hi, The implementation of the CPU Topology in QEMU has been drastically modified since the last patch series and the number of LOCs has been greatly reduced.

RE: [PATCH v2 07/19] hw/9pfs: Implement Windows specific utilities functions for 9pfs

2022-11-17 Thread Shi, Guohuai
> -Original Message- > From: Christian Schoenebeck > Sent: Thursday, November 17, 2022 23:55 > To: qemu-devel@nongnu.org > Cc: Shi, Guohuai ; Greg Kurz ; > Meng, Bin > Subject: Re: [PATCH v2 07/19] hw/9pfs: Implement Windows specific utilities > functions for 9pfs > > CAUTION: This em

[PATCH v4 3/3] vhost-user: Fix the virtio features negotiation flaw

2022-11-17 Thread huangy81
From: Hyman Huang(黄勇) This patch aims to fix unexpected negotiation features for vhost-user netdev interface. When openvswitch reconnect Qemu after an unexpected disconnection and Qemu therefore start the vhost_dev, acked_features field in vhost_dev is initialized with value fetched from acked_f

[PATCH v4 1/3] vhost-user: Refactor vhost acked features saving

2022-11-17 Thread huangy81
From: Hyman Huang(黄勇) Abstract vhost acked features saving into vhost_user_save_acked_features, export it as util function. Signed-off-by: Hyman Huang(黄勇) Signed-off-by: Guoyi Tu --- include/net/vhost-user.h | 1 + net/vhost-user.c | 21 +++-- 2 files changed, 16 inse

[PATCH v4 0/3] Fix the virtio features negotiation flaw

2022-11-17 Thread huangy81
From: Hyman Huang(黄勇) v4: -rebase on master -add stub function to fix build errors -code clean on [PATCH v2 1/2]: drop 'cleanup' parameter in vhost_user_save_acked_features. -code clean on [PATCH v2 2/2]: make refactor of chr_closed_bh a standalone patch. Above changes are suggested by Michael

[PATCH v4 2/3] vhost-user: Refactor the chr_closed_bh

2022-11-17 Thread huangy81
From: Hyman Huang(黄勇) Use vhost_user_save_acked_features to implemente acked features saving. Signed-off-by: Hyman Huang(黄勇) Signed-off-by: Guoyi Tu --- net/vhost-user.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/net/vhost-user.c b/net/vhost-user.c index f5cb095.

[PATCH for-7.2 v3 0/3] rtl8139: honor large send MSS value

2022-11-17 Thread Stefan Hajnoczi
v3: - Add Patch 1 to avoid clobbering tx descriptor bits - Add Patch 2 to avoid confusing tx command modes - Exclude IP and TCP headers from large send MSS value The rtl8139 large send offload currently does not honor the MSS value provided by the driver. This is a problem especially when the MTU

[PATCH for-7.2 v3 2/3] rtl8139: keep Tx command mode 0 and 1 separate

2022-11-17 Thread Stefan Hajnoczi
There are two Tx Descriptor formats called mode 0 and mode 1. The mode is determined by the Large Send bit. CP_TX_IPCS (bit 18) is defined in mode 1 but the code checks the bit unconditionally. In mode 0 bit 18 is part of the Large Send MSS value. Explicitly check the Large Send bit to distinguis

[PATCH for-7.2 v3 1/3] rtl8139: avoid clobbering tx descriptor bits

2022-11-17 Thread Stefan Hajnoczi
The device turns the Tx Descriptor into a Tx Status descriptor after fully reading the descriptor. This involves clearing Tx Own (bit 31) to indicate that the driver has ownership of the descriptor again as well as several other bits. The code keeps the first dword of the Tx Descriptor in the txdw

Re: [PATCH for-7.2] rtl8139: honor large send MSS value

2022-11-17 Thread Stefan Hajnoczi
Hi Tobias, My initial patch was broken. I did some cleanup and sent a v3. Stefan

[PATCH for-7.2 v3 3/3] rtl8139: honor large send MSS value

2022-11-17 Thread Stefan Hajnoczi
The Large-Send Task Offload Tx Descriptor (9.2.1 Transmit) has a Large-Send MSS value where the driver specifies the MSS. See the datasheet here: http://realtek.info/pdf/rtl8139cp.pdf The code ignores this value and uses a hardcoded MSS of 1500 bytes instead. When the MTU is less than 1500 bytes t

Re: [PATCH for-7.2] tests/avocado/boot_linux.py: Bump aarch64 virt test timeout to 720s

2022-11-17 Thread Alex Bennée
Peter Maydell writes: > The two tests > tests/avocado/boot_linux.py:BootLinuxAarch64.test_virt_tcg_gicv2 > tests/avocado/boot_linux.py:BootLinuxAarch64.test_virt_tcg_gicv3 > > take quite a long time to run, and the current timeout of 240s > is not enough for the tests to complete on slow machin

RE: [PATCH for-7.2] rtl8139: honor large send MSS value

2022-11-17 Thread Tobias Fiebig
Heho, Thanks, will test the three patches later. With best regards, Tobias -Original Message- From: Stefan Hajnoczi Sent: Thursday, 17 November 2022 17:57 To: Tobias Fiebig Cc: Jason Wang ; Stefan Hajnoczi ; qemu-devel@nongnu.org; qemu-sta...@nongnu.org; Russell King - ARM Linux Sub

Re: [PATCH v2 3/3] hw/{misc, riscv}: pfsoc: add system controller as unimplemented

2022-11-17 Thread Conor Dooley
On Sat, Nov 12, 2022 at 01:34:15PM +, Conor Dooley wrote: > From: Conor Dooley > > The system controller on PolarFire SoC is access via a mailbox. The > control registers for this mailbox lie in the "IOSCB" region & the > interrupt is cleared via write to the "SYSREG" region. It also has a >

Re: [PATCH for-8.0] MAINTAINERS: downgrade PPC KVM/TCG CPUs and pSeries to 'Odd Fixes'

2022-11-17 Thread Greg Kurz
On Thu, 17 Nov 2022 12:32:18 -0300 Daniel Henrique Barboza wrote: > The maintainer is no longer being paid to maintain these components. All > maintainership work is being done in his personal time since the middle > of the 7.2 development cycle. > Great thanks Daniel for all your contributions

Re: [PATCH v3 12/17] vfio/migration: Implement VFIO migration protocol v2

2022-11-17 Thread Avihai Horon
On 16/11/2022 20:29, Alex Williamson wrote: External email: Use caution opening links or attachments On Thu, 3 Nov 2022 18:16:15 +0200 Avihai Horon wrote: Add implementation of VFIO migration protocol v2. The two protocols, v1 and v2, will co-exist and in next patch v1 protocol will be rem

Re: [PATCH v3 14/17] vfio/migration: Reset device if setting recover state fails

2022-11-17 Thread Avihai Horon
On 16/11/2022 20:36, Alex Williamson wrote: External email: Use caution opening links or attachments On Thu, 3 Nov 2022 18:16:17 +0200 Avihai Horon wrote: If vfio_migration_set_state() fails to set the device in the requested state it tries to put it in a recover state. If setting the devi

Re: [PATCH v2 02/12] tests/avocado: improve behaviour waiting for login prompts

2022-11-17 Thread Cédric Le Goater
On 11/17/22 15:04, Alex Bennée wrote: Cédric Le Goater writes: Hello Alex, On 11/11/22 15:55, Alex Bennée wrote: This attempts to deal with the problem of login prompts not being guaranteed to be terminated with a newline. The solution to this is to peek at the incoming data looking to see

  1   2   >