> On 16 Nov 2022, at 18.47, francesco.cag...@gmail.com wrote: > > From: Francesco Cagnin <fcag...@quarkslab.com> > > Support is added for single-stepping, software breakpoints, hardware > breakpoints and watchpoints. The code has been structured like the KVM > counterpart (and many parts are basically identical). > > Guests can be debugged through the gdbstub. > > Signed-off-by: Francesco Cagnin <fcag...@quarkslab.com> > --- > accel/hvf/hvf-accel-ops.c | 123 ++++++++++++++++++++++++ > accel/hvf/hvf-all.c | 24 +++++ > cpu.c | 3 + > include/sysemu/hvf.h | 29 ++++++ > include/sysemu/hvf_int.h | 1 + > target/arm/hvf/hvf.c | 194 +++++++++++++++++++++++++++++++++++++- > 6 files changed, 372 insertions(+), 2 deletions(-)
Looks good. I've tested hw/sw breakpoints, hw watchpoints and single-stepping. Reviewed-by: Mads Ynddal <m...@ynddal.dk>