On Thu, 17 Nov 2022 at 13:39, Cédric Le Goater <c...@kaod.org> wrote: > > Hello Alex, > > On 11/11/22 15:55, Alex Bennée wrote: > > This attempts to deal with the problem of login prompts not being > > guaranteed to be terminated with a newline. The solution to this is to > > peek at the incoming data looking to see if we see an up-coming match > > before we fall back to the old readline() logic. The reason to mostly > > rely on readline is because I am occasionally seeing the peek stalling > > despite data being there. > > > > This seems kinda hacky and gross so I'm open to alternative approaches > > and cleaner python code. > > > > Signed-off-by: Alex Bennée <alex.ben...@linaro.org> > > Reviewed-by: Philippe Mathieu-Daudé <phi...@linaro.org> > > I have pulled this patch in the aspeed tree hoping it would improve tests: > > AST2x00MachineSDK.test_arm_ast2500_evb_sdk > AST2x00MachineSDK.test_arm_ast2600_evb_sdk > > but the failure rate has increased :/ I have seen failures in these also : > > AST2x00Machine.test_arm_ast2500_evb_buildroot > AST2x00Machine.test_arm_ast2600_evb_buildroot > > which used to be quite stable.
This version of this patch is buggy, so you should drop it from your tree... -- PMM
