On 17/11/2022 12.16, Peter Maydell wrote:
The two tests
tests/avocado/boot_linux.py:BootLinuxAarch64.test_virt_tcg_gicv2
tests/avocado/boot_linux.py:BootLinuxAarch64.test_virt_tcg_gicv3

take quite a long time to run, and the current timeout of 240s
is not enough for the tests to complete on slow machines:
we've seen these tests time out in the gitlab CI in the
'avocado-system-alpine' CI job, for instance. The timeout
is also insufficient for running the test with a debug build
of QEMU: on my machine the tests take over 10 minutes to run
in that config.

Push the timeout up to 720s so that the test definitely has
enough time to complete.

Signed-off-by: Peter Maydell <peter.mayd...@linaro.org>
---
  tests/avocado/boot_linux.py | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/avocado/boot_linux.py b/tests/avocado/boot_linux.py
index 571d33882ae..32adae6ff6a 100644
--- a/tests/avocado/boot_linux.py
+++ b/tests/avocado/boot_linux.py
@@ -64,7 +64,7 @@ class BootLinuxAarch64(LinuxTest):
      :avocado: tags=machine:virt
      :avocado: tags=machine:gic-version=2
      """
-    timeout = 240
+    timeout = 720

Looking at some random older builds:

 https://gitlab.com/qemu-project/qemu/-/jobs/2897087089#L175
 https://gitlab.com/qemu-project/qemu/-/jobs/2897087091#L173

... it seems like the tests took 330 - 350 seconds to finish in the past in the gitlab-CI, so the timeout of 720 seconds should be fine for the gitlab-CI. Thus:

Reviewed-by: Thomas Huth <th...@redhat.com>



Reply via email to