Re: [PATCH for-6.2 10/10] linux-user: Move DEBUG_REMAP undef to uaccess.c

On Sun, 18 Jul 2021 at 00:21, Peter Maydell wrote: > > Since commit 687ca797893ca1e853, the code that looks at the debug > define DEBUG_REMAP is all in uaccess.c; move the #undef line to > there from qemu.h (thus reducing significantly the amount of code > that gets recompiled if you need to turn

Re: [PATCH v3 01/13] accel/tcg: Reduce CF_COUNT_MASK to match TCG_MAX_INSNS

On Sat, 17 Jul 2021 at 23:18, Richard Henderson wrote: > > The space reserved for CF_COUNT_MASK was overly large. > Reduce to free up cflags bits and eliminate an extra test. > > Reviewed-by: Alex Bennée > Signed-off-by: Richard Henderson Reviewed-by: Peter Maydell thanks -- PMM

Re: [PATCH v3 08/13] target/avr: Advance pc in avr_tr_breakpoint_check

On Sat, 17 Jul 2021 at 23:18, Richard Henderson wrote: > > Since 0b00b0c1e05b, tb->size must not be zero. > Advance pc so that the breakpoint covers the insn at the bp. > > Signed-off-by: Richard Henderson > --- > target/avr/translate.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/ta

Re: [PATCH v3 09/13] target/mips: Reduce mips_tr_breakpoint_check pc advance to 2

On Sat, 17 Jul 2021 at 23:18, Richard Henderson wrote: > > The actual number of bytes advanced need not be 100% exact, > but we should not cross a page when the insn would not. > > If mips16 or mips32e are enabled, the minimum insn size is 2. > > Signed-off-by: Richard Henderson > --- > target/m

Re: [PATCH v3 10/13] target/riscv: Reduce riscv_tr_breakpoint_check pc advance to 2

On Sat, 17 Jul 2021 at 23:18, Richard Henderson wrote: > > The actual number of bytes advanced need not be 100% exact, > but we should not cross a page when the insn would not. > > If rvc is enabled, the minimum insn size is 2. > > Signed-off-by: Richard Henderson > --- > target/riscv/translate.

Re: [PATCH for-6.2 05/10] linux-user: Split mmap prototypes into user-mmap.h

On Sun, 18 Jul 2021 at 00:21, Peter Maydell wrote: > > Split out the mmap prototypes into a new header user-mmap.h > which we only include where required. > > Signed-off-by: Peter Maydell > --- > linux-user/qemu.h | 20 > linux-user/user-mmap.h | 34

Re: [PATCH] hw/intc/arm_gicv3: Fix GICv3 redistributor security checking

Hi Peter, Many thanks for your detailed explanation. Upon further reflection, it seems that I have misinterpreted some of the explanations in the manual. Sorry for the confusion, the original implementation is correct. Thanks, Tianrui On Fri, Jul 16, 2021 at 4:32 PM Peter Maydell wrote: > On W

Re: [PATCH 2/2] i2c/smbus_eeprom: Add feature bit to SPD data

On Thu, Jul 15, 2021 at 06:50:44PM +0200, BALATON Zoltan wrote: > Add the differential clock input feature bit to the generated SPD > data. Most guests don't seem to care but pegasos2 firmware version 1.2 > checks for this bit and stops with unsupported module type error if > it's not present. Sinc

Re: [PATCH 1/2] ppc/pegasos2: Fix spurious warning with -bios

On Thu, Jul 15, 2021 at 06:50:44PM +0200, BALATON Zoltan wrote: > The -append option is currently not compatible with -bios (as we don't > yet emulate nvram so we can only put it in the environment with VOF). > Therefore a warning is printed if -append is used with -bios but > because the default v

<    1   2