[PATCH] x86: add SEV hashing to fw_cfg for kernel/initrd/cmdline

2021-05-25 Thread Dov Murik
From: James Bottomley If the VM is using memory encryption and also specifies a kernel/initrd or appended command line, calculate the hashes and add them to the encrypted data. For this to work, OVMF must support an encrypted area to place the data which is advertised via a special GUID in the O

Re: [PATCH] target/riscv: hardwire bits in hideleg and hedeleg

2021-05-25 Thread LIU Zhiwei
On 5/22/21 11:59 PM, Jose Martins wrote: The specification mandates for certain bits to be hardwired in the hypervisor delegation registers. This was not being enforced. Signed-off-by: Jose Martins --- target/riscv/csr.c | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-)

Re: [PATCH v2] disas/libvixl: Protect C system header for C++ compiler

2021-05-25 Thread Philippe Mathieu-Daudé
Hi Peter, since libvixl is mostly used by the Aarch64 target, can you take this patch via your ARM tree? (Thomas reviewed it). On 5/16/21 7:10 PM, Philippe Mathieu-Daudé wrote: > When selecting an ARM target on Debian unstable, we get: > > Compiling C++ object libcommon.fa.p/disas_libvixl_vixl_

Re: [PATCH] hw/input/ps2: Use ps2_raise_irq() instead of open coding it

2021-05-25 Thread Philippe Mathieu-Daudé
ping? (patch reviewed) On 5/13/21 7:12 PM, Philippe Mathieu-Daudé wrote: > Inspired-by: Volker Rümelin > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/input/ps2.c | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/hw/input/ps2.c b/hw/input/ps2.c > index 72cdb80

Re: [PATCH] misc: Correct relative include path

2021-05-25 Thread Philippe Mathieu-Daudé
ping? (patch reviewed) On 5/16/21 10:50 PM, Philippe Mathieu-Daudé wrote: > Headers should be included from the 'include/' directory, > not from the root directory. > > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/i386/acpi-common.h | 6 +++--- > include/monitor/monitor.h | 2 +- > hw/g

[Bug 1926995] Re: hw/remote/mpqemu-link.c:221: bad error checking ?

2021-05-25 Thread Thomas Huth
Fix has been merged now: https://gitlab.com/qemu-project/qemu/-/commit/dcf20655ffca2b0219d2914d ** Changed in: qemu Status: In Progress => Fix Committed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.ne

Re: [PATCH v2] linux-user/syscall: Constify bitmask_transtbl fcntl/mmap flags_tlb[]

2021-05-25 Thread Philippe Mathieu-Daudé
ping? (patch reviewed) On 5/17/21 7:52 AM, Philippe Mathieu-Daudé wrote: > Keep bitmask_transtbl in .rodata by marking the arrays const. > > Reviewed-by: Laurent Vivier > Reviewed-by: Richard Henderson > Reviewed-by: Bin Meng > Signed-off-by: Philippe Mathieu-Daudé > --- > linux-user/syscall

Re: [PATCH 0/2] tests/acceptance: Add tests for the Pegasos2 machine

2021-05-25 Thread Philippe Mathieu-Daudé
ping? On 5/15/21 3:45 PM, Philippe Mathieu-Daudé wrote: > Philippe Mathieu-Daudé (2): > tests/acceptance: Ignore binary data sent on serial console > tests/acceptance: Add tests for the Pegasos2 machine > > tests/acceptance/avocado_qemu/__init__.py | 7 +- > tests/acceptance/machine_ppc_peg

Re: [PATCH] tests/qtest/fuzz: Fix build failure

2021-05-25 Thread Philippe Mathieu-Daudé
ping? (patch reviewed). On 5/13/21 6:20 PM, Philippe Mathieu-Daudé wrote: > On Fedora 32, using clang (version 10.0.1-3.fc32) we get: > > tests/qtest/fuzz/fuzz.c:237:5: error: implicit declaration of function > 'qemu_init' is invalid in C99 [-Werror,-Wimplicit-function-declaration] > qem

Re: [PATCH v2 0/9] accel/tcg: Add tlb_flush interface for a range of pages

2021-05-25 Thread Philippe Mathieu-Daudé
ping? On 5/9/21 5:18 PM, Philippe Mathieu-Daudé wrote: > Oops, I forgot to add 'v2' in subject line :/ > > On Sun, May 9, 2021 at 5:16 PM Philippe Mathieu-Daudé wrote: >> >> Hi Richard, >> >> I tried to make sense of the multiple changes in your patch >> https://www.mail-archive.com/qemu-devel@n

[PATCH v2 1/4] migration/rdma: cleanup rmda in rdma_start_incoming_migration error path

2021-05-25 Thread Li Zhijian
the error path after calling qemu_rdma_dest_init() should do rdma cleanup Signed-off-by: Li Zhijian Reviewed-by: Dr. David Alan Gilbert --- migration/rdma.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/migration/rdma.c b/migration/rdma.c index 41726cc74a8..7e7595fa

[PATCH v2 3/4] migration/rdma: destination: create the return patch after the first accept

2021-05-25 Thread Li Zhijian
destination side: $ build/qemu-system-x86_64 -enable-kvm -netdev tap,id=hn0,script=/etc/qemu-ifup,downscript=/etc/qemu-ifdown -device e1000,netdev=hn0,mac=50:52:54:00:11:22 -boot c -drive if=none,file=./Fedora-rdma-server-migration.qcow2,id=drive-virtio-disk0 -device virtio-blk-pci,bus=pci.0,ad

Re: [PATCH for-6.0 v1 0/3] softmmu/physmem: shared anonymous memory fixes

2021-05-25 Thread David Hildenbrand
On 06.04.21 10:01, David Hildenbrand wrote: Fixes related to shared anonymous memory, previously sent as part of https://lore.kernel.org/r/20210319101230.21531-1-da...@redhat.com Peter, Eduardo, Michael, David, Paolo, can someone please pick this up? Thanks Cc: Paolo Bonzini Cc: Pete

[PATCH v2 2/4] migration/rdma: Fix rdma_addrinfo res leaks

2021-05-25 Thread Li Zhijian
rdma_freeaddrinfo() is the reverse operation of rdma_getaddrinfo() Signed-off-by: Li Zhijian Reviewed-by: Dr. David Alan Gilbert --- migration/rdma.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/migration/rdma.c b/migration/rdma.c index 7e7595faabf..651534e8255 100644 --- a/migration/

[PATCH v2 4/4] migration/rdma: source: poll cm_event from return path

2021-05-25 Thread Li Zhijian
source side always blocks if postcopy is only enabled at source side. users are not able to cancel this migration in this case. Let source side have chance to cancel this migration Signed-off-by: Li Zhijian --- V2: utilize poll to check cm event --- migration/rdma.c | 42 +++

[PATCH 0/9] gitlab-ci: Make mainstream CI green again

2021-05-25 Thread Philippe Mathieu-Daudé
Various patches to make mainstream CI green again: - rebased "gitlab-ci: Ease forks pipeline workflow" on testing-next - split gprof-gcov job - run avocado tests manually (except on mainstream) - fix firmware jobs to only run when files changed - discard avocado results on success, keep them longe

[PATCH 3/9] gitlab-ci: Document how forks can use different set of jobs

2021-05-25 Thread Philippe Mathieu-Daudé
Document how forks can use different set of jobs and add a big warning so no new configuration is added to this file. Suggested-by: Daniel Berrangé Signed-off-by: Philippe Mathieu-Daudé --- .gitlab-ci.yml | 14 ++ 1 file changed, 14 insertions(+) diff --git a/.gitlab-ci.yml b/.gitl

[PATCH 4/9] gitlab-ci: Extract cross-container jobs to container-cross.yml

2021-05-25 Thread Philippe Mathieu-Daudé
Extract the jobs preparing the cross containers into a new file (container-cross.yml). Signed-off-by: Philippe Mathieu-Daudé --- .gitlab-ci.d/container-cross.yml | 164 ++ .gitlab-ci.d/containers.yml | 166 +-- 2 files changed, 165 ins

[PATCH 1/9] gitlab-ci: Extract all default build/test jobs to buildtest.yml

2021-05-25 Thread Philippe Mathieu-Daudé
Extract the build/test jobs run by default on the mainstream CI into a new file (buildtest.yml). Reviewed-by: Willian Rampazzo Signed-off-by: Philippe Mathieu-Daudé --- .gitlab-ci.d/buildtest.yml | 736 + .gitlab-ci.yml | 736 +

[PATCH 5/9] gitlab-ci: explicitly reference the upstream registry

2021-05-25 Thread Philippe Mathieu-Daudé
From: Alex Bennée Since c8e6793903 ("containers.yml: build with docker.py tooling") we don't need to manually pull stuff from the upstream repository. Just set the -r field to explicitly use that rather than the current registry. Signed-off-by: Alex Bennée Message-Id: <20210520174303.12310-3-al

[PATCH 6/9] gitlab-ci: Split gprof-gcov job

2021-05-25 Thread Philippe Mathieu-Daudé
This job is hitting the 70min limit, so split it in 2 tasks. Signed-off-by: Philippe Mathieu-Daudé --- .gitlab-ci.d/buildtest.yml | 17 ++--- 1 file changed, 14 insertions(+), 3 deletions(-) diff --git a/.gitlab-ci.d/buildtest.yml b/.gitlab-ci.d/buildtest.yml index f903fdea3f4..8947

[PATCH 2/9] gitlab-ci: Move current job set to qemu-project.yml

2021-05-25 Thread Philippe Mathieu-Daudé
To allow forks to easily decide which jobs they want to run, but without disrupting the current default, move the current set of jobs to a new file corresponding to the jobs run by the mainstream project CI: https://gitlab.com/qemu-project/qemu/-/pipelines Reviewed-by: Willian Rampazzo Signed-off

[PATCH 8/9] gitlab-ci: Run Avocado tests manually (except mainstream CI)

2021-05-25 Thread Philippe Mathieu-Daudé
Due to a design problem and misunderstanding between the Avocado framework and QEMU, Avocado is fetching many asset artifacts it shouldn't be fetching, exhausting the jobs CI timeout. Since Avocado artifacts are cached, this is not an issue with old forks, which already have populated the cache an

[PATCH 9/9] gitlab-ci: Use absolute path and simplify firmware jobs

2021-05-25 Thread Philippe Mathieu-Daudé
The GitLab 'add job on file changed' feature doesn't work well with relative paths: use absolute paths instead. Change the 'rules:' section by an 'only:' one which is easier to read. Signed-off-by: Philippe Mathieu-Daudé --- .gitlab-ci.d/edk2.yml| 11 +-- .gitlab-ci.d/opensbi.yml |

[Bug 1878034] Re: memcpy param-overlap through e1000e_write_to_rx_buffers

2021-05-25 Thread Thomas Huth
Can you still reproduce the crash with the current version of QEMU? At least I cannot reproduce the crash anymore, so it seems like this got fixed at one point in time? ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- de

[PATCH 7/9] gitlab-ci: Keep Avocado reports during 1 week

2021-05-25 Thread Philippe Mathieu-Daudé
Sometimes pull requests are merged during the week-end, triggering a CI pipeline. Currently if such pipeline fails, the Avocado reports are available for 2 days. For the reviewers working on the project during office hours, the reports are already discarded when they want to look at them. Increase

Re: [PATCH] target/m68k: Remove unused variable in ABCD/SBCD memory opcodes

2021-05-25 Thread Philippe Mathieu-Daudé
On 5/6/21 12:29 PM, Laurent Vivier wrote: > Le 05/05/2021 à 18:43, Laurent Vivier a écrit : >> Le 05/05/2021 à 18:03, Philippe Mathieu-Daudé a écrit : >>> The ABCD / SBCD memory opcodes (introduced in commit fb5543d8200) >>> don't use their "addr" variable. >>> >>> Remove the unused variable and pa

GSoC 2021: vhost-user-vsock application and Kata Containers integration

2021-05-25 Thread Harshavardhan Unnibhavi
Hi, I am Harshavardhan Unnibhavi. I am one of QEMU's google summer of code students for this year. I will be working with Fabiano Fidêncio and Stefano Garzarella on developing a vhost-user-vsock application and integrating it with Kata Container. Kata Containers leverage virtio-vsock to create a

Re: [PATCH] docs: fix broken reference

2021-05-25 Thread Peter Maydell
On Tue, 11 May 2021 at 20:29, John Snow wrote: > > Long story short, we need a space here for the reference to work > correctly. > > > Longer story: > > Without the space, kerneldoc generates a line like this: > > one of :c:type:`MemoryListener.region_add\(\) > `,:c:type:`MemoryListener.region_de

Re: RFC: Qemu backup interface plans

2021-05-25 Thread Max Reitz
On 19.05.21 08:11, Vladimir Sementsov-Ogievskiy wrote: 18.05.2021 19:39, Max Reitz wrote: [...] On 17.05.21 14:07, Vladimir Sementsov-Ogievskiy wrote: [...] Not also, that there is another benefit of such thing: we'll implement this callback in qcow2 driver, so that backup will read clus

Re: [PATCH 9/9] gitlab-ci: Use absolute path and simplify firmware jobs

2021-05-25 Thread Daniel P . Berrangé
On Tue, May 25, 2021 at 10:25:56AM +0200, Philippe Mathieu-Daudé wrote: > The GitLab 'add job on file changed' feature doesn't work well > with relative paths: use absolute paths instead. > > Change the 'rules:' section by an 'only:' one which is easier > to read. GitLab docs say "rules replaces

[PATCHv2] target/arm: make pointer authentication a switchable feature

2021-05-25 Thread Jamie Iles
Rather than having pointer authentication properties be specific to the max CPU type, turn this into a generic feature that can be set for each CPU model. This means that for future CPU types the feature can be set without having the ID_AA64ISAR1 bits clobbered in arm_cpu_pauth_finalize. This als

Re: [PATCH 9/9] gitlab-ci: Use absolute path and simplify firmware jobs

2021-05-25 Thread Philippe Mathieu-Daudé
On 5/25/21 10:56 AM, Daniel P. Berrangé wrote: > On Tue, May 25, 2021 at 10:25:56AM +0200, Philippe Mathieu-Daudé wrote: >> The GitLab 'add job on file changed' feature doesn't work well >> with relative paths: use absolute paths instead. >> >> Change the 'rules:' section by an 'only:' one which is

Re: [PATCH_V3] Adding ifdefs to call the respective routines only when their configs are enabled

2021-05-25 Thread Peter Maydell
On Tue, 25 May 2021 at 04:21, Richard Henderson wrote: > > On 5/24/21 7:58 PM, Swetha Joshi wrote: > > Signed-off-by: Swetha Joshi > > --- > > target/arm/kvm64.c | 12 > > 1 file changed, 8 insertions(+), 4 deletions(-) > > You're still missing the commit message. > > > > > diff -

Re: [PATCH v2] disas/libvixl: Protect C system header for C++ compiler

2021-05-25 Thread Peter Maydell
On Tue, 25 May 2021 at 08:47, Philippe Mathieu-Daudé wrote: > > Hi Peter, since libvixl is mostly used by the Aarch64 target, > can you take this patch via your ARM tree? (Thomas reviewed > it). Applied to target-arm.next, thanks. -- PMM

Re: RFC: Qemu backup interface plans

2021-05-25 Thread Vladimir Sementsov-Ogievskiy
25.05.2021 11:50, Max Reitz wrote: On 19.05.21 08:11, Vladimir Sementsov-Ogievskiy wrote: 18.05.2021 19:39, Max Reitz wrote: [...] On 17.05.21 14:07, Vladimir Sementsov-Ogievskiy wrote: [...] Not also, that there is another benefit of such thing: we'll implement this callback in qcow2 d

Re: [PATCH v5 03/13] virtio-gpu: Add udmabuf helpers

2021-05-25 Thread Gerd Hoffmann
> [Kasireddy, Vivek] Gave it a try but because of res->image, we'd need to > consider the > Pixman dependency. I think we have the following options to address this: > 1) Add pixman dependency to stubs. This may not be acceptable given that the > other > dependencies are glib, socket, etc which a

Re: [PATCH v2 3/4] migration/rdma: destination: create the return patch after the first accept

2021-05-25 Thread Dr. David Alan Gilbert
* Li Zhijian (lizhij...@cn.fujitsu.com) wrote: > destination side: > $ build/qemu-system-x86_64 -enable-kvm -netdev > tap,id=hn0,script=/etc/qemu-ifup,downscript=/etc/qemu-ifdown -device > e1000,netdev=hn0,mac=50:52:54:00:11:22 -boot c -drive > if=none,file=./Fedora-rdma-server-migration.qcow2,i

Re: [PATCH v1 3/8] gitlab: add special rule for the hexagon container

2021-05-25 Thread Philippe Mathieu-Daudé
On 5/20/21 7:42 PM, Alex Bennée wrote: > The hexagon container is always manually built but of course not > everyone will be building it themselves and pushing to their > registries. We still need to create a "local" registry copy for the > actual gitlab tests to run. We don't build it in this case

Re: [PATCH v2 0/9] accel/tcg: Add tlb_flush interface for a range of pages

2021-05-25 Thread Peter Maydell
On Tue, 25 May 2021 at 08:56, Philippe Mathieu-Daudé wrote: > > ping? I talked to RTH about this yesterday; I actually have it in my target-arm queue and reviewed. I'm just waiting for Richard to supply some commit messages to fill in the bits you left as placeholders/blank... thanks -- PMM

Re: [PATCH qemu v20] spapr: Implement Open Firmware client interface

2021-05-25 Thread BALATON Zoltan
On Tue, 25 May 2021, David Gibson wrote: On Mon, May 24, 2021 at 02:42:30PM +0200, BALATON Zoltan wrote: On Mon, 24 May 2021, David Gibson wrote: On Sun, May 23, 2021 at 07:09:26PM +0200, BALATON Zoltan wrote: On Sun, 23 May 2021, BALATON Zoltan wrote: On Sun, 23 May 2021, Alexey Kardashevski

[Bug 1878067] Re: Assertion failure in eth_get_gso_type through the e1000e

2021-05-25 Thread Thomas Huth
I can reproduce this with QEMU v5.0, but with the current master branch, the problem seems to be gone for me. Can you confirm that it is fixed? ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is subscrib

Re: [PATCH v2 4/7] block-copy: add a CoMutex to the BlockCopyTask list

2021-05-25 Thread Emanuele Giuseppe Esposito
On 20/05/2021 17:19, Vladimir Sementsov-Ogievskiy wrote: 18.05.2021 13:07, Emanuele Giuseppe Esposito wrote: Because the list of tasks is only modified by coroutine functions, add a CoMutex in order to protect them. Use the same mutex to protect also BlockCopyState in_flight_bytes field to a

Re: [PATCH qemu v20] spapr: Implement Open Firmware client interface

2021-05-25 Thread BALATON Zoltan
On Tue, 25 May 2021, David Gibson wrote: On Mon, May 24, 2021 at 12:55:07PM +0200, BALATON Zoltan wrote: On Mon, 24 May 2021, David Gibson wrote: On Sun, May 23, 2021 at 07:09:26PM +0200, BALATON Zoltan wrote: On Sun, 23 May 2021, BALATON Zoltan wrote: On Sun, 23 May 2021, Alexey Kardashevski

Re: [PATCH v2 7/7] block-copy: protect BlockCopyState .method fields

2021-05-25 Thread Emanuele Giuseppe Esposito
On 21/05/2021 19:10, Vladimir Sementsov-Ogievskiy wrote: 18.05.2021 13:07, Emanuele Giuseppe Esposito wrote: With tasks and calls lock protecting all State fields, .method is the last BlockCopyState field left unprotected. Set it as atomic. Signed-off-by: Emanuele Giuseppe Esposito OK, in

Re: [PATCH v2 0/9] accel/tcg: Add tlb_flush interface for a range of pages

2021-05-25 Thread Philippe Mathieu-Daudé
On 5/25/21 11:55 AM, Peter Maydell wrote: > On Tue, 25 May 2021 at 08:56, Philippe Mathieu-Daudé wrote: >> >> ping? > > I talked to RTH about this yesterday; I actually have it in > my target-arm queue and reviewed. I'm just waiting for Richard > to supply some commit messages to fill in the bits

Re: [PATCH 6/9] gitlab-ci: Split gprof-gcov job

2021-05-25 Thread Philippe Mathieu-Daudé
On 5/25/21 10:25 AM, Philippe Mathieu-Daudé wrote: > This job is hitting the 70min limit, so split it in 2 tasks. > > Signed-off-by: Philippe Mathieu-Daudé > --- > .gitlab-ci.d/buildtest.yml | 17 ++--- > 1 file changed, 14 insertions(+), 3 deletions(-) > > diff --git a/.gitlab-ci.d

Re: [PATCH v2 4/7] block-copy: add a CoMutex to the BlockCopyTask list

2021-05-25 Thread Vladimir Sementsov-Ogievskiy
25.05.2021 13:07, Emanuele Giuseppe Esposito wrote: On 20/05/2021 17:19, Vladimir Sementsov-Ogievskiy wrote: 18.05.2021 13:07, Emanuele Giuseppe Esposito wrote: Because the list of tasks is only modified by coroutine functions, add a CoMutex in order to protect them. Use the same mutex to pr

Re: [PATCH v2 4/4] migration/rdma: source: poll cm_event from return path

2021-05-25 Thread Dr. David Alan Gilbert
* Li Zhijian (lizhij...@cn.fujitsu.com) wrote: > source side always blocks if postcopy is only enabled at source side. > users are not able to cancel this migration in this case. > > Let source side have chance to cancel this migration > > Signed-off-by: Li Zhijian > --- > V2: utilize poll to ch

[PATCH 1/3] meson: Only build virtfs-proxy-helper if all requisites are found

2021-05-25 Thread Philippe Mathieu-Daudé
We first set have_virtfs_proxy_helper depending on have_virtfs, then update have_virtfs... While this might work, it is not clear when looking at the code logic. Move the have_virtfs_proxy_helper assignation *after* updating have_virtfs to make it obvious. Signed-off-by: Philippe Mathieu-Daudé --

[PATCH 0/3] meson: Minor improvements

2021-05-25 Thread Philippe Mathieu-Daudé
Trivial meson improvements, mostly no logical changes, improving summary display. Philippe Mathieu-Daudé (3): meson: Only build virtfs-proxy-helper if all requisites are found meson: List if X11 dependency is detected meson: List modules built in summary meson.build | 16 ++--

[PATCH 3/3] meson: List modules built in summary

2021-05-25 Thread Philippe Mathieu-Daudé
Instead of guessing the modules built, list them. Example: Modules audio: spice block: curl dmg-bz2 gluster iscsi rbd ssh chardev : spice hw-display : hw-s390x : virtio-

[PATCH 2/3] meson: List if X11 dependency is detected

2021-05-25 Thread Philippe Mathieu-Daudé
It is sometimes useful to know if X11 is detected. Signed-off-by: Philippe Mathieu-Daudé --- meson.build | 1 + 1 file changed, 1 insertion(+) diff --git a/meson.build b/meson.build index 2a7d69cf428..5ca1bd36292 100644 --- a/meson.build +++ b/meson.build @@ -2671,6 +2671,7 @@ summary_info +=

Re: [PATCH v2 5/7] block-copy: add QemuMutex lock for BlockCopyCallState list

2021-05-25 Thread Emanuele Giuseppe Esposito
On 21/05/2021 17:01, Paolo Bonzini wrote: On 20/05/21 17:30, Vladimir Sementsov-Ogievskiy wrote: 18.05.2021 13:07, Emanuele Giuseppe Esposito wrote: As for BlockCopyTask, add a lock to protect BlockCopyCallState ret and sleep_state fields. Also move ret, finished and cancelled in the OUT fie

Re: [PATCH v2 7/7] block-copy: protect BlockCopyState .method fields

2021-05-25 Thread Vladimir Sementsov-Ogievskiy
25.05.2021 13:18, Emanuele Giuseppe Esposito wrote: On 21/05/2021 19:10, Vladimir Sementsov-Ogievskiy wrote: 18.05.2021 13:07, Emanuele Giuseppe Esposito wrote: With tasks and calls lock protecting all State fields, .method is the last BlockCopyState field left unprotected. Set it as atomic.

Re: [PATCH 1/9] gitlab-ci: Extract all default build/test jobs to buildtest.yml

2021-05-25 Thread Alex Bennée
Philippe Mathieu-Daudé writes: > Extract the build/test jobs run by default on the mainstream > CI into a new file (buildtest.yml). > > Reviewed-by: Willian Rampazzo > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alex Bennée -- Alex Bennée

Re: [PATCH 3/9] gitlab-ci: Document how forks can use different set of jobs

2021-05-25 Thread Alex Bennée
Philippe Mathieu-Daudé writes: > Document how forks can use different set of jobs and add > a big warning so no new configuration is added to this > file. > > Suggested-by: Daniel Berrangé > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alex Bennée -- Alex Bennée

Re: [PATCH 2/9] gitlab-ci: Move current job set to qemu-project.yml

2021-05-25 Thread Alex Bennée
Philippe Mathieu-Daudé writes: > To allow forks to easily decide which jobs they want to run, > but without disrupting the current default, move the current > set of jobs to a new file corresponding to the jobs run by > the mainstream project CI: > https://gitlab.com/qemu-project/qemu/-/pipelin

Re: [PATCH 4/9] gitlab-ci: Extract cross-container jobs to container-cross.yml

2021-05-25 Thread Alex Bennée
Philippe Mathieu-Daudé writes: > Extract the jobs preparing the cross containers into a new file > (container-cross.yml). > > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alex Bennée -- Alex Bennée

Re: [PATCH v4 1/5] target/ppc: moved ppc_cpu_do_interrupt to cpu.c

2021-05-25 Thread Bruno Piazera Larsen
On 25/05/2021 02:09, David Gibson wrote: On Mon, May 24, 2021 at 10:59:04AM -0300, Bruno Larsen (billionai) wrote: Moved the ppc_cpu_do_interrupt function to cpu.c file, where it makes more sense, and turned powerpc_excp not static, as it now needs to be accessed from outside of excp_helper.c

Re: [PATCH 5/9] gitlab-ci: explicitly reference the upstream registry

2021-05-25 Thread Alex Bennée
Philippe Mathieu-Daudé writes: > From: Alex Bennée > > Since c8e6793903 ("containers.yml: build with docker.py tooling") we > don't need to manually pull stuff from the upstream repository. Just > set the -r field to explicitly use that rather than the current > registry. > > Signed-off-by: Al

Re: [PATCH 7/9] gitlab-ci: Keep Avocado reports during 1 week

2021-05-25 Thread Alex Bennée
Philippe Mathieu-Daudé writes: > Sometimes pull requests are merged during the week-end, triggering > a CI pipeline. Currently if such pipeline fails, the Avocado reports > are available for 2 days. For the reviewers working on the project > during office hours, the reports are already discarde

[RFC PATCH] configure: Do not add --warn-common to the linker flags anymore

2021-05-25 Thread Thomas Huth
We are compiling with -fno-common since commit 4c288acbd6 ("configure: Always build with -fno-common"), so --warn-common (which had been added in commit 49237acdb725e in 2008 already) should not be necessary anymore nowadays. Signed-off-by: Thomas Huth --- Marked as RFC since I'm not 100% sure w

[PULL 2/7] gitlab: add special rule for the hexagon container

2021-05-25 Thread Alex Bennée
The hexagon container is always manually built but of course not everyone will be building it themselves and pushing to their registries. We still need to create a "local" registry copy for the actual gitlab tests to run. We don't build it in this case, just pull it across from the upstream registr

[PULL 4/7] gdbstub: Replace GdbCmdContext with plain g_array()

2021-05-25 Thread Alex Bennée
Instead of jumping through hoops let glib deal with both tracking the number of elements and auto freeing the memory once we are done. This allows is to drop the usage of ALLOCA(3) which the man-page mentions its "use is discouraged". Signed-off-by: Alex Bennée Message-Id: <20210520174303.12310-6

[PULL 1/7] gitlab: explicitly reference the upstream registry

2021-05-25 Thread Alex Bennée
Since c8e6793903 ("containers.yml: build with docker.py tooling") we don't need to manually pull stuff from the upstream repository. Just set the -r field to explicitly use that rather than the current registry. Signed-off-by: Alex Bennée Tested-by: Philippe Mathieu-Daudé Reviewed-by: Willian Ra

[PULL 0/7] testing, gdbstub and plugin updates

2021-05-25 Thread Alex Bennée
The gprof/gcov passed on retry. I'll continue to look at it but didn't want to hold up the PR because of it. - Alex The following changes since commit 0dab1d36f55c3ed649bb8e4c74b9269ef3a63049: Merge remote-tracking branch 'remotes/stefanha-gitlab/tags/block-pull-request' into staging (2021-05-

[PULL 5/7] hmp-commands: expand type of icount to "l" in replay commands

2021-05-25 Thread Alex Bennée
This is not a 32 bit number, it can (and most likely will) be quite a big one. Signed-off-by: Alex Bennée Reviewed-by: Pavel Dovgalyuk Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20210520174303.12310-7-alex.ben...@linaro.org> diff --git a/hmp-commands.hx b/hmp-commands.hx index 435c591a1c

[PULL 3/7] gdbstub: Constify GdbCmdParseEntry

2021-05-25 Thread Alex Bennée
From: Philippe Mathieu-Daudé Signed-off-by: Philippe Mathieu-Daudé Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson Message-Id: <20210505170055.1415360-3-phi...@redhat.com> Message-Id: <20210520174303.12310-5-alex.ben...@linaro.org> diff --git a/gdbstub.c b/gdbstub.c index 9103ffc902

[PULL 7/7] plugins/syscall: Added a table-like summary output

2021-05-25 Thread Alex Bennée
From: Mahmoud Mandour Added a table-like output which contains the total number of calls for each used syscall along with the number of errors that occurred. Per-call tracing is still available through supplying the argument ``print`` to the plugin. Signed-off-by: Mahmoud Mandour Signed-off-by

[PULL 6/7] gdbstub: tidy away reverse debugging check into function

2021-05-25 Thread Alex Bennée
In theory we don't need an actual record/replay to enact reverse debugging on a purely deterministic system (i.e one with no external inputs running under icount). Tidy away the logic into a little function. Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson Reviewed-by: Philippe Mathieu-

Re: [PATCH v1 3/8] gitlab: add special rule for the hexagon container

2021-05-25 Thread Philippe Mathieu-Daudé
On 5/25/21 11:40 AM, Philippe Mathieu-Daudé wrote: > On 5/20/21 7:42 PM, Alex Bennée wrote: >> The hexagon container is always manually built but of course not >> everyone will be building it themselves and pushing to their >> registries. We still need to create a "local" registry copy for the >> a

Re: [PATCH 8/9] gitlab-ci: Run Avocado tests manually (except mainstream CI)

2021-05-25 Thread Alex Bennée
Philippe Mathieu-Daudé writes: > Due to a design problem and misunderstanding between the Avocado > framework and QEMU, Avocado is fetching many asset artifacts it > shouldn't be fetching, exhausting the jobs CI timeout. > > Since Avocado artifacts are cached, this is not an issue with old > fo

Re: [PATCH 5/9] gitlab-ci: explicitly reference the upstream registry

2021-05-25 Thread Philippe Mathieu-Daudé
On 5/25/21 1:10 PM, Alex Bennée wrote: > Philippe Mathieu-Daudé writes: >> From: Alex Bennée >> >> Since c8e6793903 ("containers.yml: build with docker.py tooling") we >> don't need to manually pull stuff from the upstream repository. Just >> set the -r field to explicitly use that rather than th

Re: 9pfs: scope of rename_lock?

2021-05-25 Thread Christian Schoenebeck
On Freitag, 21. Mai 2021 13:59:47 CEST Greg Kurz wrote: > On Sun, 16 May 2021 19:06:44 +0200 > > Christian Schoenebeck wrote: > > Hi Greg, > > > > while reviewing the 9p code base for further optimizations, I stumbled > > over > > the 'rename_lock' introduced by 02cb7f3a2 and wondered about what

[PATCH v5 0/4] target/ppc: add support to disable-tcg

2021-05-25 Thread Bruno Larsen (billionai)
This patch series finishes the the changes required to support disabling TCG for ppc targets. With the current version of the patch, the project compiles and runs ok, but we need some more testing to ensure that no regressions happened, especially with relation to gdb. Based-on: <20210521201759.8

[PATCH v5 2/4] target/ppc: added ifdefs around TCG-only code

2021-05-25 Thread Bruno Larsen (billionai)
excp_helper.c, mmu-hash64.c and mmu_helper.c have some function declarations that are TCG-only, and couldn't be easily moved to a TCG only file, so ifdefs were added around them. We also needed ifdefs around some header files because helper-proto.h includes trace/generated-helpers.h, which is neve

[PATCH v5 1/4] target/ppc: used ternary operator when registering MAS

2021-05-25 Thread Bruno Larsen (billionai)
The write calback decision when registering the MAS SPR has been turned into a ternary operation, rather than an if-then-else block. This was done because when building without TCG, even though the compiler will optimize away the pointers to spr_write_generic*, it doesn't optimize away the decisio

[PATCH v5 4/4] target/ppc: updated meson.build to support disable-tcg

2021-05-25 Thread Bruno Larsen (billionai)
updated build file to not compile some sources that are unnecessary if TCG is disabled on the system. Signed-off-by: Bruno Larsen (billionai) --- target/ppc/meson.build | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/target/ppc/meson.build b/target/ppc/meson.build inde

[PATCH v5 3/4] target/ppc: created tcg-stub.c file

2021-05-25 Thread Bruno Larsen (billionai)
Created a file with stubs needed to compile disabling TCG. *_ppc_opcodes were created to make cpu_init.c have a few less ifdefs, since they are not needed. softmmu_resize_hpt_* have to be created because the compiler can't automatically know they aren't used, but they should never be reached. Sign

Re: [PATCH 0/2] vvfat: fix two crashes.

2021-05-25 Thread Programmingkid
> On May 25, 2021, at 2:05 AM, Vladimir Sementsov-Ogievskiy > wrote: > > 24.05.2021 20:33, Programmingkid wrote: >>> On May 24, 2021, at 12:56 PM, Vladimir Sementsov-Ogievskiy >>> wrote: >>> >>> 24.05.2021 19:06, Programmingkid wrote: > On May 24, 2021, at 11:55 AM, Vladimir Sementsov-

Re: [PULL 0/7] testing, gdbstub and plugin updates

2021-05-25 Thread Philippe Mathieu-Daudé
On 5/25/21 1:24 PM, Alex Bennée wrote: > The gprof/gcov passed on retry. I'll continue to look at it but didn't want > to hold up the PR because of it. - Alex > > The following changes since commit 0dab1d36f55c3ed649bb8e4c74b9269ef3a63049: > > Merge remote-tracking branch > 'remotes/stefanha-g

Re: [PATCH v7 00/92] target/arm: Implement SVE2

2021-05-25 Thread Peter Maydell
On Tue, 25 May 2021 at 02:07, Richard Henderson wrote: > > Changes for v7: > * Incorporate patch review, some of which broke out new patches. > * Recover 4 patches which somehow got dropped during the v6 rebase. > This should have been caught by risu testing, but I must have > thought

[PATCH 0/3] testing block device blocksizes

2021-05-25 Thread Kit Westneat
These patches add a few parameters to blkdebug to allow modification of the block device block sizes, both logical and physical. It also adds a test that uses the parameter to verify correct UNMAP behavior in devices with 4k blocks. Kit Westneat (3): block/blkdebug: add blocksize parameter tes

[PATCH 1/3] block/blkdebug: add blocksize parameter

2021-05-25 Thread Kit Westneat
Allow users to specify the block size of the qdev for testing purposes. Signed-off-by: Kit Westneat --- block/blkdebug.c | 27 +++ 1 file changed, 27 insertions(+) diff --git a/block/blkdebug.c b/block/blkdebug.c index 2c0b9b0ee8..c7500746a8 100644 --- a/block/blkdebug.c

[PATCH 3/3] block/blkdebug: add log-blocksize and phys-blocksize parameters

2021-05-25 Thread Kit Westneat
Allow users to specify the logical and physical block sizes of the qdev for testing purposes. Signed-off-by: Kit Westneat --- block/blkdebug.c | 36 +++- 1 file changed, 31 insertions(+), 5 deletions(-) diff --git a/block/blkdebug.c b/block/blkdebug.c index c7500

[PATCH 2/3] tests/qtest/virtio-scsi-test: add unmap large LBA with 4k blocks test

2021-05-25 Thread Kit Westneat
Add test for issue #345 Signed-off-by: Kit Westneat --- tests/qtest/virtio-scsi-test.c | 48 ++ 1 file changed, 48 insertions(+) diff --git a/tests/qtest/virtio-scsi-test.c b/tests/qtest/virtio-scsi-test.c index 1b7ecc1c8f..6557e4f422 100644 --- a/tests/qtest/vir

Re: [PATCH 0/3] testing block device blocksizes

2021-05-25 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20210525124753.528516-1-kit.westn...@gmail.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20210525124753.528516-1-kit.westn...@gmail.com Subject: [PATCH 0/3] testing block dev

Re: [PATCH v5 2/4] target/ppc: added ifdefs around TCG-only code

2021-05-25 Thread Philippe Mathieu-Daudé
On 5/25/21 1:53 PM, Bruno Larsen (billionai) wrote: > excp_helper.c, mmu-hash64.c and mmu_helper.c have some function > declarations that are TCG-only, and couldn't be easily moved to a > TCG only file, so ifdefs were added around them. > > We also needed ifdefs around some header files because he

Re: [PATCH] x86: add SEV hashing to fw_cfg for kernel/initrd/cmdline

2021-05-25 Thread Dov Murik
On 25/05/2021 9:59, Dov Murik wrote: > From: James Bottomley > > If the VM is using memory encryption and also specifies a kernel/initrd > or appended command line, calculate the hashes and add them to the > encrypted data. For this to work, OVMF must support an encrypted area > to place the

[PATCH v2 0/3] testing block device blocksizes

2021-05-25 Thread Kit Westneat
These patches add a few parameters to blkdebug to allow modification of the block device block sizes, both logical and physical. It also adds a test that uses the parameter to verify correct UNMAP behavior in devices with 4k blocks. v2: fixes style issues Kit Westneat (3): block/blkdebug: add b

[PATCH v2 1/3] block/blkdebug: add blocksize parameter

2021-05-25 Thread Kit Westneat
Allow users to specify the block size of the qdev for testing purposes. Signed-off-by: Kit Westneat --- block/blkdebug.c | 29 + 1 file changed, 29 insertions(+) diff --git a/block/blkdebug.c b/block/blkdebug.c index 2c0b9b0ee8..d5f589920c 100644 --- a/block/blkdebug

[PATCH v2 2/3] tests/qtest/virtio-scsi-test: add unmap large LBA with 4k blocks test

2021-05-25 Thread Kit Westneat
Add test for issue #345 Signed-off-by: Kit Westneat --- tests/qtest/virtio-scsi-test.c | 50 ++ 1 file changed, 50 insertions(+) diff --git a/tests/qtest/virtio-scsi-test.c b/tests/qtest/virtio-scsi-test.c index 1b7ecc1c8f..e569bda7d0 100644 --- a/tests/qtest/vir

[PATCH v2 3/3] block/blkdebug: add log-blocksize and phys-blocksize parameters

2021-05-25 Thread Kit Westneat
Allow users to specify the logical and physical block sizes of the qdev for testing purposes. Signed-off-by: Kit Westneat --- block/blkdebug.c | 39 +-- 1 file changed, 33 insertions(+), 6 deletions(-) diff --git a/block/blkdebug.c b/block/blkdebug.c index d5

[PATCH 0/2] Fix for the 'testing, gdbstub and plugin updates' pull request

2021-05-25 Thread Philippe Mathieu-Daudé
Based-on: <20210525112431.22005-1-alex.ben...@linaro.org> https://github.com/stsquad/qemu.git tags/pull-testing-and-misc-updates-250521= -1 Philippe Mathieu-Daud=C3=A9 (2): !fixup gitlab: add special rule for the hexagon container gitlab-ci: Convert check-dco/check-patch jobs to the 'rules' sy

[PATCH 1/2] !fixup gitlab: add special rule for the hexagon container

2021-05-25 Thread Philippe Mathieu-Daudé
Make the build-user-hexagon -> hexagon-cross-container optional to avoid on mainstream CI [*]: 'build-user-hexagon' job needs 'hexagon-cross-container' job but it was not added to the pipeline [*] https://gitlab.com/qemu-project/qemu/-/pipelines/309137207 Signed-off-by: Philippe Mathieu-Daudé

[PATCH 2/2] gitlab-ci: Convert check-dco/check-patch jobs to the 'rules' syntax

2021-05-25 Thread Philippe Mathieu-Daudé
Per GitLab documentation [*]: "rules replaces only/except and they can’t be used together in the same job." Since the 'rules' syntax is more powerful and we are already using it, convert the check-dco/check-patch jobs so no job use the 'only/ except' syntax. [*] https://docs.gitlab.com/ee/c

Re: [PATCH 1/9] accel/tcg: Replace g_new() + memcpy() by g_memdup()

2021-05-25 Thread Richard Henderson
On 5/9/21 8:16 AM, Philippe Mathieu-Daudé wrote: From: Richard Henderson Signed-off-by: Richard Henderson Message-Id:<20210508201640.1045808-1-richard.hender...@linaro.org> [PMD: Split from bigger patch] Signed-off-by: Philippe Mathieu-Daudé --- accel/tcg/cputlb.c | 15 --- 1 file

Re: [PATCH 3/9] accel/tlb: Rename TLBFlushPageBitsByMMUIdxData -> TLBFlushRangeData

2021-05-25 Thread Richard Henderson
On 5/9/21 8:16 AM, Philippe Mathieu-Daudé wrote: From: Richard Henderson Signed-off-by: Richard Henderson Message-Id:<20210508201640.1045808-1-richard.hender...@linaro.org> [PMD: Split from bigger patch] Signed-off-by: Philippe Mathieu-Daudé --- accel/tcg/cputlb.c | 24

Re: [PATCH 4/9] accel/tcg: Add tlb_flush_range_by_mmuidx()

2021-05-25 Thread Richard Henderson
On 5/9/21 8:16 AM, Philippe Mathieu-Daudé wrote: From: Richard Henderson Signed-off-by: Richard Henderson Message-Id: <20210508201640.1045808-1-richard.hender...@linaro.org> [PMD: Split from bigger patch] Signed-off-by: Philippe Mathieu-Daudé --- include/exec/exec-all.h | 19 +++

  1   2   3   4   5   >