We are compiling with -fno-common since commit 4c288acbd6 ("configure:
Always build with -fno-common"), so --warn-common (which had been added
in commit 49237acdb725e in 2008 already) should not be necessary anymore
nowadays.
Signed-off-by: Thomas Huth <th...@redhat.com>
---
Marked as RFC since I'm not 100% sure whether I'm missing here something...
but IMHO the --warn-common does not buy us anything if we also compile
with -fno-common...
configure | 7 -------
1 file changed, 7 deletions(-)
diff --git a/configure b/configure
index 86a8a7e44f..99b9216af3 100755
--- a/configure
+++ b/configure
@@ -5383,13 +5383,6 @@ fi
##########################################
-# Exclude --warn-common with TSan to suppress warnings from the TSan libraries.
-if test "$solaris" = "no" && test "$tsan" = "no"; then
- if $ld --version 2>/dev/null | grep "GNU ld" >/dev/null 2>/dev/null ; then
- QEMU_LDFLAGS="-Wl,--warn-common $QEMU_LDFLAGS"
- fi
-fi
-
# Use ASLR, no-SEH and DEP if available
if test "$mingw32" = "yes" ; then
flags="--no-seh --nxcompat"
--
2.27.0
