On 25/05/2021 02:09, David Gibson wrote:
On Mon, May 24, 2021 at 10:59:04AM -0300, Bruno Larsen (billionai) wrote:
Moved the ppc_cpu_do_interrupt function to cpu.c file, where it makes
more sense, and turned powerpc_excp not static, as it now needs to be
accessed from outside of excp_helper.c
Signed-off-by: Bruno Larsen (billionai)
<bruno.lar...@eldorado.org.br>
Looking at this again, I'm inclined to agree with Richard: I don't see
a lot of point to this. It's not really clear to me that these belong
more in cpu.c than in excp_helper.c, and I believe we're already
expecting to need excp_helper.c (or at least parts of it) for !TCG
builds.
yeah, now that I look at it, I agree too. This was in my mind (or code,
can't remember) before we agreed that excp_helper needed to be compiled,
so I went ahead and posted it because it was here all along.
While we compile excp_helper, there isn't really a point. I think there
was a plan to remove or improve excp_helper, so could be something we
come back to later, but for now I'll remove from the patch series
--
Bruno Piazera Larsen
Instituto de Pesquisas ELDORADO
<https://www.eldorado.org.br/?utm_campaign=assinatura_de_e-mail&utm_medium=email&utm_source=RD+Station>
Departamento Computação Embarcada
Analista de Software Trainee
Aviso Legal - Disclaimer <https://www.eldorado.org.br/disclaimer.html>
