Re: [PATCH] MAINTAINERS: update block/rbd.c maintainer

2021-05-21 Thread Stefano Garzarella
On Wed, May 19, 2021 at 01:25:13PM +0200, Ilya Dryomov wrote: Jason has moved on from working on RBD and Ceph. I'm taking over his role upstream. Signed-off-by: Ilya Dryomov --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index eab17

Re: [RFC v3 04/29] vhost: Add x-vhost-enable-shadow-vq qmp

2021-05-21 Thread Markus Armbruster
Eugenio Pérez writes: > Command to enable shadow virtqueue looks like: > > { "execute": "x-vhost-enable-shadow-vq", > "arguments": { "name": "dev0", "enable": true } } > > Signed-off-by: Eugenio Pérez > --- > qapi/net.json | 22 ++ > hw/virtio/vhost.c | 6 ++ > 2

Re: [RFC PATCH 01/11] hw/isa: Explode pci_create_simple() calls

2021-05-21 Thread Markus Armbruster
Philippe Mathieu-Daudé writes: > To be able to set a property on the ISA-IDE bridges objects > before they are realized, explode the pci_create_simple() > calls as pci_new() + pci_realize_and_unref(). > > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/i386/pc_piix.c | 5 +++-- > hw/isa/piix

Re: [PATCH] hw/nvme/ctrl: fix functions style

2021-05-21 Thread Klaus Jensen
On May 21 11:38, Gollu Appalanaidu wrote: Identify command related functions style fix. Signed-off-by: Gollu Appalanaidu --- hw/nvme/ctrl.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/nvme/ctrl.c b/hw/nvme/ctrl.c index 0bcaf7192f..40a7efcea9 100644 --- a/hw/nvme/

Re: [RFC 1/1] acceptance tests: rename acceptance to system

2021-05-21 Thread Thomas Huth
On 20/05/2021 22.28, Philippe Mathieu-Daudé wrote: On 5/20/21 9:53 PM, Willian Rampazzo wrote: Conceptually speaking, acceptance tests "are a series of specific tests conducted by the customer in an attempt to uncover product errors before accepting the software from the developer. Conducted by

Re: A bug of Monitor Chardev ?

2021-05-21 Thread Markus Armbruster
Daniel P. Berrangé writes: > On Wed, May 19, 2021 at 08:17:51PM +0400, Marc-André Lureau wrote: >> Hi >> >> On Mon, May 17, 2021 at 11:11 AM Longpeng (Mike, Cloud Infrastructure >> Service Product Dept.) wrote: >> >> > We find a race during QEMU starting, which would case the QEMU process >> >

Re: making a qdev bus available from a (non-qtree?) device

2021-05-21 Thread Markus Armbruster
I'm about to drop off for two weeks of much-needed vacation. I meant to study your explanation and give design advice before I leave, but I'm out of time. Regrettable. I hope Stefan can help you. Or perhaps Paolo. If you still have questions when I'm back, feel free to contact me again. Klaus

Re: [PATCH 0/2] Fix SIGILL psw.addr reporting

2021-05-21 Thread David Hildenbrand
On 21.05.21 05:01, Ilya Leoshkevich wrote: qemu-s390x puts a wrong value into SIGILL's siginfo_t's psw.addr: it should be a pointer to the instruction following the illegal instruction, but at the moment it is a pointer to the illegal instruction itself. This breaks OpenJDK, which relies on this

Re: [PATCH v3 1/2] qdev-properties: Add a new macro to validate bitmask for setter

2021-05-21 Thread Markus Armbruster
Like Xu writes: > The new generic DEFINE_PROP_BITMASK_UINT64 could be used to ensure > that a user-provided property value complies with its bitmask rule > and the default value is recommended to be set in instance_init(). > > Signed-off-by: Like Xu > --- > hw/core/qdev-properties.c| 19 +++

Re: [PATCH 1/2] target/s390x: Fix SIGILL psw.addr reporting

2021-05-21 Thread David Hildenbrand
On 21.05.21 05:01, Ilya Leoshkevich wrote: When a s390x CPU attempts to execute an illegal instruction, an operation exception is recognized. This is a suppressing exception, which means that the PSW is advanced by the length of the illegal instruction. On the real hardware or in qemu-system-s39

Re: [PATCH 2/2] tests/tcg/s390x: Test SIGILL handling

2021-05-21 Thread David Hildenbrand
On 21.05.21 05:01, Ilya Leoshkevich wrote: Verify that s390x-specific uc_mcontext.psw.addr is reported correctly. Signed-off-by: Ilya Leoshkevich --- tests/tcg/s390x/Makefile.target | 1 + tests/tcg/s390x/sigill.c| 41 + 2 files changed, 42 insertion

Re: [PATCH v6 04/19] i386: stop using env->features[] for filling Hyper-V CPUIDs

2021-05-21 Thread Vitaly Kuznetsov
Eduardo Habkost writes: > On Fri, Apr 30, 2021 at 08:34:40PM -0400, Eduardo Habkost wrote: >> On Thu, Apr 22, 2021 at 06:11:15PM +0200, Vitaly Kuznetsov wrote: >> > As a preparatory patch to dropping Hyper-V CPUID leaves from >> > feature_word_info[] stop using env->features[] as a temporary >> >

Re: [PATCH v6 05/19] i386: introduce hyperv_feature_supported()

2021-05-21 Thread Vitaly Kuznetsov
Eduardo Habkost writes: > On Thu, Apr 22, 2021 at 06:11:16PM +0200, Vitaly Kuznetsov wrote: >> Clean up hv_cpuid_check_and_set() by separating hyperv_feature_supported() >> off it. No functional change intended. >> >> Signed-off-by: Vitaly Kuznetsov >> --- >> target/i386/kvm/kvm.c | 49 +++

Re: [PATCH v6 06/19] i386: introduce hv_cpuid_get_host()

2021-05-21 Thread Vitaly Kuznetsov
Eduardo Habkost writes: > On Thu, Apr 22, 2021 at 06:11:17PM +0200, Vitaly Kuznetsov wrote: >> As a preparation to implementing hv_cpuid_cache intro introduce >> hv_cpuid_get_host(). No functional change intended. >> >> Signed-off-by: Vitaly Kuznetsov >> --- >> target/i386/kvm/kvm.c | 102

[PATCH v3] spapr: Fix EEH capability issue on KVM guest for PCI passthru

2021-05-21 Thread Mahesh Salgaonkar
With upstream kernel, especially after commit 98ba956f6a389 ("powerpc/pseries/eeh: Rework device EEH PE determination") we see that KVM guest isn't able to enable EEH option for PCI pass-through devices anymore. [root@atest-guest ~]# dmesg | grep EEH [0.032337] EEH: pSeries platform initialize

Re: About the performance of hyper-v

2021-05-21 Thread Liang Li
> > Hi Vitaly, > > > > I found a case that the virtualization overhead was almost doubled > > when turning on Hper-v related features compared to that without any > > no hyper-v feature. It happens when running a 3D game in windows > > guest in qemu kvm environment. > > > > By investigation, I fou

Re: About the performance of hyper-v

2021-05-21 Thread Vitaly Kuznetsov
Liang Li writes: >> > Hi Vitaly, >> > >> > I found a case that the virtualization overhead was almost doubled >> > when turning on Hper-v related features compared to that without any >> > no hyper-v feature. It happens when running a 3D game in windows >> > guest in qemu kvm environment. >> > >

Re: making a qdev bus available from a (non-qtree?) device

2021-05-21 Thread Klaus Jensen
On May 21 09:33, Markus Armbruster wrote: I'm about to drop off for two weeks of much-needed vacation. I meant to study your explanation and give design advice before I leave, but I'm out of time. Regrettable. I hope Stefan can help you. Or perhaps Paolo. If you still have questions when I'm

Re: [PULL 21/46] meson: Warn when TCI is selected but TCG backend is available

2021-05-21 Thread Peter Maydell
On Mon, 8 Feb 2021 at 23:09, Paolo Bonzini wrote: > > From: Philippe Mathieu-Daudé > > Some new users get confused with 'TCG' and 'TCI', and enable TCI > support expecting to enable TCG. > > Emit a warning when native TCG backend is available on the > host architecture, mentioning this is a subop

Re: [PULL 00/15] QAPI patches patches for 2021-05-20

2021-05-21 Thread Peter Maydell
On Thu, 20 May 2021 at 18:53, Markus Armbruster wrote: > > The following changes since commit d874bc081600528f0400977460b4f98f21e156a1: > > Merge remote-tracking branch 'remotes/kevin/tags/for-upstream' into staging > (2021-05-19 16:10:35 +0100) > > are available in the Git repository at: > >

Re: [PULL 0/1] NBD patches for 2021-05-11

2021-05-21 Thread Peter Maydell
On Wed, 12 May 2021 at 04:43, Philippe Mathieu-Daudé wrote: > > Hi Eric, > > On 5/11/21 9:28 PM, Eric Blake wrote: > > The following changes since commit f9a576a818044133f8564e0d243ebd97df0b3280: > > > > Merge remote-tracking branch > > 'remotes/dgilbert-gitlab/tags/pull-virtiofs-20210506' into

Re: [PATCH qemu v20] spapr: Implement Open Firmware client interface

2021-05-21 Thread BALATON Zoltan
On Fri, 21 May 2021, Alexey Kardashevskiy wrote: On 21/05/2021 07:59, BALATON Zoltan wrote: On Thu, 20 May 2021, Alexey Kardashevskiy wrote: The PAPR platform describes an OS environment that's presented by a combination of a hypervisor and firmware. The features it specifies require collaborat

Re: [PATCH v7 02/12] accel: Introduce 'query-accels' QMP command

2021-05-21 Thread Markus Armbruster
Philippe Mathieu-Daudé writes: > Introduce the 'query-accels' QMP command which returns a list > of built-in accelerator names. > > - Accelerator is a QAPI enum of all existing accelerators, > > - AcceleratorInfo is a QAPI structure providing accelerator > specific information. Currently the co

Re: [PATCH v12 4/8] arm64: kvm: Introduce MTE VM feature

2021-05-21 Thread Steven Price
On 20/05/2021 18:50, Catalin Marinas wrote: > On Thu, May 20, 2021 at 04:05:46PM +0100, Steven Price wrote: >> On 20/05/2021 12:54, Catalin Marinas wrote: >>> On Mon, May 17, 2021 at 01:32:35PM +0100, Steven Price wrote: diff --git a/arch/arm64/kvm/mmu.c b/arch/arm64/kvm/mmu.c index c5d1f

Re: [PULL 12/25] virtio-gpu: move virgl realize + properties

2021-05-21 Thread Michal Prívozník
On 5/10/21 3:20 PM, Gerd Hoffmann wrote: > Move device init (realize) and properties. > > Drop the virgl property, the virtio-gpu-gl-device has virgl enabled no > matter what. Just use virtio-gpu-device instead if you don't want > enable virgl and opengl. This simplifies the logic and reduces th

Re: [PATCH v7 02/12] accel: Introduce 'query-accels' QMP command

2021-05-21 Thread Philippe Mathieu-Daudé
On 5/5/21 9:41 PM, Eduardo Habkost wrote: > On Wed, May 05, 2021 at 02:57:56PM +0200, Philippe Mathieu-Daudé wrote: >> Introduce the 'query-accels' QMP command which returns a list >> of built-in accelerator names. >> >> - Accelerator is a QAPI enum of all existing accelerators, >> >> - Accelerator

Re: [PATCH v12 7/8] KVM: arm64: ioctl to fetch/store tags in a guest

2021-05-21 Thread Steven Price
On 20/05/2021 18:27, Catalin Marinas wrote: > On Thu, May 20, 2021 at 04:58:01PM +0100, Steven Price wrote: >> On 20/05/2021 13:05, Catalin Marinas wrote: >>> On Mon, May 17, 2021 at 01:32:38PM +0100, Steven Price wrote: diff --git a/arch/arm64/kvm/arm.c b/arch/arm64/kvm/arm.c index e89a5

Re: [PATCH v7 02/12] accel: Introduce 'query-accels' QMP command

2021-05-21 Thread Markus Armbruster
Markus Armbruster writes: > Philippe Mathieu-Daudé writes: > >> Introduce the 'query-accels' QMP command which returns a list >> of built-in accelerator names. >> >> - Accelerator is a QAPI enum of all existing accelerators, >> >> - AcceleratorInfo is a QAPI structure providing accelerator >>

Re: [PATCH v7 02/12] accel: Introduce 'query-accels' QMP command

2021-05-21 Thread Markus Armbruster
Markus Armbruster writes: > The appended incremental patch conditionalizes the enum. It applies on > top of the series, and passes "make check" for me. Seems to contradict > "we can't make the enum values conditional". Neglected to mention that query-accel becomes almost useless in this versio

[PATCH v3 2/3] vl: plumb keyval-based options into -readconfig

2021-05-21 Thread Paolo Bonzini
Let -readconfig support parsing command line options into QDict or QemuOpts. This will be used to add back support for objects in -readconfig. Cc: Markus Armbruster Cc: qemu-sta...@nongnu.org Reviewed-by: Kevin Wolf Signed-off-by: Paolo Bonzini --- v1->v2: fix overlong line include/block/qdi

[PATCH v3 1/3] qemu-config: parse configuration files to a QDict

2021-05-21 Thread Paolo Bonzini
Change the parser to put the values into a QDict and pass them to a callback. qemu_config_parse's QemuOpts creation is itself turned into a callback function. This is useful for -readconfig to support keyval-based options; getting a QDict from the parser removes a roundtrip from QDict to QemuOpts

[PATCH v3 0/3] vl: add -object support back into -readconfig

2021-05-21 Thread Paolo Bonzini
LXD developers have reported that [object] stanzas have stopped working in configuration files. The problem is that QEMU 6.0 switched the creation of objects from qemu_opts_foreach to a bespoke QTAILQ, in preparation for supporting JSON syntax in -object. Entries from the configuration file howev

[PATCH v3 3/3] vl: plug -object back into -readconfig

2021-05-21 Thread Paolo Bonzini
Commit bc2f4fcb1d ("qom: move user_creatable_add_opts logic to vl.c and QAPIfy it", 2021-03-19) switched the creation of objects from qemu_opts_foreach to a bespoke QTAILQ in preparation for supporting JSON syntax in -object. Unfortunately in doing so it lost support for [object] stanzas in config

Re: [PATCH v5 0/4] GitLab Custom Runners and Jobs (was: QEMU Gating CI)

2021-05-21 Thread Alex Bennée
Cleber Rosa writes: > TL;DR: this should allow the QEMU maintainer to push to the staging > branch, and have custom jobs running on the project's aarch64 and > s390x machines. Jobs in this version are allowed to fail, to allow > for the inclusion of the novel machines/jobs without CI disruptio

[PATCH] meson: Fix 'interpretor' typo

2021-05-21 Thread Philippe Mathieu-Daudé
Fix a typo from commit fa2f7b0b9b7 ("meson: Warn when TCI is selected but TCG backend is available"). Reported-by: Peter Maydell Signed-off-by: Philippe Mathieu-Daudé --- meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meson.build b/meson.build index 1559e8d873a.

Re: [PATCH 2/2] tests/tcg/s390x: Test SIGILL handling

2021-05-21 Thread Ilya Leoshkevich
On Fri, 2021-05-21 at 09:54 +0200, David Hildenbrand wrote: > On 21.05.21 05:01, Ilya Leoshkevich wrote: > > Verify that s390x-specific uc_mcontext.psw.addr is reported > > correctly. > > > > Signed-off-by: Ilya Leoshkevich > > --- > >   tests/tcg/s390x/Makefile.target |  1 + > >   tests/tcg/s390

Re: [PATCH 0/2] Fix SIGILL psw.addr reporting

2021-05-21 Thread Ilya Leoshkevich
On Fri, 2021-05-21 at 09:42 +0200, David Hildenbrand wrote: > On 21.05.21 05:01, Ilya Leoshkevich wrote: > > qemu-s390x puts a wrong value into SIGILL's siginfo_t's psw.addr: > > it > > should be a pointer to the instruction following the illegal > > instruction, but at the moment it is a pointer t

Re: [PATCH v3 4/6] gitlab-ci: Add ccache in $PATH and display statistics

2021-05-21 Thread Thomas Huth
On 20/05/2021 13.27, Philippe Mathieu-Daudé wrote: +Stefan/Daniel On 5/20/21 10:02 AM, Thomas Huth wrote: On 19/05/2021 20.45, Philippe Mathieu-Daudé wrote: If a runner has ccache installed, use it and display statistics at the end of the build. Signed-off-by: Philippe Mathieu-Daudé ---   .

Re: [PULL 12/25] virtio-gpu: move virgl realize + properties

2021-05-21 Thread Marc-André Lureau
Hi On Fri, May 21, 2021 at 1:34 PM Michal Prívozník wrote: > On 5/10/21 3:20 PM, Gerd Hoffmann wrote: > > Move device init (realize) and properties. > > > > Drop the virgl property, the virtio-gpu-gl-device has virgl enabled no > > matter what. Just use virtio-gpu-device instead if you don't wa

Re: [PATCH v3 4/6] gitlab-ci: Add ccache in $PATH and display statistics

2021-05-21 Thread Daniel P . Berrangé
On Fri, May 21, 2021 at 12:48:21PM +0200, Thomas Huth wrote: > On 20/05/2021 13.27, Philippe Mathieu-Daudé wrote: > > +Stefan/Daniel > > > > On 5/20/21 10:02 AM, Thomas Huth wrote: > > > On 19/05/2021 20.45, Philippe Mathieu-Daudé wrote: > > > > If a runner has ccache installed, use it and display

Re: [PATCH 0/2] Fix SIGILL psw.addr reporting

2021-05-21 Thread Cornelia Huck
On Fri, 21 May 2021 12:45:30 +0200 Ilya Leoshkevich wrote: > On Fri, 2021-05-21 at 09:42 +0200, David Hildenbrand wrote: > > On 21.05.21 05:01, Ilya Leoshkevich wrote: > > > qemu-s390x puts a wrong value into SIGILL's siginfo_t's psw.addr: > > > it > > > should be a pointer to the instruction f

Re: [PULL 0/1] NBD patches for 2021-05-11

2021-05-21 Thread Peter Maydell
On Tue, 11 May 2021 at 20:30, Eric Blake wrote: > > The following changes since commit f9a576a818044133f8564e0d243ebd97df0b3280: > > Merge remote-tracking branch > 'remotes/dgilbert-gitlab/tags/pull-virtiofs-20210506' into staging > (2021-05-11 13:03:44 +0100) > > are available in the Git repo

Re: [PATCH v3 4/6] gitlab-ci: Add ccache in $PATH and display statistics

2021-05-21 Thread Thomas Huth
On 21/05/2021 12.50, Daniel P. Berrangé wrote: On Fri, May 21, 2021 at 12:48:21PM +0200, Thomas Huth wrote: On 20/05/2021 13.27, Philippe Mathieu-Daudé wrote: +Stefan/Daniel On 5/20/21 10:02 AM, Thomas Huth wrote: On 19/05/2021 20.45, Philippe Mathieu-Daudé wrote: If a runner has ccache inst

Re: [RUST] Add crate for generic vhost-user-i2c backend daemon

2021-05-21 Thread Viresh Kumar
On 28-04-21, 17:52, Viresh Kumar wrote: > Hello, > > In my earlier attempt [1], I implemented the vhost-user-i2c backend > deamon for QEMU (though the code was generic enough to be used with > any hypervisor). > > And here is a Rust implementation of the vhost-user-i2c backend > daemon. Again thi

[PATCH v2 2/2] tests/tcg/s390x: Test SIGILL handling

2021-05-21 Thread Ilya Leoshkevich
Verify that s390x-specific uc_mcontext.psw.addr is reported correctly. Signed-off-by: Ilya Leoshkevich --- tests/tcg/s390x/Makefile.target | 1 + tests/tcg/s390x/sigill.c| 52 + 2 files changed, 53 insertions(+) create mode 100644 tests/tcg/s390x/sigill.

[PATCH v2 0/2] target/s390x: Fix SIGILL psw.addr reporting

2021-05-21 Thread Ilya Leoshkevich
qemu-s390x puts a wrong value into SIGILL's siginfo_t's psw.addr: it should be a pointer to the instruction following the illegal instruction, but at the moment it is a pointer to the illegal instruction itself. This breaks OpenJDK, which relies on this value. Patch 1 fixes the issue, patch 2 adds

[PATCH v2 1/2] target/s390x: Fix SIGILL psw.addr reporting

2021-05-21 Thread Ilya Leoshkevich
When a s390x CPU attempts to execute an illegal instruction, an operation exception is recognized. This is a suppressing exception, which means that the PSW is advanced by the length of the illegal instruction. On the real hardware or in qemu-system-s390x the kernel then raises SIGILL with si_addr

Re: [PATCH v2 2/2] tests/tcg/s390x: Test SIGILL handling

2021-05-21 Thread David Hildenbrand
On 21.05.21 13:19, Ilya Leoshkevich wrote: Verify that s390x-specific uc_mcontext.psw.addr is reported correctly. Signed-off-by: Ilya Leoshkevich --- tests/tcg/s390x/Makefile.target | 1 + tests/tcg/s390x/sigill.c| 52 + 2 files changed, 53 insertion

Re: [PATCH v2 0/2] target/s390x: Fix SIGILL psw.addr reporting

2021-05-21 Thread no-reply
Patchew URL: https://patchew.org/QEMU/2021052908.2843735-1-...@linux.ibm.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 2021052908.2843735-1-...@linux.ibm.com Subject: [PATCH v2 0/2] target/s390x: Fix SIGI

Re: [RFC PATCH 0/9] Initial support for machine creation via QMP

2021-05-21 Thread Markus Armbruster
Paolo Bonzini writes: > Hi Mirela, this is very interesting! > > It's unfortunate that I completely missed the discussions in > January/February. You might have noticed that in the 5.2/6.0 > timeframe I worked on cleaning up the machine initialization phases > and qemu_init. The idea behind th

Re: [PULL 02/19] sev: update sev-inject-launch-secret to make gpa optional

2021-05-21 Thread Philippe Mathieu-Daudé
On 5/21/21 12:19 AM, James Bottomley wrote: > On Thu, 2021-05-20 at 23:36 +0200, Philippe Mathieu-Daudé wrote: >> On 2/15/21 2:16 PM, Paolo Bonzini wrote: >>> From: James Bottomley >>> >>> If the gpa isn't specified, it's value is extracted from the OVMF >>> properties table located below the rese

Re: [PATCH v3 4/6] gitlab-ci: Add ccache in $PATH and display statistics

2021-05-21 Thread Daniel P . Berrangé
On Fri, May 21, 2021 at 01:02:51PM +0200, Thomas Huth wrote: > On 21/05/2021 12.50, Daniel P. Berrangé wrote: > > On Fri, May 21, 2021 at 12:48:21PM +0200, Thomas Huth wrote: > > > On 20/05/2021 13.27, Philippe Mathieu-Daudé wrote: > > > > +Stefan/Daniel > > > > > > > > On 5/20/21 10:02 AM, Thomas

Re: [PATCH v4 9/9] docs: update the documentation about schema configuration

2021-05-21 Thread Markus Armbruster
marcandre.lur...@redhat.com writes: > From: Marc-André Lureau > > Signed-off-by: Marc-André Lureau > Reviewed-by: Stefan Hajnoczi > Tested-by: John Snow > --- > docs/devel/qapi-code-gen.txt | 27 --- > 1 file changed, 16 insertions(+), 11 deletions(-) > > diff --git a/

Re: 9pfs: scope of rename_lock?

2021-05-21 Thread Greg Kurz
On Sun, 16 May 2021 19:06:44 +0200 Christian Schoenebeck wrote: > Hi Greg, > > while reviewing the 9p code base for further optimizations, I stumbled over > the 'rename_lock' introduced by 02cb7f3a2 and wondered about what exactly it > shall protect? > > As far as I understand it, the origina

Re: [PATCH v4 8/9] qapi: make 'if' condition strings simple identifiers

2021-05-21 Thread Markus Armbruster
marcandre.lur...@redhat.com writes: > From: Marc-André Lureau > > Change the 'if' condition strings to be C-agnostic and be simple > identifiers. > > Signed-off-by: Marc-André Lureau > Reviewed-by: Stefan Hajnoczi > Tested-by: John Snow > --- [...] > diff --git a/docs/devel/qapi-code-gen.txt

Re: [RFC 1/1] acceptance tests: rename acceptance to system

2021-05-21 Thread Willian Rampazzo
On Thu, May 20, 2021 at 5:28 PM Philippe Mathieu-Daudé wrote: > > On 5/20/21 9:53 PM, Willian Rampazzo wrote: > > Conceptually speaking, acceptance tests "are a series of specific tests > > conducted by the customer in an attempt to uncover product errors before > > accepting the software from the

[Bug 1887604] Re: Forward host UNIX socket to guest TCP port

2021-05-21 Thread Thomas Huth
This is an automated cleanup. This bug report has been moved to QEMU's new bug tracker on gitlab.com and thus gets marked as 'expired' now. Please continue with the discussion here: https://gitlab.com/qemu-project/qemu/-/issues/347 ** Changed in: qemu Status: New => Expired ** Bug watch

Re: [PATCH v3 4/6] gitlab-ci: Add ccache in $PATH and display statistics

2021-05-21 Thread Philippe Mathieu-Daudé
On 5/21/21 1:53 PM, Daniel P. Berrangé wrote: > On Fri, May 21, 2021 at 01:02:51PM +0200, Thomas Huth wrote: >> On 21/05/2021 12.50, Daniel P. Berrangé wrote: >>> On Fri, May 21, 2021 at 12:48:21PM +0200, Thomas Huth wrote: On 20/05/2021 13.27, Philippe Mathieu-Daudé wrote: > +Stefan/Danie

Re: [PATCH v4 8/9] qapi: make 'if' condition strings simple identifiers

2021-05-21 Thread Marc-André Lureau
On Fri, May 21, 2021 at 4:03 PM Markus Armbruster wrote: > marcandre.lur...@redhat.com writes: > > > From: Marc-André Lureau > > > > Change the 'if' condition strings to be C-agnostic and be simple > > identifiers. > > > > Signed-off-by: Marc-André Lureau > > Reviewed-by: Stefan Hajnoczi > > T

Re: [RFC 1/1] acceptance tests: rename acceptance to system

2021-05-21 Thread Willian Rampazzo
On Fri, May 21, 2021 at 4:16 AM Thomas Huth wrote: > > On 20/05/2021 22.28, Philippe Mathieu-Daudé wrote: > > On 5/20/21 9:53 PM, Willian Rampazzo wrote: > >> Conceptually speaking, acceptance tests "are a series of specific tests > >> conducted by the customer in an attempt to uncover product err

Re: [PATCH v4 9/9] docs: update the documentation about schema configuration

2021-05-21 Thread Marc-André Lureau
Hi On Fri, May 21, 2021 at 3:58 PM Markus Armbruster wrote: > marcandre.lur...@redhat.com writes: > > > From: Marc-André Lureau > > > > Signed-off-by: Marc-André Lureau > > Reviewed-by: Stefan Hajnoczi > > Tested-by: John Snow > > --- > > docs/devel/qapi-code-gen.txt | 27 --

Re: [RFC 1/1] acceptance tests: rename acceptance to system

2021-05-21 Thread Philippe Mathieu-Daudé
On 5/21/21 2:28 PM, Willian Rampazzo wrote: > On Fri, May 21, 2021 at 4:16 AM Thomas Huth wrote: >> >> On 20/05/2021 22.28, Philippe Mathieu-Daudé wrote: >>> On 5/20/21 9:53 PM, Willian Rampazzo wrote: Conceptually speaking, acceptance tests "are a series of specific tests conducted by t

Re: [PATCH v3 4/6] gitlab-ci: Add ccache in $PATH and display statistics

2021-05-21 Thread Willian Rampazzo
On Fri, May 21, 2021 at 8:03 AM Thomas Huth wrote: > > On 21/05/2021 12.50, Daniel P. Berrangé wrote: > > On Fri, May 21, 2021 at 12:48:21PM +0200, Thomas Huth wrote: > >> On 20/05/2021 13.27, Philippe Mathieu-Daudé wrote: > >>> +Stefan/Daniel > >>> > >>> On 5/20/21 10:02 AM, Thomas Huth wrote: >

Re: [RFC 1/1] acceptance tests: rename acceptance to system

2021-05-21 Thread Thomas Huth
On 21/05/2021 14.28, Willian Rampazzo wrote: On Fri, May 21, 2021 at 4:16 AM Thomas Huth wrote: [...] Alternatively, what about renaming the "acceptance" tests to "validation" instead? That word does not have a duplicated definition in the context of QEMU yet, so I think it would be less confu

Re: [PATCH 2/2] hw/usb: hcd-xhci-pci: Fix spec violation of IP flag for MSI/MSI-X

2021-05-21 Thread Philippe Mathieu-Daudé
On 5/21/21 4:42 AM, Bin Meng wrote: > From: Ruimei Yan > > Per xHCI spec v1.2 chapter 4.17.5 page 296: > > If MSI or MSI-X interrupts are enabled, Interrupt Pending (IP) > shall be cleared automatically when the PCI dword write generated > by the interrupt assertion is complete. > > Curre

Re: [PULL 0/9] scripts/simplebench patches

2021-05-21 Thread Peter Maydell
On Tue, 4 May 2021 at 10:01, Vladimir Sementsov-Ogievskiy wrote: > > The following changes since commit 53c5433e84e8935abed8e91d4a2eb813168a0ecf: > > Merge remote-tracking branch 'remotes/rth-gitlab/tags/pull-tcg-20210501' > into staging (2021-05-02 12:02:46 +0100) > > are available in the Git

Re: [RFC 1/1] acceptance tests: rename acceptance to system

2021-05-21 Thread Philippe Mathieu-Daudé
On 5/21/21 2:42 PM, Thomas Huth wrote: > On 21/05/2021 14.28, Willian Rampazzo wrote: >> On Fri, May 21, 2021 at 4:16 AM Thomas Huth wrote: > [...] >>> Alternatively, what about renaming the "acceptance" tests to >>> "validation" >>> instead? That word does not have a duplicated definition in the

Re: [PATCH 1/2] hw/usb: hcd-xhci-pci: Raise MSI/MSI-X interrupts only when told to

2021-05-21 Thread Philippe Mathieu-Daudé
On 5/21/21 4:42 AM, Bin Meng wrote: > From: Ruimei Yan > > At present MSI / MSI-X interrupts are triggered regardless of the > irq level. We should have checked the level to determine whether > the interrupt needs to be delivered. > > The level check logic was present in early versions of the xh

[PULL 04/11] ui: add clipboard infrastructure

2021-05-21 Thread Gerd Hoffmann
Add some infrastructure to manage the clipboard in qemu. Signed-off-by: Gerd Hoffmann Reviewed-by: Marc-André Lureau Message-id: 20210519053940.1888907-1-kra...@redhat.com Message-Id: <20210519053940.1888907-3-kra...@redhat.com> --- include/ui/clipboard.h | 62 ui/c

[PULL 00/11] Ui 20210521 patches

2021-05-21 Thread Gerd Hoffmann
The following changes since commit 972e848b53970d12cb2ca64687ef8ff797fb6236: Merge remote-tracking branch 'remotes/cohuck-gitlab/tags/s390x-20210520-v2' into staging (2021-05-20 18:42:00 +0100) are available in the Git repository at: git://git.kraxel.org/qemu tags/ui-20210521-pu

[PULL 05/11] ui: add clipboard documentation

2021-05-21 Thread Gerd Hoffmann
Document clipboard infrastructure in qemu. Signed-off-by: Gerd Hoffmann Reviewed-by: Marc-André Lureau Message-id: 20210519053940.1888907-1-kra...@redhat.com Message-Id: <20210519053940.1888907-4-kra...@redhat.com> --- include/ui/clipboard.h | 133 - docs

Re: [PATCH v3 4/6] gitlab-ci: Add ccache in $PATH and display statistics

2021-05-21 Thread Daniel P . Berrangé
On Fri, May 21, 2021 at 02:27:26PM +0200, Philippe Mathieu-Daudé wrote: > On 5/21/21 1:53 PM, Daniel P. Berrangé wrote: > > On Fri, May 21, 2021 at 01:02:51PM +0200, Thomas Huth wrote: > >> On 21/05/2021 12.50, Daniel P. Berrangé wrote: > >>> On Fri, May 21, 2021 at 12:48:21PM +0200, Thomas Huth wr

[PULL 03/11] build: add separate spice-protocol config option

2021-05-21 Thread Gerd Hoffmann
When implementing spice vdagent protocol in qemu we only need the spice-protocol package for that, spice-server is not needed. So go split those two build dependencies. Signed-off-by: Gerd Hoffmann Reviewed-by: Marc-André Lureau Message-id: 20210519053940.1888907-1-kra...@redhat.com Message-Id:

[PULL 02/11] ui/spice-display: check NULL pointer in interface_release_resource()

2021-05-21 Thread Gerd Hoffmann
From: Mauro Matteo Cascella Check rext.info to avoid potential NULL pointer dereference. A similar check exists in interface_release_resource() in hw/display/qxl.c. Reported-by: Yu Lu Signed-off-by: Mauro Matteo Cascella Reviewed-by: Prasad J Pandit Message-Id: <20210520105833.183160-1-mcasc.

[PULL 01/11] vnc: spelling fix (enable->enabled)

2021-05-21 Thread Gerd Hoffmann
From: Michael Tokarev Signed-off-by: Michael Tokarev Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20210508092558.351102-1-...@msgid.tls.msk.ru> Signed-off-by: Gerd Hoffmann --- ui/vnc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ui/vnc.c b/ui/vnc.c index 456db47d7

[PULL 10/11] ui/gtk: move struct GtkDisplayState to ui/gtk.h

2021-05-21 Thread Gerd Hoffmann
Want place gtk clipboard code in a separate C file, which in turn requires GtkDisplayState being in a header file. So move it. No functional change. Signed-off-by: Gerd Hoffmann Reviewed-by: Marc-André Lureau Message-id: 20210519053940.1888907-1-kra...@redhat.com Message-Id: <20210519053940.18

[PULL 06/11] ui/vdagent: core infrastructure

2021-05-21 Thread Gerd Hoffmann
The vdagent protocol allows the guest agent (spice-vdagent) and the spice client exchange messages to implement features which require guest cooperation, for example clipboard support. This is a qemu implementation of the spice client side. This allows the spice guest agent talk to qemu directly

[PULL 08/11] ui/vdagent: add clipboard support

2021-05-21 Thread Gerd Hoffmann
This patch adds support for clipboard messages to the qemu vdagent implementation, which allows the guest exchange clipboard data with qemu. Clipboard support can be enabled/disabled using the new 'clipboard' parameter for the vdagent chardev. Default is off. Signed-off-by: Gerd Hoffmann Review

[PULL 11/11] ui/gtk: add clipboard support

2021-05-21 Thread Gerd Hoffmann
This patch adds clipboard support to the qemu gtk ui. Signed-off-by: Gerd Hoffmann Reviewed-by: Marc-André Lureau Message-id: 20210519053940.1888907-1-kra...@redhat.com Message-Id: <20210519053940.1888907-10-kra...@redhat.com> --- include/ui/gtk.h | 10 +++ ui/gtk-clipboard.c | 192 +

[PULL 07/11] ui/vdagent: add mouse support

2021-05-21 Thread Gerd Hoffmann
This patch adds support for mouse messages to the vdagent implementation. This can be enabled/disabled using the new 'mouse' parameter for the vdagent chardev. Default is on. Signed-off-by: Gerd Hoffmann Reviewed-by: Marc-André Lureau Acked-by: Markus Armbruster Message-id: 20210519053940.188

Re: [PATCH v3 4/6] gitlab-ci: Add ccache in $PATH and display statistics

2021-05-21 Thread Thomas Huth
On 21/05/2021 14.36, Willian Rampazzo wrote: On Fri, May 21, 2021 at 8:03 AM Thomas Huth wrote: On 21/05/2021 12.50, Daniel P. Berrangé wrote: [...] Is there anything functional holding up your previous full cccache support series from last month ? Or is it just lack of reviews ? It's basi

[PULL 09/11] ui/vnc: clipboard support

2021-05-21 Thread Gerd Hoffmann
This patch adds support for cut+paste to the qemu vnc server, which allows the vnc client exchange clipbaord data with qemu and other peers like the qemu vdagent implementation. Signed-off-by: Gerd Hoffmann Reviewed-by: Marc-André Lureau Message-id: 20210519053940.1888907-1-kra...@redhat.com Mes

Re: [RFC 1/1] acceptance tests: rename acceptance to system

2021-05-21 Thread Alex Bennée
Philippe Mathieu-Daudé writes: > On 5/21/21 2:28 PM, Willian Rampazzo wrote: >> On Fri, May 21, 2021 at 4:16 AM Thomas Huth wrote: >>> >>> On 20/05/2021 22.28, Philippe Mathieu-Daudé wrote: On 5/20/21 9:53 PM, Willian Rampazzo wrote: > Conceptually speaking, acceptance tests "are a se

Re: [PULL 0/9] scripts/simplebench patches

2021-05-21 Thread Vladimir Sementsov-Ogievskiy
21.05.2021 15:45, Peter Maydell wrote: On Tue, 4 May 2021 at 10:01, Vladimir Sementsov-Ogievskiy wrote: The following changes since commit 53c5433e84e8935abed8e91d4a2eb813168a0ecf: Merge remote-tracking branch 'remotes/rth-gitlab/tags/pull-tcg-20210501' into staging (2021-05-02 12:02:46 +

Re: [RFC 1/1] acceptance tests: rename acceptance to system

2021-05-21 Thread Alex Bennée
Thomas Huth writes: > On 21/05/2021 14.28, Willian Rampazzo wrote: >> On Fri, May 21, 2021 at 4:16 AM Thomas Huth wrote: > [...] >>> Alternatively, what about renaming the "acceptance" tests to "validation" >>> instead? That word does not have a duplicated definition in the context of >>> QEMU

Re: [PULL 00/11] Ui 20210521 patches

2021-05-21 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20210521125119.3173309-1-kra...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20210521125119.3173309-1-kra...@redhat.com Subject: [PULL 00/11] Ui 20210521 patches

RE: [PATCH] scripts/checkpatch.pl: process .c.inc and .h.inc files as C source

2021-05-21 Thread Luis Fernando Fujita Pires
From: Matheus Ferst > > Change the regex used to determine whether a file should be processed as C > source to include .c.inc and .h.inc extensions. > > Signed-off-by: Matheus Ferst > --- > scripts/checkpatch.pl | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Luis Pir

Windows fails to boot after rebase to QEMU master

2021-05-21 Thread Siddharth Chandrasekaran
After a rebase to QEMU master, I am having trouble booting windows VMs. Git bisect indicates commit f5cc5a5c1686 ("i386: split cpu accelerators from cpu.c, using AccelCPUClass") to have introduced the issue. I spent some time looking at into it yesterday without much luck. Steps to reproduce:

Re: [PATCH 2/2] hw/usb: hcd-xhci-pci: Fix spec violation of IP flag for MSI/MSI-X

2021-05-21 Thread Bin Meng
On Fri, May 21, 2021 at 8:46 PM Philippe Mathieu-Daudé wrote: > > On 5/21/21 4:42 AM, Bin Meng wrote: > > From: Ruimei Yan > > > > Per xHCI spec v1.2 chapter 4.17.5 page 296: > > > > If MSI or MSI-X interrupts are enabled, Interrupt Pending (IP) > > shall be cleared automatically when the PCI

Re: [PULL 00/26] Misc patches for 2021-05-20

2021-05-21 Thread Paolo Bonzini
On 20/05/21 15:26, Peter Maydell wrote: WARNING: Project specifies a minimum meson_version '>=0.55.0' but uses features which were added in newer versions: * 0.57.0: {'test() timeout <= 0'} ERROR: Could not detect Ninja v1.8.2 or newer (This system has ninja-build 1.7.2.) What OS is it, and

Re: [PATCH V3 11/22] vfio-pci: refactor for cpr

2021-05-21 Thread Steven Sistare
On 5/19/2021 6:38 PM, Alex Williamson wrote: > On Fri, 7 May 2021 05:25:09 -0700 > Steve Sistare wrote: > >> Export vfio_address_spaces and vfio_listener_skipped_section. >> Add optional eventfd arg to vfio_add_kvm_msi_virq. >> Refactor vector use into a helper vfio_vector_init. >> All for use b

[RFC PATCH] meson.build: fix cosmetics of compiler display

2021-05-21 Thread Alex Bennée
If you specify something like --cc="ccache gcc" on your configure line the summary output misses the rest of the cmd_array. Do some string joining to make it complete. Signed-off-by: Alex Bennée --- meson.build | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/meson.bui

Re: [PULL 00/26] Misc patches for 2021-05-20

2021-05-21 Thread Peter Maydell
On Fri, 21 May 2021 at 14:27, Paolo Bonzini wrote: > > On 20/05/21 15:26, Peter Maydell wrote: > > WARNING: Project specifies a minimum meson_version '>=0.55.0' but uses > > features which were added in newer versions: > > * 0.57.0: {'test() timeout <= 0'} > > > > ERROR: Could not detect Ninja v

Re: [PULL 12/25] virtio-gpu: move virgl realize + properties

2021-05-21 Thread Gerd Hoffmann
Hi, > (it's not clear to me if virtio-gpu*-device should be user_creatable on x86 > at least) Yes (microvm uses virtio-mmio). take care, Gerd

Re: [PATCH 1/4] target/m68k: introduce is_singlestepping() function

2021-05-21 Thread Richard Henderson
On 5/19/21 9:29 AM, Mark Cave-Ayland wrote: The m68k translator currently checks the DisasContextBase singlestep_enabled boolean directly to determine whether to single-step execution. Soon single-stepping may also be triggered by setting the appropriate bits in the SR register so centralise the

Re: [PATCH 2/4] target/m68k: call gen_raise_exception() directly if single-stepping in gen_jmp_tb()

2021-05-21 Thread Richard Henderson
On 5/19/21 9:29 AM, Mark Cave-Ayland wrote: In order to consolidate the single-step exception handling into a single helper, change gen_jmp_tb() so that it calls gen_raise_exception() directly instead of gen_exception(). This ensures that all single-step exceptions are now handled directly by gen

Re: [PATCH 3/4] target/m68k: introduce gen_singlestep_exception() function

2021-05-21 Thread Richard Henderson
On 5/19/21 9:29 AM, Mark Cave-Ayland wrote: Introduce a new gen_singlestep_exception() function to be called when generating the EXCP_DEBUG exception in single-step mode rather than calling gen_raise_exception(EXCP_DEBUG) directly. This allows for the single-step exception behaviour for all calle

Re: [PATCH 4/4] target/m68k: implement m68k "any instruction" trace mode

2021-05-21 Thread Richard Henderson
On 5/19/21 9:29 AM, Mark Cave-Ayland wrote: The m68k trace mode is controlled by the top 2 bits in the SR register. Implement the m68k "any instruction" trace mode where bit T1=1 and bit T0=0 in which the CPU generates an EXCP_TRACE exception (vector 9 or offset 0x24) after executing each instr

Re: [PULL 12/25] virtio-gpu: move virgl realize + properties

2021-05-21 Thread Gerd Hoffmann
Hi, > Sorry for catching this a bit late, but libvirt is looking for "virgl" > property when guest XML has 3D acceleration enabled: Yes, libvirt must be adapted to this. https://gitlab.com/libvirt/libvirt/-/issues/167 As far I know libvirt checks whenever the virgl property exists to figure w

Re: [RFC PATCH] meson.build: fix cosmetics of compiler display

2021-05-21 Thread Thomas Huth
On 21/05/2021 15.44, Alex Bennée wrote: If you specify something like --cc="ccache gcc" on your configure line the summary output misses the rest of the cmd_array. Do some string joining to make it complete. Signed-off-by: Alex Bennée --- meson.build | 8 1 file changed, 4 insertions

  1   2   3   >