On Tue, Apr 20, 2021 at 10:51:47AM +0100, Igor Druzhinin wrote:
> On 20/04/2021 04:39, no-re...@patchew.org wrote:
> > === OUTPUT BEGIN ===
> > ERROR: Author email address is mangled by the mailing list
> > #2:
> > Author: Igor Druzhinin via
> >
> > total: 1 errors, 0 warnings, 21 lines checked
>
On 4/20/21 12:36 PM, David Hildenbrand wrote:
> On 20.04.21 12:18, Philippe Mathieu-Daudé wrote:
>> Hi David,
>>
>> On 4/20/21 11:52 AM, Philippe Mathieu-Daudé wrote:
>>> On 4/13/21 11:14 AM, David Hildenbrand wrote:
Let's pass in ram flags just like we do with
qemu_ram_alloc_from_file(),
Claudio Fontana writes:
> give them their own common module cpregs.c, and an interface cpregs.h.
> Extract the raw cpustate list to its own module.
> This is more or less needed for KVM too.
>
> For the tcg-specific registers, stuff them into tcg/cpregs.c
>
> As a result, the monster that is tc
On 4/13/21 11:14 AM, David Hildenbrand wrote:
> Let's print the property.
>
> Cc: Markus Armbruster
> Cc: Eric Blake
> Cc: Igor Mammedov
> Signed-off-by: David Hildenbrand
> ---
> hw/core/machine-hmp-cmds.c | 2 ++
> 1 file changed, 2 insertions(+)
Reviewed-by: Philippe Mathieu-Daudé
Claudio Fontana writes:
> Signed-off-by: Claudio Fontana
> Reviewed-by: Richard Henderson
Reviewed-by: Alex Bennée
--
Alex Bennée
On 4/20/21 11:34 AM, Alex Bennée wrote:
>
> Claudio Fontana writes:
>
>> On 4/19/21 12:29 PM, Thomas Huth wrote:
>>> On 19/04/2021 12.24, Claudio Fontana wrote:
On 4/19/21 12:22 PM, Thomas Huth wrote:
> On 16/04/2021 18.27, Claudio Fontana wrote:
>> Skip the test_device_intro_concre
On 20.04.21 12:45, Philippe Mathieu-Daudé wrote:
On 4/20/21 12:36 PM, David Hildenbrand wrote:
On 20.04.21 12:18, Philippe Mathieu-Daudé wrote:
Hi David,
On 4/20/21 11:52 AM, Philippe Mathieu-Daudé wrote:
On 4/13/21 11:14 AM, David Hildenbrand wrote:
Let's pass in ram flags just like we do w
* Markus Armbruster (arm...@redhat.com) wrote:
> "Zhang, Chen" writes:
>
> >> -Original Message-
> >> From: Markus Armbruster
> >> Sent: Thursday, April 15, 2021 11:15 PM
> >> To: Zhang, Chen
> >> Cc: Dr. David Alan Gilbert ; Lukas Straub
> >> ; Li Zhijian ; Jason Wang
> >> ; qemu-dev ;
On 20.04.21 12:40, Philippe Mathieu-Daudé wrote:
On 4/20/21 12:27 PM, David Hildenbrand wrote:
On 20.04.21 12:20, Philippe Mathieu-Daudé wrote:
Hi David,
On 4/13/21 11:14 AM, David Hildenbrand wrote:
Let's forward ram_flags instead, renaming
memory_region_init_ram_shared_nomigrate() into
memo
On 20.04.21 12:40, Philippe Mathieu-Daudé wrote:
On 4/20/21 12:27 PM, David Hildenbrand wrote:
On 20.04.21 12:20, Philippe Mathieu-Daudé wrote:
Hi David,
On 4/13/21 11:14 AM, David Hildenbrand wrote:
Let's forward ram_flags instead, renaming
memory_region_init_ram_shared_nomigrate() into
memo
On Tue, 20 Apr 2021 at 10:25, Dr. David Alan Gilbert
wrote:
>
> * Daniel P. Berrangé (berra...@redhat.com) wrote:
> > On Tue, Apr 20, 2021 at 07:19:06AM +0200, Markus Armbruster wrote:
> > > Result @blocked is true when and only when result @blocked-reasons is
> > > present. It's always non-empty
On 4/19/21 3:42 PM, Peter Maydell wrote:
> On Thu, 25 Mar 2021 at 18:14, Philippe Mathieu-Daudé wrote:
>>
>> Hi Peter,
>>
>> On 3/25/21 5:33 PM, Peter Maydell wrote:
>>> Currently the gpex PCI controller implements no special behaviour for
>>> guest accesses to areas of the PIO and MMIO where it h
* Eduardo Habkost (ehabk...@redhat.com) wrote:
> On Mon, Apr 19, 2021 at 07:47:34PM +0100, Dr. David Alan Gilbert wrote:
> > * Daniel P. Berrangé (berra...@redhat.com) wrote:
> > > On Mon, Apr 19, 2021 at 06:15:56PM +0100, Daniel P. Berrangé wrote:
> > > > On Mon, Apr 19, 2021 at 06:11:47PM +0100,
Added a table-like output which contains the total number of calls
for each used syscall along with the number of errors that occurred.
Per-call tracing is still available through supplying the argument
``print`` to the plugin.
Signed-off-by: Mahmoud Mandour
---
v2 -> v3: * Locked shared hash-ta
20.04.2021 13:04, Emanuele Giuseppe Esposito wrote:
As done in BlockCopyCallState, categorize BlockCopyTask
in IN, State and OUT fields. This is just to understand
which field has to be protected with a lock.
Also add coroutine_fn attribute to block_copy_task_create,
because it is only usedn blo
** Changed in: qemu
Status: Incomplete => New
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1806196
Title:
qed leaked clusters
Status in QEMU:
New
Bug description:
There are examples o
David Gibson writes:
> On Mon, Apr 19, 2021 at 10:33:07PM -0300, matheus.fe...@eldorado.org.br wrote:
>> From: Matheus Ferst
>>
>> A newer compiler is needed to build tests for Power10 instructions. As
>> done for arm64 on c729a99d2701, a new '-test-cross' image is created for
>> ppc64 and pp
On Tue, Apr 20, 2021 at 1:52 PM Philippe Mathieu-Daudé wrote:
> On 4/19/21 3:42 PM, Peter Maydell wrote:
> >>
> >> I suspect PCI-ISA bridges to provide an EISA bus.
> >
> > I'm not sure what you mean here -- there isn't an ISA bridge
> > or an EISA bus involved here. This is purely about the behav
In tlbi_aa64_vae2is_write() the calculation
bits = tlbbits_for_regime(env, secure ? ARMMMUIdx_E2 : ARMMMUIdx_SE2,
pageaddr)
has the two arms of the ?: expression reversed. Fix the bug.
Fixes: b6ad6062f1e5
Reported-by: Rebecca Cran
Signed-off-by: Peter Maydell
---
On 4/20/21 2:26 PM, Arnd Bergmann wrote:
> On Tue, Apr 20, 2021 at 1:52 PM Philippe Mathieu-Daudé
> wrote:
>> On 4/19/21 3:42 PM, Peter Maydell wrote:
I suspect PCI-ISA bridges to provide an EISA bus.
>>>
>>> I'm not sure what you mean here -- there isn't an ISA bridge
>>> or an EISA bu
On Tue, 20 Apr 2021 at 13:31, Peter Maydell wrote:
>
> In tlbi_aa64_vae2is_write() the calculation
> bits = tlbbits_for_regime(env, secure ? ARMMMUIdx_E2 : ARMMMUIdx_SE2,
> pageaddr)
>
> has the two arms of the ?: expression reversed. Fix the bug.
>
> Fixes: b6ad6062f
On 4/20/21 2:20 PM, Alex Bennée wrote:
> David Gibson writes:
>> On Mon, Apr 19, 2021 at 10:33:07PM -0300, matheus.fe...@eldorado.org.br
>> wrote:
>>> From: Matheus Ferst
>>>
>>> A newer compiler is needed to build tests for Power10 instructions. As
>>> done for arm64 on c729a99d2701, a new '-te
On Wed, 31 Mar 2021 at 12:19, Cornelia Huck wrote:
>
> Add 6.1 machine types for arm/i440fx/q35/s390x/spapr.
>
> Signed-off-by: Cornelia Huck
> ---
> hw/arm/virt.c | 7 ++-
> hw/core/machine.c | 3 +++
> hw/i386/pc.c | 3 +++
> hw/i386/pc_piix.c
+Rémi
On 4/20/21 2:31 PM, Peter Maydell wrote:
> In tlbi_aa64_vae2is_write() the calculation
> bits = tlbbits_for_regime(env, secure ? ARMMMUIdx_E2 : ARMMMUIdx_SE2,
> pageaddr)
>
> has the two arms of the ?: expression reversed. Fix the bug.
>
> Fixes: b6ad6062f1e5
** Changed in: qemu
Status: New => Incomplete
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1819908
Title:
slight screen corruption when maximizing window
Status in QEMU:
Incomplete
Bug
On Tue, 20 Apr 2021 at 11:24, Michael S. Tsirkin wrote:
>
> On Thu, Mar 25, 2021 at 04:33:15PM +, Peter Maydell wrote:
> > Currently the gpex PCI controller implements no special behaviour for
> > guest accesses to areas of the PIO and MMIO where it has not mapped
> > any PCI devices, which me
Suggested patch:
https://lists.gnu.org/archive/html/qemu-devel/2021-03/msg09422.html
** Changed in: qemu
Status: New => Confirmed
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1819182
Title:
On Tue, 20 Apr 2021 13:37:07 +0100
Peter Maydell wrote:
> On Wed, 31 Mar 2021 at 12:19, Cornelia Huck wrote:
> >
> > Add 6.1 machine types for arm/i440fx/q35/s390x/spapr.
> >
> > Signed-off-by: Cornelia Huck
> > ---
> > hw/arm/virt.c | 7 ++-
> > hw/core/machine.c |
On 20.04.21 12:36, Claudio Fontana wrote:
we stop short of renaming the actual qom object though,
so type remains TYPE_QEMU_S390_TOD, ie "s390-tod-qemu".
Signed-off-by: Claudio Fontana
---
hw/s390x/{tod-qemu.c => tod-tcg.c} | 0
hw/s390x/meson.build | 2 +-
2 files changed, 1
On 20.04.21 12:36, Claudio Fontana wrote:
this will allow in later patches to remove unneeded stubs
in target/s390x.
Signed-off-by: Claudio Fontana
---
hw/s390x/meson.build | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/hw/s390x/meson.build b/hw/s390x/meson.build
ind
On 20.04.21 12:36, Claudio Fontana wrote:
replace general "else" with specific checks for each possible accelerator.
> Handle qtest as a NOP,
^ weird line break
Reviewed-by: David Hildenbrand
and error out for an unknown accelerator used in combination with tod.
Signed-off-by: Claudio Fon
On 20/04/2021 14:03, Vladimir Sementsov-Ogievskiy wrote:
20.04.2021 13:04, Emanuele Giuseppe Esposito wrote:
As done in BlockCopyCallState, categorize BlockCopyTask
in IN, State and OUT fields. This is just to understand
which field has to be protected with a lock.
Also add coroutine_fn attr
On 20.04.21 12:36, Claudio Fontana wrote:
now that we protect all calls to the tcg-specific functions
with if (tcg_enabled()), we do not need the TCG stub anymore.
You need compile-time checks, not runtime checks. Any calls have to be
protected by #ifdef, otherwise the compiler might bail out.
From: Marc-André Lureau
Commit 54aa3de72 ("qapi: Use QAPI_LIST_PREPEND() where possible")
inadvertently removed the has_dependencies from the partition disk
info, resulting in empty list being returned.
Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1950833
Signed-off-by: Marc-André Lureau
On 4/20/21 2:54 PM, David Hildenbrand wrote:
> On 20.04.21 12:36, Claudio Fontana wrote:
>> now that we protect all calls to the tcg-specific functions
>> with if (tcg_enabled()), we do not need the TCG stub anymore.
>
> You need compile-time checks, not runtime checks. Any calls have to be
> pro
On 20.04.21 15:00, Claudio Fontana wrote:
On 4/20/21 2:54 PM, David Hildenbrand wrote:
On 20.04.21 12:36, Claudio Fontana wrote:
now that we protect all calls to the tcg-specific functions
with if (tcg_enabled()), we do not need the TCG stub anymore.
You need compile-time checks, not runtime
On Tue, Apr 20, 2021 at 04:58:31PM +0400, marcandre.lur...@redhat.com wrote:
> From: Marc-André Lureau
>
> Commit 54aa3de72 ("qapi: Use QAPI_LIST_PREPEND() where possible")
> inadvertently removed the has_dependencies from the partition disk
> info, resulting in empty list being returned.
>
> Fi
On 20.04.21 12:36, Claudio Fontana wrote:
now that we protect all calls to the tcg-specific functions
with if (tcg_enabled()), we do not need the TCG stub anymore.
As we keep the prototypes, this should indeed work
Reviewed-by: David Hildenbrand
--
Thanks,
David / dhildenb
20.04.2021 15:51, Emanuele Giuseppe Esposito wrote:
On 20/04/2021 14:03, Vladimir Sementsov-Ogievskiy wrote:
20.04.2021 13:04, Emanuele Giuseppe Esposito wrote:
As done in BlockCopyCallState, categorize BlockCopyTask
in IN, State and OUT fields. This is just to understand
which field has to b
20.04.2021 13:04, Emanuele Giuseppe Esposito wrote:
This serie of patches continues Paolo's series on making the
block layer thread safe. Add a CoMutex lock for both tasks and
calls list present in block/block-copy.c
I think, we need more information about what kind of thread-safety we want.
On 4/20/21 2:58 PM, marcandre.lur...@redhat.com wrote:
> From: Marc-André Lureau
>
> Commit 54aa3de72 ("qapi: Use QAPI_LIST_PREPEND() where possible")
> inadvertently removed the has_dependencies from the partition disk
> info, resulting in empty list being returned.
>
> Fixes: https://bugzilla.
On 20.04.21 12:36, Claudio Fontana wrote:
move everything related to translate, as well as HELPER code in tcg/
mmu_helper.c stays put for now, as it contains both TCG and KVM code.
How hard would it be to split that up as well?
The internal.h file is renamed to s390x-internal.h, because of
On 4/20/21 3:04 PM, David Hildenbrand wrote:
> On 20.04.21 15:00, Claudio Fontana wrote:
>> On 4/20/21 2:54 PM, David Hildenbrand wrote:
>>> On 20.04.21 12:36, Claudio Fontana wrote:
now that we protect all calls to the tcg-specific functions
with if (tcg_enabled()), we do not need the TC
On 4/20/21 3:16 PM, David Hildenbrand wrote:
> On 20.04.21 12:36, Claudio Fontana wrote:
>> move everything related to translate, as well as HELPER code in tcg/
>>
>> mmu_helper.c stays put for now, as it contains both TCG and KVM code.
>>
>
> How hard would it be to split that up as well?
>
>> T
On Tue, Apr 20, 2021 at 12:51:43PM +0100, Dr. David Alan Gilbert wrote:
> * Eduardo Habkost (ehabk...@redhat.com) wrote:
> > On Mon, Apr 19, 2021 at 07:47:34PM +0100, Dr. David Alan Gilbert wrote:
> > > * Daniel P. Berrangé (berra...@redhat.com) wrote:
> > > > On Mon, Apr 19, 2021 at 06:15:56PM +01
On 4/20/21 6:31 AM, Peter Maydell wrote:
In tlbi_aa64_vae2is_write() the calculation
bits = tlbbits_for_regime(env, secure ? ARMMMUIdx_E2 : ARMMMUIdx_SE2,
pageaddr)
has the two arms of the ?: expression reversed. Fix the bug.
Fixes: b6ad6062f1e5
Reported-by: Rebe
On 4/19/21 1:42 PM, Philippe Mathieu-Daudé wrote:
On 4/19/21 9:27 PM, Richard Henderson wrote:
On 4/19/21 12:18 PM, Philippe Mathieu-Daudé wrote:
Rename set_pc() as mips_cpu_set_error_pc(), declare it inlined
and use it in cpu.c and op_helper.c.
Why "error_pc"? The usage in mips_cpu_set_pc c
On Tue, 20 Apr 2021 at 11:06, Philippe Mathieu-Daudé wrote:
>
> When adding this file and its new content in commit 3f7a927847a
> ("target/mips: LSA/DLSA R6 decodetree helpers") I did 2 mistakes:
>
> 1: Listed authors who haven't been involved in its development,
> 2: Used an incorrect GNU GPLv2 l
On Thursday, 2021-04-15 at 01:23:54 +08, huangy wrote:
> From: Hyman Huang(黄勇)
>
> introduce optional sample-pages argument in calc-dirty-rate,
> making sample page count per GB configurable so that more
> accurate dirtyrate can be calculated.
>
> Signed-off-by: Hyman Huang(黄勇)
> ---
> migratio
* Eduardo Habkost (ehabk...@redhat.com) wrote:
> On Tue, Apr 20, 2021 at 12:51:43PM +0100, Dr. David Alan Gilbert wrote:
> > * Eduardo Habkost (ehabk...@redhat.com) wrote:
> > > On Mon, Apr 19, 2021 at 07:47:34PM +0100, Dr. David Alan Gilbert wrote:
> > > > * Daniel P. Berrangé (berra...@redhat.com
On Tue, Apr 20, 2021 at 03:10:44PM +0100, Dr. David Alan Gilbert wrote:
> * Eduardo Habkost (ehabk...@redhat.com) wrote:
> > On Tue, Apr 20, 2021 at 12:51:43PM +0100, Dr. David Alan Gilbert wrote:
> > > I prefer things that are fairly obvious without needing to look at the
> > > documentation until
On 4/19/21 6:31 PM, frank.ch...@sifive.com wrote:
From: Frank Chang
In IEEE 754-2008 spec:
Invalid operation exception is signaled when doing:
fusedMultiplyAdd(0, Inf, c) or fusedMultiplyAdd(Inf, 0, c)
unless c is a quiet NaN; if c is a quiet NaN then it is
implementation defined whe
On 20/04/2021 09:20, Alex Bennée wrote:
David Gibson writes:
On Mon, Apr 19, 2021 at 10:33:07PM -0300, matheus.fe...@eldorado.org.br wrote:
From: Matheus Ferst
A newer compiler is needed to build tests for Power10 instructions. As
done for arm64 on c729a99d2701, a new '-test-cross' image i
15.04.2021 18:22, Kevin Wolf wrote:
In order to avoid RMW cycles, is_allocated_sectors() treats zeroed areas
like non-zero data if the end of the checked area isn't aligned. This
can improve the efficiency of the conversion and was introduced in
commit 8dcd3c9b91a.
However, it comes with a corre
@Thomas,
Is there really no way to detect the format other than relying on
extension? :-(
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1819182
Title:
info does not recognize file format of vpc wi
On 4/19/21 6:33 PM, matheus.fe...@eldorado.org.br wrote:
+var = 0xFEDCBA9876543210;
+asm("brh %0, %0" : "=r"(var));
+assert(var == 0xDCFE98BA54761032);
Incorrect inline assembly, you are not declaring an input.
Use "+r" for in/out argument.
r~
On 20/04/2021 11:58, Richard Henderson wrote:
On 4/19/21 6:33 PM, matheus.fe...@eldorado.org.br wrote:
+#include
+#include
+
+int main(void)
+{
Oh, also, there's nothing in here that requires stdio.h.
r~
Forgot to remove. Will be fixed in the next version.
Thanks,
Matheus K. Ferst
Insti
On Tue, Apr 20, 2021 at 03:10:44PM +0100, Dr. David Alan Gilbert wrote:
> * Eduardo Habkost (ehabk...@redhat.com) wrote:
> > On Tue, Apr 20, 2021 at 12:51:43PM +0100, Dr. David Alan Gilbert wrote:
> > > * Eduardo Habkost (ehabk...@redhat.com) wrote:
> > > > On Mon, Apr 19, 2021 at 07:47:34PM +0100,
> -Original Message-
> From: Dr. David Alan Gilbert
> Sent: Tuesday, April 20, 2021 7:06 PM
> To: Markus Armbruster
> Cc: Zhang, Chen ; Lukas Straub
> ; Li Zhijian ; Jason Wang
> ; qemu-dev ; Zhang
> Chen
> Subject: Re: [PATCH V4 1/7] qapi/net.json: Add IP_PROTOCOL definition
>
> * M
Due to some real user scenarios don't need to monitor all traffic.
And qemu net-filter also need function to more detailed flow control.
This series give user ability to passthrough kinds of COLO network stream.
For example, windows guest user want to enable windows remote desktop
to touch guest(U
Rename structure with COLO index and move it to .h file,
It make other modules can reuse COLO code.
Signed-off-by: Zhang Chen
---
net/colo-compare.c | 134 +
net/colo-compare.h | 106 +++
2 files changed, 120 insertions(
Add hmp_colo_passthrough_add and hmp_colo_passthrough_del make user
can maintain COLO network passthrough list in human monitor
Signed-off-by: Zhang Chen
---
hmp-commands.hx | 26 ++
include/monitor/hmp.h | 2 ++
monitor/hmp-cmds.c| 82 +
Since the real user scenario does not need COLO to monitor all traffic.
Add colo-passthrough-add and colo-passthrough-del to maintain
a COLO network passthrough list. Add IPFlowSpec struct for all QMP commands.
Except protocol field is necessary, other fields are optional.
Signed-off-by: Zhang Che
Add passthrough list for each CompareState.
Signed-off-by: Zhang Chen
---
net/colo-compare.c | 28
net/colo-compare.h | 12
2 files changed, 40 insertions(+)
diff --git a/net/colo-compare.c b/net/colo-compare.c
index b51b1437ef..7109e2ed30 100644
--- a/
No need to carry the flag all the time in many scenarios.
Signed-off-by: Zhang Chen
---
include/qemu/sockets.h | 1 +
util/qemu-sockets.c| 14 ++
2 files changed, 15 insertions(+)
diff --git a/include/qemu/sockets.h b/include/qemu/sockets.h
index 7d1f813576..d5abc227eb 100644
-
Use connection protocol,src port,dst port,src ip,dst ip as the key
to bypass certain network traffic in COLO compare.
Signed-off-by: Zhang Chen
---
net/net.c | 160 +-
1 file changed, 158 insertions(+), 2 deletions(-)
diff --git a/net/net.c b/
On Tue, 20 Apr 2021 at 16:03, Markus Armbruster wrote:
>
> marcandre.lur...@redhat.com writes:
>
> > From: Marc-André Lureau
> >
> > Commit 54aa3de72 ("qapi: Use QAPI_LIST_PREPEND() where possible")
> > inadvertently removed the has_dependencies from the partition disk
> > info, resulting in empt
Am 20.04.2021 um 16:31 hat Vladimir Sementsov-Ogievskiy geschrieben:
> 15.04.2021 18:22, Kevin Wolf wrote:
> > In order to avoid RMW cycles, is_allocated_sectors() treats zeroed areas
> > like non-zero data if the end of the checked area isn't aligned. This
> > can improve the efficiency of the con
On 4/19/21 6:33 PM, matheus.fe...@eldorado.org.br wrote:
+#include
+#include
+
+int main(void)
+{
Oh, also, there's nothing in here that requires stdio.h.
r~
marcandre.lur...@redhat.com writes:
> From: Marc-André Lureau
>
> Commit 54aa3de72 ("qapi: Use QAPI_LIST_PREPEND() where possible")
> inadvertently removed the has_dependencies from the partition disk
> info, resulting in empty list being returned.
>
> Fixes: https://bugzilla.redhat.com/show_bug.
On 20/04/2021 09:35, Philippe Mathieu-Daudé wrote:
On 4/20/21 2:20 PM, Alex Bennée wrote:
David Gibson writes:
On Mon, Apr 19, 2021 at 10:33:07PM -0300, matheus.fe...@eldorado.org.br wrote:
From: Matheus Ferst
A newer compiler is needed to build tests for Power10 instructions. As
done for a
On 20/04/2021 11:58, Richard Henderson wrote:
On 4/19/21 6:33 PM, matheus.fe...@eldorado.org.br wrote:
+ var = 0xFEDCBA9876543210;
+ asm("brh %0, %0" : "=r"(var));
+ assert(var == 0xDCFE98BA54761032);
Incorrect inline assembly, you are not declaring an input.
Use "+r" for in/out argum
Replaced allocations done using malloc(), calloc(), and realloc()
to their equivalent functions in GLib.
Memory that is allocated locally and freed when the function exits
are annotated g_autofree so that the deallocation is automatically
handled. Subsequently, I could remove a bunch of free() cal
Replaced the allocation and deallocation of fuse_req structs
using calloc()/free() call pairs to a GLib's g_try_new0()
and g_free().
Signed-off-by: Mahmoud Mandour
Reviewed-by: Stefan Hajnoczi
---
tools/virtiofsd/fuse_lowlevel.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff
Replaced the calls to malloc()/calloc() and their respective
calls to free() of iovec structs with GLib's allocation and
deallocation functions.
Also, in one instance, used g_new0() instead of a calloc() call plus
a null-checking assertion.
iovec structs were created locally and freed as the func
Replaced the allocation and deallocation of fuse_session structs
from calloc() and free() calls to g_try_new0() and g_free().
Signed-off-by: Mahmoud Mandour
Reviewed-by: Stefan Hajnoczi
---
tools/virtiofsd/fuse_lowlevel.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a
Replaced (re)allocation of lo_map_elem structs from realloc() to
GLib's g_try_realloc_n() and replaced the respective free() call
with a g_free().
Signed-off-by: Mahmoud Mandour
Reviewed-by: Stefan Hajnoczi
---
tools/virtiofsd/passthrough_ll.c | 4 ++--
1 file changed, 2 insertions(+), 2 deleti
Replaced the allocation of local variables from malloc() to
GLib allocation functions.
In one instance, dropped the usage to an assert after a malloc()
call and used g_malloc() instead.
Signed-off-by: Mahmoud Mandour
Reviewed-by: Stefan Hajnoczi
---
tools/virtiofsd/fuse_virtio.c | 9 -
Changed the allocations of fv_VuDev structs, VuDev structs, and
fv_QueueInfo strcuts from using calloc()/realloc() & free() to using
the equivalent functions from GLib.
In instances, removed the pair of allocation and assertion for
non-NULL checking with a GLib function that aborts on error.
Remo
Changed the allocations of some local variables to GLib's allocation
functions, such as g_try_malloc0(), and annotated those variables
as g_autofree. Subsequently, I was able to remove the calls to free().
Signed-off-by: Mahmoud Mandour
Reviewed-by: Stefan Hajnoczi
---
tools/virtiofsd/passthrou
Hi Philippe,
> The plan is to drop the nanoMIPS disassembler because it is broken
> since more than 2 years and nobody ever cared to fix it after Stefan's
> attempt in Nov 2018:
> https://www.mail-archive.com/qemu-devel@nongnu.org/msg576504.html
> So it is certainly unused. Unused unmaintained cod
** Tags added: block
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/304636
Title:
-hda FAT:. limited to 504MBytes
Status in QEMU:
Confirmed
Status in qemu package in Ubuntu:
Won't Fix
Bug desc
@smoser : fixed-size VHD images don't have a header, and there is AFAIK
currently no way for probing a footer in the QEMU code, so relying on
the extension seems to be the only way right now, as far as I can tell.
--
You received this bug notification because you are a member of qemu-
devel-ml, w
Hello,
Thanks for the patch. Comments below:
On Tue, Apr 20, 2021 at 05:37:36PM +0800, Chenyi Qiang wrote:
> Virtual Machines can exploit bus locks to degrade the performance of
> system. To address this kind of performance DOS attack, bus lock VM exit
> is introduced in KVM and it will report t
Introducing new qapi method 'query-cpu-model-cpuid'. This method can be used to
get virtualized cpu model info generated by QEMU during VM initialization in
the form of cpuid representation.
Diving into more details about virtual cpu generation: QEMU first parses '-cpu'
command line option. From t
Patchew URL:
https://patchew.org/QEMU/20210420161940.24306-1-valeriy.vdo...@virtuozzo.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20210420161940.24306-1-valeriy.vdo...@virtuozzo.com
Subject: [PATCH v6] qapi: in
On 4/20/21 6:06 PM, Aleksandar Rikalo wrote:
> Hi Philippe,
>
>> The plan is to drop the nanoMIPS disassembler because it is broken
>> since more than 2 years and nobody ever cared to fix it after Stefan's
>> attempt in Nov 2018:
>> https://www.mail-archive.com/qemu-devel@nongnu.org/msg576504.html
Changes from v1:
- added more context in the commit message
- added David's R-b
v1 link: https://lists.gnu.org/archive/html/qemu-devel/2021-04/msg03145.html
Hi,
This is the QEMU side of a kernel change being proposed in [1],
where an attempt to implement a CPU hotunplug error report
mechanism wa
At this moment, PAPR does not provide a way to report errors during a
device removal operation. This led the pSeries machine to implement
extra mechanisms to try to fallback and recover from an error that might
have happened during the hotunplug in the guest side. This started to
change a bit with
20.04.2021 18:04, Kevin Wolf wrote:
Am 20.04.2021 um 16:31 hat Vladimir Sementsov-Ogievskiy geschrieben:
15.04.2021 18:22, Kevin Wolf wrote:
In order to avoid RMW cycles, is_allocated_sectors() treats zeroed areas
like non-zero data if the end of the checked area isn't aligned. This
can improve
"Matheus K. Ferst" writes:
> On 20/04/2021 09:20, Alex Bennée wrote:
>> David Gibson writes:
>>
>>> On Mon, Apr 19, 2021 at 10:33:07PM -0300, matheus.fe...@eldorado.org.br
>>> wrote:
From: Matheus Ferst
A newer compiler is needed to build tests for Power10 instructions. As
>>
20.04.2021 19:19, Valeriy Vdovin wrote:
Introducing new qapi method 'query-cpu-model-cpuid'. This method can be used to
get virtualized cpu model info generated by QEMU during VM initialization in
the form of cpuid representation.
[..]
+CpuModelCpuidDescription *qmp_query_cpu_model_cpuid(Err
On Tue, Apr 20, 2021 at 07:19:40PM +0300, Valeriy Vdovin wrote:
[...]
> +##
> +# @query-cpu-model-cpuid:
> +#
> +# Returns description of a virtual CPU model, created by QEMU after cpu
> +# initialization routines. The resulting information is a reflection of a
> parsed
> +# '-cpu' command line op
Hello,
Quick update about this work:
- the hotunplug timeout was reverted in the pSeries machine for 6.0.0.
This means that we have no use for a DEVICE_NOT_DELETED event or similar.
I'll drop it for the next version of the series.
- there is a good chance that the pSeries kernel will introduce
On Mon, Apr 19, 2021 at 09:27:47PM +0200, Klaus Jensen wrote:
> From: Klaus Jensen
>
> This series consists of various clean up patches.
>
> The final patch moves nvme emulation from hw/block to hw/nvme.
Series looks good to me.
Reviewed-by: Keith Busch
my patches went in, ultimately, and my focus was since shifted
elsewhere. I just tried this by *manually* adding some extra data to a
bitmap by hand.
qemu-img create -f qcow2 foo.qcow2 64m
qemu-img bitmap --add foo.qcow2 mybitmap
This creates a bitmap extension header like this (starting at 0x1f
Sorry, that formatted *terribly*... please see the attachment for a raw
text version with arbitrarily long columns that looks nicer. :(
** Attachment added: "Raw text for comment #7 with better formatting (?)"
https://bugs.launchpad.net/qemu/+bug/1808928/+attachment/5490362/+files/bztemp
--
On Thu, Apr 15, 2021 at 08:14:30PM +0100, Dr. David Alan Gilbert wrote:
> * Paolo Bonzini (pbonz...@redhat.com) wrote:
> > On 06/04/21 13:42, Vitaly Kuznetsov wrote:
> > > older machine types are still available (I disable it for <= 5.1 but we
> > > can consider disabling it for 5.2 too). The featu
The CACHEE opcode "requires CP0 privilege".
The pseudocode checks in the ISA manual is:
if is_eva and not C0.Config5.EVA:
raise exception('RI')
if not IsCoprocessor0Enabled():
raise coprocessor_exception(0)
Add the missing checks.
Inspired-by: Richard Henderson
Signed-off-
On 4/17/21 6:52 AM, Markus Armbruster wrote:
John Snow writes:
On 4/16/21 8:44 AM, Markus Armbruster wrote:
John Snow writes:
It will be an eventual thing, though: I think we need to agree on a
style guide document and in that same series, fix up the instances of
defying that guide. I thin
101 - 200 of 276 matches
Mail list logo
