On 3/28/21 7:21 PM, Richard Henderson wrote:
> On 3/26/21 1:36 PM, Claudio Fontana wrote:
>> test is TCG-only.
>>
>> Signed-off-by: Claudio Fontana
>> Cc: Philippe Mathieu-Daudé
>> ---
>> tests/qtest/bios-tables-test.c | 7 +++
>> 1 file changed, 7 insertions(+)
>>
>> diff --git a/tests/qt
On 3/26/21 8:48 PM, Klaus Heinrich Kiwi wrote:
>
>>
>> static const struct masks ast2600_masks = {
>> - .src = 0x7fff,
>> - .dest = 0x7ff8,
>> - .len = 0x0fff,
>> + .src = 0x7fff,
>> + .dest = 0x7ff8,
>> + .len = 0x0fff,
>> };
On Mon, Mar 29, 2021 at 11:48 AM Dylan Jhong wrote:
>
> Use target_ulong to instead of uint64_t on reset vector address
> to adapt on both 32/64 machine.
>
> Signed-off-by: Dylan Jhong
> Signed-off-by: Ruinland ChuanTzu Tsai
> ---
> target/riscv/cpu.c | 2 +-
> 1 file changed, 1 insertion(+), 1
Fixed-size VHD images don't have a header, only a footer. To be able
to still detect them right, support probing via the file name, too.
Without this change, images get detected as raw:
$ qemu-img create -f vpc -o subformat=fixed test.vhd 2G
Formatting 'test.vhd', fmt=vpc size=2147483648 subforma
This patch handles icount mode for timer read/write instructions,
because it is required to call gen_io_start in such cases.
Signed-off-by: Pavel Dovgalyuk
Reviewed-by: Richard Henderson
---
target/alpha/translate.c |9 +++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a
This patch adds icount handling to mfspr/mtspr instructions
that may deal with hardware timers.
Signed-off-by: Pavel Dovgalyuk
---
target/openrisc/translate.c | 15 +++
1 file changed, 15 insertions(+)
diff --git a/target/openrisc/translate.c b/target/openrisc/translate.c
index c6
This patch adds ioeventfd flag for virtio-mmio configuration.
It allows switching ioeventfd on and off.
Signed-off-by: Pavel Dovgalyuk
---
hw/virtio/virtio-mmio.c | 11 ++-
include/hw/virtio/virtio-mmio.h |5 +
2 files changed, 15 insertions(+), 1 deletion(-)
diff --gi
This patch enables vCPU notification to wake it up
when new async event comes in replay mode.
The motivation of this patch is the following.
Consider recorded block async event. It is saved into the log
with one of the checkpoints. This checkpoint may be passed in
vCPU loop. In replay mode when th
Record/replay uses checkpoints to synchronize the execution
of the threads and timers. Hardware events such as BH are
processed at the checkpoints too.
Event processing can cause refreshing the virtual timers
and calling the icount-related functions, that also use checkpoints.
This patch prevents r
In record/replay mode waiting for vCPU to execute
the task scheduled by run_on_cpu may lead to deadlock,
because when run_on_cpu is executed in main_loop
(e.g., in loadvm processing) it holds replay mutex.
This patch allows running scheduled task in iothread
when it holds the replay mutex.
Signed-
Regular virtual timers are used to emulate timings
related to vCPU and peripheral states. QCOW2 uses timers
to clean the cache. These timers should have external
flag. In the opposite case they affect the execution
and it can't be recorded and replayed.
This patch adds external flag to the timer fo
On 3/26/21 8:37 PM, Klaus Heinrich Kiwi wrote:
> Complement the Aspeed HACE support with Scatter-Gather hash support for
> sha256 and sha512. Scatter-Gather is only supported on AST2600-series.
...
> static uint64_t aspeed_hace_read(void *opaque, hwaddr addr, unsigned int
> size)
> {
> @@ -187
Ping
On 17.03.2021 19:32, Andrey Gruzdev wrote:
This series is a kind of PoC for asynchronous snapshot reverting. This is
about external snapshots only and doesn't involve block devices. Thus, it's
mainly intended to be used with the new 'background-snapshot' migration
capability and otherwise
I also have this problem. On both QEMU 5.2.0 and QEMU 3.1. The situation is
still the same as the original report.
For Solaris 8 the following configuration causes an error when the installer
attempts to boot:
-m 256M -display gtk -monitor stdio -hda Sol8.qcow2 -cdrom sol8_x86_install.ISO
-boot
Respected Organizer
I'm Swetha Vipparla, a computer science student of International Institute of
Information Technology, Hyderabad, India (IIIT H). I am currently studying in
my first year.
I would like to interact with a mentor in relation to my open-source proposals
submitted for GSOC 2021
Le 28/03/2021 à 20:01, Frédéric Fortier via a écrit :
> getsockopt(fd, SOL_NETLINK, NETLINK_LIST_MEMBERSHIPS, *optval, *optlen)
> syscall allows optval to be NULL/invalid if optlen points to a size of
> zero. This allows userspace to query the length of the array they should
> use to get the full m
On 29/03/2021 06.27, Swetha Vipparla wrote:
Respected Organizer
I'm Swetha Vipparla, a computer science student of International Institute
of Information Technology, Hyderabad, India (IIIT H). I am currently
studying in my first year.
I would like to interact with a mentor in relation to my
On Fri, Mar 26, 2021 at 08:30:00PM +0300, Valeriy Vdovin wrote:
> Other than debug, the method is useful in cases when we would like to
> utilize QEMU's virtual cpu initialization routines and put the retrieved
> values into kernel CPUID overriding mechanics for more precise control
> over how vari
On Fri, Mar 26, 2021 at 01:47:00PM +0100, Gerd Hoffmann wrote:
> Hi,
>
> > eg a trace point "dma_map_wait" gets mapped to probes in many
> > .stp files, once per target, because we need to match based on
> > the executable path:
> >
> > probe qemu.system.x86_64.dma_map_wait =
> > process("/u
On 3/24/21 8:37 AM, David Gibson wrote:
On Tue, Mar 23, 2021 at 09:47:38AM -0400, Shivaprasad G Bhat wrote:
machine vmstate.
Signed-off-by: Shivaprasad G Bhat
An overal question: surely the same issue must arise on x86 with
file-backed NVDIMMs. How do they handle this case?
Discussed in ot
On 29/03/21 07:35, David Gibson wrote:
regarding unplug - on device_del QEMU raises SCI interrupt, after this the
process is
asynchronous. When ACPI interpreter gets SCI it sends a respective _EJ0 event
to
devices mentioned in PCI_DOWN_BASE register. After getting the event, guest
OS may
On 29/03/21 10:05, Pavel Dovgalyuk wrote:
@@ -136,7 +137,13 @@ void do_run_on_cpu(CPUState *cpu, run_on_cpu_func func,
run_on_cpu_data data,
{
struct qemu_work_item wi;
-if (qemu_cpu_is_self(cpu)) {
+if (qemu_cpu_is_self(cpu)
+/*
+ * vCPU thread is waiting whe
On 29/03/21 09:59, Pavel Dovgalyuk wrote:
Record/replay uses checkpoints to synchronize the execution
of the threads and timers. Hardware events such as BH are
processed at the checkpoints too.
Event processing can cause refreshing the virtual timers
and calling the icount-related functions, that
On 29/03/21 10:06, Pavel Dovgalyuk wrote:
Regular virtual timers are used to emulate timings
related to vCPU and peripheral states. QCOW2 uses timers
to clean the cache. These timers should have external
flag. In the opposite case they affect the execution
and it can't be recorded and replayed.
T
On 28/03/21 07:47, Thomas Huth wrote:
This reverts commit 6d9abb6de9cc53a508823db0283061824f2f98a2.
The real code change had already been added by Kevin's commit da0a932bbf
("hmp: QAPIfy object_add") and commit 6d9abb6d just added a duplicated
include statement as a left-over of a rebase.
Signe
On Mon, Mar 29, 2021 at 10:23:42AM +0100, Daniel P. Berrangé wrote:
> On Fri, Mar 26, 2021 at 01:47:00PM +0100, Gerd Hoffmann wrote:
> > Hi,
> >
> > > eg a trace point "dma_map_wait" gets mapped to probes in many
> > > .stp files, once per target, because we need to match based on
> > > the exec
On 3/26/21 3:48 PM, Markus Armbruster wrote:
Wolfgang Bumiller writes:
On Thu, Mar 18, 2021 at 02:35:50PM +0100, Stefan Reiter wrote:
If OOB is disabled, events received in monitor_qmp_event will be handled
in the main context. Thus, we must not acquire a qmp_queue_lock there,
as the dispatch
On Mon, Mar 29, 2021 at 11:48:18AM +0200, Gerd Hoffmann wrote:
> On Mon, Mar 29, 2021 at 10:23:42AM +0100, Daniel P. Berrangé wrote:
> > On Fri, Mar 26, 2021 at 01:47:00PM +0100, Gerd Hoffmann wrote:
> > > Hi,
> > >
> > > > eg a trace point "dma_map_wait" gets mapped to probes in many
> > > > .s
This patch moves static last_delta variable into timers_state
structure to allow correct vmstate operations with icount shift=auto enabled.
Signed-off-by: Pavel Dovgalyuk
---
softmmu/cpu-timers.c |5 +++--
softmmu/icount.c |9 +++--
softmmu/timers-state.h |2 ++
3 files c
On 29/03/21 12:22, Pavel Dovgalyuk wrote:
This patch moves static last_delta variable into timers_state
structure to allow correct vmstate operations with icount shift=auto enabled.
Signed-off-by: Pavel Dovgalyuk
---
softmmu/cpu-timers.c |5 +++--
softmmu/icount.c |9 +++-
On 29/03/21 09:43, Pavel Dovgalyuk wrote:
This patch enables vCPU notification to wake it up
when new async event comes in replay mode.
The motivation of this patch is the following.
Consider recorded block async event. It is saved into the log
with one of the checkpoints. This checkpoint may be
On 29.03.2021 12:42, Paolo Bonzini wrote:
On 29/03/21 10:05, Pavel Dovgalyuk wrote:
@@ -136,7 +137,13 @@ void do_run_on_cpu(CPUState *cpu, run_on_cpu_func
func, run_on_cpu_data data,
{
struct qemu_work_item wi;
- if (qemu_cpu_is_self(cpu)) {
+ if (qemu_cpu_is_self(cpu)
+ /*
Hi,
The following are broadly just expanding our testing on arm64 systems
which I think is permissible on later release candidates but it's not a
major problem if they slip into the next release.
The latest arm64 CI box has access to a fair few cross compilers for
other arches thanks to Ubuntu an
While docker is nominally multarch these days it doesn't mean our
distros actually package all cross compilers for all architectures.
The upcoming Debian bullseye release will improve things further. At
least for now we can get things like the 32 bit ARM compiler on it's
64 bit cousin.
Signed-off-
Currently our gitlab registry is x86_64 only so attempting to pull an
image from it on something else will end in tears.
Signed-off-by: Alex Bennée
---
tests/docker/Makefile.include | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/tests/docker/Makefile.include b/tests/dock
Newer compilers might end up putting some data in .data.rel.local
which was getting skipped resulting in hilarious confusion on some
tests. Fix that.
Signed-off-by: Alex Bennée
---
tests/tcg/i386/system/kernel.ld | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/tcg/i386/
You don't usually notice this is broken on developer system on x86 as
we use the normal host compiler. However on other systems the -pc was
extraneous. Also for 32 bit only i686 packages exist now so we should
use those when available.
Signed-off-by: Alex Bennée
---
tests/tcg/configure.sh | 4 ++
While it's hard to find cross compilers packaged for arches other than
x86_64 the same cannot be said for the x86_64 compiler which is
available on Debians i386, arm64 and ppc64el release architectures.
Signed-off-by: Alex Bennée
---
tests/tcg/configure.sh | 5 +
1 file changed, 5 insertions
Newer compilers complain about non-matching constraints:
test-i386.c:1393:5: error: asm operand 2 probably doesn’t match constraints
[-Werror]
1393 | asm volatile ("lcall %1, %2"
| ^~~
It seems the plain "i" immediate constraint is a little too lax here.
What we are actually
Patchew URL:
https://patchew.org/QEMU/20210329110303.15235-1-alex.ben...@linaro.org/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20210329110303.15235-1-alex.ben...@linaro.org
Subject: [PATCH for 6.0-rc2? v1 0/6] che
On Sun, 28 Mar 2021 at 17:09, Laurent Vivier wrote:
>
> The following changes since commit 9e2e9fe3df9f539f8b6941ceb96d25355fdae47e:
>
> Update version for v6.0.0-rc0 release (2021-03-24 19:50:49 +)
>
> are available in the Git repository at:
>
> git://github.com/vivier/qemu.git tags/linux
On 29.03.2021 13:29, Paolo Bonzini wrote:
On 29/03/21 09:43, Pavel Dovgalyuk wrote:
This patch enables vCPU notification to wake it up
when new async event comes in replay mode.
The motivation of this patch is the following.
Consider recorded block async event. It is saved into the log
with one
* Rao, Lei (lei@intel.com) wrote:
>
> -Original Message-
> From: Dr. David Alan Gilbert
> Sent: Friday, March 26, 2021 2:08 AM
> To: Rao, Lei
> Cc: Zhang, Chen ; lizhij...@cn.fujitsu.com;
> jasow...@redhat.com; quint...@redhat.com; pbonz...@redhat.com;
> lukasstra...@web.de; qemu-
On 29/03/2021 13.02, Alex Bennée wrote:
Currently our gitlab registry is x86_64 only so attempting to pull an
image from it on something else will end in tears.
Signed-off-by: Alex Bennée
---
tests/docker/Makefile.include | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git
On Mon, Mar 29, 2021 at 10:20:54AM +0100, Daniel P. Berrang?? wrote:
> On Fri, Mar 26, 2021 at 08:30:00PM +0300, Valeriy Vdovin wrote:
> > Other than debug, the method is useful in cases when we would like to
> > utilize QEMU's virtual cpu initialization routines and put the retrieved
> > values in
On 29/03/2021 13.03, Alex Bennée wrote:
Newer compilers might end up putting some data in .data.rel.local
which was getting skipped resulting in hilarious confusion on some
tests. Fix that.
Signed-off-by: Alex Bennée
---
tests/tcg/i386/system/kernel.ld | 2 +-
1 file changed, 1 insertion(+),
Pavel Dovgalyuk writes:
> Record/replay uses checkpoints to synchronize the execution
> of the threads and timers. Hardware events such as BH are
> processed at the checkpoints too.
> Event processing can cause refreshing the virtual timers
> and calling the icount-related functions, that also
On Mon, Mar 29, 2021 at 02:21:53PM +0300, Valeriy Vdovin wrote:
> On Mon, Mar 29, 2021 at 10:20:54AM +0100, Daniel P. Berrang?? wrote:
> > On Fri, Mar 26, 2021 at 08:30:00PM +0300, Valeriy Vdovin wrote:
> > > Other than debug, the method is useful in cases when we would like to
> > > utilize QEMU's
On Mon, Mar 22, 2021 at 01:09:43PM +0100, Klaus Jensen wrote:
From: Klaus Jensen
If nvme_map_dptr() fails, nvme_dif_rw() will leak the bounce context.
Fix this by using the same error handling as everywhere else in the
function.
Reported-by: Coverity (CID 1451080)
Fixes: 146f720c5563 ("hw/bloc
* leirao (lei@intel.com) wrote:
> From: "Rao, Lei"
>
> When flushing memory from ram cache to ram during every checkpoint
> on secondary VM, we can copy continuous chunks of memory instead of
> 4096 bytes per time to reduce the time of VM stop during checkpoint.
>
> Signed-off-by: Lei Rao
On 29/03/21 13:23, Pavel Dovgalyuk wrote:
I still do not understand why the qemu_clock_notify function is used
to notify the CPU. It would be nice to have a description of the call
chain in a comment or to have a more appropriate API. I can queue the
patch since it's deep in replay-events.c
On 29/03/21 12:55, Pavel Dovgalyuk wrote:
Is the "or" saying that the execution is using the lockstep mode? If
so, can you put it in a separate function so that it's more
self-explanatory and check if it should be used elsewhere?
It was replay (is that lockstep that you mentioned?).
Loc
Implement an IPMI BT interface model using a chardev backend to
communicate with an external PowerNV machine. It uses the OpenIPMI
simulator protocol for virtual machines described in :
https://github.com/cminyard/openipmi/blob/master/lanserv/README.vm
and implemented by the 'ipmi-bmc-extern'
* Vitaly Kuznetsov (vkuzn...@redhat.com) wrote:
> KVM doesn't fully support Hyper-V reenlightenment notifications on
> migration. In particular, it doesn't support emulating TSC frequency
> of the source host by trapping all TSC accesses so unless TSC scaling
> is supported on the destination host
When assign EHCI device to the virtual machine,
after initializing EHCI in seabios,it will continuously
send dma cycles.
Flatview_simplify() will merge a very large range.The IOVA
mappings of the EHCI device will be innocently unmapped
between the delete and add phases of the VFIO MemoryListener.
A
Flatview_simplify() can merge many small memory ranges
into a large one and contains EHCI dma buffers.
For example,the merged range maybe0xc-0xbfff.
When seabios write PAM register to change the properties
of part of the merged range from RW to readonly,
this action cause the merged IOVA ma
"Dr. David Alan Gilbert" writes:
> * Vitaly Kuznetsov (vkuzn...@redhat.com) wrote:
>> KVM doesn't fully support Hyper-V reenlightenment notifications on
>> migration. In particular, it doesn't support emulating TSC frequency
>> of the source host by trapping all TSC accesses so unless TSC scaling
On 17.03.21 17:02, Vladimir Sementsov-Ogievskiy wrote:
Just demonstrate one of x-blockdev-reopen usecases. We can't simply
remove persistent bitmap from RO node (for example from backing file),
as we need to remove it from the image too. So, we should reopen the
node first.
Signed-off-by: Vladim
29.03.2021 14:48, Daniel P. Berrangé wrote:
On Mon, Mar 29, 2021 at 02:21:53PM +0300, Valeriy Vdovin wrote:
On Mon, Mar 29, 2021 at 10:20:54AM +0100, Daniel P. Berrang?? wrote:
On Fri, Mar 26, 2021 at 08:30:00PM +0300, Valeriy Vdovin wrote:
Other than debug, the method is useful in cases when
On Wed, 24 Mar 2021 11:03:02 +1100
David Gibson wrote:
> On Tue, Mar 23, 2021 at 12:43:32PM -0600, Richard Henderson wrote:
> > Copying flags directly from msr has drawbacks: (1) msr bits
> > mean different things per cpu, (2) msr has 64 bits on 64 cpus
> > while tb->flags has only 32 bits.
> >
On Mon, Mar 22, 2021 at 01:09:44PM +0100, Klaus Jensen wrote:
From: Klaus Jensen
Max noticed that since blk_aio_pwrite_zeroes() may invoke the callback
before returning, the callbacks will never see *count == 0 and thus
never free the count variable or decrement num_formats causing a CQE to
nev
pylint complains that discards1_sha256 and all_discards_sha256 are first
set in non-__init__ methods. Let's make it happy.
Signed-off-by: Max Reitz
---
tests/qemu-iotests/tests/migrate-bitmaps-postcopy-test | 3 +++
1 file changed, 3 insertions(+)
diff --git a/tests/qemu-iotests/tests/migrate-
There are a couple of things pylint takes issue with:
- The "time" import is unused
- The import order (iotests should come last)
- get_bitmap_hash() doesn't use @self and so should be a function
- Semicolons at the end of some lines
- Parentheses after "if"
- Some lines are too long (80 characters
297 so far does not check the named tests, which reside in the tests/
directory (i.e. full path tests/qemu-iotests/tests). Fix it.
Thanks to the previous two commits, all named tests pass its scrutiny,
so we do not have to add anything to SKIP_FILES.
Signed-off-by: Max Reitz
---
tests/qemu-iot
169 and 199 have been renamed and moved to tests/ (commit a44be0334be:
"iotests: rename and move 169 and 199 tests"), so we can drop them from
the skip list.
Signed-off-by: Max Reitz
---
tests/qemu-iotests/297 | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/qemu-iotests
29.03.2021 15:56, Max Reitz wrote:
On 17.03.21 17:02, Vladimir Sementsov-Ogievskiy wrote:
Just demonstrate one of x-blockdev-reopen usecases. We can't simply
remove persistent bitmap from RO node (for example from backing file),
as we need to remove it from the image too. So, we should reopen th
Hi,
When reviewing Vladimir’s new addition to tests/, I noticed that 297 so
far does not cover named tests. That isn’t so good.
This series makes it cover them, and because tests/ is rather sparse at
this point, I decided to also fix up the two tests in there that don’t
pass pylint’s scrutiny ye
Hi David,
@@ -241,6 +241,31 @@ static void spapr_dt_pa_features(SpaprMachineState *spapr,
/* 60: NM atomic, 62: RNG */
0x80, 0x00, 0x80, 0x00, 0x00, 0x00, /* 60 - 65 */
};
+uint8_t pa_features_310[] = { 66, 0,
+/* 0: MMU|FPU|SLB|RUN|DABR|NX, 1: fri[nzpm]|DAB
ping!
On 25.03.2021 18:12, Denis Plotnikov wrote:
v3:
* 0003: a new patch added fixing the problem on vm shutdown
I stumbled on this bug after v2 sending.
* 0001: gramma fixing (Raphael)
* 0002: commit message fixing (Raphael)
v2:
* split the initial patch into two (Raphael)
On Sun, 28 Mar 2021 at 19:45, wrote:
>
> From: Marc-André Lureau
>
> The following changes since commit 7b9a3c9f94bcac23c534bc9f42a9e914b433b299:
>
> Merge remote-tracking branch
> 'remotes/kraxel/tags/fixes-20210326-pull-request' into staging (2021-03-26
> 12:58:58 +)
>
> are available i
On 3/29/21 1:02 AM, Claudio Fontana wrote:
On 3/28/21 7:21 PM, Richard Henderson wrote:
On 3/26/21 1:36 PM, Claudio Fontana wrote:
test is TCG-only.
Signed-off-by: Claudio Fontana
Cc: Philippe Mathieu-Daudé
---
tests/qtest/bios-tables-test.c | 7 +++
1 file changed, 7 insertions(+)
On Fri, Mar 19, 2021 at 12:27:10PM -0300, Wainer dos Santos Moschetta wrote:
> Hi,
>
> On 3/19/21 8:34 AM, Philippe Mathieu-Daudé wrote:
> > On 3/19/21 11:59 AM, Paolo Bonzini wrote:
> > > On 19/03/21 11:18, Andrew Jones wrote:
> > > > > Yikes, that is 41 hours per CI run. I wonder if GitLab's CI
Hi
On Mon, Mar 29, 2021 at 5:54 PM Peter Maydell
wrote:
> On Sun, 28 Mar 2021 at 19:45, wrote:
> >
> > From: Marc-André Lureau
> >
> > The following changes since commit
> 7b9a3c9f94bcac23c534bc9f42a9e914b433b299:
> >
> > Merge remote-tracking branch
> 'remotes/kraxel/tags/fixes-20210326-pul
On Mon, Mar 29, 2021 at 8:03 AM Alex Bennée wrote:
>
> Currently our gitlab registry is x86_64 only so attempting to pull an
> image from it on something else will end in tears.
>
> Signed-off-by: Alex Bennée
> ---
> tests/docker/Makefile.include | 5 -
> 1 file changed, 4 insertions(+), 1 d
On Thu, 25 Mar 2021 09:55:09 -0400
Matthew Rosato wrote:
> S390 PCI currently has no backup, add one. Add an additional backup
> for vfio-ccw and refresh the backup for vfio-ap.
>
> Signed-off-by: Matthew Rosato
> ---
> MAINTAINERS | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
* Igor Mammedov (imamm...@redhat.com) wrote:
> On Tue, 23 Mar 2021 17:40:36 +
> Daniel P. Berrangé wrote:
>
> > On Tue, Mar 23, 2021 at 05:54:47PM +0100, Igor Mammedov wrote:
> > > Let me hijack this thread for beyond this case scope.
> > >
> > > I agree that for this particular bug we've do
* Vitaly Kuznetsov (vkuzn...@redhat.com) wrote:
> "Dr. David Alan Gilbert" writes:
>
> > * Vitaly Kuznetsov (vkuzn...@redhat.com) wrote:
> >> KVM doesn't fully support Hyper-V reenlightenment notifications on
> >> migration. In particular, it doesn't support emulating TSC frequency
> >> of the so
No changes to the text, just plain rst-ification of the original
source text. Notably:
- fixed up indentation of bullet points
- proper :: escapes for code samples
- added titles to paper links
- moved events into a table
Signed-off-by: Alex Bennée
---
docs/devel/index.rst
In qemu_rbd_connect(), 'mon_host' is allocated by qemu_rbd_mon_host()
using g_strjoinv(), but it's only freed in the error path, leaking
memory in the success path as reported by valgrind:
80 bytes in 4 blocks are definitely lost in loss record 5,028 of 6,516
at 0x4839809: malloc (vg_replac
This series fixes two memory leaks, found through valgrind, in the
rbd driver.
Stefano Garzarella (2):
block/rbd: fix memory leak in qemu_rbd_connect()
block/rbd: fix memory leak in qemu_rbd_co_create_opts()
block/rbd.c | 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)
--
2.
When we allocate 'q_namespace', we forgot to set 'has_q_namespace'
to true. This can cause several issues, including a memory leak,
since qapi_free_BlockdevCreateOptions() does not deallocate that
memory, as reported by valgrind:
13 bytes in 1 blocks are definitely lost in loss record 7 of 96
Patchew URL:
https://patchew.org/QEMU/20210329145947.14280-1-alex.ben...@linaro.org/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20210329145947.14280-1-alex.ben...@linaro.org
Subject: [RFC PATCH] docs: rst-ify the r
Viresh Kumar writes:
> This creates the QEMU side of the vhost-user-i2c device which connects
> to the remote daemon. It is based of vhost-user-fs code.
>
> Signed-off-by: Viresh Kumar
> ---
> hw/virtio/Kconfig | 5 +
> hw/virtio/meson.build |
Viresh Kumar writes:
> This allows is to instantiate a vhost-user-i2c device as part of a PCI
> bus. It is mostly boilerplate which looks pretty similar to the
> vhost-user-fs-pci device.
>
> Signed-off-by: Viresh Kumar
> ---
> hw/virtio/meson.build | 1 +
> hw/virtio/vhost-user-i2c
On 3/29/21 6:20 AM, David Gibson wrote:
> On Thu, Mar 25, 2021 at 09:56:04AM +0100, Cédric Le Goater wrote:
>> On 3/25/21 3:10 AM, David Gibson wrote:
>>> On Tue, Mar 23, 2021 at 02:21:33PM -0300, Daniel Henrique Barboza wrote:
On 3/22/21 10:03 PM, David Gibson wrote:
> On Fri, M
On Thu, Mar 25, 2021 at 11:38:52AM -0400, Vivek Goyal wrote:
> When posix access acls are set on a file, it can lead to adjusting file
> permissions (mode) as well. If caller does not have CAP_FSETID and it
> also does not have membership of owner group, this will lead to clearing
> SGID bit in mod
On Mon, Mar 29, 2021 at 10:28 AM Max Reitz wrote:
>
> 169 and 199 have been renamed and moved to tests/ (commit a44be0334be:
> "iotests: rename and move 169 and 199 tests"), so we can drop them from
> the skip list.
>
> Signed-off-by: Max Reitz
> ---
> tests/qemu-iotests/297 | 2 +-
> 1 file cha
On Mon, Mar 29, 2021 at 10:28 AM Max Reitz wrote:
>
> pylint complains that discards1_sha256 and all_discards_sha256 are first
> set in non-__init__ methods. Let's make it happy.
>
> Signed-off-by: Max Reitz
> ---
> tests/qemu-iotests/tests/migrate-bitmaps-postcopy-test | 3 +++
> 1 file change
On Mon, Mar 29, 2021 at 10:28 AM Max Reitz wrote:
>
> There are a couple of things pylint takes issue with:
> - The "time" import is unused
> - The import order (iotests should come last)
> - get_bitmap_hash() doesn't use @self and so should be a function
> - Semicolons at the end of some lines
>
On Mon, Mar 29, 2021 at 10:28 AM Max Reitz wrote:
>
> 297 so far does not check the named tests, which reside in the tests/
> directory (i.e. full path tests/qemu-iotests/tests). Fix it.
>
> Thanks to the previous two commits, all named tests pass its scrutiny,
> so we do not have to add anything
On 26/03/2021 18:56, Catalin Marinas wrote:
Hi Steven,
On Fri, Mar 12, 2021 at 03:18:57PM +, Steven Price wrote:
A KVM guest could store tags in a page even if the VMM hasn't mapped
the page with PROT_MTE. So when restoring pages from swap we will
need to check to see if there are any saved
On Mon, 29 Mar 2021 at 15:17, Marc-André Lureau
wrote:
>
> Hi
>
> On Mon, Mar 29, 2021 at 5:54 PM Peter Maydell
> wrote:
>>
>> This produces a backtrace from sphinx-build which nonetheless doesn't
>> cause a build failure:
>>
>>
>> Program sphinx-build found: YES
>> ../docs/meson.build:30: WARNI
On 29.03.21 10:06, Pavel Dovgalyuk wrote:
Regular virtual timers are used to emulate timings
related to vCPU and peripheral states. QCOW2 uses timers
to clean the cache. These timers should have external
flag. In the opposite case they affect the execution
and it can't be recorded and replayed.
T
On 18.09.20 17:33, Max Reitz wrote:
For its concurrent requests, 046 has always filtered the offset,
probably because concurrent requests may settle in any order. However,
it did not filter the request length, and so if requests with different
lengths settle in an unexpected order (notably the l
On 28/03/2021 13:21, Catalin Marinas wrote:
On Sat, Mar 27, 2021 at 03:23:24PM +, Catalin Marinas wrote:
On Fri, Mar 12, 2021 at 03:18:58PM +, Steven Price wrote:
diff --git a/arch/arm64/kvm/mmu.c b/arch/arm64/kvm/mmu.c
index 77cb2d28f2a4..b31b7a821f90 100644
--- a/arch/arm64/kvm/mmu.c
On 11.02.21 18:22, Max Reitz wrote:
Hi,
[...]
(Speaking of “unless the WRITE permission is shared”: mirror_top is a
bit broken in that it takes no permissions (but WRITE if necessary) and
shares everything. That seems wrong. Patch 1 addresses that, so that
patch 2 can actually do something
On 3/29/21 7:05 AM, Greg Kurz wrote:
On Wed, 24 Mar 2021 11:03:02 +1100
David Gibson wrote:
On Tue, Mar 23, 2021 at 12:43:32PM -0600, Richard Henderson wrote:
Copying flags directly from msr has drawbacks: (1) msr bits
mean different things per cpu, (2) msr has 64 bits on 64 cpus
while tb->fl
On Mon, 29 Mar 2021 18:16:59 +0400
Marc-André Lureau wrote:
> Hi
>
> On Mon, Mar 29, 2021 at 5:54 PM Peter Maydell
> wrote:
> > [...]
> >
> > I dunno if we can get the error message neater (I know sphinx-build,
> > especially older versions, is a bit unhelpful about what it lets us
> > report.)
On 17.02.21 12:58, Max Reitz wrote:
Implementing FUSE exports required no changes to the storage daemon, so
we forgot to document them there. Considering that both NBD and
vhost-user-blk exports are documented in its man page (and NBD exports
in its --help text), we should probably do the same f
Hi
On Mon, Mar 29, 2021 at 7:56 PM Peter Maydell
wrote:
> On Mon, 29 Mar 2021 at 15:17, Marc-André Lureau
> wrote:
> >
> > Hi
> >
> > On Mon, Mar 29, 2021 at 5:54 PM Peter Maydell
> wrote:
> >>
> >> This produces a backtrace from sphinx-build which nonetheless doesn't
> >> cause a build failur
1 - 100 of 164 matches
Mail list logo
