On 11.02.21 18:22, Max Reitz wrote:
Hi,
[...]
(Speaking of “unless the WRITE permission is shared”: mirror_top is a
bit broken in that it takes no permissions (but WRITE if necessary) and
shares everything. That seems wrong. Patch 1 addresses that, so that
patch 2 can actually do something when mirroring an image.)
I plan to send a v2 of patch 2 at some point, but for now I’ve applied
patch 1 to my block branch:
https://git.xanclic.moe/XanClic/qemu/commits/branch/block
https://bugzilla.redhat.com/show_bug.cgi?id=1940118 reports an abort,
which I think can be avoided with patch 1 of this series: The mirror job
lifts all permissions on the source node, so you can freely take locks
with some other process, and then mirror_exit_common() fails when it
tries to take those permissions back (at least when cancelling the job).
I plan to send an iotest for this, but getting this into rc1 is more
important than waiting for the test, I think.
Max
