Re: [PATCH] virtio-rng: return available data with O_NONBLOCK

2020-07-15 Thread Martin Wilck
On Wed, 2020-07-15 at 00:00 +0200, mwi...@suse.com wrote: > From: Martin Wilck > > If a program opens /dev/hwrng with O_NONBLOCK and uses poll() and > non-blocking read() to retrieve random data, it ends up in a tight > loop with poll() always returning POLLIN and read() returning EAGAIN. > This

Re: [PULL 0/4] qemu-ga patch queue for hard-freeze

2020-07-15 Thread Peter Maydell
On Tue, 14 Jul 2020 at 05:51, Michael Roth wrote: > > The following changes since commit 20c1df5476e1e9b5d3f5b94f9f3ce01d21f14c46: > > Merge remote-tracking branch > 'remotes/kraxel/tags/fixes-20200713-pull-request' into staging (2020-07-13 > 16:58:44 +0100) > > are available in the Git reposi

Re: [Qemu-devel][PATCH v5 1/4] x86/cpu: Add CET CPUID/XSAVES flags and data structures

2020-07-15 Thread Xiaoyao Li
On 5/10/2020 9:42 AM, Yang Weijiang wrote: CET feature SHSTK and IBT are enumerated via CPUID(EAX=0x7,0):ECX[bit 7] and EDX[bit 20] respectively. Two CET bits (bit 11 and 12) are defined in MSR_IA32_XSS to support XSAVES/XRSTORS. CPUID(EAX=0xd, 1):ECX[bit 11] and ECX[bit 12] correspond to CET sta

Re: [PATCH v5 02/11] hw/misc: Add NPCM7xx Clock Controller device model

2020-07-15 Thread Philippe Mathieu-Daudé
On 7/9/20 2:35 AM, Havard Skinnemoen wrote: > Enough functionality to boot the Linux kernel has been implemented. This > includes: > > - Correct power-on reset values so the various clock rates can be > accurately calculated. > - Clock enables stick around when written. > > In addition, a

Re: [Qemu-devel][PATCH v5 2/4] x86/cpuid: Add XSAVES feature words and CET related state bits

2020-07-15 Thread Xiaoyao Li
On 5/10/2020 9:42 AM, Yang Weijiang wrote: CET SHSTK/IBT MSRs can be saved/restored with XSAVES/XRSTORS, but currently the related feature words are not supported, so add the new entries. XSAVES/RSTORS always use compacted storage format, which means the supervisor states' offsets are always 0, i

Re: [PATCH v5 03/11] hw/timer: Add NPCM7xx Timer device model

2020-07-15 Thread Philippe Mathieu-Daudé
On 7/9/20 2:36 AM, Havard Skinnemoen wrote: > The NPCM730 and NPCM750 SoCs have three timer modules each holding five > timers and some shared registers (e.g. interrupt status). > > Each timer runs at 25 MHz divided by a prescaler, and counts down from a > configurable initial value to zero. When

Re: [PATCH] util: qemu_get_thread_id for OpenBSD

2020-07-15 Thread Brad Smith
On 7/15/2020 12:54 AM, Thomas Huth wrote: On 14/07/2020 23.26, David CARLIER wrote: From 9c7f54c67d40fae0174ba795fbaad829cd59c264 Mon Sep 17 00:00:00 2001 From: David Carlier Date: Tue, 14 Jul 2020 23:23:55 +0100 Subject: [PATCH] util: qemu_get_thread_id implementation for OpenBSD. ussage of

Re: [PATCH v5 10/11] hw/arm: Wire up BMC boot flash for npcm750-evb and quanta-gsj

2020-07-15 Thread Cédric Le Goater
On 7/14/20 4:56 AM, Havard Skinnemoen wrote: > On Mon, Jul 13, 2020 at 7:57 AM Cédric Le Goater wrote: >> >> On 7/9/20 2:36 AM, Havard Skinnemoen wrote: >>> This allows these NPCM7xx-based boards to boot from a flash image, e.g. >>> one built with OpenBMC. For example like this: >>> >>> IMAGE=${OP

Re: [PATCH] .travis.yml: skip ppc64abi32-linux-user with plugins

2020-07-15 Thread Alex Bennée
David Gibson writes: > On Tue, Jul 14, 2020 at 06:55:16PM +0100, Alex Bennée wrote: >> We actually see failures on threadcount running without plugins: >> >> retry.py -n 1000 -c -- \ >> ./ppc64abi32-linux-user/qemu-ppc64abi32 \ >> ./tests/tcg/ppc64abi32-linux-user/threadcount >> >>

Re: [PULL 0/9] final misc fixes for 5.1-rc0

2020-07-15 Thread Peter Maydell
On Tue, 14 Jul 2020 at 10:52, Alex Bennée wrote: > > The following changes since commit 20c1df5476e1e9b5d3f5b94f9f3ce01d21f14c46: > > Merge remote-tracking branch > 'remotes/kraxel/tags/fixes-20200713-pull-request' into staging (2020-07-13 > 16:58:44 +0100) > > are available in the Git reposit

Re: [PATCH v4 2/2] nvme: allow cmb and pmr to be enabled on same device

2020-07-15 Thread Klaus Jensen
On Jul 7 21:44, Andrzej Jakowski wrote: > On 7/6/20 12:15 AM, Klaus Jensen wrote: > > On Jul 2 16:33, Andrzej Jakowski wrote: > >> On 7/2/20 10:51 AM, Klaus Jensen wrote: > >>> On Jul 2 08:07, Andrzej Jakowski wrote: > On 7/2/20 3:31 AM, Klaus Jensen wrote: > > Aight, an update here. Th

Re: [PATCH v4 2/2] nvme: allow cmb and pmr to be enabled on same device

2020-07-15 Thread Klaus Jensen
On Jul 15 10:06, Klaus Jensen wrote: > > Can you reproduce the issues with that patch? I can't on a stock Arch > Linux 5.7.5-arch1-1 kernel. > Was afraid I said this a bit too early since the stock kernel does not enable the iommu by default. Tested with another kernel and yes, I still cannot re

Re: device compatibility interface for live migration with assigned devices

2020-07-15 Thread Dr. David Alan Gilbert
* Alex Williamson (alex.william...@redhat.com) wrote: > On Tue, 14 Jul 2020 18:19:46 +0100 > "Dr. David Alan Gilbert" wrote: > > > * Alex Williamson (alex.william...@redhat.com) wrote: > > > On Tue, 14 Jul 2020 11:21:29 +0100 > > > Daniel P. Berrangé wrote: > > > > > > > On Tue, Jul 14, 2020

Re: sysbus_create_simple Vs qdev_create

2020-07-15 Thread Markus Armbruster
Philippe Mathieu-Daudé writes: > Hi Pratik, > > On 7/14/20 6:17 PM, Pratik Parvati wrote: >> Here is a brief context that might help you. >> I am referring hw/arm/versatilepb.c >> >> The ARM PrimeCell UART (PL011) device created as follows >> >> dev = qdev_create(NULL, "pl011"); >> s =

Re: device compatibility interface for live migration with assigned devices

2020-07-15 Thread Yan Zhao
On Tue, Jul 14, 2020 at 02:59:48PM -0600, Alex Williamson wrote: > On Tue, 14 Jul 2020 18:19:46 +0100 > "Dr. David Alan Gilbert" wrote: > > > * Alex Williamson (alex.william...@redhat.com) wrote: > > > On Tue, 14 Jul 2020 11:21:29 +0100 > > > Daniel P. Berrangé wrote: > > > > > > > On Tue, Ju

Re: [Bug 1886362] [NEW] Heap use-after-free in lduw_he_p through e1000e_write_to_rx_buffers

2020-07-15 Thread Jason Wang
On 2020/7/14 下午6:48, Li Qiang wrote: Jason Wang 于2020年7月14日周二 下午4:56写道: On 2020/7/10 下午6:37, Li Qiang wrote: Paolo Bonzini 于2020年7月10日周五 上午1:36写道: On 09/07/20 17:51, Li Qiang wrote: Maybe we should check whether the address is a RAM address in 'dma_memory_rw'? But it is a hot path. I'm n

[PATCH v5 1/2] acpi: i386: Move VMBus DSDT entry to SB

2020-07-15 Thread Jon Doron
Signed-off-by: Jon Doron --- hw/i386/acpi-build.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c index b7bc2a..7708a27f70 100644 --- a/hw/i386/acpi-build.c +++ b/hw/i386/acpi-build.c @@ -975,7 +975,6 @@ static Aml *

[PATCH v5 0/2] hyperv: vmbus: ACPI various corrections

2020-07-15 Thread Jon Doron
After doing further tests and looking at the latest HyperV ACPI DSDT. Do minor fix to our VMBus ACPI entry. v5: * Rebased on latest master * Added a patch to fix 32bit compliation on VMBus v4: * Removed the patch which adds _ADR definition to the VMBus * Correct the change which moves the VMBus u

[PATCH v5 2/2] hw: hyperv: vmbus: Fix 32bit compilation

2020-07-15 Thread Jon Doron
Signed-off-by: Jon Doron --- hw/hyperv/vmbus.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/hyperv/vmbus.c b/hw/hyperv/vmbus.c index 34392e892a..c28bb4201b 100644 --- a/hw/hyperv/vmbus.c +++ b/hw/hyperv/vmbus.c @@ -383,7 +383,8 @@ static ssize_t gpadl_iter_io(GpadlIter

RE: device compatibility interface for live migration with assigned devices

2020-07-15 Thread Feng, Shaohe
-Original Message- From: Zhao, Yan Y Sent: 2020年7月15日 16:21 To: Alex Williamson Cc: Dr. David Alan Gilbert ; Daniel P. Berrangé ; de...@ovirt.org; openstack-disc...@lists.openstack.org; libvir-l...@redhat.com; intel-gvt-...@lists.freedesktop.org; k...@vger.kernel.org; qemu-devel@non

Re: [PATCH v5 10/11] hw/arm: Wire up BMC boot flash for npcm750-evb and quanta-gsj

2020-07-15 Thread Markus Armbruster
Philippe Mathieu-Daudé writes: > On 7/14/20 6:21 PM, Markus Armbruster wrote: >> Philippe Mathieu-Daudé writes: >> >>> + qemu-block experts. >>> >>> On 7/14/20 11:16 AM, Markus Armbruster wrote: Havard Skinnemoen writes: > On Mon, Jul 13, 2020 at 7:57 AM Cédric Le Goater wrote:

Re: [PATCH] tests: qmp-cmd-test: fix memory leak

2020-07-15 Thread Auger Eric
Hi Li, On 7/14/20 7:15 PM, Li Qiang wrote: > Fixes: 5b88849e7b9("tests/qmp-cmd-test: Add > qmp/object-add-failure-modes" Thank you for fixing this. Adding a commit message generally is welcome such as for example: properly free each test response and separate qtest_qmp() calls with spare lines,

Re: [PATCH] qtest: bios-tables-test: fix a memory leak

2020-07-15 Thread Auger Eric
Hi Li, On 7/14/20 5:35 PM, Li Qiang wrote: > Fixes: 5da7c35e25a("bios-tables-test: Add Q35/TPM-TIS test") > Signed-off-by: Li Qiang > --- > tests/qtest/bios-tables-test.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/tests/qtest/bios-tables-test.c b/tests/qtest/bios-tables-test.c > i

Re: [PATCH v4 0/2] net: tap: check file descriptor can be used

2020-07-15 Thread Laurent Vivier
On 09/07/2020 07:46, Jason Wang wrote: > > On 2020/7/8 上午2:45, Laurent Vivier wrote: >> v4: use qemu_try_set_nonblock() with vhostfd in net_init_tap_one(), >> and with fd in net_init_socket() >> >> v3: move qemu_fd_is_valid() checking into a new function >> qemu_try_set_nonblock(), and u

Re: device compatibility interface for live migration with assigned devices

2020-07-15 Thread Daniel P . Berrangé
On Tue, Jul 14, 2020 at 02:47:15PM -0600, Alex Williamson wrote: > On Tue, 14 Jul 2020 17:47:22 +0100 > Daniel P. Berrangé wrote: > > I'm sure OpenStack maintainers can speak to this more, as they've put > > alot of work into their scheduling engine to optimize the way it places > > VMs largely d

Re: [PATCH RFCv2 3/6] s390x/diag: implement diag260

2020-07-15 Thread David Hildenbrand
On 14.07.20 12:17, Claudio Imbrenda wrote: > On Fri, 10 Jul 2020 17:12:36 +0200 > David Hildenbrand wrote: > >> Let's implement diag260 - "Access Certain Virtual Machine >> Information", used under z/VM to expose the storage configuration >> (especially, layout of storage extends and thereby hole

Re: [PATCH for-5.1 1/2] block: Require aligned image size to avoid assertion failure

2020-07-15 Thread Kevin Wolf
Am 14.07.2020 um 18:22 hat Max Reitz geschrieben: > On 14.07.20 13:08, Kevin Wolf wrote: > > Am 14.07.2020 um 11:56 hat Max Reitz geschrieben: > >> On 13.07.20 16:29, Kevin Wolf wrote: > >>> Am 13.07.2020 um 13:19 hat Max Reitz geschrieben: > On 10.07.20 16:21, Kevin Wolf wrote: > > Unalig

[Bug 1887641] [NEW] PCI bus not available for hda

2020-07-15 Thread InfoLibre
Public bug reported: I'm trying to boot Mac OS 9.2.2 image in order to install it on a qcow disk image. I'm using Linux Mint MATE 20 and QEMU emulator version 4.2.0 (Debian 1:4.2-3ubuntu6.3). When I boot, I've got this error message and boot fails : $ /usr/bin/qemu-system-ppc -monitor stdio -soun

[Bug 1887641] Re: PCI bus not available for hda

2020-07-15 Thread InfoLibre
MLas OS 9.2.2 ISO is here if you need to test : https://infolib.re/tests/OS9General.iso -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1887641 Title: PCI bus not available for hda Status in QEMU:

Re: [PATCH RFCv2 2/6] s390x/diag: no need to check for PGM_PRIVILEGED in diag308

2020-07-15 Thread Janosch Frank
On 7/10/20 5:12 PM, David Hildenbrand wrote: > Whenever we reach this point via KVM or TCG, we already verified that we > are running in the supervisor state. > > TCG checks this via IF_PRIV, KVM checks this directly in the diag > instruction handler, before exiting to userspace. > > Signed-off-b

Re: [PATCH v5 04/11] hw/arm: Add NPCM730 and NPCM750 SoC models

2020-07-15 Thread Markus Armbruster
Havard Skinnemoen writes: > On Tue, Jul 14, 2020 at 10:11 AM Philippe Mathieu-Daudé > wrote: >> >> On 7/14/20 6:01 PM, Markus Armbruster wrote: >> > Philippe Mathieu-Daudé writes: >> > >> >> +Markus >> >> >> >> On 7/14/20 2:44 AM, Havard Skinnemoen wrote: >> >>> On Mon, Jul 13, 2020 at 8:02 AM

Re: [PATCH 3/4] hw/arm/virt-acpi-build: Only expose flash on older machine types

2020-07-15 Thread Andrew Jones
On Wed, Jul 15, 2020 at 08:36:48AM +0200, Andrew Jones wrote: > On Tue, Jul 14, 2020 at 04:41:41PM +0200, Igor Mammedov wrote: > > > > In this particular case I'd drop versioning. > > > > So it sounds to me like we have some flexibility in our versioned machine > maintenance. We can choose to for

[PATCH 3/7] pc-bios: s390x: Remove unneeded dasd-ipl.c reset psw mask changes

2020-07-15 Thread Janosch Frank
jump_to_low_kernel() and the functions that it calls will already or 64 bit addressing into the reset psw mask when executing jump_to_IPL_2() after the diag308 subcode 1. The kernel proper is then branched to rather than doing a full PSW change. Signed-off-by: Janosch Frank --- pc-bios/s390-ccw

[PATCH 1/7] pc-bios: s390x: Fix bootmap.c zipl component entry data handling

2020-07-15 Thread Janosch Frank
The two main types of zipl component entries are execute and load/data. The last member of the component entry struct therefore denotes either a PSW or an address. Let's make this a bit more clear by introducing a union and cleaning up the code that uses that struct member. The execute type compon

[PATCH 6/7] pc-bios: s390x: Use PSW constants in start.S

2020-07-15 Thread Janosch Frank
Let's decrease the number of magic numbers. Signed-off-by: Janosch Frank Reviewed-by: Pierre Morel --- pc-bios/s390-ccw/s390-arch.h | 25 +++-- pc-bios/s390-ccw/start.S | 9 + 2 files changed, 20 insertions(+), 14 deletions(-) diff --git a/pc-bios/s390-ccw/s390

[PATCH 0/7] pc-bios: s390x: Cleanup part 2

2020-07-15 Thread Janosch Frank
So, here are a few more cleanup patches mostly cleaning up ipl code and some of the assembly. The patches are available here: https://github.com/frankjaa/qemu/pull/new/cleanup_bios2 Janosch Frank (7): pc-bios: s390x: Fix bootmap.c zipl component entry data handling pc-bios: s390x: Cleanup jum

[PATCH 7/7] pc-bios: s390x: Setup io and ext new psws only once

2020-07-15 Thread Janosch Frank
Absolutely no need to set them up every time before we enable our interrupt masks. Signed-off-by: Janosch Frank --- pc-bios/s390-ccw/start.S | 30 +- 1 file changed, 13 insertions(+), 17 deletions(-) diff --git a/pc-bios/s390-ccw/start.S b/pc-bios/s390-ccw/start.S in

[PATCH 5/7] pc-bios: s390x: Replace lowcore offsets with pointers in dasd-ipl.c

2020-07-15 Thread Janosch Frank
Let's replace some more constant offsets with references into the lowcore for better readability. Signed-off-by: Janosch Frank --- pc-bios/s390-ccw/dasd-ipl.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/pc-bios/s390-ccw/dasd-ipl.c b/pc-bios/s390-ccw/dasd-ipl.c

Re: [PATCH RFC 2/5] s390x: implement diag260

2020-07-15 Thread David Hildenbrand
On 13.07.20 13:08, Christian Borntraeger wrote: > On 13.07.20 12:27, David Hildenbrand wrote: >> >> >>> Am 13.07.2020 um 11:12 schrieb Heiko Carstens : >>> >>> On Fri, Jul 10, 2020 at 05:24:07PM +0200, David Hildenbrand wrote: > On 10.07.20 17:18, Heiko Carstens wrote: > On Fri, Jul 10, 20

[PATCH 4/7] pc-bios: s390x: Rework data initialization

2020-07-15 Thread Janosch Frank
Sometimes a memset is nicer to read than multiple struct->data = 0; Signed-off-by: Janosch Frank Reviewed-by: Pierre Morel --- pc-bios/s390-ccw/dasd-ipl.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/pc-bios/s390-ccw/dasd-ipl.c b/pc-bios/s390-ccw/dasd-ipl.c index e

[PATCH 2/7] pc-bios: s390x: Cleanup jump to ipl code

2020-07-15 Thread Janosch Frank
jump_to_IPL_code takes a 64 bit address, masks it with the short psw address mask and later branches to it using a full 64 bit register. * As the masking is not necessary, let's remove it * Without the mask we can save the ipl address to a static 64 bit function ptr as we later branch to it * Le

Re: [PATCH for-5.1 4/4] docs/system: Document the arm virt board

2020-07-15 Thread Auger Eric
Hi Peter, On 7/13/20 7:57 PM, Peter Maydell wrote: > Document the arm 'virt' board, which has been undocumented > for far too long given that it is the main recommended board > type for arm guests. > > Signed-off-by: Peter Maydell > --- > docs/system/arm/virt.rst | 157

Re: RFC: use VFIO over a UNIX domain socket to implement device offloading

2020-07-15 Thread Stefan Hajnoczi
On Wed, Jul 01, 2020 at 11:23:25PM -0700, John G Johnson wrote: > > We’ve made the review changes to the doc, and moved to RST format, > so the doc can go into the QEMU sources. > > Thanos & JJ > > > https://github.com/tmakatos/qemu/blob/mast

[PATCH 1/2] hw/mips: remove exit(1) in case of missing ROM

2020-07-15 Thread Pavel Dovgalyuk
This patch updates MIPS-based machines to allow starting them without ROM. In this case CPU starts to execute instructions from the empty memory, but QEMU allows introspecting the machine configuration. Signed-off-by: Pavel Dovgalyuk --- 0 files changed diff --git a/hw/mips/fuloong2e.c b/hw/mip

[PATCH 0/2] Romless QEMU shutdown patches

2020-07-15 Thread Pavel Dovgalyuk
Some machines require custom ROMs or kernels. They can't be started without -bios, -kernel, or -pflash options. But this requirement can't be detected automatically. Running a romless machine may be needed for automatic introspection of default machine hardware, when QEMU is started with a single

[PATCH 2/2] hw/arm: remove exit(1) in case of missing ROM

2020-07-15 Thread Pavel Dovgalyuk
This patch updates ARM-based machines to allow starting them without ROM. In this case CPU starts to execute instructions from the empty memory, but QEMU allows introspecting the machine configuration. Signed-off-by: Pavel Dovgalyuk --- 0 files changed diff --git a/hw/arm/digic_boards.c b/hw/ar

Re: [PATCH] .travis.yml: skip ppc64abi32-linux-user with plugins

2020-07-15 Thread David Gibson
On Wed, Jul 15, 2020 at 09:02:05AM +0100, Alex Bennée wrote: > > David Gibson writes: > > > On Tue, Jul 14, 2020 at 06:55:16PM +0100, Alex Bennée wrote: > >> We actually see failures on threadcount running without plugins: > >> > >> retry.py -n 1000 -c -- \ > >> ./ppc64abi32-linux-user/qe

Re: [PATCH] vfio: fix use-after-free in display

2020-07-15 Thread Gerd Hoffmann
Hi, > Tricky, but I think I follow that dpy->region.surface is only ever > allocated to replace dpy->con->surface, so when ramfb_display_update() > then replaces and frees dpy->con->surface with dpy->ramfb->ds, that's > where the object point to by dpy->region.surface was freed. Right? Correct

Re: [PATCH RFC 2/5] s390x: implement diag260

2020-07-15 Thread Heiko Carstens
On Wed, Jul 15, 2020 at 11:42:37AM +0200, David Hildenbrand wrote: > So, in summary, we want to indicate to the guest a memory region that > will be used to place memory devices ("device memory region"). The > region might have holes and the memory within this region might have > different semantic

Re: [PATCH v3 3/3] usb/hcd-xhci: Split pci wrapper for xhci base model

2020-07-15 Thread Gerd Hoffmann
Hi, > --- a/hw/usb/Kconfig > --- a/hw/usb/Makefile.objs These two hunks need to go to patch 2/3 take care, Gerd

Re: [PULL 0/9] final misc fixes for 5.1-rc0

2020-07-15 Thread Alex Bennée
Peter Maydell writes: > On Tue, 14 Jul 2020 at 10:52, Alex Bennée wrote: >> >> The following changes since commit 20c1df5476e1e9b5d3f5b94f9f3ce01d21f14c46: >> >> Merge remote-tracking branch >> 'remotes/kraxel/tags/fixes-20200713-pull-request' into staging (2020-07-13 >> 16:58:44 +0100) >>

Re: [PATCH v3 0/3] Make hcd-xhci independent of pci hooks

2020-07-15 Thread Gerd Hoffmann
On Tue, Jul 14, 2020 at 01:59:12PM +, Sai Pavan Boddu wrote: > Hi Gerd, > > Any review on V3. So that I can work on. Busy due to freeze, sorry for the delay. Looks good to me overall. Not tested yet. Wasn't the plan to include the sysbus bits too, so it's easier to see how code code separat

Re: [PATCH RFCv2 3/6] s390x/diag: implement diag260

2020-07-15 Thread Heiko Carstens
On Wed, Jul 15, 2020 at 11:19:03AM +0200, David Hildenbrand wrote: > On 14.07.20 12:17, Claudio Imbrenda wrote: > > shouldn't it return all the hotplugged areas once hotplugging is > > enabled? > > No, that would be dangerous and wrong. Memory ranges part of memory > devices never must be indicate

[PULL v2 0/8] final misc fixes for 5.1-rc0

2020-07-15 Thread Alex Bennée
Dropped configure patch --- The following changes since commit c920fdba39480989cb5f1af3cc63acccef021b54: Merge remote-tracking branch 'remotes/mdroth/tags/qga-pull-2020-07-13-tag' into staging (2020-07-14 21:21:58 +0100) are available in the Git repository at: https://github.com/stsquad/qe

Re: [PATCH v5 10/11] hw/arm: Wire up BMC boot flash for npcm750-evb and quanta-gsj

2020-07-15 Thread Philippe Mathieu-Daudé
On 7/15/20 11:00 AM, Markus Armbruster wrote: > Philippe Mathieu-Daudé writes: > >> On 7/14/20 6:21 PM, Markus Armbruster wrote: >>> Philippe Mathieu-Daudé writes: >>> + qemu-block experts. On 7/14/20 11:16 AM, Markus Armbruster wrote: > Havard Skinnemoen writes: > >>

Re: [Bug 1887641] [NEW] PCI bus not available for hda

2020-07-15 Thread BALATON Zoltan
On Wed, 15 Jul 2020, InfoLibre wrote: Public bug reported: I'm trying to boot Mac OS 9.2.2 image in order to install it on a qcow disk image. I'm using Linux Mint MATE 20 and QEMU emulator version 4.2.0 (Debian 1:4.2-3ubuntu6.3). When I boot, I've got this error message and boot fails : $ /usr/

Re: [PATCH v1 1/2] semihosting: defer connect_chardevs a little more to use serialx

2020-07-15 Thread Fred Konrad
Le 6/26/20 à 12:06 PM, Fred Konrad a écrit : Le 6/16/20 à 4:52 PM, Alex Bennée a écrit : kon...@adacore.com writes: From: KONRAD Frederic With that we can just use chardev=serial0. I don't quite follow what this means. ./aarch64-softmmu/qemu-system-aarch64 -cpu max -monitor none -ch

Re: migration: broken snapshot saves appear on s390 when small fields in migration stream removed

2020-07-15 Thread Claudio Fontana
Hi Thomas, On 7/14/20 4:35 PM, Thomas Huth wrote: > On 14/07/2020 16.29, Claudio Fontana wrote: >> Hello, >> >> I have some tiny progress in narrowing down this issue, possibly a qcow2 >> issue, still unclear, >> but involving Kevin Wolf and Max Reitz. >> >> >> The reproducer again: >> >>> --

Re: [PATCH RFCv2 3/6] s390x/diag: implement diag260

2020-07-15 Thread David Hildenbrand
On 15.07.20 12:53, Heiko Carstens wrote: > On Wed, Jul 15, 2020 at 11:19:03AM +0200, David Hildenbrand wrote: >> On 14.07.20 12:17, Claudio Imbrenda wrote: >>> shouldn't it return all the hotplugged areas once hotplugging is >>> enabled? >> >> No, that would be dangerous and wrong. Memory ranges pa

Re: [PATCH v3 4/4] spapr: Forbid nested KVM-HV in pre-power9 compat mode

2020-07-15 Thread Greg Kurz
On Mon, 13 Jul 2020 14:53:30 +1000 David Gibson wrote: > On Fri, Jul 03, 2020 at 04:19:24PM +0200, Greg Kurz wrote: > > On Mon, 15 Jun 2020 11:20:31 +0200 > > Greg Kurz wrote: > > > > > On Sat, 13 Jun 2020 17:18:04 +1000 > > > David Gibson wrote: > > > > > > > On Thu, Jun 11, 2020 at 03:40:33

Re: [PULL v2 0/8] final misc fixes for 5.1-rc0

2020-07-15 Thread Alex Bennée
Alex Bennée writes: > Dropped configure patch > > --- > The following changes since commit c920fdba39480989cb5f1af3cc63acccef021b54: > > Merge remote-tracking branch 'remotes/mdroth/tags/qga-pull-2020-07-13-tag' > into staging (2020-07-14 21:21:58 +0100) > > are available in the Git reposito

[PULL v3 0/9] final misc fixes for 5.1-rc0

2020-07-15 Thread Alex Bennée
Sorry about that, dropped configure patch, added Travis ppc64abi32 patch. --- The following changes since commit c920fdba39480989cb5f1af3cc63acccef021b54: Merge remote-tracking branch 'remotes/mdroth/tags/qga-pull-2020-07-13-tag' into staging (2020-07-14 21:21:58 +0100) are available in the

Re: [PULL 0/9] sdcard: Fix CVE-2020-13253

2020-07-15 Thread Peter Maydell
On Tue, 14 Jul 2020 at 15:00, Philippe Mathieu-Daudé wrote: > > The following changes since commit 20c1df5476e1e9b5d3f5b94f9f3ce01d21f14c46: > > Merge remote-tracking branch 'remotes/kraxel/tags/fixes-20200713-pull-reque= > st' into staging (2020-07-13 16:58:44 +0100) > > are available in the Gi

Re: [PATCH 05/13] qapi: introduce replay.json for record/replay-related stuff

2020-07-15 Thread Alex Bennée
Pavel Dovgalyuk writes: > From: Pavel Dovgalyuk > > This patch adds replay.json file. It will be > used for adding record/replay-related data structures and commands. > > Signed-off-by: Pavel Dovgalyuk > Reviewed-by: Markus Armbruster > --- > 0 files changed > > diff --git a/MAINTAINERS b/M

Re: [PATCH RFC 2/5] s390x: implement diag260

2020-07-15 Thread David Hildenbrand
On 15.07.20 12:43, Heiko Carstens wrote: > On Wed, Jul 15, 2020 at 11:42:37AM +0200, David Hildenbrand wrote: >> So, in summary, we want to indicate to the guest a memory region that >> will be used to place memory devices ("device memory region"). The >> region might have holes and the memory with

Inter-VM device emulation (call on Mon 20th July 2020)

2020-07-15 Thread Stefan Hajnoczi
Hi, Several projects are underway to create an inter-VM device emulation interface: * ivshmem v2 https://www.mail-archive.com/qemu-devel@nongnu.org/msg706465.html A PCI device that provides shared-memory communication between VMs. This device already exists but is limited in its current

Re: [PATCH] ppc/spapr: Fix 32 bit logical memory block size assumptions

2020-07-15 Thread David Gibson
On Wed, Jul 15, 2020 at 10:42:28AM +1000, Anton Blanchard wrote: > When testing large LMB sizes (eg 4GB), I found a couple of places > that assume they are 32bit in size. > > Signed-off-by: Anton Blanchard Applied to ppc-for-5.2. > --- > hw/ppc/spapr.c | 6 -- > 1 file changed, 4 insertion

Re: [PATCH 10/13] gdbstub: add reverse step support in replay mode

2020-07-15 Thread Alex Bennée
Pavel Dovgalyuk writes: > From: Pavel Dovgalyuk > > GDB remote protocol supports two reverse debugging commands: > reverse step and reverse continue. > This patch adds support of the first one to the gdbstub. > Reverse step is intended to step one instruction in the backwards > direction. This

Re: Inter-VM device emulation (call on Mon 20th July 2020)

2020-07-15 Thread Jan Kiszka
On 15.07.20 13:23, Stefan Hajnoczi wrote: > Hi, > Several projects are underway to create an inter-VM device emulation > interface: > > * ivshmem v2 >https://www.mail-archive.com/qemu-devel@nongnu.org/msg706465.html > >A PCI device that provides shared-memory communication between VMs. >

[Bug 1887641] Re: PCI bus not available for hda

2020-07-15 Thread InfoLibre
How to close this bug report ??? -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1887641 Title: PCI bus not available for hda Status in QEMU: New Bug description: I'm trying to boot Mac OS 9.2.

[Bug 1887641] Re: PCI bus not available for hda

2020-07-15 Thread InfoLibre
Sorry, I made a mistake, I'm trying to boot PowerPC Debian edition, not Mac OS 9.2.2. I removed the sound card and it boots now. Thank uou very much for your help. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad

Re: [PATCH RFC 2/5] s390x: implement diag260

2020-07-15 Thread Heiko Carstens
On Wed, Jul 15, 2020 at 01:21:06PM +0200, David Hildenbrand wrote: > > At least in v4.1 the kernel will calculate the max address by using > > increment size * increment number and then test if *each* increment is > > available with tprot. > > Yes, we do the same in kvm-unit-tests. But it's not su

Re: [PATCH RFC 2/5] s390x: implement diag260

2020-07-15 Thread David Hildenbrand
On 15.07.20 13:34, Heiko Carstens wrote: > On Wed, Jul 15, 2020 at 01:21:06PM +0200, David Hildenbrand wrote: >>> At least in v4.1 the kernel will calculate the max address by using >>> increment size * increment number and then test if *each* increment is >>> available with tprot. >> >> Yes, we do

Re: [PATCH v11 00/34] Add subcluster allocation to qcow2

2020-07-15 Thread Alberto Garcia
On Tue, Jul 14, 2020 at 02:56:57PM +0200, Max Reitz wrote: > Thanks, fixed up patch 21 (by initializing expected_type to just > anything, I chose QCOW2_SUBCLUSTER_NORMAL, which I preferred over > just using 0), resolved some iotest conflicts (I’m sure, more are > to come before the release, but we’

Re: [PULL v2 0/8] final misc fixes for 5.1-rc0

2020-07-15 Thread Peter Maydell
On Wed, 15 Jul 2020 at 12:15, Alex Bennée wrote: > > > Alex Bennée writes: > > > Dropped configure patch > > > > --- > > The following changes since commit c920fdba39480989cb5f1af3cc63acccef021b54: > > > > Merge remote-tracking branch > > 'remotes/mdroth/tags/qga-pull-2020-07-13-tag' into stag

[Bug 1887641] Re: PCI bus not available for hda

2020-07-15 Thread Laurent Vivier
** Changed in: qemu Status: New => Invalid -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1887641 Title: PCI bus not available for hda Status in QEMU: Invalid Bug description: I'm tryin

Re: migration: broken snapshot saves appear on s390 when small fields in migration stream removed

2020-07-15 Thread Claudio Fontana
On 7/15/20 1:10 PM, Claudio Fontana wrote: > Hi Thomas, > > On 7/14/20 4:35 PM, Thomas Huth wrote: >> On 14/07/2020 16.29, Claudio Fontana wrote: >>> Hello, >>> >>> I have some tiny progress in narrowing down this issue, possibly a qcow2 >>> issue, still unclear, >>> but involving Kevin Wolf and

Re: [PATCH 3/4] hw/arm/virt-acpi-build: Only expose flash on older machine types

2020-07-15 Thread Laszlo Ersek
Hi Drew, On 07/15/20 08:36, Andrew Jones wrote: > So it sounds to me like we have some flexibility in our versioned machine > maintenance. We can choose to forgo the usual compat code when the risk is > deemed low enough. And, if somebody screams, we can always fix it later. > I can live with tha

Re: [PULL 0/9] final misc fixes for 5.1-rc0

2020-07-15 Thread Philippe Mathieu-Daudé
Hi Peter, On 7/15/20 10:06 AM, Peter Maydell wrote: > On Tue, 14 Jul 2020 at 10:52, Alex Bennée wrote: >> >> The following changes since commit 20c1df5476e1e9b5d3f5b94f9f3ce01d21f14c46: >> >> Merge remote-tracking branch >> 'remotes/kraxel/tags/fixes-20200713-pull-request' into staging (2020-0

Re: [RFC 3/3] x68: acpi: trigger SMI before scanning for hotplugged CPUs

2020-07-15 Thread Laszlo Ersek
On 07/14/20 17:19, Igor Mammedov wrote: > On Tue, 14 Jul 2020 14:41:28 +0200 > Laszlo Ersek wrote: > >> On 07/14/20 14:28, Laszlo Ersek wrote: >>> (CC'ing Peter Krempa due to virsh setvcpu (singular) / setvcpus (plural) >>> references) >>> >>> On 07/10/20 18:17, Igor Mammedov wrote: In cas

Re: [PULL 0/9] final misc fixes for 5.1-rc0

2020-07-15 Thread Peter Maydell
On Wed, 15 Jul 2020 at 13:29, Philippe Mathieu-Daudé wrote: > What host/distrib are you using? > > I can not reproduce on aarch64 (Ubuntu 20.04 LTS) using: > gcc (Ubuntu 9.3.0-10ubuntu2) 9.3.0 Ubuntu 20.04 LTS (this is the aarch64.ci.qemu.org packet.net box you have access to). Also Ubuntu 18.04.

Re: [PATCH v7 21/47] block: Use CAFs in bdrv_refresh_filename()

2020-07-15 Thread Andrey Shinkevich
On 25.06.2020 18:21, Max Reitz wrote: bdrv_refresh_filename() and the kind of related bdrv_dirname() should look to the primary child when they wish to copy the underlying file's filename. Signed-off-by: Max Reitz --- block.c | 29 + 1 file changed, 21 insertions(

Re: [PULL 00/19] Python patches for 5.1

2020-07-15 Thread Peter Maydell
On Tue, 14 Jul 2020 at 23:23, Philippe Mathieu-Daudé wrote: > > The following changes since commit 1a53dfee92284d3016a579ef31d53367e84d9dd8: > > Merge remote-tracking branch 'remotes/ericb/tags/pull-nbd-2020-07-13' into > staging (2020-07-14 13:52:10 +0100) > > are available in the Git reposito

Re: [PULL 0/9] final misc fixes for 5.1-rc0

2020-07-15 Thread Philippe Mathieu-Daudé
On 7/15/20 2:51 PM, Peter Maydell wrote: > On Wed, 15 Jul 2020 at 13:29, Philippe Mathieu-Daudé wrote: >> What host/distrib are you using? >> >> I can not reproduce on aarch64 (Ubuntu 20.04 LTS) using: >> gcc (Ubuntu 9.3.0-10ubuntu2) 9.3.0 > > Ubuntu 20.04 LTS (this is the aarch64.ci.qemu.org pac

Re: device compatibility interface for live migration with assigned devices

2020-07-15 Thread Alex Xu
Alex Williamson 于2020年7月15日周三 上午5:00写道: > On Tue, 14 Jul 2020 18:19:46 +0100 > "Dr. David Alan Gilbert" wrote: > > > * Alex Williamson (alex.william...@redhat.com) wrote: > > > On Tue, 14 Jul 2020 11:21:29 +0100 > > > Daniel P. Berrangé wrote: > > > > > > > On Tue, Jul 14, 2020 at 07:29:57AM +0

Re: device compatibility interface for live migration with assigned devices

2020-07-15 Thread Alex Xu
Alex Williamson 于2020年7月15日周三 上午12:16写道: > On Tue, 14 Jul 2020 11:21:29 +0100 > Daniel P. Berrangé wrote: > > > On Tue, Jul 14, 2020 at 07:29:57AM +0800, Yan Zhao wrote: > > > hi folks, > > > we are defining a device migration compatibility interface that helps > upper > > > layer stack like ope

Re: device compatibility interface for live migration with assigned devices

2020-07-15 Thread Alex Xu
Yan Zhao 于2020年7月15日周三 下午4:32写道: > On Tue, Jul 14, 2020 at 02:59:48PM -0600, Alex Williamson wrote: > > On Tue, 14 Jul 2020 18:19:46 +0100 > > "Dr. David Alan Gilbert" wrote: > > > > > * Alex Williamson (alex.william...@redhat.com) wrote: > > > > On Tue, 14 Jul 2020 11:21:29 +0100 > > > > Daniel

Re: [PATCH v7 21/47] block: Use CAFs in bdrv_refresh_filename()

2020-07-15 Thread Andrey Shinkevich
On 15.07.2020 15:52, Andrey Shinkevich wrote: On 25.06.2020 18:21, Max Reitz wrote: bdrv_refresh_filename() and the kind of related bdrv_dirname() should look to the primary child when they wish to copy the underlying file's filename. Signed-off-by: Max Reitz ---   block.c | 29 +

Re: [PULL v2 0/8] final misc fixes for 5.1-rc0

2020-07-15 Thread Philippe Mathieu-Daudé
On 7/15/20 12:55 PM, Alex Bennée wrote: > Dropped configure patch Ah, after looking at v1 I was going to suggest there is probably a dependency issue with the configure patch, we let old objects in the directory, make doesn't source .d and doesn't rebuilt them.

Re: [PATCH 3/4] hw/arm/virt-acpi-build: Only expose flash on older machine types

2020-07-15 Thread Andrew Jones
On Wed, Jul 15, 2020 at 02:26:19PM +0200, Laszlo Ersek wrote: > Hi Drew, > > On 07/15/20 08:36, Andrew Jones wrote: > > > So it sounds to me like we have some flexibility in our versioned machine > > maintenance. We can choose to forgo the usual compat code when the risk is > > deemed low enough.

Re: [PATCH] hw/arm/aspeed: Add board model for Supermicro X11 BMC

2020-07-15 Thread Cédric Le Goater
> Signed-off-by: erik-smit > -- > checkpatch was complaining about the length of > aspeed_machine_supermicrox11_bmc_class_init(ObjectClass *oc, void *data) in which way ? line too long ? If so, you can insert a return inside the parameter list. > so I renamed it to aspeed_machine_smx11_bmc_cl

[PATCH-for-5.2] hw/vfio: Move some target-independent devices to common-objs

2020-07-15 Thread Philippe Mathieu-Daudé
These devices do not depend on the target CPU configuration (32 or 64-bit, big / little endian). Move them to common-obj to compile them once for all the targets. Signed-off-by: Philippe Mathieu-Daudé --- hw/vfio/Makefile.objs | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff

Re: [PATCH 7/7] pc-bios: s390x: Setup io and ext new psws only once

2020-07-15 Thread Janosch Frank
On 7/15/20 11:40 AM, Janosch Frank wrote: > Absolutely no need to set them up every time before we enable our > interrupt masks. > > Signed-off-by: Janosch Frank So, this one doesn't seem to be a great idea as a kernel loaded to 0x0 will overwrite the ext/io new PSWs and we'll then try to load a

Re: [RFC PATCH 3/5] hw/i386/acpi-build: Add ACPI PCI hot-plug methods to q35

2020-07-15 Thread Igor Mammedov
On Wed, 15 Jul 2020 08:57:51 +0200 Gerd Hoffmann wrote: > On Mon, Jul 13, 2020 at 04:39:54PM +0200, Igor Mammedov wrote: > > On Thu, 9 Jul 2020 00:46:13 +0200 > > Julia Suvorova wrote: > > > > > Implement notifications and gpe to support q35 ACPI PCI hot-plug. > > > The addresses specified i

Re: [PATCH 7/7] pc-bios: s390x: Setup io and ext new psws only once

2020-07-15 Thread Christian Borntraeger
On 15.07.20 15:13, Janosch Frank wrote: > On 7/15/20 11:40 AM, Janosch Frank wrote: >> Absolutely no need to set them up every time before we enable our >> interrupt masks. >> >> Signed-off-by: Janosch Frank > > So, this one doesn't seem to be a great idea as a kernel loaded to 0x0 > will over

[PATCH-for-5.2] hw/s390x: Move S390_ADAPTER_SUPPRESSIBLE from 'css.h' to 's390_flic.h'

2020-07-15 Thread Philippe Mathieu-Daudé
Not all s390x devices require to have access to the CPU internals. To reduce the include dependencies on "s390x/css.h", move the S390_ADAPTER_SUPPRESSIBLE definition to "s390x/s390_flic.h". Signed-off-by: Philippe Mathieu-Daudé --- include/hw/s390x/css.h | 7 --- include/hw/s390x/s390

Re: [PATCH] cpu-models-x86: Fix CPU model name - s/IBR/IBRS/

2020-07-15 Thread Kashyap Chamarthy
On Fri, Jun 19, 2020 at 06:26:23AM -0700, no-re...@patchew.org wrote: > Patchew URL: > https://patchew.org/QEMU/20200619125413.2210-1-kcham...@redhat.com/ [...] > clang -iquote /tmp/qemu-test/build/tests -iquote tests -iquote > /tmp/qemu-test/src/tcg/i386 -isystem /tmp/qemu-test/src/linux-heade

Re: [PATCH for-5.1 1/2] block: Require aligned image size to avoid assertion failure

2020-07-15 Thread Nir Soffer
On Mon, Jul 13, 2020 at 7:56 PM Kevin Wolf wrote: > > Am 13.07.2020 um 18:33 hat Nir Soffer geschrieben: > > On Fri, Jul 10, 2020 at 5:22 PM Kevin Wolf wrote: > > > > > > Unaligned requests will automatically be aligned to bl.request_alignment > > > and we don't want to extend requests to access

Re: [RFC PATCH 4/5] hw/i386/acpi-build: Turn off support of PCIe native hot-plug and SHPC in _OSC

2020-07-15 Thread Igor Mammedov
On Tue, 14 Jul 2020 04:39:53 -0400 "Michael S. Tsirkin" wrote: > On Mon, Jul 13, 2020 at 04:56:54PM +0200, Igor Mammedov wrote: > > On Thu, 9 Jul 2020 00:46:14 +0200 > > Julia Suvorova wrote: > > > > > Other methods may be used if the system is capable of this and the _OSC > > > bit > > > i

Re: [virtio-comment] [RFC] ivshmem v2: Shared memory device specification

2020-07-15 Thread Stefan Hajnoczi
On Mon, May 25, 2020 at 09:58:28AM +0200, Jan Kiszka wrote: > IVSHMEM Device Specification > > > ** NOTE: THIS IS WORK-IN-PROGRESS, NOT YET A STABLE INTERFACE SPECIFICATION! > ** Hi Jan, Thanks for posting this! I have a posted comments where I wasn't sure what the s

  1   2   3   >